[native-toolchain-CR] Remove colon from filename

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16139 ) Change subject: Remove colon from filename .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16139 To

[native-toolchain-CR] Remove colon from filename

Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16139 ) Change subject: Remove colon from filename .. Remove colon from filename Some OSes don't allow cloning the repo if it has a

[native-toolchain-CR] Remove colon from filename

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16139 ) Change subject: Remove colon from filename .. Patch Set 2: I'm not sure - these patches are usually manually generated so not sure

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 11: Code-Review+1 rebased onto latest master -- To view,

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 12: Code-Review+1 rebased onto latest master -- To

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#12). Change subject: IMPALA-9917: grouping() and grouping_id() support

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

Hello Aman Sinha, Quanlong Huang, Fang-Yu Rao, Qifan Chen, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#11). Change subject: IMPALA-9898: generate grouping set plans

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#11). Change subject: IMPALA-9917: grouping() and grouping_id() support

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#10). Change subject: IMPALA-9917: grouping() and grouping_id() support

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#9). Change subject: IMPALA-9917: grouping() and grouping_id() support

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 8: I added a couple of basic view compatibility tests.

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 8: Oh I missed the logical view comment, will think

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#8). Change subject: IMPALA-9917: grouping() and grouping_id() support

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 7: (9 comments)

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I was a little scared since Q1 is a

[Impala-ASF-CR] IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16146 ) Change subject: IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 16: Hit IMPALA-9923 -- To view, visit

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 15: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Hello Aman Sinha, Quanlong Huang, Thomas Tauber-Marshall, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16112 to look at the new patch set (#15). Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#7). Change subject: IMPALA-9917: grouping() and grouping_id() support

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 10: Code-Review+1 carry -- To view, visit

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 14: Code-Review+1 carry -- To view, visit

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

Hello Fang-Yu Rao, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16118 to look at the new patch set (#3). Change subject: IMPALA-9902: add rewrite of TPC-DS q38 ..

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Hello Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#6). Change subject: IMPALA-9917: grouping() and grouping_id() support

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

Hello Aman Sinha, Quanlong Huang, Fang-Yu Rao, Qifan Chen, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#10). Change subject: IMPALA-9898: generate grouping set plans

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 13: (11 comments)

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Hello Aman Sinha, Quanlong Huang, Thomas Tauber-Marshall, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16112 to look at the new patch set (#14). Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and

[Impala-ASF-CR] WIP

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16144 Change subject: WIP .. WIP Change-Id: I31c3f019dc6d68cc5c433b53b74ac7b13e328dfa --- M

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: Code-Review+2 (1 comment) GOod point about

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

Hello Shant Hovsepian, David Rorke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#5). Change subject: IMPALA-9917: grouping() and grouping_id() support

[Impala-ASF-CR] IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING.

Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16052 ) Change subject: IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING. .. IMPALA-9784, IMPALA-9905: Uncorrelated

[Impala-ASF-CR] IMPALA-8954: Uncorrelated scalar subqueries in the select list

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16007 ) Change subject: IMPALA-8954: Uncorrelated scalar subqueries in the select list .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8954: Uncorrelated scalar subqueries in the select list

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16007 ) Change subject: IMPALA-8954: Uncorrelated scalar subqueries in the select list .. Patch Set 9: Verified+1 Verifying since parent

[Impala-ASF-CR] IMPALA-8954: Uncorrelated scalar subqueries in the select list

Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16007 ) Change subject: IMPALA-8954: Uncorrelated scalar subqueries in the select list .. IMPALA-8954: Uncorrelated scalar subqueries

[Impala-ASF-CR] IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING.

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16052 ) Change subject: IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING. .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8954: Uncorrelated scalar subqueries in the select list

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16007 ) Change subject: IMPALA-8954: Uncorrelated scalar subqueries in the select list .. Patch Set 8: Code-Review+2 (6 comments) I had a

[Impala-ASF-CR] IMPALA-9916: Fix DiskIoMgrTest.MetricsOfWriteIoError failed due to data race in TSAN build

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16142 ) Change subject: IMPALA-9916: Fix DiskIoMgrTest.MetricsOfWriteIoError failed due to data race in TSAN build .. Patch Set 1:

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

Hello Aman Sinha, Fang-Yu Rao, Qifan Chen, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#9). Change subject: IMPALA-9898: generate grouping set plans

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I think scale factor 2 might be too small to get

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 8: Exhaustive tests passed. -- To view, visit

[native-toolchain-CR] Remove colon from filename

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16139 Change subject: Remove colon from filename .. Remove colon from filename Some OSes don't allow cloning the repo if it has a filename

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 5: Code-Review+2 Yeah maybe it doesn't matter too

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 ) Change subject: IMPALA-9898: Plan generation and execution for grouping sets .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I took a quick pass and this seems fine in

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 8: I rebased this onto the latest version of Aman's patch. --

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

Hello Aman Sinha, Fang-Yu Rao, Qifan Chen, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#8). Change subject: IMPALA-9898: generate grouping set plans

[Impala-ASF-CR] WIP - IMPALA-9898: generate grouping set plans

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: WIP - IMPALA-9898: generate grouping set plans .. Patch Set 6: (6 comments)

[Impala-ASF-CR] WIP - IMPALA-9898: generate grouping set plans

Hello Aman Sinha, Fang-Yu Rao, Qifan Chen, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#7). Change subject: WIP - IMPALA-9898: generate grouping set plans

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 ) Change subject: IMPALA-9898: Plan generation and execution for grouping sets .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 11: Code-Review+1 Carry +1 -- To view,

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] WIP - IMPALA-9898: generate grouping set plans

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: WIP - IMPALA-9898: generate grouping set plans .. Patch Set 6: (2 comments)

[Impala-ASF-CR] WIP - IMPALA-9898: generate grouping set plans

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16128 Change subject: WIP - IMPALA-9898: generate grouping set plans .. WIP - IMPALA-9898: generate grouping set plans Testing: * Add

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 11: > LGTM, nice approach of keeping the

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Hello Aman Sinha, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16112 to look at the new patch set (#11). Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 10: I added some more logic to generate

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Hello Aman Sinha, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16112 to look at the new patch set (#10). Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 2: (3 comments) Thanks for pointing out that I need to update

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

Hello Fang-Yu Rao, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16118 to look at the new patch set (#2). Change subject: IMPALA-9902: add rewrite of TPC-DS q38 ..

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 43: Code-Review+1 (1 comment) I can upgrade to a +2 if

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Hello Aman Sinha, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16112 to look at the new patch set (#9). Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

[Impala-ASF-CR] IMPALA-9903: Reduce Kudu openTable calls per query

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16120 ) Change subject: IMPALA-9903: Reduce Kudu openTable calls per query .. Patch Set 2: I think for the non-local catalog to get query

[Impala-ASF-CR] IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING.

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16052 ) Change subject: IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING. .. Patch Set 3: Code-Review+1 (1 comment) Assume Aman

[Impala-ASF-CR] IMPALA-9903: Reduce Kudu openTable calls per query

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16120 ) Change subject: IMPALA-9903: Reduce Kudu openTable calls per query .. Patch Set 2: Some of these table objects will have longer than

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Hello Aman Sinha, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16112 to look at the new patch set (#8). Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Tim Armstrong has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. IMPALA-9897: GROUPING SETS parsing and analysis.

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

Hello Aman Sinha, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16112 to look at the new patch set (#7). Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16118 Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. IMPALA-9902: add rewrite of TPC-DS q38 I generated the query with dsqgen and

[Impala-ASF-CR] IMPALA-9790: option to use resolved hostname everywhere

Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16108 ) Change subject: IMPALA-9790: option to use resolved hostname everywhere .. IMPALA-9790: option to use resolved hostname

[Impala-ASF-CR] IMPALA-9784: Non correlated subqueries in HAVING.

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16052 ) Change subject: IMPALA-9784: Non correlated subqueries in HAVING. .. Patch Set 2: (8 comments) I think this makes sense, doing the

[Impala-ASF-CR] IMPALA-7020: fix costing of non-trivial CAST expressions

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16073 ) Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7020: fix costing of non-trivial CAST expressions

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16073 ) Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7020: fix costing of non-trivial CAST expressions

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16073 ) Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7020: fix costing of non-trivial CAST expressions

Hello Aman Sinha, Thomas Tauber-Marshall, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16073 to look at the new patch set (#5). Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions

[Impala-ASF-CR] IMPALA-9697: Support priority based scratch directory selection

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16091 ) Change subject: IMPALA-9697: Support priority based scratch directory selection .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7020: fix costing of non-trivial CAST expressions

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16073 ) Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-9790: option to use resolved hostname everywhere

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16108 Change subject: IMPALA-9790: option to use resolved hostname everywhere .. IMPALA-9790: option to use resolved hostname everywhere

[Impala-ASF-CR] IMPALA-9697: Support priority based scratch directory selection

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16091 ) Change subject: IMPALA-9697: Support priority based scratch directory selection .. Patch Set 2: (4 comments) I think this basically

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 41: (2 comments)

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 41: (6 comments) LGTM once the specific issues I mentioned

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key .. Patch Set 1: Yeah, I think we should probably be

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 6: (1 comment) I fixed most of the TODOs. I

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

Hello Quanlong Huang, Grant Henke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15966 to look at the new patch set (#8). Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose

[Impala-ASF-CR] IMPALA-7020: fix costing of non-trivial CAST expressions

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16073 ) Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-7020: fix costing of non-trivial CAST expressions

Hello Aman Sinha, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16073 to look at the new patch set (#4). Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions

[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 ) Change subject: IMPALA-8755: Unlock Z-ordering by default .. Patch Set 2: I'm going to start the merge, since it'd be great to have

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key .. Patch Set 1: Sahil, was the conclusion here that

[Impala-ASF-CR] IMPALA-8253: Parquet delta encoding and decoding.

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12621 ) Change subject: IMPALA-8253: Parquet delta encoding and decoding. .. Patch Set 16: Is this something that's still needed a review?

[Impala-ASF-CR] [WIP] IMPALA-8821: Use RECOVER PARTITIONS in dataload to get partition metadata

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14060 ) Change subject: [WIP] IMPALA-8821: Use RECOVER PARTITIONS in dataload to get partition metadata .. Patch Set 2: Is this something

[Impala-ASF-CR] Add raw values to pretty-printed time profiles.

Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/12403 ) Change subject: Add raw values to pretty-printed time profiles. .. Abandoned Stale code review -- To view, visit

[Impala-ASF-CR] IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/12497 ) Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh .. Abandoned Looks like this is no longer relevant

<    4   5   6   7   8   9   10   11   12   13   >