[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 19: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. IMPALA-376: add built-in functions for parsing

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 19: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 19: Build started:

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 18: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 18: Build Successful

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Quanlong Huang (Code Review)
Hello Greg Rahn, Zoltan Borok-Nagy, Attila Jeges, Todd Lipcon, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10950 to look at the new patch set (#18). Change subject: IMPALA-376: add built-in functions for parsing

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 17: Looks like a clang-tidy failure: 12:13:38

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 17: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 17: Will this warning fail the GVO?

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 17: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 16: Code-Review+2 LGTM! Thank you Quanlong for

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 16: Build Failed

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 16: (6 comments) Thanks for your patience too.

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Quanlong Huang (Code Review)
Hello Greg Rahn, Zoltan Borok-Nagy, Attila Jeges, Todd Lipcon, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10950 to look at the new patch set (#16). Change subject: IMPALA-376: add built-in functions for parsing

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 15: Code-Review+1 Just skimmed through what have

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 15: Code-Review+1 (4 comments) Thanks for your

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 15: (2 comments) Responses to responses. Need to

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 15: Build Failed

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-24 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 15: (24 comments) Thanks for your comments, Tim!

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-24 Thread Quanlong Huang (Code Review)
Hello Greg Rahn, Zoltan Borok-Nagy, Attila Jeges, Todd Lipcon, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10950 to look at the new patch set (#15). Change subject: IMPALA-376: add built-in functions for parsing

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 14: (23 comments) Based on the list discussion it

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 14: Build Successful

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-08 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 14: Add more tests for coverage and add support for

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-08 Thread Quanlong Huang (Code Review)
Hello Greg Rahn, Zoltan Borok-Nagy, Attila Jeges, Todd Lipcon, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10950 to look at the new patch set (#14). Change subject: IMPALA-376: add built-in functions for parsing

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-08 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-05 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-05 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-05 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: Yeah, we should have full test coverage on

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: > Patch Set 13: > > I think adding more tests for

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: I think adding more tests for the json path

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-27 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: > We can also add things to the random query

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: I didn't do anything that sophisticated - just

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: I don't feel really strongly, but this seems like

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: Code-Review+1 Thanks Quanlong for your great

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-27 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: (2 comments)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-27 Thread Quanlong Huang (Code Review)
Hello Zoltan Borok-Nagy, Attila Jeges, Todd Lipcon, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10950 to look at the new patch set (#13). Change subject: IMPALA-376: add built-in functions for parsing JSON

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 11: (3 comments) Thanks for applying the

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 12: (12 comments) Refactor based on comments and

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-25 Thread Quanlong Huang (Code Review)
Hello Zoltan Borok-Nagy, Attila Jeges, Todd Lipcon, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10950 to look at the new patch set (#12). Change subject: IMPALA-376: add built-in functions for parsing JSON

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 11: (11 comments)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-22 Thread Quanlong Huang (Code Review)
Hello Zoltan Borok-Nagy, Attila Jeges, Todd Lipcon, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10950 to look at the new patch set (#11). Change subject: IMPALA-376: add built-in functions for parsing JSON

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 10: (5 comments)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-22 Thread Quanlong Huang (Code Review)
Hello Zoltan Borok-Nagy, Attila Jeges, Todd Lipcon, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10950 to look at the new patch set (#10). Change subject: IMPALA-376: add built-in functions for parsing JSON

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (3 comments) Thanks for your response!

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (12 comments) Zoltan, thank you for taking a

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (12 comments) Thanks for taking this on! It

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-07-31 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-07-31 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (2 comments) Thanks for your cool idea! Just be

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-07-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-07-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10950 Change subject: IMPALA-376: add built-in functions for parsing JSON .. IMPALA-376: add built-in functions for parsing JSON This patch