[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. IMPALA-6728: Always use Kudu based

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-27 Thread Anonymous Coward (Code Review)
Anonymous Coward #248 has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 6: (2 comments) I have 2 minor findings only.

[Impala-ASF-CR] IMPALA-6338: Disable flaky bloom filter test

2018-03-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9822 ) Change subject: IMPALA-6338: Disable flaky bloom filter test .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. IMPALA-6389: Make '\0' delimited text files work

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9833 Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list. .. Adding "IMPALA-4277: Pin

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 3: (4 comments) Logic looks good to me, had some minor

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 4: (4 comments) This

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 6: Verified-1

[Impala-ASF-CR] IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION

2018-03-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9819 ) Change subject: IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9749 to look at the new patch set (#4). Change subject: IMPALA-6694: fix "buffer pool" child profile order ..

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. IMPALA-6752: fix pip --no-binary usage The key facts here

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. IMPALA-5980: Upgrade to LLVM 5.0.1 Highlighting a few changes in

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. Patch Set 4: Looks like a jenkins issue: 19:37:21

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 8: I was surprised this commit is missing

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9584 to look at the new patch set (#5). Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 3: Code-Review+2 This looks good to me. Thanks for

[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

2018-03-27 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9030 ) Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: Jin Chul, Could you please

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 8: > I was surprised this commit is

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Philip Zeyliger (Code Review)
Hello Michael Brown, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9743 to look at the new patch set (#9). Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9829 Change subject: IMPALA-6752: fix pip --no-binary usage .. IMPALA-6752: fix pip --no-binary usage The key facts here are: *

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 1: GVO and a Cloudera-internal build using a PYPI_MIRROR both got

[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9833 ) Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list. .. Adding "IMPALA-4277: Pin

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 3: Code-Review+1 This makes sense as I understand

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. IMPALA-6699: Fix DST end time for Australian

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. IMPALA-4277: Switch to using Hadoop 3

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 9: Verified+1 -- To view, visit

[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9833 ) Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list. .. Patch Set 1: Verified+1 There's no

[Impala-ASF-CR] IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9680 ) Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns .. Patch Set 12: Code-Review+1 (4 comments) Looks good,

[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9833 ) Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list. .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 1: (1 comment) Awesome find, this explains why --no-index seemingly

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 ) Change subject: IMPALA-4123 (prep): Parquet column reader cleanup .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-27 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9799 to look at the new patch set (#3). Change subject: IMPALA-4123 (prep): Parquet column reader cleanup

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 6: (10 comments)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-27 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#7). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9836 Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. IMPALA-6753: Update Hadoop versions in impala-config.sh

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread David Knupp (Code Review)
Hello Lars Volker, Michael Brown, Philip Zeyliger, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9836 to look at the new patch set (#3). Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh

[Impala-ASF-CR] IMPALA-6711: loosen shell test prompt regex

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9831 Change subject: IMPALA-6711: loosen shell test prompt regex .. IMPALA-6711: loosen shell test prompt regex We have seen this test fail

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Tim Armstrong (Code Review)
Hello Lars Volker, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9829 to look at the new patch set (#2). Change subject: IMPALA-6752: fix pip --no-binary usage

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5384, part 1: introduce InsertExecState

2018-03-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9793 ) Change subject: IMPALA-5384, part 1: introduce InsertExecState .. Patch Set 4: (13 comments)

[Impala-ASF-CR] IMPALA-5384, part 1: introduce InsertExecState

2018-03-27 Thread Dan Hecht (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9793 to look at the new patch set (#5). Change subject: IMPALA-5384, part 1: introduce InsertExecState

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-03-27 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. IMPALA-6649: Add fine-grained ALTER privilege Updated support and

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-03-27 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. IMPALA-6649: Add fine-grained ALTER privilege Updated support and

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-03-27 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. Patch Set 1: (16 comments) Resolved comments.

[Impala-ASF-CR] IMPALA-4277: Pin org.glassfish:javax.el version.

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9808 ) Change subject: IMPALA-4277: Pin org.glassfish:javax.el version. .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4277: Pin org.glassfish:javax.el version.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9808 ) Change subject: IMPALA-4277: Pin org.glassfish:javax.el version. .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. Patch Set 4: Code-Review+1 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create/drop function statements

2018-03-27 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create/drop function statements .. Patch Set 5: (10 comments)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#6). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9815 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-03-27 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. IMPALA-6649: Add fine-grained ALTER privilege Updated support and

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-03-27 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. Patch Set 3: (1 comment) Updated commit.

[Impala-ASF-CR] IMPALA-4277: Pin org.glassfish:javax.el version.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9808 ) Change subject: IMPALA-4277: Pin org.glassfish:javax.el version. .. Patch Set 1: -Verified -- To view, visit

[Impala-ASF-CR] IMPALA-4277: Pin org.glassfish:javax.el version.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9808 ) Change subject: IMPALA-4277: Pin org.glassfish:javax.el version. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-27 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 6: Code-Review+2 Rebase.

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. IMPALA-4277: Switch to using Hadoop 3 and friends by

[Impala-ASF-CR] IMPALA-4277: Pin org.glassfish:javax.el version.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9808 Change subject: IMPALA-4277: Pin org.glassfish:javax.el version. .. IMPALA-4277: Pin org.glassfish:javax.el version. This pins a

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 8: Tested in

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-03-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9815 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION

2018-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9819 ) Change subject: IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION .. IMPALA-6739: IndexOutOfBoundsException in ALTER

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-03-27 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. Patch Set 3: (2 comments) Answered questions.

[Impala-ASF-CR] IMPALA-4277: Pin org.glassfish:javax.el version.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9808 ) Change subject: IMPALA-4277: Pin org.glassfish:javax.el version. .. Patch Set 1: Tested in

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION

2018-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9819 Change subject: IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION .. IMPALA-6739: IndexOutOfBoundsException in ALTER

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9815 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-03-27 Thread Bharath Vissapragada (Code Review)
Hello Lars Volker, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9815 to look at the new patch set (#3). Change subject: IMPALA-6747: Automate diagnostics collection. ..

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9815 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 3: Code-Review+1 Philip, do you want to have another look?

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 6: Zach, can this be merged? -- To view, visit

[Impala-ASF-CR] IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION

2018-03-27 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9819 ) Change subject: IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create/drop function statements

2018-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create/drop function statements .. IMPALA-6724: Incorrect exception handling

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 ) Change subject: IMPALA-4123 (prep): Parquet column reader cleanup .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 ) Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 ) Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9813 ) Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect .. IMPALA-6510: [DOCS] Remove refresh_after_connect

  1   2   >