[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 17: Code-Review+2 rebase and fix minor

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#17). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR](2.x) Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10497 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7067: deflake test cancellation

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10499 ) Change subject: IMPALA-7067: deflake test_cancellation .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10495 ) Change subject: IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter

2018-05-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10495 ) Change subject: IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter .. Patch Set 1: Code-Review+2 thanks for the cleanup -- To

[Impala-ASF-CR] IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10495 ) Change subject: IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10495 ) Change subject: IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter .. IMPALA-4025: Part 1: Generalize and

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 17: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 ) Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 ) Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. Patch Set 1: > Is this a breaking

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-24 Thread Csaba Ringhofer (Code Review)
Hello Jim Apple, Attila Jeges, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10486 to look at the new patch set (#3). Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-24 Thread Csaba Ringhofer (Code Review)
Hello Jim Apple, Attila Jeges, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10486 to look at the new patch set (#2). Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 17: hmm. looks like some dependency order for

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 3: Hit IMPALA-7067 -- To view, visit

[Impala-ASF-CR](2.x) Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10497 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 ) Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. Patch Set 3: > > Is this a breaking change?

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 3: It looks like that flake occurred on a different branch too.

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

2018-05-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 ) Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. .. Patch Set 10: > Hi Jim, > > Please ignore the last

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances() RPC per query.

2018-05-24 Thread Rahul Shivu Mahadev (Code Review)
Rahul Shivu Mahadev has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10490 Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() RPC per query. .. IMPALA-4970: Record

[Impala-ASF-CR] IMPALA-7067: deflake test cancellation

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10499 ) Change subject: IMPALA-7067: deflake test_cancellation .. Patch Set 1: Well, we could make the test wait until we know the sleep has

[Impala-ASF-CR] IMPALA-7067: deflake test cancellation

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10499 ) Change subject: IMPALA-7067: deflake test_cancellation .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 4: > > preads add some

[Impala-ASF-CR](2.x) Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10497 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Trimming

[Impala-ASF-CR] IMPALA-7067: deflake test cancellation

2018-05-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10499 ) Change subject: IMPALA-7067: deflake test_cancellation .. Patch Set 1: Code-Review+2 Seems strictly better. It's a parallel test,

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 11: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] [DOCS] Sentry is required for Impala to enable delegation

2018-05-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10451 ) Change subject: [DOCS] Sentry is required for Impala to enable delegation .. Patch Set 2: Code-Review+2 Thanks for sharing the info.

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 11: The crash this hit is IMPALA-7069. I can reproduce it

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-05-24 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10503 Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. IMPALA-6812: Fix flaky Kudu scan tests Many of our Kudu related tests have

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10447 ) Change subject: IMPALA-7061: Rework HBase splitting and assignment .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not requirerd in comments

2018-05-24 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10474 ) Change subject: IMPALA-2751: Matching quotes are not requirerd in comments .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Sentry is required for Impala to enable delegation

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10451 ) Change subject: [DOCS] Sentry is required for Impala to enable delegation .. [DOCS] Sentry is required for Impala to

[Impala-ASF-CR] [DOCS] Sentry is required for Impala to enable delegation

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10451 ) Change subject: [DOCS] Sentry is required for Impala to enable delegation .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-05-24 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: ping -- To view, visit

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-05-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 17: Odd that this happens with gvo, but not for

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: Should we run benchmarks to see if upgrading this causes any regressions?

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh File

[Impala-ASF-CR] IMPALA-4025: Part 2: Add percentile disc aggregation function

2018-05-24 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/9777 ) Change subject: IMPALA-4025: Part 2: Add percentile_disc aggregation function .. IMPALA-4025: Part 2: Add percentile_disc aggregation

[Impala-ASF-CR] IMPALA-4025: Part 3: Add percentile cont & median aggregation functions

2018-05-24 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9778 ) Change subject: IMPALA-4025: Part 3: Add percentile_cont & median aggregation functions .. IMPALA-4025: Part 3: Add percentile_cont &

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh File

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not requirerd in comments

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10474 ) Change subject: IMPALA-2751: Matching quotes are not requirerd in comments .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7067: deflake test cancellation

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10499 ) Change subject: IMPALA-7067: deflake test_cancellation .. Patch Set 3: Verified+1 Code-Review+2 Rebase and carry verification/+2 --

[Impala-ASF-CR] IMPALA-7067: deflake test cancellation

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10499 ) Change subject: IMPALA-7067: deflake test_cancellation .. IMPALA-7067: deflake test_cancellation Tweak the query so that it

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances() RPC per query.

2018-05-24 Thread Rahul Shivu Mahadev (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10490 to look at the new patch set (#2). Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() RPC per query.

[Impala-ASF-CR] [DOCS] Sentry is required for Impala to enable delegation

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10451 ) Change subject: [DOCS] Sentry is required for Impala to enable delegation .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10447 ) Change subject: IMPALA-7061: Rework HBase splitting and assignment .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: It looks like there's some history here, but can we make

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. IMPALA-7055: fix race with DML errors Error statuses could

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-24 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 ) Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. Patch Set 3: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10447 ) Change subject: IMPALA-7061: Rework HBase splitting and assignment .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor tje INVALIDATE METADATA and REFRESH docs

2018-05-24 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 ) Change subject: IMPALA-6987: [DOCS] Refactor tje INVALIDATE METADATA and REFRESH docs .. Patch Set 3: The latest HTML docs were shared

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10447 ) Change subject: IMPALA-7061: Rework HBase splitting and assignment .. IMPALA-7061: Rework HBase splitting and

[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs

2018-05-24 Thread Alex Rodoni (Code Review)
Hello Balazs Jeszenszky, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10339 to look at the new patch set (#4). Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs

[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10504 ) Change subject: IMPALA-7068: fix test_unsupported_text_compression table location .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location

2018-05-24 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10504 ) Change subject: IMPALA-7068: fix test_unsupported_text_compression table location .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances() RPC per query.

2018-05-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() RPC per query. .. Patch Set 2: (9 comments)

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Bump libunwind version to 1.3-rc1 This changes bumps libunwind to version

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 1: Verified+1 Built the toolchain locally -- To view, visit

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. IMPALA-6953: part 1: clean up DiskIoMgr There should be no

[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location

2018-05-24 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10504 Change subject: IMPALA-7068: fix test_unsupported_text_compression table location .. IMPALA-7068: fix test_unsupported_text_compression

[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10504 ) Change subject: IMPALA-7068: fix test_unsupported_text_compression table location .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location

2018-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10504 ) Change subject: IMPALA-7068: fix test_unsupported_text_compression table location .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 18: latest change explicitly adds a dep for

[Impala-ASF-CR] [DOCS] Complex types in DDL not supported for text format files

2018-05-24 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10508 Change subject: [DOCS] Complex types in DDL not supported for text format files .. [DOCS] Complex types in DDL not supported for text

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not requirerd in comments

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10474 ) Change subject: IMPALA-2751: Matching quotes are not requirerd in comments .. IMPALA-2751: Matching quotes are not

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not requirerd in comments

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10474 ) Change subject: IMPALA-2751: Matching quotes are not requirerd in comments .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-24 Thread Rahul Shivu Mahadev (Code Review)
Rahul Shivu Mahadev has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 3: (9 comments)

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 12: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#18). Change subject: IMPALA-5931: Generates scan ranges

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10496/1/buildall.sh

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 1: (1 comment)

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10496/1/buildall.sh

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-24 Thread Rahul Shivu Mahadev (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10490 to look at the new patch set (#3). Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

[Impala-ASF-CR] IMPALA-7012: Fix NPE when parsing unexpected tokens

2018-05-24 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10512 Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens .. IMPALA-7012: Fix NPE when parsing unexpected tokens Currently

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

2018-05-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 ) Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. .. Patch Set 10: > > (1 comment) > > Hi Jim, in the original

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh File

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/10480 To

[Impala-ASF-CR] IMPALA-5522: Add support for authorized proxy groups

2018-05-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10510 Change subject: IMPALA-5522: Add support for authorized proxy groups .. IMPALA-5522: Add support for authorized proxy groups The patch

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-24 Thread Lars Volker (Code Review)
Hello Thomas Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10483 to look at the new patch set (#3). Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-24 Thread Lars Volker (Code Review)
Hello Thomas Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10483 to look at the new patch set (#4). Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 14: (2 comments) > Do we have sufficient test

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10480 to look at the new patch set (#2). Change subject: Upgrade Protobuf to 3.5.1 .. Upgrade Protobuf to

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-24 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#15). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 18: Code-Review+2 -- To view, visit

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10480 To

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 2: Verified the change by building on various platforms and tried the new bits on

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10480 To

[Impala-ASF-CR] IMPALA-5740: [DOCS] Correct the max length of STRING

2018-05-24 Thread Alex Rodoni (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10511 to look at the new patch set (#2). Change subject: IMPALA-5740: [DOCS] Correct the max length of STRING

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10483 ) Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size .. Patch Set 2: (1 comment) Thanks for the review.

[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10504 ) Change subject: IMPALA-7068: fix test_unsupported_text_compression table location .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location

2018-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10504 ) Change subject: IMPALA-7068: fix test_unsupported_text_compression table location .. IMPALA-7068: fix