[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics .. Patch Set 5: -Code-Review Can we add a test

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics .. Patch Set 5: (9 comments) Thanks. I'm

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 12: Build Started

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. IMPALA-7209: Disallow self referencing in ALTER

[Impala-ASF-CR] IMPALA-6490: Reconnect shell when remote restarts

2018-07-30 Thread Le Minh Nghia (Code Review)
Hello Zoltan Borok-Nagy, Attila Jeges, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10992 to look at the new patch set (#6). Change subject: IMPALA-6490: Reconnect shell when remote restarts

[Impala-ASF-CR] IMPALA-6490: Reconnect shell when remote restarts

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 ) Change subject: IMPALA-6490: Reconnect shell when remote restarts .. Patch Set 6: Build Started

[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository

2018-07-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Patch Set 3: Code-Review+1 (1 comment) Thanks. This looks

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-07-30 Thread Csaba Ringhofer (Code Review)
Hello Attila Jeges, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11064 to look at the new patch set (#4). Change subject: IMPALA-7362: Add query option to set timezone

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 11: Code-Review+2 (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-6490: Reconnect shell when remote restarts

2018-07-30 Thread Le Minh Nghia (Code Review)
Le Minh Nghia has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 ) Change subject: IMPALA-6490: Reconnect shell when remote restarts .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 12: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 13: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 13: (3 comments) Yeah I was anticipating that this

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 14: Build Started

[Impala-ASF-CR] IMPALA-6490: Reconnect shell when remote restarts

2018-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 ) Change subject: IMPALA-6490: Reconnect shell when remote restarts .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 14: Changes weren't totally trivial so I'll let you

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 11: fyi, the builds probably failed because of

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics .. Patch Set 5: I should add that I think

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 14: (3 comments)

[Impala-ASF-CR] IMPALA-7234: Improve memory estimates produced by the Planner

2018-07-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11001 ) Change subject: IMPALA-7234: Improve memory estimates produced by the Planner .. IMPALA-7234: Improve memory estimates produced by

[Impala-ASF-CR] IMPALA-7234: Improve memory estimates produced by the Planner

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11001 ) Change subject: IMPALA-7234: Improve memory estimates produced by the Planner .. Patch Set 6: Build Started

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 ) Change subject: IMPALA-7362: Add query option to set timezone .. Patch Set 4: Build Started

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics .. Patch Set 5: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-6490: Reconnect shell when remote restarts

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 ) Change subject: IMPALA-6490: Reconnect shell when remote restarts .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 13: Build Started

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 ) Change subject: IMPALA-7362: Add query option to set timezone .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7170: Update data generator.py for Hadoop 3

2018-07-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11041 ) Change subject: IMPALA-7170: Update data_generator.py for Hadoop 3 .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 12: Code-Review+2 Carry -- To view, visit

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 12: Build Started

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Tim Armstrong (Code Review)
Hello Thomas Marshall, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11007 to look at the new patch set (#12). Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 ) Change subject: IMPALA-7362: Add query option to set timezone .. Patch Set 2: (2 comments) The future of this change in under

[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups

2018-07-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 ) Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 13: Code-Review+2 (3 comments) I looked this over.

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Tim Armstrong (Code Review)
Hello Michael Brown, Philip Zeyliger, David Knupp, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11054 to look at the new patch set (#14). Change subject: IMPALA-7317: add scripts to post flake8 comments

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. IMPALA-7209: Disallow self referencing in ALTER

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6034: Add scanned bytes limits per query

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11081 ) Change subject: IMPALA-6034: Add scanned bytes limits per query .. Patch Set 1: Code-Review+1 Carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-6034: Add scanned bytes limits per query

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add scanned bytes limits per query .. Abandoned Move to https://gerrit.cloudera.org/#/c/11081/ -- To view, visit

[Impala-ASF-CR] IMPALA-6034: Add scanned bytes limits per query

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11081 ) Change subject: IMPALA-6034: Add scanned bytes limits per query .. Patch Set 1: Continuing from

[Impala-ASF-CR] [WIP] IMPALA-6153: Execute UpdateFilter() only for executing queries

2018-07-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11005 ) Change subject: [WIP] IMPALA-6153: Execute UpdateFilter() only for executing queries .. [WIP] IMPALA-6153: Execute UpdateFilter()

[Impala-ASF-CR] IMPALA-6335. Allow most shell tests to run in parallel

2018-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11045 ) Change subject: IMPALA-6335. Allow most shell tests to run in parallel .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository

2018-07-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6644: Add recent heartbeat timestamp into Statestore metric

2018-07-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add recent heartbeat timestamp into Statestore metric .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-6034: Add scanned bytes limits per query

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11081 Change subject: IMPALA-6034: Add scanned bytes limits per query .. IMPALA-6034: Add scanned bytes limits per query This adds support

[Impala-ASF-CR] IMPALA-6644: Add recent heartbeat timestamp into Statestore metric

2018-07-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add recent heartbeat timestamp into Statestore metric .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6644: Add recent heartbeat timestamp into Statestore metric

2018-07-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add recent heartbeat timestamp into Statestore metric .. IMPALA-6644: Add recent heartbeat timestamp

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-30 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#9). Change subject: IMPALA-7163: Implement a state machine for the QueryState class

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 14: Code-Review+2 Fix tests, will wait for

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Tim Armstrong (Code Review)
Hello Thomas Marshall, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11007 to look at the new patch set (#14). Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

[Impala-ASF-CR] IMPALA-7234: Improve memory estimates produced by the Planner

2018-07-30 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has removed Bharath Vissapragada from this change. ( http://gerrit.cloudera.org:8080/11001 ) Change subject: IMPALA-7234: Improve memory estimates produced by the Planner .. Removed reviewer Bharath

[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog

2018-07-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 ) Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog .. Patch Set 1: (7 comments) Looks good. The way that hbase

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 8: (9 comments)

[Impala-ASF-CR] [DOCS] Dedicated coordinators and executors explained

2018-07-30 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11080 Change subject: [DOCS] Dedicated coordinators and executors explained .. [DOCS] Dedicated coordinators and executors explained

[Impala-ASF-CR] IMPALA-7296: bytes limit for row batch queue

2018-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10977 ) Change subject: IMPALA-7296: bytes limit for row batch queue .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7296: bytes limit for row batch queue

2018-07-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10977 ) Change subject: IMPALA-7296: bytes limit for row batch queue .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [WIP] IMPALA-6153: Execute UpdateFilter() only for executing queries

2018-07-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11005 ) Change subject: [WIP] IMPALA-6153: Execute UpdateFilter() only for executing queries .. Patch Set 4: (7 comments) I have

[Impala-ASF-CR] IMPALA-6335. Allow most shell tests to run in parallel

2018-07-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11045 ) Change subject: IMPALA-6335. Allow most shell tests to run in parallel .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository

2018-07-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Patch Set 4: > Patch Set 3: Code-Review+1 > > (1 comment) > >

[Impala-ASF-CR] IMPALA-3330: [DOCS] TRANSLATE function updated

2018-07-30 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11074 ) Change subject: IMPALA-3330: [DOCS] TRANSLATE function updated .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository

2018-07-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. IMPALA-7329: Blacklist CDH Maven snapshots repository The

[Impala-ASF-CR] IMPALA-7234: Improve memory estimates produced by the Planner

2018-07-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11001 ) Change subject: IMPALA-7234: Improve memory estimates produced by the Planner .. IMPALA-7234: Improve memory estimates produced by

[Impala-ASF-CR] IMPALA-7234: Improve memory estimates produced by the Planner

2018-07-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11001 ) Change subject: IMPALA-7234: Improve memory estimates produced by the Planner .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 14: Seems fine. Have you yet tested reviews with

[Impala-ASF-CR] IMPALA-7234: Improve memory estimates produced by the Planner

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11001 ) Change subject: IMPALA-7234: Improve memory estimates produced by the Planner .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-30 Thread Bharath Vissapragada (Code Review)
Hello Tianyi Wang, Philip Zeyliger, Todd Lipcon, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10998 to look at the new patch set (#6). Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-7296: bytes limit for row batch queue

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10977 ) Change subject: IMPALA-7296: bytes limit for row batch queue .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7296: bytes limit for row batch queue

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10977 ) Change subject: IMPALA-7296: bytes limit for row batch queue .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics .. Patch Set 6: Build Started

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 17: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics

2018-07-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 ) Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-4690: [DOCS] More content for CONV()

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11075 ) Change subject: IMPALA-4690: [DOCS] More content for CONV() .. Patch Set 2: Verified+1 Build Successful

[Impala-ASF-CR] Fix TestKuduOperations tests in test-with-docker by using consistent hostname.

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11082 ) Change subject: Fix TestKuduOperations tests in test-with-docker by using consistent hostname. .. Patch Set 1: Verified-1

[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 ) Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog .. Patch Set 1: No Builds Executed -- To view,

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 9: No Builds Executed -- To

[Impala-ASF-CR] IMPALA-7234: Improve memory estimates produced by the Planner

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11001 ) Change subject: IMPALA-7234: Improve memory estimates produced by the Planner .. Patch Set 7: No Builds Executed -- To

[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Patch Set 4: No Builds Executed -- To view, visit

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 14: No Builds Executed -- To view,

[Impala-ASF-CR] [WIP] IMPALA-6153: Execute UpdateFilter() only for executing queries

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11005 ) Change subject: [WIP] IMPALA-6153: Execute UpdateFilter() only for executing queries .. Patch Set 5: No Builds Executed --

[Impala-ASF-CR] Fix TestKuduOperations tests in test-with-docker by using consistent hostname.

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11082 ) Change subject: Fix TestKuduOperations tests in test-with-docker by using consistent hostname. .. Patch Set 1: No Builds

[Impala-ASF-CR] IMPALA-6335. Allow most shell tests to run in parallel

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11045 ) Change subject: IMPALA-6335. Allow most shell tests to run in parallel .. Patch Set 3: No Builds Executed -- To view, visit

[Impala-ASF-CR] IMPALA-6034: Add scanned bytes limits per query

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11081 ) Change subject: IMPALA-6034: Add scanned bytes limits per query .. Patch Set 1: No Builds Executed -- To view, visit

[Impala-ASF-CR] IMPALA-6644: Add recent heartbeat timestamp into Statestore metric

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add recent heartbeat timestamp into Statestore metric .. Patch Set 3: No Builds Executed --

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 ) Change subject: IMPALA-7362: Add query option to set timezone .. Patch Set 2: (1 comment) Thanks for mentioning the ANSI SQL

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 14: I ran the job pointed at a CR with no python

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 15: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Tim Armstrong (Code Review)
Hello Michael Brown, Philip Zeyliger, David Knupp, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11054 to look at the new patch set (#15). Change subject: IMPALA-7317: add scripts to post flake8 comments

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 15: Build Started

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 14: Build started:

[Impala-ASF-CR] [DOCS] Dedicated coordinators and executors explained

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11080 ) Change subject: [DOCS] Dedicated coordinators and executors explained .. Patch Set 3: Verified-1 Build Failed

[Impala-ASF-CR] WIP: IMPALA-7317: comment on long lines and whitespace

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11085 ) Change subject: WIP: IMPALA-7317: comment on long lines and whitespace .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 ) Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups .. Patch Set 4: Verified+1 Build Successful

[Impala-ASF-CR] [WIP] IMPALA-6153: Execute UpdateFilter() only for executing queries

2018-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11005 ) Change subject: [WIP] IMPALA-6153: Execute UpdateFilter() only for executing queries .. Patch Set 6: Build Successful

  1   2   >