[Impala-ASF-CR] IMPALA-3040: Remove cache directive before dropping a table

2018-06-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directive before dropping a table .. Patch Set 2: Your theory seems plausible to me

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/108

[Impala-ASF-CR] IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated

2018-06-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10815 ) Change subject: IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated .. Patch Set 2: (2 commen

[Impala-ASF-CR] IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated

2018-06-26 Thread Dan Hecht (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10815 to look at the new patch set (#2). Change subject: IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated ...

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. IMPALA-6305: Allow column definitions in ALTER V

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 8: Verified+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 6: Code-Review+1 (3 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-06-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 1: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-06-26 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10835 Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. IMPALA-7212: Deprecate --use_krpc flag and re

[Impala-ASF-CR] IMPALA-3040: Remove cache directive before dropping a table

2018-06-26 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directive before dropping a table .. Patch Set 2: The exception thrown is: E0614 17:03:05.768

[Impala-ASF-CR] IMPALA-5981: [DOCS] Documented SET=""

2018-06-26 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10816 ) Change subject: IMPALA-5981: [DOCS] Documented SET="" .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10816/1/docs/topi

[Impala-ASF-CR] IMPALA-5981: [DOCS] Documented SET=""

2018-06-26 Thread Alex Rodoni (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10816 to look at the new patch set (#2). Change subject: IMPALA-5981: [DOCS] Documented SET="" ...

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 18: Verified-1 Build failed: https://jenkins.impala.io/jo

[Impala-ASF-CR] [DOCS] Clarification on admission control and DDL statements

2018-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10829 ) Change subject: [DOCS] Clarification on admission control and DDL statements .. Patch Set 2: To be clear, I meant the existing text ab

[Impala-ASF-CR] [DOCS] Clarification on admission control and DDL statements

2018-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10829 ) Change subject: [DOCS] Clarification on admission control and DDL statements .. Patch Set 2: (7 comments) Thanks for taking this on.

[Impala-ASF-CR] IMPALA-5981: [DOCS] Documented SET=""

2018-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10816 ) Change subject: IMPALA-5981: [DOCS] Documented SET="" .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10816/1/docs/to

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-26 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 5: (9 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-26 Thread Thomas Marshall (Code Review)
Hello Tim Armstrong, Alex Behm, Vuk Ercegovac, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10394 to look at the new patch set (#5). Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode ..

[Impala-ASF-CR] IMPALA-7149: Disable some tests in the EC build

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10804 ) Change subject: IMPALA-7149: Disable some tests in the EC build .. IMPALA-7149: Disable some tests in the EC build We

[Impala-ASF-CR] IMPALA-7149: Disable some tests in the EC build

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10804 ) Change subject: IMPALA-7149: Disable some tests in the EC build .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 8: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 8: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-7102(Part 1): Disable reading of erasure coding by default

2018-06-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102(Part 1): Disable reading of erasure coding by default .. IMPALA-7102(Part 1): Disable reading of erasure

[Impala-ASF-CR] IMPALA-7102: Disable support of erasure coding by default

2018-06-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102: Disable support of erasure coding by default .. Patch Set 1: (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion()

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10705 ) Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() .. IMPALA-6816: minimise calls to GetMinS

[Impala-ASF-CR] IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion()

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10705 ) Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() .. Patch Set 7: Verified+1 -- To view, visit ht

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. IMPALA-6305: Allow column definitions in ALTER VIEW This chang

[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 2: Verified-1 Build failed: https:/

[Impala-ASF-CR] [DOCS] Clarification on admission control and DDL statements

2018-06-26 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10829 ) Change subject: [DOCS] Clarification on admission control and DDL statements .. Patch Set 2: > I think this is somehow much more confusi

[Impala-ASF-CR] [DOCS] Clarification on admission control and DDL statements

2018-06-26 Thread Alex Rodoni (Code Review)
Hello Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10829 to look at the new patch set (#2). Change subject: [DOCS] Clarification on admission control and DDL statements

[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 2: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh

2018-06-26 Thread Joe McDonnell (Code Review)
Hello Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10615 to look at the new patch set (#2). Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh ...

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2018-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 5: Verified+1 Fixed the issue, confirmed that it bui

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2018-06-26 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#5). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 18: Build started: https://jenkins.impala.io/job/gerrit-v

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 18: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] [DOCS] Clarification on admission control and DDL statements

2018-06-26 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10829 ) Change subject: [DOCS] Clarification on admission control and DDL statements .. Patch Set 1: I think this is somehow much more con

[Impala-ASF-CR] [DOCS] Clarification on admission control and DDL statements

2018-06-26 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10829 Change subject: [DOCS] Clarification on admission control and DDL statements .. [DOCS] Clarification on admission control and DDL statemen

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 9: Build started: https://je

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 9: Code-Review+2 -- To view

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-06-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 8: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-06-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. IMPALA-6625: Skip computing parquet conjuncts

[Impala-ASF-CR] IMPALA-7149: Disable some tests in the EC build

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10804 ) Change subject: IMPALA-7149: Disable some tests in the EC build .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-7149: Disable some tests in the EC build

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10804 ) Change subject: IMPALA-7149: Disable some tests in the EC build .. Patch Set 3: Build started: https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion()

2018-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10705 ) Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() .. Patch Set 6: Code-Review+2 (1 comment) Thanks for th

[Impala-ASF-CR] IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion()

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10705 ) Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() .. Patch Set 7: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion()

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10705 ) Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion()

2018-06-26 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10705 to look at the new patch set (#6). Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() ..

[Impala-ASF-CR] IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion()

2018-06-26 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10705 ) Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10827 Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215: Implement a templatized CountingBarrier Currently,

[Impala-ASF-CR] IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated

2018-06-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10815 ) Change subject: IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated .. Patch Set 1: (1 co

[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10814 ) Change subject: IMPALA-7210: global debug actions should be case insensitive .. IMPALA-7210: global debug actions shoul

[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10814 ) Change subject: IMPALA-7210: global debug actions should be case insensitive .. Patch Set 3: Verified+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-06-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. IMPALA-6625: Skip computing parquet conjuncts

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-06-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 5: > Patch Set 3: > > I don't thi

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-06-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. IMPALA-6625: Skip computing parquet conjuncts

[Impala-ASF-CR] IMPALA-6425: reduce MemPool max chunk size

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10789 ) Change subject: IMPALA-6425: reduce MemPool max chunk size .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6425: reduce MemPool max chunk size

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10789 ) Change subject: IMPALA-6425: reduce MemPool max chunk size .. IMPALA-6425: reduce MemPool max chunk size IMPALA-2742 c

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 18: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 20: (11 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-26 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Michael Brown, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#20). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing sam

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (12 comments) Some initial high level com

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. IMPALA-7095: clean up scan node profiles Add counters to scan node implement

[Impala-ASF-CR] IMPALA-7190: Remove unsupported format writer support

2018-06-26 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10823 Change subject: IMPALA-7190: Remove unsupported format writer support .. IMPALA-7190: Remove unsupported format writer support This pa

[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10814 ) Change subject: IMPALA-7210: global debug actions should be case insensitive .. Patch Set 3: Build started: https://jenkins.im

[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive

2018-06-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10814 ) Change subject: IMPALA-7210: global debug actions should be case insensitive .. Patch Set 3: Code-Review+2 Carry -- To view, visit http:

[Impala-ASF-CR] WIP IMPALA-7178: Add the possibility to reduce logging for common data errors

2018-06-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10793 ) Change subject: WIP IMPALA-7178: Add the possibility to reduce logging for common data errors .. Patch Set 1: (2 comments) http://gerrit

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6425: reduce MemPool max chunk size

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10789 ) Change subject: IMPALA-6425: reduce MemPool max chunk size .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-6425: reduce MemPool max chunk size

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10789 ) Change subject: IMPALA-6425: reduce MemPool max chunk size .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-6425: reduce MemPool max chunk size

2018-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10789 ) Change subject: IMPALA-6425: reduce MemPool max chunk size .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10789/1/be

[Impala-ASF-CR] IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion()

2018-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10705 ) Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion()

2018-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10705 ) Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() .. Patch Set 5: I looped the modified test overnight -

[Impala-ASF-CR] IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion()

2018-06-26 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10705 to look at the new patch set (#5). Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() ..

[Impala-ASF-CR] WIP IMPALA-7178: Add the possibility to reduce logging for common data errors

2018-06-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10793 ) Change subject: WIP IMPALA-7178: Add the possibility to reduce logging for common data errors .. Patch Set 1: (2 comments) http://

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 19: Cleaned up impala-flake8 output

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-26 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Michael Brown, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#19). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing sam

[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive

2018-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10814 ) Change subject: IMPALA-7210: global debug actions should be case insensitive .. Patch Set 2: Verified-1 Build failed: https://