[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services

2018-07-17 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10835 to look at the new patch set (#4). Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services

[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services

2018-07-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-7311. Allow INSERT on writable partitions even if some other partition is READ ONLY

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10974 ) Change subject: IMPALA-7311. Allow INSERT on writable partitions even if some other partition is READ_ONLY .. Patch Set 1:

[Impala-ASF-CR] IMPALA-7314: Doc generation should fail on error

2018-07-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10976 Change subject: IMPALA-7314: Doc generation should fail on error .. IMPALA-7314: Doc generation should fail on error This patch updates

[Impala-ASF-CR] IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10918 ) Change subject: IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis .. Patch Set 5: Verified+1 -- To

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 4: Verified+1 -- To

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. IMPALA-7059:

[Impala-ASF-CR] [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc

2018-07-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10975 Change subject: [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc .. [DOCS] Fix UPDATE/UPSERT/DELETE authorization doc The patch also

[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10964 ) Change subject: IMPALA-7014: Disable stacktrace symbolisation by default .. IMPALA-7014: Disable stacktrace

[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10964 ) Change subject: IMPALA-7014: Disable stacktrace symbolisation by default .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog

2018-07-17 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10914 to look at the new patch set (#3). Change subject: IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog

[Impala-ASF-CR] IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable

2018-07-17 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10973 to review the following change. Change subject: IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable

[Impala-ASF-CR] IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog

2018-07-17 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10972 to review the following change. Change subject: IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog

[Impala-ASF-CR] IMPALA-7307 (part 1). Support stats extrapolation in LocalCatalog

2018-07-17 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10971 to review the following change. Change subject: IMPALA-7307 (part 1). Support stats extrapolation in LocalCatalog

[Impala-ASF-CR] IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog

2018-07-17 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Csaba Ringhofer, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10913 to look at the new patch set (#3). Change subject: IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog

[Impala-ASF-CR] IMPALA-7311. Allow INSERT on writable partitions even if some other partition is READ ONLY

2018-07-17 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10974 to review the following change. Change subject: IMPALA-7311. Allow INSERT on writable partitions even if some other partition is READ_ONLY

[Impala-ASF-CR] IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10914 ) Change subject: IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10913 ) Change subject: IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog

2018-07-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10914 ) Change subject: IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog .. Patch Set 2: Code-Review+2 remaining

[Impala-ASF-CR] IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10918 ) Change subject: IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10918 ) Change subject: IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis

2018-07-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10918 ) Change subject: IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7217: Incorrect UPDATE/DELETE authorization privilege

2018-07-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10966 Change subject: IMPALA-7217: Incorrect UPDATE/DELETE authorization privilege .. IMPALA-7217: Incorrect UPDATE/DELETE authorization

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 3: > (1 comment) Another wrinkle here is that this doesn't

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 4: Code-Review+2 --

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 3: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. IMPALA-7059: Inconsistent privilege

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 11: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis

2018-07-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10918 ) Change subject: IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis

2018-07-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10918 ) Change subject: IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis .. IMPALA-6881: COMPUTE STATS should require

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10964 ) Change subject: IMPALA-7014: Disable stacktrace symbolisation by default .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10964 ) Change subject: IMPALA-7014: Disable stacktrace symbolisation by default .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7294. TABLESAMPLE should not allocate array based on total table file count

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10936 ) Change subject: IMPALA-7294. TABLESAMPLE should not allocate array based on total table file count .. IMPALA-7294. TABLESAMPLE

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7294. TABLESAMPLE should not allocate array based on total table file count

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10936 ) Change subject: IMPALA-7294. TABLESAMPLE should not allocate array based on total table file count .. Patch Set 1: Verified+1

[Impala-ASF-CR] cleanup: extract RowBatchQueue into its own file

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10943 ) Change subject: cleanup: extract RowBatchQueue into its own file .. cleanup: extract RowBatchQueue into its own file

[Impala-ASF-CR] cleanup: extract RowBatchQueue into its own file

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10943 ) Change subject: cleanup: extract RowBatchQueue into its own file .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default

2018-07-17 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10964 Change subject: IMPALA-7014: Disable stacktrace symbolisation by default .. IMPALA-7014: Disable stacktrace symbolisation by default

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7186: [DOCS] Documented the KUDU READ MODE query option

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10897 ) Change subject: IMPALA-7186: [DOCS] Documented the KUDU_READ_MODE query option .. IMPALA-7186: [DOCS] Documented the

[Impala-ASF-CR] IMPALA-7186: [DOCS] Documented the KUDU READ MODE query option

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10897 ) Change subject: IMPALA-7186: [DOCS] Documented the KUDU_READ_MODE query option .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7186: [DOCS] Documented the KUDU READ MODE query option

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10897 ) Change subject: IMPALA-7186: [DOCS] Documented the KUDU_READ_MODE query option .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7186: [DOCS] Documented the KUDU READ MODE query option

2018-07-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10897 ) Change subject: IMPALA-7186: [DOCS] Documented the KUDU_READ_MODE query option .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7186: [DOCS] Documented the KUDU READ MODE query option

2018-07-17 Thread Alex Rodoni (Code Review)
Hello Thomas Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10897 to look at the new patch set (#4). Change subject: IMPALA-7186: [DOCS] Documented the KUDU_READ_MODE query option

[Impala-ASF-CR] IMPALA-7186: [DOCS] Documented the KUDU READ MODE query option

2018-07-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10897 ) Change subject: IMPALA-7186: [DOCS] Documented the KUDU_READ_MODE query option .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-17 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. IMPALA-7209: Disallow self referencing in ALTER

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-17 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-7186: [DOCS] Documented the KUDU READ MODE query option

2018-07-17 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10897 ) Change subject: IMPALA-7186: [DOCS] Documented the KUDU_READ_MODE query option .. Patch Set 3: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7294. TABLESAMPLE should not allocate array based on total table file count

2018-07-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10936 ) Change subject: IMPALA-7294. TABLESAMPLE should not allocate array based on total table file count .. Patch Set 1: Code-Review+2 --

[Impala-ASF-CR] IMPALA-7294. TABLESAMPLE should not allocate array based on total table file count

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10936 ) Change subject: IMPALA-7294. TABLESAMPLE should not allocate array based on total table file count .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-7294. TABLESAMPLE should not allocate array based on total table file count

2018-07-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10936 ) Change subject: IMPALA-7294. TABLESAMPLE should not allocate array based on total table file count .. Patch Set 1: Code-Review+2

[Impala-ASF-CR] cleanup: extract RowBatchQueue into its own file

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10943 ) Change subject: cleanup: extract RowBatchQueue into its own file .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] cleanup: extract RowBatchQueue into its own file

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10943 ) Change subject: cleanup: extract RowBatchQueue into its own file .. Patch Set 3: Build started:

[Impala-ASF-CR] cleanup: extract RowBatchQueue into its own file

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10943 ) Change subject: cleanup: extract RowBatchQueue into its own file .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 3: (1 comment)

[Impala-ASF-CR](2.x) IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10960 ) Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. .. Patch Set 1: Verified-1

[Impala-ASF-CR] IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog

2018-07-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10914 ) Change subject: IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10914 ) Change subject: IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog

2018-07-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10914 ) Change subject: IMPALA-7277. Support INSERT and LOAD DATA statements in LocalCatalog .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-17 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 5: Code-Review+1 LGTM -- To

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7199: Add scripts to create code coverage reports

2018-07-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10791 ) Change subject: IMPALA-7199: Add scripts to create code coverage reports .. IMPALA-7199: Add scripts to create code coverage

[Impala-ASF-CR] IMPALA-7238: Use custom timeout for create unique database

2018-07-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10862 ) Change subject: IMPALA-7238: Use custom timeout for create unique database .. IMPALA-7238: Use custom timeout for create

[Impala-ASF-CR] Remove dead multiple filesystems member from THdfsTable

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10935 ) Change subject: Remove dead multiple_filesystems member from THdfsTable .. Remove dead multiple_filesystems member from

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 2: (1 comment) > (1 comment) > > Yeah I generally

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Jim Apple (Code Review)
Hello Zoltan Borok-Nagy, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10948 to look at the new patch set (#3). Change subject: IMPALA-5031: Fix undefined behavior: memset NULL

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 2: (1 comment) Yeah I generally disagree with the idea

[Impala-ASF-CR] [experimental] Clang Tidy Diff trial balloon

2018-07-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9751 ) Change subject: [experimental] Clang Tidy Diff trial balloon .. Patch Set 2: Now that the clang-tidy quiet patch is in, is this unblocked?

[Impala-ASF-CR](2.x) IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10960 ) Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. .. Patch Set 1: Build

[Impala-ASF-CR](2.x) IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.

2018-07-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10960 ) Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. .. Patch Set 1: Code-Review+2 --

[Impala-ASF-CR](2.x) IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.

2018-07-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10960 to review the following change. Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 2: Code-Review+1 Thank you for your answers, lgtm.

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 2: > Do we want to update the other call sites of

[Impala-ASF-CR] IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10951 ) Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. .. IMPALA-7304: Don't

[Impala-ASF-CR] IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10951 ) Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. .. Patch Set 2: Verified+1

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL

2018-07-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 2: Do we want to update the other call sites of

[Impala-ASF-CR] IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10951 ) Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10951 ) Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. .. Patch Set 2: Code-Review+2

[Impala-ASF-CR] Remove dead multiple filesystems member from THdfsTable

2018-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10935 ) Change subject: Remove dead multiple_filesystems member from THdfsTable .. Patch Set 1: Verified+1 -- To view, visit