[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-20 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Laszlo Gaal, Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#11). Change subject: IMPALA-5801: Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-20 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#15). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 14: (6 comments)

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-02-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9403 Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. IMPALA-6324: Support reading

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-02-22 Thread Csaba Ringhofer (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9403 to look at the new patch set (#2). Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-16 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#14). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: I took the liberty to make the GetIntConstant

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-16 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#8). Change subject: IMPALA-5801: Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 17: (3 comments) I have marked the

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-22 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#16). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-22 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#17). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2017-12-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2017-12-22 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#6). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-7175: deflake check for failed impalad

2018-06-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10745 ) Change subject: IMPALA-7175: deflake check for failed impalad .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7175: deflake check for failed impalad

2018-06-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10745 ) Change subject: IMPALA-7175: deflake check for failed impalad .. Patch Set 3: Code-Review+1 Sorry, I gave it a bit more thought,

[Impala-ASF-CR] IMPALA-7175: deflake check for failed impalad

2018-06-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10745 ) Change subject: IMPALA-7175: deflake check for failed impalad .. Patch Set 3: Code-Review+2 I did not notice at first that the

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 9: (5 comments) The new test seems

[Impala-ASF-CR] IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset

2018-08-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11109 ) Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset

2018-08-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11109 ) Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-08-03 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 ) Change subject: IMPALA-7362: Add query option to set timezone .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-08-03 Thread Csaba Ringhofer (Code Review)
Hello Attila Jeges, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11064 to look at the new patch set (#8). Change subject: IMPALA-7362: Add query option to set timezone

[Impala-ASF-CR] IMPALA-6335. Allow most shell tests to run in parallel

2018-08-03 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11045 ) Change subject: IMPALA-6335. Allow most shell tests to run in parallel .. Patch Set 6: (1 comment)

[Impala-ASF-CR] WIP IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-08-03 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11057 to look at the new patch set (#2). Change subject: WIP IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet

[Impala-ASF-CR] WIP IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-08-03 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: WIP IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 2: (4

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-07-30 Thread Csaba Ringhofer (Code Review)
Hello Attila Jeges, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11064 to look at the new patch set (#4). Change subject: IMPALA-7362: Add query option to set timezone

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 11: Code-Review+2 (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-6490: Reconnect shell when remote restarts

2018-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 ) Change subject: IMPALA-6490: Reconnect shell when remote restarts .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 11: fyi, the builds probably failed because of

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 ) Change subject: IMPALA-7362: Add query option to set timezone .. Patch Set 2: (2 comments) The future of this change in under

[Impala-ASF-CR] IMPALA-6335. Allow most shell tests to run in parallel

2018-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11045 ) Change subject: IMPALA-6335. Allow most shell tests to run in parallel .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11064 Change subject: IMPALA-7362: Add query option to set timezone .. IMPALA-7362: Add query option to set timezone This change adds a

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-07-26 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11064 to look at the new patch set (#2). Change subject: IMPALA-7362: Add query option to set timezone ..

[Impala-ASF-CR] WIP IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: WIP IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 1: (1

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-07-27 Thread Csaba Ringhofer (Code Review)
Hello Attila Jeges, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11064 to look at the new patch set (#3). Change subject: IMPALA-7362: Add query option to set timezone

[Impala-ASF-CR] IMPALA-7217: Incorrect UPDATE/DELETE authorization privilege

2018-07-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10966 ) Change subject: IMPALA-7217: Incorrect UPDATE/DELETE authorization privilege .. Patch Set 4: (4 comments) My comments are mainly

[Impala-ASF-CR] IMPALA-5542: Impala cannot scan Parquet decimal stored as int64 t/int32 t

2018-07-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11000 ) Change subject: IMPALA-5542: Impala cannot scan Parquet decimal stored as int64_t/int32_t .. Patch Set 2: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-08-01 Thread Csaba Ringhofer (Code Review)
Hello Attila Jeges, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11064 to look at the new patch set (#5). Change subject: IMPALA-7362: Add query option to set timezone

[Impala-ASF-CR] IMPALA-6335. Allow most shell tests to run in parallel

2018-08-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11045 ) Change subject: IMPALA-6335. Allow most shell tests to run in parallel .. Patch Set 5: Code-Review+2 As the flake8 warnings seem to

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-08-01 Thread Csaba Ringhofer (Code Review)
Hello Attila Jeges, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11064 to look at the new patch set (#6). Change subject: IMPALA-7362: Add query option to set timezone

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-08-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 ) Change subject: IMPALA-7362: Add query option to set timezone .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-08-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 ) Change subject: IMPALA-7362: Add query option to set timezone .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-08-02 Thread Csaba Ringhofer (Code Review)
Hello Attila Jeges, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11064 to look at the new patch set (#7). Change subject: IMPALA-7362: Add query option to set timezone

[Impala-ASF-CR] IMPALA-6490: Reconnect shell when remote restarts

2018-07-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 ) Change subject: IMPALA-6490: Reconnect shell when remote restarts .. Patch Set 7: Code-Review+1 Thanks for the changes! -- To

[Impala-ASF-CR] IMPALA-6335. Allow most shell tests to run in parallel

2018-07-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11045 ) Change subject: IMPALA-6335. Allow most shell tests to run in parallel .. Patch Set 5: Code-Review+1 Tim: I added you as a reviewer

[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS

2018-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-7324: remove MarkNeedsDeepCopy() from sorter

2018-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11048 ) Change subject: IMPALA-7324: remove MarkNeedsDeepCopy() from sorter .. Patch Set 1: Code-Review+1 (2 comments) comments about nit

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

2018-07-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 ) Change subject: IMPALA-7362: Add query option to set timezone .. Patch Set 3: (8 comments)

[Impala-ASF-CR] IMPALA-7324: remove MarkNeedsDeepCopy() from sorter

2018-07-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11048 ) Change subject: IMPALA-7324: remove MarkNeedsDeepCopy() from sorter .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11057 Change subject: WIP IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. WIP IMPALA-5050: Add

[Impala-ASF-CR] IMPALA-6709: Simplify tests that copy local files to tables

2018-08-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 ) Change subject: IMPALA-6709: Simplify tests that copy local files to tables .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6709: Simplify tests that copy local files to tables

2018-08-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 ) Change subject: IMPALA-6709: Simplify tests that copy local files to tables .. Patch Set 2: This was missing from my last reply:

[Impala-ASF-CR] IMPALA-7421. Static methods use wrong JNI call function

2018-08-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11181 ) Change subject: IMPALA-7421. Static methods use wrong JNI call function .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 2: (2 comments) I did not check the python

[Impala-ASF-CR] IMPALA-7442: reduce mem requirement of semi-joins-exhaustive

2018-08-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11223 ) Change subject: IMPALA-7442: reduce mem requirement of semi-joins-exhaustive .. Patch Set 1: Code-Review+1 Lgtm + started a new

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 ) Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor .. Patch Set 2: Code-Review+1

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7428: Fix flaky test shell command line::test large sql

2018-08-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11201 ) Change subject: IMPALA-7428: Fix flaky test_shell_command_line::test_large_sql .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7428: Fix flaky test shell command line::test large sql

2018-08-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11201 ) Change subject: IMPALA-7428: Fix flaky test_shell_command_line::test_large_sql .. Patch Set 4: (1 comment) See comment, would be

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11241 ) Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection

2018-08-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 ) Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection .. Patch Set 1: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-6709: Simplify tests that copy local files to tables

2018-08-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 ) Change subject: IMPALA-6709: Simplify tests that copy local files to tables .. Patch Set 1: (2 comments) Thanks for jumping on

[Impala-ASF-CR] WIP IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-08-06 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11057 to look at the new patch set (#4). Change subject: WIP IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet

[Impala-ASF-CR] WIP IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-08-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: WIP IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 4: Patch set

[Impala-ASF-CR] WIP IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-13 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11183 to look at the new patch set (#4). Change subject: WIP IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

[Impala-ASF-CR] IMPALA-6709: Simplify tests that copy local files to tables

2018-08-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 ) Change subject: IMPALA-6709: Simplify tests that copy local files to tables .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7388. Fix issues in and optimize various Status macros

2018-08-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11153 ) Change subject: IMPALA-7388. Fix issues in and optimize various Status macros .. Patch Set 2: (5 comments) I have added some

[Impala-ASF-CR] IMPALA-7409. CatalogObjectVersionSet should not allow duplicates

2018-08-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11151 ) Change subject: IMPALA-7409. CatalogObjectVersionSet should not allow duplicates .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7421. Static methods use wrong JNI call function

2018-08-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11181 ) Change subject: IMPALA-7421. Static methods use wrong JNI call function .. Patch Set 1: (6 comments)

[Impala-ASF-CR] WIP IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11183 Change subject: WIP IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. WIP IMPALA-7417: Speed up sub-second

[Impala-ASF-CR] WIP IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-13 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11183 to look at the new patch set (#5). Change subject: WIP IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-7428: Fix flaky test shell command line::test large sql

2018-08-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11201 ) Change subject: IMPALA-7428: Fix flaky test_shell_command_line::test_large_sql .. Patch Set 1: Code-Review+1 (2 comments) 1

[Impala-ASF-CR] WIP IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: WIP IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 5: The last failure was

[Impala-ASF-CR] WIP IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-08-06 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11057 to look at the new patch set (#3). Change subject: WIP IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 ) Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor .. Patch Set 4: Code-Review+1

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 8: Sorry for the large number

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 6: Code-Review+1 (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-17 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11183 to look at the new patch set (#7). Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-17 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11183 to look at the new patch set (#6). Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 8: Code-Review-2 The test

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11241 ) Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender .. Patch Set 4: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11282 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 1: Code-Review+1 lgtm The review would have

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-23 Thread Csaba Ringhofer (Code Review)
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11183 to look at the new patch set (#11). Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 11: (18 comments)

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 11: The last build failure was

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 12: (15 comments)

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 9: -Code-Review (1 comment)

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Csaba Ringhofer (Code Review)
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11183 to look at the new patch set (#9). Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 10: The test has hit

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-27 Thread Csaba Ringhofer (Code Review)
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11183 to look at the new patch set (#12). Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

[Impala-ASF-CR] IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell

2018-07-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10900 ) Change subject: IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell .. Patch Set 4:

[Impala-ASF-CR] IMPALA-6490: Reconnect shell when remote restarts

2018-07-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 ) Change subject: IMPALA-6490: Reconnect shell when remote restarts .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-6335. Allow most shell tests to run in parallel

2018-07-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11045 ) Change subject: IMPALA-6335. Allow most shell tests to run in parallel .. Patch Set 2: (2 comments) Thanks for the change! I had

<    1   2   3   4   5   6   7   8   9   10   >