[Impala-ASF-CR] IMPALA-8303: [DOCS] Impala 3.2 release notes

2019-03-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12752 ) Change subject: IMPALA-8303: [DOCS] Impala 3.2 release notes .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8303: [DOCS] Impala 3.2 release notes

2019-03-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12752 ) Change subject: IMPALA-8303: [DOCS] Impala 3.2 release notes .. Patch Set 1: Hey Alex, I'm not sure how this usually is handled:

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has abandoned this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Abandoned Will deliver a feature in one patch instead of splitting it to 2

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 7: There was an ongoing discussion on the Jira during this

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-18 Thread Gabor Kaszab (Code Review)
Hello Greg Rahn, Paul Rogers, Philip Zeyliger, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12267 to look at the new patch set (#7). Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST()

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 7: (8 comments)

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 6: (4 comments) Sorry, the last patch set came together

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-13 Thread Gabor Kaszab (Code Review)
Hello Greg Rahn, Paul Rogers, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12267 to look at the new patch set (#6). Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST()

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 5: (2 comments) Hey, I managed to cover all the comments.

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-08 Thread Gabor Kaszab (Code Review)
Hello Greg Rahn, Paul Rogers, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12267 to look at the new patch set (#5). Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST()

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-01 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 4: (11 comments) Thanks everyone for taking a look and

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-01 Thread Gabor Kaszab (Code Review)
Hello Greg Rahn, Paul Rogers, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12267 to look at the new patch set (#4). Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST()

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 3: (13 comments) Hey Paul, Thanks for taking a look! The

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Gabor Kaszab (Code Review)
Hello Paul Rogers, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12267 to look at the new patch set (#3). Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST()

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12267 Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. IMPALA-4018 Part1: Add FORMAT clause in CAST() This enhancement

[Impala-ASF-CR] IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

2018-12-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12021 ) Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue() .. Patch Set 5: Thanks Tim for kicking off the GVO! About

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-12-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

2018-12-06 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12021 to look at the new patch set (#3). Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

[Impala-ASF-CR] IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

2018-12-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12021 ) Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue() .. Patch Set 2: I did some research on the GVO failure and

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-12-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-12-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 3: I think this verify job failed due to

[Impala-ASF-CR] IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

2018-12-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12021 ) Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue() .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

2018-12-03 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12021 to look at the new patch set (#2). Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-12-01 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. Patch Set 4: (3 comments) Thanks for taking

[Impala-ASF-CR] IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

2018-12-01 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12021 Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue() .. IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

[Impala-ASF-CR] IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query

2018-11-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/11990 ) Change subject: IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-11-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-7623: [DOCS] Disallow name changes for managed Kudu tables

2018-10-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/11518 ) Change subject: IMPALA-7623: [DOCS] Disallow name changes for managed Kudu tables .. Patch Set 1: Code-Review+2 Sorry for the delay.

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-07-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 20: Hey, Sorry for the delay, I

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 20: (11 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-26 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Michael Brown, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#20). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 19: Cleaned up impala-flake8

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-26 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Michael Brown, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#19). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 18: (10 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-22 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Michael Brown, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#18). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-22 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Todd Lipcon, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10654 to look at the new patch set (#6). Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-22 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Todd Lipcon, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10654 to look at the new patch set (#5). Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-20 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Todd Lipcon, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10654 to look at the new patch set (#4). Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 16: Pls ignore the comments for

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 16: (11 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-20 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Michael Brown, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#16). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-19 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#15). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-19 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#14). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-19 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#13). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 3: -Code-Review Todd, I see you have a +2 on

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 2: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 12: Patch set 12 is adjusting

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-15 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#12). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 3: Code-Review+1 Patch set 3 is a rebase. (Carry +1)

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-14 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Todd Lipcon, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10654 to look at the new patch set (#3). Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 2: (1 comment) Thanks for taking a look Todd and Tim!

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-14 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#11). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 10: Hey, could you please take a

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 2: Hey, could you please take a look at this review or

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 2: (1 comment) FYI, ran a core test suite and all

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. IMPALA-7121: Clean up partitionIds_ from HdfsTable The purpose of

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10654 Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. IMPALA-7121: Clean up partitionIds_ from HdfsTable The purpose of

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-08 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#10). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 9: Verified-1 FYI, apparently

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 9: Patchset 9 is a rebase -- To

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#9). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 8: (1 comment) Thanks for your

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#8). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#7). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-05 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#6). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-04 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#5). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-04 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#4). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-01 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-01 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#3). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-05-31 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 2: (12 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-05-31 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#2). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-05-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10543 Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. IMPALA-6119: Fix issue with multiple

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 17: Verified+1 I've spent some time (way more than wanted to:) )

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-28 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#17). Change subject: IMPALA-5706: Spilling sort optimisations

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-28 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#16). Change subject: IMPALA-5706: Spilling sort optimisations

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-25 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#15). Change subject: IMPALA-5706: Spilling sort optimisations

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-21 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#14). Change subject: IMPALA-5706: Spilling sort optimisations

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-18 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#13). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-17 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#12). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-17 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#11). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 10: FYI, ran an exhaustive suite on this change and some

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 7: Code-Review+1 (4 comments) Thanks Attila for addressing

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 10: (6 comments)

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-16 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#10). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-6995: avoid DCHECK in TimestampParse::Parse()

2018-05-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10349 ) Change subject: IMPALA-6995: avoid DCHECK in TimestampParse::Parse() .. Patch Set 3: Code-Review+1 Thank for responding to my

[Impala-ASF-CR] IMPALA-6995: avoid DCHECK in TimestampParse::Parse()

2018-05-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10349 ) Change subject: IMPALA-6995: avoid DCHECK in TimestampParse::Parse() .. Patch Set 2: (4 comments) Hey Tim, I'm fine with the change

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-15 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#9). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 8: (16 comments)

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-15 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#8). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 5: (19 comments) Thanks for dealing with my previous

<    5   6   7   8   9   10   11   12   >