[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page

2017-11-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 ) Change subject: [DOCS] Include the current Impala version number on PDF title page .. Patch Set 1: Code-Review-1 (1 comment)

[Impala-ASF-CR] [DOCS] include version when building

2017-11-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8654 ) Change subject: [DOCS] include version when building .. Patch Set 1: > In general, I would like to keep a checked-in version of >

[Impala-ASF-CR] [DOCS] include version when building

2017-11-27 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8654 Change subject: [DOCS] include version when building .. [DOCS] include version when building This patch includes the canonical Impala

[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page

2017-11-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 ) Change subject: [DOCS] Include the current Impala version number on PDF title page .. Patch Set 1: > I wonder though do we need the

[Impala-ASF-CR](asf-site) Make wording around adopters of Impala more consistent.

2017-11-26 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8609 ) Change subject: Make wording around adopters of Impala more consistent. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Update incubator-impala -> impala URLs

2017-11-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8685 ) Change subject: Update incubator-impala -> impala URLs .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

2017-11-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 ) Change subject: IMPALA-6241: timeout in admission control test under ASAN .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

2017-11-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 ) Change subject: IMPALA-6241: timeout in admission control test under ASAN .. Patch Set 1: (1 comment)

[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page

2017-11-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 ) Change subject: [DOCS] Include the current Impala version number on PDF title page .. Patch Set 1: Here is my approach to this

[Impala-ASF-CR] Removing testdata/bin/run-hive.sh.

2017-11-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8503 ) Change subject: Removing testdata/bin/run-hive.sh. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

2017-11-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 ) Change subject: IMPALA-6241: timeout in admission control test under ASAN .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] include version when building

2017-12-12 Thread Michael Brown (Code Review)
Michael Brown has abandoned this change. ( http://gerrit.cloudera.org:8080/8654 ) Change subject: [DOCS] include version when building .. Abandoned Not working on this, not enough apparent interest among stake holders. -- To

[Impala-ASF-CR] Revert "IMPALA-3887: Wait for HDFS replication in data loading"

2017-12-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8880 ) Change subject: Revert "IMPALA-3887: Wait for HDFS replication in data loading" .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 1: (1 comment)

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6298: Skip test profile fragment instances on local filesystem

2017-12-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8809 ) Change subject: IMPALA-6298: Skip test_profile_fragment_instances on local filesystem .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6272: Update external Hadoop ecosystem versions

2017-12-06 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8759 ) Change subject: IMPALA-6272: Update external Hadoop ecosystem versions .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 2: Code-Review+2 IMPALA-7026 -- To view, visit

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: > I just checked and Cwiki won't

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: > Ibis looked like a legit site.

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: (1 comment)

[Impala-ASF-CR](asf-site) [DOCS] Impala doc site update for 3.0

2018-05-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10322 ) Change subject: [DOCS] Impala doc site update for 3.0 .. Patch Set 1: (1 comment)

[Impala-ASF-CR](asf-site) Added changelog for 3.0.0

2018-05-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10334 ) Change subject: Added changelog for 3.0.0 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10334 To

[Impala-ASF-CR](asf-site) [DOCS] Impala doc site update for 3.0

2018-05-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10322 ) Change subject: [DOCS] Impala doc site update for 3.0 .. Patch Set 4: (2 comments) soft +2. I think this can go in as soon as the

[Impala-ASF-CR](asf-site) Update download and signature links for 3.0.0 release.

2018-05-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10333 ) Change subject: Update download and signature links for 3.0.0 release. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 2: > Will there be another change addressing similar

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10351 Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. IMPALA-6781: expand ORDER BY in some TPCH queries Fix determinism

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Brown (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10351 to look at the new patch set (#2). Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. IMPALA-6781:

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 3: Code-Review+2 IMPALA-6970 -- To view, visit

[Impala-ASF-CR](asf-site) Update download and signature links for 3.0.0 release.

2018-05-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10333 ) Change subject: Update download and signature links for 3.0.0 release. .. Patch Set 1: Code-Review+2 Oops, I'll try to remember that

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 ) Change subject: Speed up Python dependencies. .. Patch Set 1: (1 comment)

[Impala-ASF-CR](2.x) IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10232 ) Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. Patch Set 1: Thanks Tim. It did look trivial but I

[Impala-ASF-CR] Update version to 3.1.0-SNAPSHOT

2018-05-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10360 ) Change subject: Update version to 3.1.0-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](asf-site) [DOCS] Impala doc site update for 3.0

2018-05-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10322 ) Change subject: [DOCS] Impala doc site update for 3.0 .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 1: > I don't have permissions to give +2 >

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-11 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10381 Change subject: IMPALA-6983: stress: don't write a null runtime profile .. IMPALA-6983: stress: don't write a null runtime profile

[Impala-ASF-CR](2.x) Ignore 3.x version update patch

2018-05-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10383 ) Change subject: Ignore 3.x version update patch .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](asf-site) [DOCS] Impala doc site update for 3.0

2018-05-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10322 ) Change subject: [DOCS] Impala doc site update for 3.0 .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-16 Thread Michael Brown (Code Review)
Michael Brown has removed a vote on this change. Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 3: Verified+1 False positive failure due to

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-16 Thread Michael Brown (Code Review)
Michael Brown has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. IMPALA-6983: stress: don't write a null runtime

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-15 Thread Michael Brown (Code Review)
Michael Brown has removed a vote on this change. Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 2: IMPALA-7030 -- To view, visit

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 1: (1 comment) Looks fine.

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10513 ) Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. Patch Set 1: We had a long out of band discussion about this

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not requirerd in comments

2018-05-24 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10474 ) Change subject: IMPALA-2751: Matching quotes are not requirerd in comments .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 4: (3 comments) > I accidentally

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 6: > And I believe the changes were

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 14: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 14: +1 since we are trying to ease changes in

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 13: (8 comments) I checked out your patch and ran

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 14: Code-Review+2 Seems like we're loosening things

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-05-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 1: (2 comments) Please add another appropriate

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10529 ) Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. Patch Set 3: Code-Review+1 ...pending

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-05-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7104: test bloom wait time failing with timeout on asan

2018-05-31 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10565 ) Change subject: IMPALA-7104: test_bloom_wait_time failing with timeout on asan .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 12: > No takers for +2? This has been lingering for

[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10603 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10513 ) Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support

2018-05-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 1: Alex Rodoni is currently most familiar with docs so

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 4: Code-Review+1 Looks fine from my end. The python

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 20: (1 comment) +2 for

[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option

2018-06-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10795 ) Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option

2018-06-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10795 ) Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 18: (9 comments)

[Impala-ASF-CR](asf-site) [DOCS] Add Impala docs from branch 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10258 ) Change subject: [DOCS] Add Impala docs from branch 2.x .. Patch Set 1: (2 comments) When I make the HTML docs from commit

[Impala-ASF-CR](asf-site) [DOCS] Add Impala docs from branch 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10258 ) Change subject: [DOCS] Add Impala docs from branch 2.x .. Patch Set 1: > > > What's going on there? > > > > Found

[Impala-ASF-CR](2.x) [DOCS] Fixed the version variables for release notes

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10259 ) Change subject: [DOCS] Fixed the version variables for release notes .. Patch Set 1: Code-Review+2 Let me know if your workflow would

[Impala-ASF-CR](asf-site) [DOCS] Add Impala docs from branch 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10258 ) Change subject: [DOCS] Add Impala docs from branch 2.x .. Patch Set 2: (4 comments)

[Impala-ASF-CR](2.x) IMPALA-6070: Further improvements to test-with-docker.

2018-04-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10248 ) Change subject: IMPALA-6070: Further improvements to test-with-docker. .. Patch Set 1: (1 comment) Not a clean cherry-pick. See

[Impala-ASF-CR](2.x) IMPALA-6070: Further improvements to test-with-docker.

2018-04-30 Thread Michael Brown (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10248 to review the following change. Change subject: IMPALA-6070: Further improvements to test-with-docker.

[Impala-ASF-CR](asf-site) [DOCS] Add Impala docs from branch 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10258 ) Change subject: [DOCS] Add Impala docs from branch 2.x .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR](asf-site) [DOCS] Add Impala docs from branch 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10258 ) Change subject: [DOCS] Add Impala docs from branch 2.x .. Patch Set 1: > What's going on there? Found

[Impala-ASF-CR](asf-site) [DOCS] Add Impala docs from branch 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10258 ) Change subject: [DOCS] Add Impala docs from branch 2.x .. Patch Set 3: Sorry, I keep finding things thanks to diff -urZ. I believe

[Impala-ASF-CR](asf-site) Added changelog for 2.12.0

2018-04-26 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 ) Change subject: Added changelog for 2.12.0 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10184 To

[Impala-ASF-CR](asf-site) [DOCS] Add Impala docs from branch 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10258 ) Change subject: [DOCS] Add Impala docs from branch 2.x .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10244 ) Change subject: Warn about Hadoop / Java version incompatibility .. Patch Set 2: (1 comment)

[Impala-ASF-CR](2.x) ignore Hadoop 3-related commits in 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10260 Change subject: ignore Hadoop 3-related commits in 2.x .. ignore Hadoop 3-related commits in 2.x These commits are about Hadoop 3 and

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10244 ) Change subject: Warn about Hadoop / Java version incompatibility .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) ignore Hadoop 3-related commits in 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10260 ) Change subject: ignore Hadoop 3-related commits in 2.x .. ignore Hadoop 3-related commits in 2.x These commits are about

[Impala-ASF-CR](2.x) ignore Hadoop 3-related commits in 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10260 ) Change subject: ignore Hadoop 3-related commits in 2.x .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

2018-04-30 Thread Michael Brown (Code Review)
Michael Brown has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10238 ) Change subject: IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility" .. IMPALA-6951: Revert "Warn about

[Impala-ASF-CR] IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

2018-04-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10238 ) Change subject: IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility" .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

2018-04-30 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10238 Change subject: IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility" .. IMPALA-6951: Revert "Warn about Hadoop /

[Impala-ASF-CR](2.x) ignore decimal v2 doc commit

2018-05-03 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10295 ) Change subject: ignore decimal_v2 doc commit .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10295 To

[Impala-ASF-CR](2.x) ignore decimal v2 doc commit

2018-05-03 Thread Michael Brown (Code Review)
Michael Brown has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10295 ) Change subject: ignore decimal_v2 doc commit .. ignore decimal_v2 doc commit 167ed627febe5a10d8a4a7474a34efde1ac6f1c2 should

[Impala-ASF-CR] IMPALA-6866: Rework timeouts for test exchange delays.py

2018-05-03 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10208 ) Change subject: IMPALA-6866: Rework timeouts for test_exchange_delays.py .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) ignore decimal v2 doc commit

2018-05-03 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10295 Change subject: ignore decimal_v2 doc commit .. ignore decimal_v2 doc commit 167ed627febe5a10d8a4a7474a34efde1ac6f1c2 should have had

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

2018-01-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 4: Tim, thanks for this. Do you feel confident this

[Impala-ASF-CR](asf-site) Fixed broken link to sha for 2.10 on downloads page.

2018-01-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8944 ) Change subject: Fixed broken link to sha for 2.10 on downloads page. .. Patch Set 2: Code-Review+2 -- To view, visit

  1   2   3   >