[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

2018-01-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9035 ) Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4 .. Patch Set 1: (3 comments) Thanks! Minor comments below. We had

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 4: -Code-Review We're seeing some failures

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 4: Code-Review+2 GVO caught that the checked

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#4) to the change originally created by Taras Bobrovytsky. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation ..

[Impala-ASF-CR] IMPALA-6363: avoid cscope build races

2018-01-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 ) Change subject: IMPALA-6363: avoid cscope build races .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9006 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 4: The error

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 4:

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Philip Zeyliger (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/ to look at the new patch set (#3). Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 2: (1

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-09 Thread Philip Zeyliger (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/ to look at the new patch set (#2). Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 1: (1

[native-toolchain-CR] Bump LLVM to 5.0.0

2018-01-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8932 ) Change subject: Bump LLVM to 5.0.0 .. Patch Set 1: They've released 5.0.1. Does it make sense to go straight there? (I've not

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

2017-12-20 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 ) Change subject: Move symlinked auxiliary tests/* to tests/functional/* .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-20 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 6: (1 comment)

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

2017-12-20 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 ) Change subject: Move symlinked auxiliary tests/* to tests/functional/* .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2017-12-20 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 1: Running

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2017-12-20 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/ Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. IMPALA-6330,

[Impala-ASF-CR] Remove unused deps, centralize some pom versions, upgrade SLF4J and commons-io.

2017-12-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8853 ) Change subject: Remove unused deps, centralize some pom versions, upgrade SLF4J and commons-io. .. Patch Set 2: (3 comments)

[Impala-ASF-CR] Remove unused deps, centralize some pom versions, upgrade SLF4J and commons-io.

2017-12-19 Thread Philip Zeyliger (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8853 to look at the new patch set (#3). Change subject: Remove unused deps, centralize some pom versions, upgrade SLF4J and commons-io.

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2017-12-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8852 ) Change subject: IMPALA-6318: Adjustment for hanging query cancellation test .. Patch Set 5: Code-Review+1 (1 comment) I think this

[Impala-ASF-CR] Remove unused deps, centralize some pom versions, upgrade SLF4J and commons-io.

2017-12-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8853 ) Change subject: Remove unused deps, centralize some pom versions, upgrade SLF4J and commons-io. .. Patch Set 2:

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 6: Code-Review+1

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-3887: Wait for HDFS replication in data loading

2017-12-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8846 ) Change subject: IMPALA-3887: Wait for HDFS replication in data loading .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 4: (1 comment) One

[Impala-ASF-CR] IMPALA-6070: Parallelize another bit of data load.

2017-12-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8822 ) Change subject: IMPALA-6070: Parallelize another bit of data load. .. Patch Set 1:

[Impala-ASF-CR] IMPALA-6070: Parallelize another bit of data load.

2017-12-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8822 Change subject: IMPALA-6070: Parallelize another bit of data load. .. IMPALA-6070: Parallelize another bit of data load. The two Kudu

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 4: (3 comments) Just a

[Impala-ASF-CR] IMPALA-6270: remove redundant version properties

2017-12-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8827 Change subject: IMPALA-6270: remove redundant version properties .. IMPALA-6270: remove redundant version properties Removes

[Impala-ASF-CR] IMPALA-6270: remove redundant version properties

2017-12-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8827 ) Change subject: IMPALA-6270: remove redundant version properties .. Patch Set 1:

[Impala-ASF-CR] IMPALA-6270: create Impala parent pom

2017-12-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8753 ) Change subject: IMPALA-6270: create Impala parent pom .. Patch Set 1: > Patch Set 1: > > Build started:

[Impala-ASF-CR] Add 'lsof' to bootstrap system.

2017-12-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8813 Change subject: Add 'lsof' to bootstrap_system. .. Add 'lsof' to bootstrap_system. "be/src/kudu/security/test/mini_kdc.cc" uses lsof,

[Impala-ASF-CR](asf-site) IMPALA-6302: "Impala" is not spelled "Impalagg"

2017-12-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8808 ) Change subject: IMPALA-6302: "Impala" is not spelled "Impalagg" .. Patch Set 1: Code-Review+1 Very true. -- To view, visit

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 3: (3 comments) Thanks

[native-toolchain-CR] Prepare to move automated toolchain builds to a new environment

2017-12-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8787 ) Change subject: Prepare to move automated toolchain builds to a new environment .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

2017-12-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6272: Update external Hadoop ecosystem versions

2017-12-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8759 Change subject: IMPALA-6272: Update external Hadoop ecosystem versions .. IMPALA-6272: Update external Hadoop ecosystem versions

[Impala-ASF-CR] IMPALA-6270: create Impala parent pom

2017-12-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8753 Change subject: IMPALA-6270: create Impala parent pom .. IMPALA-6270: create Impala parent pom This commit links together all the

[Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

2017-12-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs .. Patch Set 4: Code-Review+1 (2 comments) Works for me.

[Impala-ASF-CR] IMPALA-6265 Increase timeout in test cancellation tests

2017-12-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8713 ) Change subject: IMPALA-6265 Increase timeout in test cancellation tests .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4506: Do not display some intro message if --quiet is set

2017-11-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8613 ) Change subject: IMPALA-4506: Do not display some intro message if --quiet is set .. Patch Set 5: Code-Review+1 Thanks. -- To view,

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-11-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: > Patch Set 1: > > (2 comments) I found out recently that

[Impala-ASF-CR] IMPALA-4506: Do not display some intro message if --quiet is set

2017-11-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8613 ) Change subject: IMPALA-4506: Do not display some intro message if --quiet is set .. Patch Set 4: Code-Review-1 (1 comment) Thanks

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 6: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 7: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-4927: Impala should handle invalid input from Sentry

2017-11-21 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 ) Change subject: IMPALA-4927: Impala should handle invalid input from Sentry .. Patch Set 8: (1 comment) I'm not too familiar with

[Impala-ASF-CR] IMPALA-4506: Do not display "tip of the day" if --quiet is set

2017-11-20 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8613 ) Change subject: IMPALA-4506: Do not display "tip of the day" if --quiet is set .. Patch Set 1: (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8610 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 1: Thanks! I think

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 5: > The only way to

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 4: Code-Review+1 Looks fine as far as

[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging

2017-11-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 ) Change subject: IMPALA-6210: Add query id to lineage graph logging .. Patch Set 1: (4 comments) Thanks! This looks largely good to

[Impala-ASF-CR] Removing testdata/bin/run-hive.sh.

2017-11-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8503 Change subject: Removing testdata/bin/run-hive.sh. .. Removing testdata/bin/run-hive.sh. I can't find any uses of it. Change-Id:

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-11-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 3: Code-Review+1 (3 comments) I'm fine with

<    4   5   6   7   8   9