[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 8: thanks for the reviews! alex, pls have a look

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 4: (1 comment) yes, missed adding the file when renaming.

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#5). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#4). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 1: (1 comment) missing test file?

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: (3 comments) update fixes the bug tim

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-15 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#16). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. IMPALA-6215: Removes race when using LibCache. LibCache's api to

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9089 Change subject: IMPALA-6215: Removes race when using LibCache. .. IMPALA-6215: Removes race when using LibCache. LibCache's api to

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-21 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#7). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-24 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#4). Change subject: IMPALA-6215: Removes race when using LibCache.

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 3: (1 comment) jira for further cleanup: IMPALA-6439

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 8: Code-Review+1 carry +1 from dimitris -- To

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 4: Code-Review+1 carry the +1 from Bikram. any takers to

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-17 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#17). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-17 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#18). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 4: (9 comments)

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-17 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#5). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-17 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#6). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. IMPALA-3562: support column restriction for compute stats

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9133 Change subject: IMPALA-3562: support column restriction for compute stats .. IMPALA-3562: support column restriction for compute stats

[Impala-ASF-CR] IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9113 ) Change subject: IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE .. Patch Set 1: (5 comments) looks good, just a couple of

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-09 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#8). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators

2018-01-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 3: (3 comments) couple of

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 13: carry alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#14). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 13: (2 comments)

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: noticed a discrepancy in the s3 ranges from run-to-run for

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: thanks for catching this! looking into it.

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#15). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: clang-tidy on gvo found an issue. latest

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 8: (23 comments)

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-11 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#9). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: alex, pls have a look and let me know if you have

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-11 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#4). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 10: tests found a bad dep, next patch fixes it.

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-11 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#13). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-11 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#11). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-11 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#12). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9113 ) Change subject: IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#5). Change subject: IMPALA-6215: Removes race when using LibCache.

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#6). Change subject: IMPALA-6215: Removes race when using LibCache.

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 5: next change replaces the explicitly managed opaque

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 4: (11 comments)

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-01-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9139 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 1: (6 comments) looks good. mostly nit comments

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-30 Thread Vuk Ercegovac (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9133 to look at the new patch set (#4). Change subject: IMPALA-3562: support column restriction for compute stats ..

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-01-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9139 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 8: (9 comments) thanks for the changes--

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-01-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9139 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#7). Change subject: IMPALA-6215: Removes race when using LibCache.

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 6: latest patch fixes a failure in gvo. would

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 4: Looks like this failed due to:

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#9). Change subject: IMPALA-6215: Removes race when using LibCache.

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 8: clang tidy found an issue.. update fixes it and what

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-30 Thread Vuk Ercegovac (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9133 to look at the new patch set (#3). Change subject: IMPALA-3562: support column restriction for compute stats ..

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 2: (9 comments)

[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9244 Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Revert "IMPALA-6215: Removes race when using LibCache." This

[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: decided to assert that all plans should be the same on all

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has abandoned this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/8890 To unsubscribe,

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9251 Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. IMPALA-4475: part 1, reduce size of

[Impala-ASF-CR] IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9232 ) Change subject: IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart .. Patch Set 1: quick comment here... is there any

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9251 ) Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. Patch Set 1: yes, that's what the Compact protocol

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 7: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 13: Code-Review+1 (2 comments) minor

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-02-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 9: (14 comments) main changes: (1) minimized

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-02-12 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Dimitris Tsirogiannis, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#10). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 12: (10 comments) couple of proposals for

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-02-19 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Dimitris Tsirogiannis, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#11). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 9: Code-Review+1 lgtm. would anyone with more experience

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 4: Code-Review+1 (5 comments) thanks for the refactor and

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-3887: Wait for HDFS replication in data loading

2017-12-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8916 ) Change subject: IMPALA-3887: Wait for HDFS replication in data loading .. Patch Set 1: (1 comment) thanks for the fix-- I just have a

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#2). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7140 (part 4): support creating descriptors for FS tables

2018-06-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10735 ) Change subject: IMPALA-7140 (part 4): support creating descriptors for FS tables .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-7175: deflake check for failed impalad

2018-06-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10745 ) Change subject: IMPALA-7175: deflake check for failed impalad .. Patch Set 3: The thing I'm really after with this patch is to check

[Impala-ASF-CR] IMPALA-7203. Support UDFs in LocalCatalog

2018-08-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11053 ) Change subject: IMPALA-7203. Support UDFs in LocalCatalog .. Patch Set 3: (1 comment) looks fine. still reviewing LocalDb.

[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog

2018-08-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 ) Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog .. Patch Set 2: (15 comments) mostly minor comments,

[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog

2018-08-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 ) Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7203. Support UDFs in LocalCatalog

2018-08-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11053 ) Change subject: IMPALA-7203. Support UDFs in LocalCatalog .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions

2018-08-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10995 ) Change subject: IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7354: planner test resource estimates for more workloads

2018-08-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11087 ) Change subject: IMPALA-7354: planner test resource estimates for more workloads .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6994: Avoid reloading a table's HMS data for file-only operations

2018-08-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10587 ) Change subject: IMPALA-6994: Avoid reloading a table's HMS data for file-only operations .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog

2018-08-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10972 ) Change subject: IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog .. Patch Set 5: Code-Review+2 -- To view, visit

<    1   2   3   4   5   6   7   8   >