[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 11: > I was talking to Pooja offline and

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 11: I was talking to Pooja offline and realised

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 11: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 11: I really liked the suggestions btw, I think

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10) to the change originally created by Mostafa Mokhtar. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query ..

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 9: (11 comments)

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 9: Could you take another look, Bikram? -- To

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9) to the change originally created by Mostafa Mokhtar. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query ..

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 8: (6 comments) There's some more cleanup to do

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 7: (5 comments) Addressed the previous comments

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7) to the change originally created by Mostafa Mokhtar. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query ..

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-07-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 6: I'm going to take over this patch from

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 6: Following diff prevents it from crashing

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 6: (2 comments) I ran a local stress test with

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#6). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#5). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 4: Build failed:

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-07 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#4). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-07 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 3: (22 comments)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 3: (21 comments)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-21 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 1: (31 comments)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-21 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#3). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-21 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#2). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-16 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 1: (5 comments) just a few more cleanup asks

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 1: (29 comments) I have one major concern about

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-15 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10415 Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. IMPALA-6034: Add Cpu and scanned bytes limits per query