[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4968/6/testdata/bad_parquet_data/README File

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/5115/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner * Extend

[Impala-ASF-CR] PREVIEW: IMPALA-1788: Fold constant expressions during plan generation.

2016-11-16 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: PREVIEW: IMPALA-1788: Fold constant expressions during plan generation. .. Patch Set 1: (20 comments)

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4968 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3812: Fix error message for unsupported types

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3812: Fix error message for unsupported types .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4859 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3812: Fix error message for unsupported types

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3812: Fix error message for unsupported types .. IMPALA-3812: Fix error message for unsupported types Before this patch an unclear error

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4968/5/be/src/exec/parquet-column-readers.cc

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add Parquet timestamp validation Before this patch, we would simply read the INT96 Parquet

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4969 To unsubscribe,

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. IMPALA-4392: restore PeakMemoryUsage to DataSink profiles The join build sink patches

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting Adds support in the shell to report

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5103 To unsubscribe,

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4956/4/be/src/exec/hdfs-scanner.h File

[Impala-ASF-CR] IMPALA-4466: Improve Kudu CRUD test coverage

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4466: Improve Kudu CRUD test coverage .. IMPALA-4466: Improve Kudu CRUD test coverage The results in the test files were verified by hand.

[Impala-ASF-CR] IMPALA-4466: Improve Kudu CRUD test coverage

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu CRUD test coverage .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4953 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5105/2/be/src/exec/aggregation-node.cc

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-16 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-4432: Handle internal codegen disabling properly .. IMPALA-4432: Handle internal codegen disabling properly There are some conditions in which codegen is

[Impala-ASF-CR] Improve message output from run-step.sh

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Improve message output from run-step.sh .. Patch Set 2: Code-Review+2 This was indeed annoying! Thanks for fixing it. -- To view, visit

[Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4493: fix string-compare-test when using clang .. IMPALA-4493: fix string-compare-test when using clang Only the 0 value or sign bit is

[Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4493: fix string-compare-test when using clang .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5110 To unsubscribe,

[Impala-ASF-CR] IMPALA-4490: Only generate runtime filters for hash join nodes.

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes. .. IMPALA-4490: Only generate runtime filters for hash join nodes. Change-Id:

[Impala-ASF-CR] IMPALA-4490: Only generate runtime filters for hash join nodes.

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4490: Only generate runtime filters for hash join nodes.

2016-11-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4490: Only generate runtime filters for hash join nodes.

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes. .. IMPALA-4490: Only generate runtime filters for hash join nodes. Change-Id:

[Impala-ASF-CR] IMPALA-4490: Only generate runtime filters for hash join nodes.

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. IMPALA-4397,IMPALA-3259: reduce codegen time and memory A handful of fixes to codegen memory usage: *

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 7: PS7 is a rebase -- To view, visit http://gerrit.cloudera.org:8080/4956 To unsubscribe,

[Impala-ASF-CR] IMPALA-4490: Only generate runtime filters for hash join nodes.

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. IMPALA-4397,IMPALA-3259: reduce codegen time and memory A handful of fixes to codegen memory usage: *

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 4: (16 comments) http://gerrit.cloudera.org:8080/#/c/4956/4/be/src/codegen/llvm-codegen.cc

[Impala-ASF-CR] Improve message output from run-step.sh

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: Improve message output from run-step.sh .. Improve message output from run-step.sh run-step prints a message to tell the reader what it's doing. However, that

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5115/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. IMPALA-4397,IMPALA-3259: reduce codegen time and memory A handful of fixes to codegen memory usage: *

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-4490: Only generate runtime filters for hash join nodes.

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5117 Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes. .. IMPALA-4490: Only generate runtime filters for hash join

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5115/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5115/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5115/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. Patch Set 2: > Thanks!Do you think I should add some code to catalog to validate the

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5115 Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. IMPALA-2494: Support for byte array-encoded

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. Our

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5050 To

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5103 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-3812: Fix error message for unsupported types

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3812: Fix error message for unsupported types .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4859 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-11-16 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-3812: Fix error message for unsupported types

2016-11-16 Thread Taras Bobrovytsky (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4859 to look at the new patch set (#3). Change subject: IMPALA-3812: Fix error message for unsupported types

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: (22 comments) what's the plan for keeping this compiling?

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5103/2/common/thrift/ImpalaService.thrift

[Impala-ASF-CR] IMPALA-4466: Improve Kudu CRUD test coverage

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu CRUD test coverage .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4953 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/4956/4/be/src/codegen/llvm-codegen.cc

[Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3882: Simplify some query exec state locking .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-4466: Improve Kudu CRUD test coverage

2016-11-16 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu CRUD test coverage .. Patch Set 12: (1 comment) Yes, the only changes since the last time it was +2ed are the three new test

[Impala-ASF-CR] IMPALA-4466: Improve Kudu CRUD test coverage

2016-11-16 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4953 to look at the new patch set (#12). Change subject: IMPALA-4466: Improve Kudu CRUD test coverage

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. IMPALA-4477: Upgrade Kudu version to latest master Change the toolchain build and Kudu version

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5106 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang

2016-11-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4493: fix string-compare-test when using clang .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5110 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4493: fix string-compare-test when using clang .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang

2016-11-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4493: fix string-compare-test when using clang .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5110/1/be/src/runtime/string-compare-test.cc

[Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang

2016-11-16 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5110 to look at the new patch set (#2). Change subject: IMPALA-4493: fix string-compare-test when using clang ..

[Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang

2016-11-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4493: fix string-compare-test when using clang .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5110/1/be/src/runtime/string-compare-test.cc

[Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang

2016-11-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4493: fix string-compare-test when using clang .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5110/1/be/src/runtime/string-compare-test.cc

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang

2016-11-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4493: fix string-compare-test when using clang .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5110/1/be/src/runtime/string-compare-test.cc

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-16 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4493: fix string-compare-test when using clang .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5110 To unsubscribe,

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5105/2/be/src/exec/aggregation-node.cc

[Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang

2016-11-16 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/5110 Change subject: IMPALA-4493: fix string-compare-test when using clang .. IMPALA-4493: fix string-compare-test when using clang Only the 0

[Impala-ASF-CR] IMPALA-4466: Improve Kudu CRUD test coverage

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu CRUD test coverage .. Patch Set 11: Code-Review+2 (1 comment) Reviewed the new test cases that were added. I assume there weren't

[Impala-ASF-CR] PREVIEW: IMPALA-1788: Fold constant expressions during plan generation.

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: PREVIEW: IMPALA-1788: Fold constant expressions during plan generation. .. Patch Set 1: There are still some failing tests because of expected warnings from expr

[Impala-ASF-CR] PREVIEW: IMPALA-1788: Fold constant expressions during plan generation.

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5109 Change subject: PREVIEW: IMPALA-1788: Fold constant expressions during plan generation. .. PREVIEW: IMPALA-1788: Fold constant expressions

[Impala-ASF-CR] IMPALA-4216: Test became flaky: TestTpchMemLimitError.test low mem limit q20

2016-11-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4216: Test became flaky: TestTpchMemLimitError.test_low_mem_limit_q20 .. Patch Set 1: Tim, maybe this was one of the dropped scanner status that you've

[Impala-ASF-CR] IMPALA-4216: Test became flaky: TestTpchMemLimitError.test low mem limit q20

2016-11-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4216: Test became flaky: TestTpchMemLimitError.test_low_mem_limit_q20 .. Patch Set 1: > > But why do we no longer get the MEM_LIMIT_EXCEEDED error status >

[Impala-ASF-CR] IMPALA-4216: Test became flaky: TestTpchMemLimitError.test low mem limit q20

2016-11-16 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-4216: Test became flaky: TestTpchMemLimitError.test_low_mem_limit_q20 .. Patch Set 1: > But why do we no longer get the MEM_LIMIT_EXCEEDED error status

[Impala-ASF-CR] IMPALA-3838: Codegen EvalRuntimeFilters().

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3838: Codegen EvalRuntimeFilters(). .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4833/1/be/src/exec/hdfs-parquet-scanner-ir.cc File

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5106 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Matthew Jacobs (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5106 to look at the new patch set (#2). Change subject: IMPALA-4477: Upgrade Kudu version to latest master ..

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5106/1/bin/impala-config.sh File

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5106 Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. IMPALA-4477: Upgrade Kudu version to latest master Change the

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting Adds support in the shell to report the number of

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 3: Build failed:

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 3: Build failed:

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. Patch Set 5: Build failed:

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 3: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/4969 To

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-16 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. Patch Set 2: > Thanks! > > Do you think I should add some code to catalog to

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-16 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5050 to look at the new patch set (#5). Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. Patch Set 5: Code-Review+2 fixed typo, rebase -- To view, visit

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-16 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#2). Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present This change

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-16 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. Patch Set 1: Thanks! Do you think I should add some code to catalog to validate the

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-16 Thread Attila Jeges (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5095 to look at the new patch set (#2). Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-16 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. Patch Set 1: (3 comments)

  1   2   >