[Impala-ASF-CR] IMPALA-4525: follow-on: cleanup error handling

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4525: follow-on: cleanup error handling .. Patch Set 5: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5212 To unsubscribe,

[Impala-ASF-CR] IMPALA-4525: follow-on: cleanup error handling

2016-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4525: follow-on: cleanup error handling .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/67/ -- To view,

[Impala-ASF-CR] IMPALA-4525: follow-on: cleanup error handling

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4525: follow-on: cleanup error handling .. Patch Set 4: Failed because of IMPALA-4567 -- To view, visit http://gerrit.cloudera.org:8080/5212 To

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. Patch Set 1: (7 comments) To avoid more rounds, maybe we should sync on the exact

[Impala-ASF-CR] IMPALA-4571: InList predicates not being pushed to Kudu scans

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4571: InList predicates not being pushed to Kudu scans .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/5316/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4525: follow-on: cleanup error handling

2016-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4525: follow-on: cleanup error handling .. Patch Set 4: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/66/ --

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5317 Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. IMPALA-4561: Replace DISTRIBUTE BY with

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

2016-12-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures .. Patch Set 2: I see this is already submitted, but: > Do you know how I can only run 1 of the 2

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-12-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 8: Code-Review+1 (1 comment) Hi Taras, please see patch set 8.

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-12-01 Thread Michael Brown (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5162 to look at the new patch set (#8). Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures .. IMPALA-4567: Fix test_kudu_alter_table exhaustive failures The issue is that we set

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5312 To unsubscribe,

[Impala-ASF-CR] IMPALA-4571: InList predicates not being pushed to Kudu scans

2016-12-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4571: InList predicates not being pushed to Kudu scans .. IMPALA-4571: InList predicates not being pushed to Kudu scans Fixes the KuduScanNode to convert

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. IMPALA-4527: Columns in Kudu tables created from Impala default to

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5259

[Impala-ASF-CR] IMPALA-4572: Run COMPUTE STATS on Parquet tables with MT DOP=4.

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5315 Change subject: IMPALA-4572: Run COMPUTE STATS on Parquet tables with MT_DOP=4. .. IMPALA-4572: Run COMPUTE STATS on Parquet tables with

[Impala-ASF-CR] IMPALA-4564,IMPALA-4565: mt dop fixes for old aggs and joins

2016-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5302 To

[Impala-ASF-CR] IMPALA-4564,IMPALA-4565: mt dop fixes for old aggs and joins

2016-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins .. IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins Fix a test bug

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5144 To

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-12-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-12-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#5). Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load If a

[Impala-ASF-CR] IMPALA-4525: follow-on: cleanup error handling

2016-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4525: follow-on: cleanup error handling .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/66/ -- To view,

[Impala-ASF-CR] IMPALA-4525: follow-on: cleanup error handling

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4525: follow-on: cleanup error handling .. Patch Set 4: Code-Review+2 (3 comments) Carry +2

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. IMPALA-3200: Implement suballocator for splitting buffers This is useful for situations like hash

[Impala-ASF-CR] IMPALA-4570: shell tarball breaks with certain setuptools versions

2016-12-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4570: shell tarball breaks with certain setuptools versions .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5314 To

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. IMPALA-3200: Implement suballocator for splitting buffers This is useful for situations like hash

[Impala-ASF-CR] IMPALA-4570: shell tarball breaks with certain setuptools versions

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4570: shell tarball breaks with certain setuptools versions .. IMPALA-4570: shell tarball breaks with certain setuptools versions The bug was in the

[Impala-ASF-CR] IMPALA-3875: Thrift threaded server hang in some cases

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3875: Thrift threaded server hang in some cases .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 12: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4525: follow-on: cleanup error handling

2016-12-01 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Michael Ho, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5212 to look at the new patch set (#4). Change subject: IMPALA-4525: follow-on: cleanup error handling

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 6: It doesn't seem to cause any actual problems, so maybe I'll hold off on it. That will

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-12-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

2016-12-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures .. Patch Set 1: > I used this command to see the test simply runs the .test file with > codegen

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join.

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join. .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ.

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ. .. IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ. Background: We

[Impala-ASF-CR] Fix E2E test infrastructure to handle missing exceptions correctly

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Fix E2E test infrastructure to handle missing exceptions correctly .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5260 To

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: Add "Effective Coding Practices" doc to site .. Abandoned will add to wiki -- To view, visit http://gerrit.cloudera.org:8080/4961 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-01 Thread Tim Armstrong (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5251 to look at the new patch set (#6). Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp ..

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-12-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-12-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load If a

[Impala-ASF-CR] Bump Kudu python version to 1.1

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Bump Kudu python version to 1.1 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5307 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 4: (2 comments) Dan: so there's actually a special case in exprs/scalar-fn-call.cc that

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-12-01 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. Patch Set 2: For the goal mentioned, it LGTM. I'll defer to others for tag specific

[Impala-ASF-CR] Add Apache license header to files in doc directory

2016-12-01 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: Add Apache license header to files in doc directory .. Patch Set 1: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:8080/5232 To unsubscribe,

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-12-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 12: Code-Review+2 Rebase. Promote +1 to +2. -- To view, visit

[Impala-ASF-CR] IMPALA-4564,IMPALA-4565: mt dop fixes for old aggs and joins

2016-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/65/

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4564,IMPALA-4565: mt dop fixes for old aggs and joins

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5302 To unsubscribe,

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5259 To

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. Patch Set 3: Also, thanks for digging up IMPALA-594, that's indeed the one I meant. How

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-12-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

2016-12-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures .. Patch Set 1: I used this command to see the test simply runs the .test file with codegen enabled

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-12-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 17: Was just going through this patch. I think it's necessary to run some tests on

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

2016-12-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5312 To

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-12-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. Patch Set 3: (1 comment) The closest JIRA I could find was IMPALA-594, but

[Impala-ASF-CR] IMPALA-4564,IMPALA-4565: mt dop fixes for old aggs and joins

2016-12-01 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5302 to look at the new patch set (#3). Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins

[Impala-ASF-CR] IMPALA-4564,IMPALA-4565: mt dop fixes for old aggs and joins

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

2016-12-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5312 To unsubscribe,

[Impala-ASF-CR] IMPALA-4564,IMPALA-4565: mt dop fixes for old aggs and joins

2016-12-01 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5302 to look at the new patch set (#2). Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-12-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load If a

[Impala-ASF-CR] IMPALA-4562: Fix for crash on kerberized clusters w/o Kudu support

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4562: Fix for crash on kerberized clusters w/o Kudu support .. IMPALA-4562: Fix for crash on kerberized clusters w/o Kudu support commit

[Impala-ASF-CR] IMPALA-4562: Fix for crash on kerberized clusters w/o Kudu support

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4562: Fix for crash on kerberized clusters w/o Kudu support .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5295 To

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

2016-12-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5312 Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures .. IMPALA-4567: Fix test_kudu_alter_table exhaustive

[Impala-ASF-CR] IMPALA-3875: Thrift threaded server hang in some cases

2016-12-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3875: Thrift threaded server hang in some cases .. Patch Set 2: Code-Review+2 Rebase, carry +2. -- To view, visit http://gerrit.cloudera.org:8080/5263

[Impala-ASF-CR] IMPALA-4525: follow-on: cleanup error handling

2016-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4525: follow-on: cleanup error handling .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/64/ -- To view,

[Impala-ASF-CR] IMPALA-3875: Thrift threaded server hang in some cases

2016-12-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3875: Thrift threaded server hang in some cases .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5263 To unsubscribe,

[Impala-ASF-CR] Start a docs build system.

2016-12-01 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Start a docs build system. .. Start a docs build system. The docs can be built by running "make" from the docs directory. This does not hook into

[Impala-ASF-CR] Start a docs build system.

2016-12-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Start a docs build system. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5238 To unsubscribe, visit

[Impala-ASF-CR] Start a docs build system.

2016-12-01 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: Start a docs build system. .. Patch Set 2: Code-Review+1 LGTM. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/5238 To unsubscribe, visit

[Impala-ASF-CR] Fix E2E test infrastructure to handle missing exceptions correctly

2016-12-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: Fix E2E test infrastructure to handle missing exceptions correctly .. Patch Set 3: Code-Review+2 Carry Tim's +2. -- To view, visit

[Impala-ASF-CR] Fix E2E test infrastructure to handle missing exceptions correctly

2016-12-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: Fix E2E test infrastructure to handle missing exceptions correctly .. Patch Set 2: Yes, merging now. The private exhaustive build just completed. -- To view,

[Impala-ASF-CR] IMPALA-4564,IMPALA-4565: mt dop fixes for old aggs and joins

2016-12-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4525: follow-on: cleanup error handling

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4525: follow-on: cleanup error handling .. IMPALA-4525: follow-on: cleanup error handling Testing: Ran exhaustive build. There is already some test

[Impala-ASF-CR] Bump Kudu python version to 1.1

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Bump Kudu python version to 1.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5307 To unsubscribe, visit

[Impala-ASF-CR] Start a docs build system.

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Start a docs build system. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5238 To unsubscribe, visit

[Impala-ASF-CR] Start a docs build system.

2016-12-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Start a docs build system. .. Patch Set 2: Any additional concerns, here? -- To view, visit http://gerrit.cloudera.org:8080/5238 To unsubscribe, visit

[Impala-ASF-CR] Add Apache license header to files in doc directory

2016-12-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add Apache license header to files in doc directory .. Patch Set 1: Once this is merged, we can add RAT checks to our pre-merge testing. -- To view, visit

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-12-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. Patch Set 3: Any additional concerns, here? -- To view, visit

[Impala-ASF-CR] Fix E2E test infrastructure to handle missing exceptions correctly

2016-12-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Fix E2E test infrastructure to handle missing exceptions correctly .. Patch Set 2: I've seen this breaking Impala Public Jenkins test runs. Is this ready for

[Impala-ASF-CR] Bump Kudu python version to 1.1

2016-12-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5307 Change subject: Bump Kudu python version to 1.1 .. Bump Kudu python version to 1.1 Change-Id:

[Impala-ASF-CR] IMPALA-4564,IMPALA-4565: mt dop fixes for old aggs and joins

2016-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/63/

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-12-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 17: Code-Review+2 - Hdfs core exhaustive failed on a single test

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-12-01 Thread Bharath Vissapragada (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5148 to look at the new patch set (#17). Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

[Impala-ASF-CR] IMPALA-4557: Fix flakiness with FLAGS stress free pool alloc

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5281 To

[Impala-ASF-CR] IMPALA-4557: Fix flakiness with FLAGS stress free pool alloc

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc .. IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc

[Impala-ASF-CR] Bracketing Java logging output with log level checks part 2.

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Bracketing Java logging output with log level checks part 2. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5297 To

[Impala-ASF-CR] Bracketing Java logging output with log level checks part 2.

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Bracketing Java logging output with log level checks part 2. .. Bracketing Java logging output with log level checks part 2. This reduces creation

[Impala-ASF-CR] IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes.

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. .. IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. The bug was that

[Impala-ASF-CR] IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes.

2016-12-01 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5274 To

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-12-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5288/1/be/src/exec/kudu-scanner.cc File