[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 4: I changed the approach, please take another look. -- To view, visit

[Impala-ASF-CR] IMPALA-4745: fix TestScratchLimit failure on S3

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4745: fix TestScratchLimit failure on S3 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5654 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4745: fix TestScratchLimit failure on S3

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4745: fix TestScratchLimit failure on S3 .. IMPALA-4745: fix TestScratchLimit failure on S3 The commit "IMPALA-3202,IMPALA-2079: rework

[Impala-ASF-CR] Major update to Impala + Kudu page

2017-01-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Major update to Impala + Kudu page .. Patch Set 4: (31 comments) http://gerrit.cloudera.org:8080/#/c/5649/4/docs/topics/impala_alter_table.xml File

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5646/1/docs/topics/impala_delete.xml File

[Impala-ASF-CR] IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements

2017-01-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements .. Patch Set 6: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 6: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4036: show create table outputs invalid SQL for partitioned table with comment

2017-01-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4036: show create table outputs invalid SQL for partitioned table with comment .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Marcel Kornacker (Code Review)
Hello Impala Public Jenkins, Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5662 to look at the new patch set (#4). Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Marcel Kornacker (Code Review)
Hello Impala Public Jenkins, Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5662 to look at the new patch set (#3). Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-10 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Abandoned Abandoned in lieu of https://gerrit.cloudera.org/5667 -- To view, visit

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-10 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5667 Change subject: Initial commit of the blog section of the Impala ASF website. .. Initial commit of the blog section of the Impala ASF

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#5). Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. IMPALA-1861: Simplify conditionals with constant conditions When there are conditionals

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr .. IMPALA-4707: fix use-after-free in QueryExecMgr The bug is that the QueryState was

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5615 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4745: fix TestScratchLimit failure on S3

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4745: fix TestScratchLimit failure on S3 .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/162/ -- To view,

[Impala-ASF-CR] IMPALA-4745: fix TestScratchLimit failure on S3

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4745: fix TestScratchLimit failure on S3 .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5654 To unsubscribe,

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5665/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. IMPALA-4549: consistently treat as upper bound for timestamp year Previously

[Impala-ASF-CR] IMPALA-4749: hit DCHECK in sorter with scratch limit

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4749: hit DCHECK in sorter with scratch limit .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5653 To unsubscribe,

[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option. .. Patch Set 1: Code-Review+1 (1 comment) The technical content looks accurate.

[Impala-ASF-CR] IMPALA-4163: Add doc for sortby() hint

2017-01-10 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-4163: Add doc for sortby() hint .. IMPALA-4163: Add doc for sortby() hint Add SORTBY() to list of hints in "Hints" topic. Update hint syntax in INSERT

[Impala-ASF-CR] IMPALA-4163: Add doc for sortby() hint

2017-01-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-4163: Add doc for sortby() hint .. Patch Set 1: Code-Review-1 (1 comment) Needs another patch set for sure.

[Impala-ASF-CR] IMPALA-4036: show create table outputs invalid SQL for partitioned table with comment

2017-01-10 Thread Joe McDonnell (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5648 to look at the new patch set (#3). Change subject: IMPALA-4036: show create table outputs invalid SQL for partitioned table with comment

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5646/1//COMMIT_MSG Commit Message: PS1, Line 7:

[Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML

2017-01-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 7: (12 comments)

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-10 Thread Thomas Tauber-Marshall (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5389 to look at the new patch set (#7). Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5665/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-3973: optional 2nd and 3rd arguments for instr().

2017-01-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr(). .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 3: this draft looks fine to me. -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add Kudu cmake utilities .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5656/2/cmake_modules/kudu_cmake_fns.txt File

[Impala-ASF-CR] Major update to Impala + Kudu page

2017-01-10 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#4). Change subject: Major update to Impala + Kudu page .. Major update to Impala + Kudu page Upgrade with details of latest syntax. Fine-tune discussion of PK and other Kudu notions.

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. Patch Set 2: > > Okay > > Do you think this needs more explanation in the breakpad tests? I guess you

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. Patch Set 2: > Okay Do you think this needs more explanation in the breakpad tests? -- To view, visit

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. Patch Set 2: Okay -- To view, visit http://gerrit.cloudera.org:8080/5669 To unsubscribe, visit

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5668/1//COMMIT_MSG Commit Message: Line 28: Change-Id:

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-10 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5668/1/docs/topics/impala_incompatible_changes.xml File

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Add Kudu cmake utilities .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5656/2/cmake_modules/kudu_cmake_fns.txt File

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. Patch Set 2: > Should we add this to tests/custom_cluster/test_breakpad.py where > we also look for

[Impala-ASF-CR] IMPALA-4652: Add crcutil to build

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4652: Add crcutil to build .. Patch Set 1: Code-Review+2 (1 comment) Looks good, looking forward to the follow-up patches when we make use of all of

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4651: Add LibEv to build .. Patch Set 1: Code-Review+2 (1 comment) Looks good, looking forward to the follow-up patches when we make use of all of

[Impala-ASF-CR] IMPALA-4036: show create table outputs invalid SQL for partitioned table with comment

2017-01-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4036: show create table outputs invalid SQL for partitioned table with comment .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/160/ -- To view,

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5615 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 2: Marcel just informed me that he will continue working on this patch. (I am no longer

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. Patch Set 2: Should we add this to tests/custom_cluster/test_breakpad.py where we also look for logs? --

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5668/1/docs/topics/impala_incompatible_changes.xml File

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4751: Remove blank line from raw_text template .. IMPALA-4751: Remove blank line from raw_text template The additional blank line can

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5664 To unsubscribe,

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5669 To unsubscribe,

[Impala-ASF-CR] IMPALA-4749: hit DCHECK in sorter with scratch limit

2017-01-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4749: hit DCHECK in sorter with scratch limit .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5653 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4745: fix TestScratchLimit failure on S3

2017-01-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4745: fix TestScratchLimit failure on S3 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5654 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. Patch Set 1: (2 comments) Thanks for the review, please see PS2.

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-10 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. IMPALA-4722: Disable log caching in test_scratch_disk test_scratch_disk fails sporadically when trying to

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 2: I think this requires some additional test fixes, I am looking into it. -- To view,

[Impala-ASF-CR] IMPALA-4745: fix TestScratchLimit failure on S3

2017-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4745: fix TestScratchLimit failure on S3 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5654 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 2: Is this ready for a new pre-commit Jenkins test? -- To view, visit

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 2: Code-Review+2 Test fixes look good to me -- To view, visit

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-10 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5669 Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. IMPALA-4722: Disable log caching in test_scratch_disk

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-10 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5668 Change subject: Release note updates for Impala 2.8 .. Release note updates for Impala 2.8 First cut at 'new features' topic. Commented

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Marcel Kornacker (Code Review)
Hello Impala Public Jenkins, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5662 to look at the new patch set (#2). Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr .. Patch Set 6: I had to make a non-trivial change to fix a bug, would be good if reviewers could take another

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-10 Thread Tim Armstrong (Code Review)
Hello Marcel Kornacker, Impala Public Jenkins, Jim Apple, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5615 to look at the new patch set (#6). Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4036: show create table outputs invalid SQL for partitioned table with comment

2017-01-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4036: show create table outputs invalid SQL for partitioned table with comment .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5665 Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. IMPALA-4549: consistently treat as upper

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: (1 comment)

Re: [Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Henry Robinson
Let's get it in. We can discuss the other issues later. On Tue, Jan 10, 2017 at 9:33 AM Tim Armstrong (Code Review) < ger...@cloudera.org> wrote: > Tim Armstrong has posted comments on this change. > > > > Change subject: IMPALA-4751: Remove blank line from raw_text template > >

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5664 To unsubscribe,

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 2: > Why can't this be fixed on the consumer side? Stripping out leading > and trailing white

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 2: Why can't this be fixed on the consumer side? Stripping out leading and trailing white

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/158/ -- To

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 2: > DO you want me to start the pre-commit testing Jenkins job? Thanks for the review. Yes,

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 1: (3 comments) Thanks for the reviews, please see PS2.

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Lars Volker (Code Review)
Hello David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5664 to look at the new patch set (#2). Change subject: IMPALA-4751: Remove blank line from raw_text template ..

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5664/1/tests/webserver/test_web_pages.py

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5664 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5664 Change subject: IMPALA-4751: Remove blank line from raw_text template .. IMPALA-4751: Remove blank line from raw_text template The

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 1: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/156/ -- To

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 1: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/157/