[Impala-ASF-CR] IMPALA-5419: Check for cancellation when building hash tables

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5419: Check for cancellation when building hash tables .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/670/

[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result

2017-06-01 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-4418: Extra blank lines in query result .. IMPALA-4418: Extra blank lines in query result This change will remove the blank lines resulting from the

[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result

2017-06-01 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/7055 Change subject: IMPALA-4418: Extra blank lines in query result .. IMPALA-4418: Extra blank lines in query result This change will remove

[Impala-ASF-CR] IMPALA-5419: Check for cancellation when building hash tables

2017-06-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5419: Check for cancellation when building hash tables .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7047 To unsubscribe,

[Impala-ASF-CR] IMPALA-5377: Impala may crash if given a fragment instance while restarting

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5377: Impala may crash if given a fragment instance while restarting .. IMPALA-5377: Impala may crash if given a fragment instance while

[Impala-ASF-CR] IMPALA-5377: Impala may crash if given a fragment instance while restarting

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5377: Impala may crash if given a fragment instance while restarting .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads

2017-06-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-01 Thread Steve Carlin (Code Review)
Steve Carlin has abandoned this change. Change subject: IMPALA-4892: Session ID included in error message .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7051 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-01 Thread Steve Carlin (Code Review)
Steve Carlin has uploaded a new patch set (#2). Change subject: IMPALA-4892: Session ID included in error message .. IMPALA-4892: Session ID included in error message Included the Session ID in the invalid session ID message.

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-01 Thread Steve Carlin (Code Review)
Steve Carlin has uploaded a new patch set (#2). Change subject: IMPALA-4892: Session ID included in error message .. IMPALA-4892: Session ID included in error message Included the Session ID in the invalid session ID message.

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4892: Session ID included in error message .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7054/1/be/src/service/impala-server.cc File

[Impala-ASF-CR] IMPALA-5030: [TESTS] Adds support for NVL2() function

2017-06-01 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#5). Change subject: IMPALA-5030: [TESTS] Adds support for NVL2() function .. IMPALA-5030: [TESTS] Adds support for NVL2() function This change adds value tests to expr-test.cc to

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-06-01 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7000/3/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-5030: [TESTS] Adds support for NVL2() function

2017-06-01 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#4). Change subject: IMPALA-5030: [TESTS] Adds support for NVL2() function .. IMPALA-5030: [TESTS] Adds support for NVL2() function This change adds value tests to expr-test.cc to

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-01 Thread Steve Carlin (Code Review)
Steve Carlin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7054 Change subject: IMPALA-4892: Session ID included in error message .. IMPALA-4892: Session ID included in error message Included the

[Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE

2017-06-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5413: Skip test seq writer hive compatibility on remote clusters.

2017-06-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5413: Skip test_seq_writer_hive_compatibility on remote clusters. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5413: Skip test seq writer hive compatibility on remote clusters.

2017-06-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5413: Skip test_seq_writer_hive_compatibility on remote clusters. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5338: Fix Kudu timestamp column default values .. IMPALA-5338: Fix Kudu timestamp column default values While support for TIMESTAMP

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5338: Fix Kudu timestamp column default values .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6936 To unsubscribe,

[Impala-ASF-CR] IMPALA-4864 Speed up single slot predicates with dictionaries

2017-06-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries .. Patch Set 14: I'm getting kind of disheartened by this approach. The biggest obstacle is that

[Impala-ASF-CR] IMPALA-4864 Speed up single slot predicates with dictionaries

2017-06-01 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#14). Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries .. IMPALA-4864 Speed up single slot predicates with dictionaries When dictionaries are present we can

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4892: Session ID included in error message .. Patch Set 1: (1 comment) Thanks for the patch! Just one minor comment.

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-01 Thread Steve Carlin (Code Review)
Steve Carlin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7051 Change subject: IMPALA-4892: Session ID included in error message .. IMPALA-4892: Session ID included in error message Included the

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-06-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5377: Impala may crash if given a fragment instance while restarting

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5377: Impala may crash if given a fragment instance while restarting .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5419: Check for cancellation when building hash tables

2017-06-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5419: Check for cancellation when building hash tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5419: Check for cancellation when building hash tables

2017-06-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5419: Check for cancellation when building hash tables .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5419: Check for cancellation when building hash tables

2017-06-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5419: Check for cancellation when building hash tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE

2017-06-01 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE .. IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE

[Impala-ASF-CR] IMPALA-5419: Check for cancellation when building hash tables

2017-06-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5419: Check for cancellation when building hash tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE

2017-06-01 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE .. Patch Set 1: (5 comments) Addressed all the comments from Lars.

[Impala-ASF-CR] IMPALA-5419: Check for cancellation when building hash tables

2017-06-01 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/7047 Change subject: IMPALA-5419: Check for cancellation when building hash tables .. IMPALA-5419: Check for cancellation when building hash

[Impala-ASF-CR] IMPALA-5377: Impala may crash if given a fragment instance while restarting

2017-06-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5377: Impala may crash if given a fragment instance while restarting .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7036

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Henry Robinson (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7045 to look at the new patch set (#3). Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 2: Rebased and included an unsquashed fix. -- To view, visit

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Henry Robinson (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7045 to look at the new patch set (#2). Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

[Impala-ASF-CR] IMPALA-5378: Disk IO manager needs to understand ADLS

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7033 To unsubscribe,

[Impala-ASF-CR] IMPALA-5378: Disk IO manager needs to understand ADLS

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS .. IMPALA-5378: Disk IO manager needs to understand ADLS The Disk IO Manager had

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-06-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5338: Fix Kudu timestamp column default values .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads .. IMPALA-5350: Tidy up thread groups for finst exec threads Put all per-finst

[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6951 To

[Impala-ASF-CR] IMPALA-5413: Skip test seq writer hive compatibility on remote clusters.

2017-06-01 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/7046 Change subject: IMPALA-5413: Skip test_seq_writer_hive_compatibility on remote clusters. .. IMPALA-5413: Skip

[Impala-ASF-CR] IMPALA-5411: Avoid log spew from GetRuntimeProfileStr

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr .. IMPALA-5411: Avoid log spew from GetRuntimeProfileStr GetRuntimeProfileStr can

[Impala-ASF-CR] IMPALA-5411: Avoid log spew from GetRuntimeProfileStr

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7042 To unsubscribe,

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-06-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5338: Fix Kudu timestamp column default values .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6936 To unsubscribe,

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5338: Fix Kudu timestamp column default values .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/668/ -- To

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-06-01 Thread Matthew Jacobs (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6936 to look at the new patch set (#5). Change subject: IMPALA-5338: Fix Kudu timestamp column default values ..

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 1: Code-Review+2 (1 comment) Thanks. Not sure if I am

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-06-01 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5338: Fix Kudu timestamp column default values .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case

2017-06-01 Thread Joe McDonnell (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7020 to look at the new patch set (#4). Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case ..

[Impala-ASF-CR] IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case

2017-06-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case .. Patch Set 2: > > > See IMPALA-5403, which is something we should do in the near > > term, > > > so

[Impala-ASF-CR] IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case

2017-06-01 Thread Joe McDonnell (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7020 to look at the new patch set (#3). Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case ..

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7045 Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. IMPALA-5056: Ensure analysis uses 'fresh'

[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test

2017-06-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5400: Execute tests in subplans.test .. Patch Set 1: (14 comments)

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-06-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-5338: Fix Kudu timestamp column default values .. IMPALA-5338: Fix Kudu timestamp column default values While support for TIMESTAMP columns in Kudu tables

[Impala-ASF-CR] IMPALA-5137: [DOCS] Document TIMESTAMP for Kudu tables

2017-06-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: [DOCS] Document TIMESTAMP for Kudu tables .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7035/1/docs/shared/impala_common.xml

[Impala-ASF-CR] IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS

2017-06-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7044/1/docs/shared/impala_common.xml File

[Impala-ASF-CR] IMPALA-5378: Disk IO manager needs to understand ADLS

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/667/ -- To

[Impala-ASF-CR] IMPALA-5378: Disk IO manager needs to understand ADLS

2017-06-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS .. Patch Set 3: Code-Review+2 > Uploaded patch set 3: Patch Set 2 was rebased. Thanks for the review

[Impala-ASF-CR] IMPALA-5377: Impala may crash if given a fragment instance while restarting

2017-06-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5377: Impala may crash if given a fragment instance while restarting .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/666/ --

[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads

2017-06-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads .. Patch Set 3: Code-Review+2 (2 comments) Carry +2

[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads

2017-06-01 Thread Henry Robinson (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6951 to look at the new patch set (#3). Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads

[Impala-ASF-CR] IMPALA-5377: Impala may crash if given a fragment instance while restarting

2017-06-01 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7036 to look at the new patch set (#2). Change subject: IMPALA-5377: Impala may crash if given a fragment instance while restarting

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu .. IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu I added the syntax and

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7041 To

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/122/ --

[Impala-ASF-CR] IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS

2017-06-01 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7044 Change subject: IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS .. IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS The text from impala_common.xml

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

2017-06-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7041 To unsubscribe,

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

2017-06-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu .. Patch Set 1: > did we also add ALTER TABLE ALTER COLUMN SET DEFAULT and such? Didn't make it in

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu .. Patch Set 1: did we also add ALTER TABLE ALTER COLUMN SET DEFAULT and such? -- To view, visit

[Impala-ASF-CR] IMPALA-4988: Add query option read parquet statistics

2017-06-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4988: Add query option read_parquet_statistics .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5411: Avoid log spew from GetRuntimeProfileStr

2017-06-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr .. Patch Set 1: Code-Review+2 I had no idea that Expected() existed... thanks! -- To view, visit

[Impala-ASF-CR] IMPALA-4988: Add query option read parquet statistics

2017-06-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4988: Add query option read_parquet_statistics .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5411: Avoid log spew from GetRuntimeProfileStr

2017-06-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/7042 Change subject: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr .. IMPALA-5411: Avoid log spew from GetRuntimeProfileStr

[Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5326: [DOCS] Document REPLACE() function .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6979 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5326: [DOCS] Document REPLACE() function .. IMPALA-5326: [DOCS] Document REPLACE() function Included syntax, mention of performance

[Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function

2017-06-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5326: [DOCS] Document REPLACE() function .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/121/ -- To view,

[Impala-ASF-CR] IMPALA-5378: Disk IO manager needs to understand ADLS

2017-06-01 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7033 To unsubscribe,

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-06-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 16: (6 comments) Looking good, just had a handful of comments.

[Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function

2017-06-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5326: [DOCS] Document REPLACE() function .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6979 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test

2017-06-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5400: Execute tests in subplans.test .. Patch Set 1: Code-Review+1 (1 comment) Change looks good, my only question is whether we need the test coverage.

[Impala-ASF-CR] IMPALA-5377: Impala may crash if given a fragment instance while restarting

2017-06-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5377: Impala may crash if given a fragment instance while restarting .. Patch Set 1: Code-Review+1 Same comment as Alex. -- To view, visit

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-06-01 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 6: > Was able to run Impala exhaustive tests with this toolchain > version. > > Thanks

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

2017-06-01 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7041 Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu .. IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu I

[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test

2017-06-01 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5400: Execute tests in subplans.test .. Patch Set 1: (1 comment)