[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 18: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1045/ -- To

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 18: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1043/

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. Patch Set 15: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1044/ -- To

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 7: Code-Review+2 ... and a BE test needed to be updated after the #include was removed from

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7630 to look at the new patch set (#7). Change subject: IMPALA-4833: Compute precise per-host reservation size

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/5717/18/LICENSE.txt File LICENSE.txt: Line

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 2: > (19 comments) Done -- To view, visit http://gerrit.cloudera.org:8080/7643 To

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. IMPALA-4794: Grouping distinct agg plan robust to data skew This patch changes the query plan for

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/5717/18/LICENSE.txt File LICENSE.txt:

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. IMPALA-5773: Correctly account for memory used in data stream receiver

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/5717/18/LICENSE.txt File LICENSE.txt: Line

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/7639/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 6: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1041/

[Impala-ASF-CR] IMPALA-5708: Test failure with invalid exec summary

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5708: Test failure with invalid exec summary .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1039/

[Impala-ASF-CR] IMPALA-4794: Partition distinct expr for skew data

2017-08-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4794: Partition distinct expr for skew data .. Patch Set 1: (19 comments) http://gerrit.cloudera.org:8080/#/c/7643/1//COMMIT_MSG Commit Message: Line 7:

[Impala-ASF-CR] IMPALA-4874: Increase the maximum KRPC message size to 4GB

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4874: Increase the maximum KRPC message size to 4GB .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5887 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5720 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4889: Use client sidecars for Thrift RPCs

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6473 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4856: Port data stream service to KRPC .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7103 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 18: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1043/ -- To

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5717 to look at the new patch set (#18). Change subject: IMPALA-4669: [SECURITY] Add security library to build

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-11 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5716 to look at the new patch set (#15). Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

[Impala-ASF-CR] IMPALA-5412: Fix scan result with partitions on same file

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5412: Fix scan result with partitions on same file .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1041/ -- To

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7630 to look at the new patch set (#6). Change subject: IMPALA-4833: Compute precise per-host reservation size

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. Patch Set 14: Build failed:

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 17: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1034/ -- To

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1038/

[Impala-ASF-CR] IMPALA-5412: Fix scan result with partitions on same file

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5412: Fix scan result with partitions on same file .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1040/ --

[Impala-ASF-CR] IMPALA-5412: Fix scan result with partitions on same file

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5412: Fix scan result with partitions on same file .. Patch Set 7: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/7625 To

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. Patch Set 3: This patch fixes two issues over the previous patch: 1. Fix quadratic behaviour when

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-11 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7591 to look at the new patch set (#3). Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool ..

[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-2422: Fix escaping in LIKE clause .. IMPALA-2422: Fix escaping in LIKE clause There are two stages to processing a like clause. First, we determine if

[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-2422: Fix escaping in LIKE clause .. IMPALA-2422: Fix escaping in LIKE clause There are two stages to processing a like clause. First, we determine if

[Impala-ASF-CR] IMPALA-5708: Test failure with invalid exec summary

2017-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5708: Test failure with invalid exec summary .. Patch Set 2: GVD is going to fail. I think you need to rebase:

[Impala-ASF-CR] IMPALA-5681: release reservation from blocking operators

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5681: release reservation from blocking operators .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/7526/8/be/src/codegen/codegen-anyval.h

[Impala-ASF-CR] IMPALA-5412: Fix scan result with partitions on same file

2017-08-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5412: Fix scan result with partitions on same file .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7625 To unsubscribe,

[Impala-ASF-CR] IMPALA-5681: release reservation from blocking operators

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5681: release reservation from blocking operators .. Patch Set 4: Code-Review+1 carry +1 -- To view, visit http://gerrit.cloudera.org:8080/7619 To

[Impala-ASF-CR] IMPALA-5681: release reservation from blocking operators

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5681: release reservation from blocking operators .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7619/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5681: release reservation from blocking operators

2017-08-11 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7619 to look at the new patch set (#4). Change subject: IMPALA-5681: release reservation from blocking operators

[Impala-ASF-CR] IMPALA-5412: Fix scan result with partitions on same file

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5412: Fix scan result with partitions on same file .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 8: > (4 comments) > > Yeah, we use Status almost universally for error handling. We don't >

[Impala-ASF-CR] IMPALA-5412: Fix scan result with partitions on same file

2017-08-11 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7625 to look at the new patch set (#6). Change subject: IMPALA-5412: Fix scan result with partitions on same file ..

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3208: max_row_size option .. IMPALA-3208: max_row_size option This is a preview because it is missing tests. I have manually tested it and it is behaving

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5708: Test failure with invalid exec summary

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5708: Test failure with invalid exec summary .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1039/ -- To

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1038/ -- To

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7630 To unsubscribe,

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7630 To unsubscribe,

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 7: (4 comments) Yeah, we use Status almost universally for error handling. We don't currently

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Matthew Jacobs (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7630 to look at the new patch set (#5). Change subject: IMPALA-4833: Compute precise per-host reservation size ..

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-5749: coordinator race hits DCHECK 'num remaining backends > 0'

2017-08-11 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7577 to look at the new patch set (#3). Change subject: IMPALA-5749: coordinator race hits DCHECK 'num_remaining_backends_ > 0'

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 4: Code-Review+1 (3 comments) Looks good to me. Not sure if Lars wants to take a look too.

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 4: > Build started:

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. Patch Set 3: Code-Review+1 -- To view, visit

Re: [Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-11 Thread Dimitris Tsirogiannis
Sounds good to me. Dimitris On Fri, Aug 11, 2017 at 2:21 PM, Bharath Vissapragada (Code Review) < ger...@cloudera.org> wrote: > Bharath Vissapragada has posted comments on this change. > > Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code >

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. Patch Set 3: Thanks Dimitris for the quick reviews. I'll run the metadata benchmark again

[Impala-ASF-CR] IMPALA-5412: Fix scan result with partitions on same file

2017-08-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5412: Fix scan result with partitions on same file .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7625/5/be/src/exec/hdfs-scan-node-base.h

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7652 To

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. IMPALA-4847: Simplify HdfsTable block metadata loading code This commit is a part of ground

[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7660 Change subject: IMPALA-2422: Fix escaping in LIKE clause .. IMPALA-2422: Fix escaping in LIKE clause There are two stages to

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#7). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 6: D > (7 comments) Done(Test is still ongoing). I have a question: when doing error handling

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#6). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. Patch Set 2: (3 comments) Yay, more lined deleted :)

[Impala-ASF-CR] IMPALA-5116: Remove deprecated hash * types in gutil

2017-08-11 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil .. Patch Set 4: (2 comments) Sorry for the late. Let me answer Jim's comment soon.

[Impala-ASF-CR] IMPALA-5708: Test failure with invalid exec summary

2017-08-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5708: Test failure with invalid exec summary .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7627 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. IMPALA-4847: Simplify HdfsTable block metadata loading code This commit is a part of ground

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 3: (2 comments) I didn't notice any significant performance

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7646 to look at the new patch set (#4). Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. Patch Set 14: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1032/

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 17: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1033/ This was a bug in a

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. Patch Set 14: Build started:

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. Patch Set 14: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 17: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1034/ -- To

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 17: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1033/

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 17: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1033/ -- To

[Impala-ASF-CR] IMPALA-5791: Make bootstrap development.sh survive apt-get failure

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5791: Make bootstrap_development.sh survive apt-get failure .. IMPALA-5791: Make bootstrap_development.sh survive apt-get failure This

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. Patch Set 14: Build started:

[Impala-ASF-CR] IMPALA-5791: Make bootstrap development.sh survive apt-get failure

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5791: Make bootstrap_development.sh survive apt-get failure .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7657

[Impala-ASF-CR] IMPALA-5749: coordinator race hits DCHECK 'num remaining backends > 0'

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5749: coordinator race hits DCHECK 'num_remaining_backends_ > 0' .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-11 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. Patch Set 3: (13 comments)

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7639/2/be/src/exec/hdfs-text-scanner.cc

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 15: I've tested (at least by building) this on all the platforms we distribute at Cloudera.

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-11 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#3). Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

  1   2   >