[Impala-ASF-CR] Add search / sort to HTML tables for metrics and threads

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4743 Change subject: Add search / sort to HTML tables for metrics and threads .. Add search / sort to HTML tables for metrics and threads

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Remove Llama dependency .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/metrics.json File common/thrift/metrics.json:

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 8: Code-Review+1 (11 comments)

[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2916: Add warning to query profile if debug build .. Patch Set 1: (2 comments) This will be useful to have.

[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Follow Apache Project Branding Requirements .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4683/1/bylaws.html File bylaws.html: PS1, Line

[Impala-ASF-CR] review comments 1

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: review comments 1 .. Abandoned Mistakenly pushed. -- To view, visit http://gerrit.cloudera.org:8080/4735 To unsubscribe, visit

[Impala-ASF-CR] review comments 1

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4735 Change subject: review comments 1 .. review comments 1 Change-Id: I3d1094dffd6b0341f8554283c3b77c6a970ca7ec --- M

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4736 Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module .. IMPALA-2905: Move QueryResultSet

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-16 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 21: Rebase. Carry +2. Fixed a bug in test_hs2::test_get_log where the test

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-16 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#21). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-16 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#20). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-14 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#19). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 18: I think this change has exposed a race in error log reporting that's very

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-14 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#18). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-14 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#17). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#16). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 15: Code-Review+2 Rebase, carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#12). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#11). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

[Impala-ASF-CR] IMPALA-3853: squeasel is MIT (and dual copyright) not Apache

2016-10-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3853: squeasel is MIT (and dual copyright) not Apache .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4646 To

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 10: EE tests pass with this new sink implementation as well. -- To view,

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 9: After some discussion, moved the result materialization into Send(). The

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#9). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 8: Code-Review+2 Rebase (plus add a flag and disable the test), carry

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#8). Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high load During

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-06 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#8). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

[Impala-ASF-CR] IMPALA-3342: Adding new timer to accurately measure the TotalCpuTime

2016-10-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3342: Adding new timer to accurately measure the TotalCpuTime .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4633/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-10-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 18: Code-Review+1 (1 comment) Changes since PS16

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 7: (28 comments) This patch passes EE tests. I haven't completely addressed

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 2: (1 comment) Any easy way to test this? Can you add some UDFs and then check

[Impala-ASF-CR] IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s

2016-10-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: Do you understand the relationship between the resulting .clang-format file and the

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 5: (3 comments) This looks good to me. One last thing: we should

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 4: (7 comments) Looking pretty good.

[Impala-ASF-CR] Remove spurious Boost warnings on compilation errors

2016-09-29 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4564 Change subject: Remove spurious Boost warnings on compilation errors .. Remove spurious Boost warnings on compilation errors

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 3: (8 comments) Some comments before I head off to Strata. I would

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Henry Robinson (Code Review)
Hello Juan Yu, Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4516 to look at the new patch set (#4). Change subject: IMPALA-4187: Switch RPC latency metrics to histograms

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-26 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 1: (7 comments) I think Sailesh's suggestion is a good one. Is there

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace.cc File

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 14: (15 comments) I think it would be good to

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. IMPALA-4011: Remove / reword messages when statestore messages are late

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 2: Code-Review+2 I'm going to submit this as is, then someone can take on

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 2: Before we consider adding a histogram, we'll need one that can be

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: The core change to HistogramMetric (adding a Reset() method) is needed for our proposed

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4516 Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. IMPALA-4187: Switch RPC latency metrics to histograms It's

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4050: Support starting webserver specified by hostname .. Patch Set 1: I think you've submitted this patch without squashing it - so you've got two

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. IMPALA-4011: Remove / reword messages when statestore messages are late Change-Id:

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-20 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4160: Remove Llama support. .. IMPALA-4160: Remove Llama support. Alas, poor Llama! I knew him, Impala: a system of infinite jest, of most

[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.

2016-09-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4479 To

[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.

2016-09-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4479/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4050: Support starting webserver specified by hostname .. Patch Set 2: See comments on your other patch - I think you can make the changes requested

[Impala-ASF-CR] IMPALA-4057:fix webserver interface with 127.0.0.1 when start impala process

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4057:fix webserver_interface with 127.0.0.1 when start impala process .. Patch Set 1: (6 comments) Sorry for the delay - looks pretty good, just a few

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4160: Remove Llama support. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/query-schedule.cc File

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4445 to look at the new patch set (#5). Change subject: IMPALA-4160: Remove Llama support. ..

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4160: Remove Llama support. .. Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/4445/1//COMMIT_MSG Commit Message: Line 7: Remove Llama

[Impala-ASF-CR] IMPALA-4610: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4610: Remove Llama support. .. Patch Set 1: (4 comments) Matt's going to weigh in on what parts of the memory estimation path we can remove, depending

[Impala-ASF-CR] IMPALA-4610: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4610: Remove Llama support. .. IMPALA-4610: Remove Llama support. Alas, poor Llama! I knew him, Impala: a system of infinite jest, of most excellent

[Impala-ASF-CR] Remove Llama support.

2016-09-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Remove Llama support. .. Patch Set 1: Passed a core test run. -- To view, visit http://gerrit.cloudera.org:8080/4445 To unsubscribe, visit

[Impala-ASF-CR] Remove Llama support.

2016-09-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4445 Change subject: Remove Llama support. .. Remove Llama support. Alas, poor Llama! I knew him, Impala: a system of infinite jest, of

[Impala-ASF-CR] IMPALA-4014: HEADERS ONLY: Introduce query-wide execution state.

2016-09-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4014: HEADERS ONLY: Introduce query-wide execution state. .. Patch Set 1: (17 comments)

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that change capacity

2016-09-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that change capacity .. Patch Set 4: (2 comments) Rebased to include IMPALA_ASSERT_DEBUG_DEATH macro from trunk.

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that change capacity

2016-09-16 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4428 to look at the new patch set (#5). Change subject: IMPALA-4138: Fix AcquireState() for batches that change capacity

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4428 to look at the new patch set (#4). Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called If

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. Patch Set 1: (1 comment) Agree that this maybe isn't a fix so much as an

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4428 Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. IMPALA-4138: Fix AcquireState() for

<    4   5   6   7   8   9