Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 23: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5483
To unsubscribe, visit
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192: Disentangle Expr and ExprContext
This change separates Expr and ExprContext. This
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 23:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/754/
--
To view,
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 23: Code-Review+2
Rebase.
--
To view, visit http://gerrit.cloudera.org:8080/5483
To unsubscribe, visit
Hello Marcel Kornacker, Impala Public Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#23).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 22: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5483
To unsubscribe, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 22:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/753/
--
To view,
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 22: Code-Review+2
Carry +2.
--
To view, visit http://gerrit.cloudera.org:8080/5483
To unsubscribe,
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 22:
Fix clang-tidy errors:
1. Missing override in function declarations
2. Remove unused variables in
Hello Marcel Kornacker, Impala Public Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#22).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 21: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/743/
--
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 21:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/743/
--
To view,
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 21:
Rebase. Fix some bugs found during stress tests. Carry +2.
--
To view, visit
Hello Marcel Kornacker, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#21).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 19:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/analytic-eval-node.h
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 20: Code-Review+2
Carry +2 forward.
--
To view, visit http://gerrit.cloudera.org:8080/5483
To
Hello Marcel Kornacker, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#20).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 19: Code-Review+2
(9 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 16:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/analytic-eval-node.h
File
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#19).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 18:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5483/18/be/src/exec/partitioned-aggregation-node.cc
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 16:
(61 comments)
http://gerrit.cloudera.org:8080/#/c/5483/16/be/src/exec/aggregation-node.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 17: Code-Review+1
(2 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 17:
please fix the pervasive non-const vector& or switch to vector* and explain why
it can get
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 17:
(62 comments)
http://gerrit.cloudera.org:8080/#/c/5483/16/be/src/exec/aggregation-node.cc
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#17).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 17:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5483/16/be/src/exec/aggregation-node.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 16:
(6 comments)
Looking good, just had a handful of comments.
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 14:
(70 comments)
http://gerrit.cloudera.org:8080/#/c/5483/14/be/src/exec/aggregation-node.cc
File
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#15).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 14:
(32 comments)
Made it through, finally... Overall looks way saner and easier to understand
than
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 14:
(14 comments)
Next batch - made it through everything except the expr/ subdirectory.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 14:
(26 comments)
First batch of comments - made it through exec/kudu*
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#14).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 13:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5483/13/be/src/exec/hdfs-parquet-scanner.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5483/13/be/src/exec/kudu-scanner.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5483/9/be/src/exprs/scalar-expr.h
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5483/7/be/src/exec/exec-node.h
File
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#12).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#11).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 10:
(57 comments)
http://gerrit.cloudera.org:8080/#/c/5483/9/be/src/exec/aggregation-node.cc
File
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#10).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 9:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5483/9/be/src/exec/aggregation-node.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 9:
(10 comments)
Still trying to come to grips with it all but did an initial pass over the
query
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 9:
(45 comments)
first half
http://gerrit.cloudera.org:8080/#/c/5483/7/be/src/exec/exec-node.h
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#9).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 8:
(56 comments)
http://gerrit.cloudera.org:8080/#/c/5483/7/be/src/exec/aggregation-node.h
File
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#8).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 7:
(25 comments)
some more comments. i haven't looked at the exec nodes in detail yet.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 7:
(31 comments)
initial comments
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#7).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 6:
I will post a new patch once the draft has gotten further along. Please feel
free to wait till then
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 6:
Is this superseded by the other review?
--
To view, visit http://gerrit.cloudera.org:8080/5483
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5483/6/be/src/exprs/expr.h
File be/src/exprs/expr.h:
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5483/6/be/src/exprs/expr.h
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5483/6/be/src/exprs/expr.h
File be/src/exprs/expr.h:
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 6:
(38 comments)
http://gerrit.cloudera.org:8080/#/c/5483/6/be/src/exprs/case-expr.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 6:
(1 comment)
One final issue. I'm assuming that we're going to rename
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#6).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 4:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/5483/4//COMMIT_MSG
Commit Message:
PS4, Line 31:
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#5).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5483/4/be/src/exec/hash-table-test.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 4:
(12 comments)
I had some high level comments. Still trying to understand the flow of
execution
63 matches
Mail list logo
