[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 17: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5719 To unsubscribe,

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. IMPALA-4669: [KRPC] Add kudu_rpc library to build Import FindKRPC.cmake from Apache Kudu.

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. IMPALA-5838: Improve errors on AC buffer mem rejection The error message returned when a query is

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 1: (1 comment) Looks like there are some stray comments?

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7834 To unsubscribe,

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-08-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-5425: Add test for validating input when setting query options .. IMPALA-5425: Add test for validating input when setting query options This patch adds

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-08-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). Change subject: IMPALA-5425: Add test for validating input when setting query options .. IMPALA-5425: Add test for validating input when setting query options This patch adds

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7834 to look at the new patch set (#3). Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection ..

[Impala-ASF-CR] IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch()

2017-08-25 Thread anujphadke (Code Review)
anujphadke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7849 Change subject: IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() .. IMPALA-3897 Codegen null-aware constant in

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/7730/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5846: Fix output path for kudu libraries

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5846: Fix output path for kudu libraries .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1155/ -- To view,

[Impala-ASF-CR] IMPALA-4856: Add KRPC service address to backend descriptor and plan fragment's destination

2017-08-25 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7760 to look at the new patch set (#3). Change subject: IMPALA-4856: Add KRPC service address to backend descriptor and plan fragment's destination

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5846: Fix output path for kudu libraries

2017-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5846: Fix output path for kudu libraries .. Patch Set 1: Code-Review+2 I took a quick look at the cmake docs and I also don't fully understand what was

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7834 to look at the new patch set (#4). Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection ..

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 5: Code-Review+1 Those messages make sense to me now, but let's see what others say. -- To

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7834 Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. IMPALA-5838: Improve errors on AC buffer mem rejection The

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-08-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5425: Add test for validating input when setting query options .. IMPALA-5425: Add test for validating input when setting query options This patch adds

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-08-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has restored this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Restored Move the test to backend -- To view, visit http://gerrit.cloudera.org:8080/7805 To

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7834 to look at the new patch set (#5). Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection ..

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#4). Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. IMPALA-5750: Catch exceptions from boost thread creation The boost thread constructor will throw

[Impala-ASF-CR] IMPALA-5846: Fix output path for kudu libraries

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5846: Fix output path for kudu libraries .. IMPALA-5846: Fix output path for kudu libraries Prior to this patch, libraries and

[Impala-ASF-CR] IMPALA-5846: Fix output path for kudu libraries

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5846: Fix output path for kudu libraries .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7818 To unsubscribe, visit

[Impala-ASF-CR] Rename thrift-deps to gen-deps

2017-08-25 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/7851 Change subject: Rename thrift-deps to gen-deps .. Rename thrift-deps to gen-deps As a preparation to start generating Protobuf files, this

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-08-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). Change subject: IMPALA-5425: Add test for validating input when setting query options .. IMPALA-5425: Add test for validating input when setting query options This patch adds

[Impala-ASF-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-08-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7741 To

[Impala-ASF-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-08-25 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7741 to look at the new patch set (#2). Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS

[Impala-ASF-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1157/ --

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-25 Thread John Sherman (Code Review)
John Sherman has uploaded a new patch set (#8). Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer - Previously

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-25 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 8: (1 comment) Thanks for the feedback Henry. I've attempted to create an

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-25 Thread John Sherman (Code Review)
John Sherman has uploaded a new patch set (#7). Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer - Previously

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7781 To

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-25 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 7: A couple of test questions: Would the custom cluster test framework be the

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 16: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1152/ --

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-08-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new change for review. http://gerrit.cloudera.org:8080/7829 Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. IMPALA-5211: Simplifying conditionals (istrue, nullif,

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Philip Zeyliger (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7781 to look at the new patch set (#7). Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 16: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1152/ -- To view,

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 17: Code-Review+2 Forgot to add necessary changes to logging.cc to patch. -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-25 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5719 to look at the new patch set (#17). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 17: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1154/ -- To view,

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-08-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#2). Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) This commit simplifies the

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 7: I wonder if you could write a test in thrift-server-test, that did