[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7854 Change subject: Update stress test with admission control rejected messages .. Update stress test with admission control rejected

[Impala-ASF-CR] IMPALA-5840: Don't write page-level statistics in Parquet files.

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5840: Don't write page-level statistics in Parquet files. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7817 To

[Impala-ASF-CR] IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch()

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() .. Patch Set 1: (2 comments) Looks good to me, only a couple of minor comments.

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-28 Thread Bharath Vissapragada (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7652 to look at the new patch set (#4). Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. Patch Set 4: Code-Review+2 Here is the perf analysis of this jira [1]. This regresses the

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/7730/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 1: Code-Review+2 Looks like this satisfies https://gerrit.cloudera.org/#/c/7834/ as

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 1: Verified+1 Precommit test doesn't exercise this. Manually verified by running stress

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Update stress test with admission control rejected messages .. Update stress test with admission control rejected messages IMPALA-5644 added a couple

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7834 To unsubscribe,

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec .. Patch Set 7: Did you have a change to look at the test failures? They looked

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1158/ --

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1159/ -- To

[native-toolchain-CR] Bump Kudu version to 1c70e5d

2017-08-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: Bump Kudu version to 1c70e5d .. Bump Kudu version to 1c70e5d Change-Id: Iba57fbe903a2aea0e34851f1a0611691a9bb319e --- M buildall.sh 1 file changed, 1

[native-toolchain-CR] Bump Kudu version to 1c70e5d

2017-08-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to 1c70e5d .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7855/1//COMMIT_MSG Commit Message: PS1, Line 7: 1c70e5d

[native-toolchain-CR] Bump Kudu version to 1c70e5d

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 1c70e5d .. Patch Set 2: > (1 comment) Ah, that's on Cloudera's github mirror. Let's choose the Apache repo. -- To view, visit

[native-toolchain-CR] Bump Kudu version to 1c70e5d

2017-08-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to 1c70e5d .. Patch Set 2: > > (1 comment) > > Ah, that's on Cloudera's github mirror. Let's choose the Apache > repo. Sure, so

[native-toolchain-CR] Bump Kudu version to 1c70e5d

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 1c70e5d .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7855 To unsubscribe, visit

[native-toolchain-CR] Bump Kudu version to 22a19d9

2017-08-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/7855 Change subject: Bump Kudu version to 22a19d9 .. Bump Kudu version to 22a19d9 Change-Id:

[native-toolchain-CR] Bump Kudu version to 22a19d9

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 22a19d9 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7855/1//COMMIT_MSG Commit Message: PS1, Line 7: 22a19d9 where is

[native-toolchain-CR] Bump Kudu version to 1c70e5d

2017-08-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. Change subject: Bump Kudu version to 1c70e5d .. Bump Kudu version to 1c70e5d Change-Id: Iba57fbe903a2aea0e34851f1a0611691a9bb319e --- M buildall.sh 1 file

[native-toolchain-CR] Bump Kudu version to 1c70e5d

2017-08-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to 1c70e5d .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7855 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 2: (1 comment)

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7859 Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. IMPALA-5849: Disable compile-time checks for OpenSSL >

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-28 Thread Pranay Singh (Code Review)
Pranay Singh has abandoned this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Abandoned Need to use the old commit id -- To view, visit http://gerrit.cloudera.org:8080/7807 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. IMPALA-4847: Simplify HdfsTable block metadata loading code This commit is a

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7652 To

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 Thrift commit taken from:

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-08-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7857 Change subject: IMPALA-2810: Remove column stats restoration when altering table .. IMPALA-2810: Remove column stats restoration when

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 3: (7 comments)

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7861 Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error .. IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error

[Impala-ASF-CR] IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5317: add DATE_TRUNC() function .. Patch Set 2: (15 comments) Just minor comments, mainly cleanup. I'd also like someone else to look over the code,

[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id

2017-08-28 Thread Dan Hecht (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7863 to look at the new patch set (#2). Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-28 Thread Matthew Jacobs (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7834 to look at the new patch set (#6). Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7861 to look at the new patch set (#3). Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error ..

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7861 to look at the new patch set (#2). Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error ..

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Matthew Mulder (Code Review)
Matthew Mulder has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 2: (16 comments)

[Impala-ASF-CR] IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/7863 Change subject: IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing .. IMPALA-5853: GetResultSetMetadata()

[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id .. Patch Set 2: Code-Review+2 carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7863/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 6: Code-Review+2 Agg memory changed in the test cases after Tim's recent patch for pre-agg

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1161/ -- To

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error .. Patch Set 1: Code-Review+1 Looks more helpful to me, thanks -- To view, visit

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7861 To unsubscribe,

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1163/ --

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Matthew Mulder (Code Review)
Matthew Mulder has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1159/

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: > (1 comment) What I'm worried about is if we didn't fix that, then we should -- it's a

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-28 Thread Pranay Singh (Code Review)
Pranay Singh has abandoned this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-28 Thread Pranay Singh (Code Review)
Pranay Singh has restored this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Restored -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-28 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded a new patch set (#2). Change subject: IMPALA-5108: Followup change to do the cleanup. .. IMPALA-5108: Followup change to do the cleanup. This change involves giving names to constant values to improve

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-28 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded a new patch set (#3). Change subject: IMPALA-5108: Followup change to do the cleanup. .. IMPALA-5108: Followup change to do the cleanup. This change involves giving names to constant values to improve

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1160/ -- To view,

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Patch Set 3: Code-Review+2 Looks like you uploaded this as a draft? You can upload it as a regular review and I

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-28 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded a new patch set (#3). Change subject: IMPALA-5108: Followup change to do the cleanup. .. IMPALA-5108: Followup change to do the cleanup. This change involves giving names to constant values to improve

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 3: (3 comments)

[Impala-ASF-CR] Update stress test with admission control rejected messages

2017-08-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Update stress test with admission control rejected messages .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-467: enable disabled metric verification

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-467: enable disabled metric verification .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7827 To unsubscribe, visit

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#4). Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 Thrift commit taken from:

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#5). Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. IMPALA-5750: Catch exceptions from boost thread creation The boost thread constructor will throw

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/7730/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-467: enable disabled metric verification

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-467: enable disabled metric verification .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1164/ -- To view,

[Impala-ASF-CR] Rename thrift-deps to gen-deps

2017-08-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Rename thrift-deps to gen-deps .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7851/1//COMMIT_MSG Commit Message: Line 9: As a preparation to

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7866 Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. IMPALA-5849: Remove compile-time checks for OpenSSL >

[Impala-ASF-CR] IMPALA-5840: Don't write page-level statistics in Parquet files.

2017-08-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5840: Don't write page-level statistics in Parquet files. .. Patch Set 2: Code-Review+2 Rebased, carrying Tim's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5840: Don't write page-level statistics in Parquet files.

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5840: Don't write page-level statistics in Parquet files. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1165/

[Impala-ASF-CR] IMPALA-5210: Count rows and collection items in parquet scanner separately

2017-08-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7776

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5108: Followup change to do the cleanup. .. IMPALA-5108: Followup change to do the cleanup. This change involves giving names to

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. IMPALA-5838: Improve errors on AC buffer mem rejection The error message returned

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7834 To

[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5853: fix GetResultSetMetadata() error message for invalid query id .. IMPALA-5853: fix GetResultSetMetadata() error message for invalid

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error .. IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error Augment the error

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7861 To

[Impala-ASF-CR] IMPALA-4856: Rename thrift-deps to gen-deps

2017-08-28 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-4856: Rename thrift-deps to gen-deps .. IMPALA-4856: Rename thrift-deps to gen-deps As a preparation to start generating Protobuf files for IMPALA-4856, this

[Impala-ASF-CR] IMPALA-4856: Rename thrift-deps to gen-deps

2017-08-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4856: Rename thrift-deps to gen-deps .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7851/1//COMMIT_MSG Commit Message: Line 9: As a

[Impala-ASF-CR] IMPALA-4856: Rename thrift-deps to gen-deps

2017-08-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4856: Rename thrift-deps to gen-deps .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7851 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5840: Don't write page-level statistics in Parquet files.

2017-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5840: Don't write page-level statistics in Parquet files. .. IMPALA-5840: Don't write page-level statistics in Parquet files. Page level

  1   2   >