[Impala-ASF-CR] DRAFT PREVIEW: Prereqs for load test system testing

2017-01-31 Thread Harrison Sheinblatt (Code Review)
Harrison Sheinblatt has abandoned this change. Change subject: DRAFT PREVIEW: Prereqs for load test system testing .. Abandoned New one submitted -- To view, visit http://gerrit.cloudera.org:8080/3785 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-4808: old hash join can reference invalid memory

2017-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4808: old hash join can reference invalid memory .. IMPALA-4808: old hash join can reference invalid memory The bug was that 'probe_rows_

[Impala-ASF-CR] IMPALA-4808: old hash join can reference invalid memory

2017-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4808: old hash join can reference invalid memory .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5850 To unsubscribe

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-01-31 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5800/1/testdata/workloads/func

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-01-31 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#2). Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. IMPALA-4738: STDDEV_SAMP should return NULL for single record input In calculating the STDDEV_

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 9: Michael, yeah, I will fix those. I still need to plug in the additional tests that will be required now that we

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-01-31 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. IMPALA-3586 (Part 1): Implement Union Pass Through The union node acts as pass through operator and forwa

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-01-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/5732/4//COMMIT_MSG Commit M

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-01-31 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. IMPALA-3586 (Part 1): Implement Union Pass Through The union node acts as pass through operator and forwa

[Impala-ASF-CR] IMPALA-4808: old hash join can reference invalid memory

2017-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4808: old hash join can reference invalid memory .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/224/ -- T

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-01-31 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. IMPALA-3586 (Part 1): Implement Union Pass Through The union node acts as pass through operator and forwa

[Impala-ASF-CR] IMPALA-4808: old hash join can reference invalid memory

2017-01-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4808: old hash join can reference invalid memory .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5850 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-4809: Add Stability for codegen constants

2017-01-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4809: Add Stability for codegen constants .. Patch Set 1: IMPALA-4809 isn't about inlining an expression related value, it's just that the way the code is cu

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 9: What do you mean by "complicated" queries? And how much did computing the StringSearch only once help? From your nu

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 9: Added support for saving StringSearcher for complicated queries.

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#9). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] Prereqs for load test system testing

2017-01-31 Thread Harrison Sheinblatt (Code Review)
Harrison Sheinblatt has uploaded a new change for review. http://gerrit.cloudera.org:8080/5851 Change subject: Prereqs for load test system testing .. Prereqs for load test system testing Additional py.test parameters to cont

[Impala-ASF-CR] IMPALA-4809: Add Stability for codegen constants

2017-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4809: Add Stability for codegen constants .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5848/1//COMMIT_MSG Commit Message: PS1, Line 16:

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5668/7/docs/topics/impala_incompatible_changes.xml File docs/top

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. Patch Set 3: @reviewers: Please don't review PS2/3. My next PS includes a bunch of

[Impala-ASF-CR] IMPALA-4809: Add Stability for codegen constants

2017-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4809: Add Stability for codegen constants .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5848/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-01-31 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 3: (3 comments) regarding testing, let's discuss that. http://gerr

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-31 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5640/7/tests/run-tests.py File tests/r

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-31 Thread David Knupp (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5640 to look at the new patch set (#8). Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. IM

[Impala-ASF-CR] IMPALA-4809: Add Stability for codegen constants

2017-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4809: Add Stability for codegen constants .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5848/1//COMMIT_MSG Commit Message: PS1, Line 16:

[Impala-ASF-CR] IMPALA-4808: old hash join can reference invalid memory

2017-01-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4808: old hash join can reference invalid memory .. Patch Set 1: Code-Review+1 Yeah, I guess it wasn't harmless after all. I think it makes sense to remo

[Impala-ASF-CR] IMPALA-4808: old hash join can reference invalid memory

2017-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4808: old hash join can reference invalid memory .. Patch Set 1: It looks like on the original CR there was some discussion about whether this was right/

[Impala-ASF-CR] IMPALA-4808: old hash join can reference invalid memory

2017-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5850 Change subject: IMPALA-4808: old hash join can reference invalid memory .. IMPALA-4808: old hash join can reference invalid memory The b

[Impala-ASF-CR] IMPALA-4809: Add Stability for codegen constants

2017-01-31 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5848 Change subject: IMPALA-4809: Add Stability for codegen constants .. IMPALA-4809: Add Stability for codegen constants Having two boolean pa

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/5776/8/be/src/exprs/string-functions-ir.cc File be/src/exprs/stri

[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-01-31 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4359: qgen: add UPSERT support .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5795/1/tests/comparison/model_translator.py File test

[Impala-ASF-CR] Improvements to "Unknown disk-ID" warning

2017-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Improvements to "Unknown disk-ID" warning .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5828/1//COMMIT_MSG Commit Message: Line 7: Improvements

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-31 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 13: (8 comments) New patch set coming any second. http://gerrit.cloudera.org:8080/#/c/5649/13/docs/topics

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-01-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5840 Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. IMPALA-4828: Alter Kudu schema outside Impala may cra

[Impala-ASF-CR](asf-site) Remove "Git repository" from navigation bar.

2017-01-31 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Remove "Git repository" from navigation bar. .. Remove "Git repository" from navigation bar. It is not in the navigation bar of any other page; it remained

[Impala-ASF-CR](asf-site) Remove "Git repository" from navigation bar.

2017-01-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Remove "Git repository" from navigation bar. .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5785 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-01-31 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. IMPALA-3586 (Part 1): Implement Union Pass Through The union node acts as pass through operator and forwa

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-01-31 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/5816/2/be/src/exec/union-node.cc File be

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-01-31 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. IMPALA-3586 (Part 1): Implement Union Pass Through The union node acts as pass through operator and forwa

[Impala-ASF-CR](asf-site) Remove "Git repository" from navigation bar.

2017-01-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: Remove "Git repository" from navigation bar. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5785 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. IMPALA-3989: Display skew warning for poorly formatted Parquet files Pa

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5400

[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial

2017-01-31 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5663/1//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial

2017-01-31 Thread John Russell (Code Review)
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5663 to look at the new patch set (#2). Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch

[Impala-ASF-CR] [DOCS] List SCHEDULE RANDOM REPLICA in alphabetical order.

2017-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] List SCHEDULE_RANDOM_REPLICA in alphabetical order. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5835 To unsubscr

[Impala-ASF-CR] [DOCS] List SCHEDULE RANDOM REPLICA in alphabetical order.

2017-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: [DOCS] List SCHEDULE_RANDOM_REPLICA in alphabetical order. .. [DOCS] List SCHEDULE_RANDOM_REPLICA in alphabetical order. Change-Id: I1e5ad55b588

[Impala-ASF-CR] [DOCS] List SCHEDULE RANDOM REPLICA in alphabetical order.

2017-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] List SCHEDULE_RANDOM_REPLICA in alphabetical order. .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/33/ -- T

[Impala-ASF-CR] [DOCS] List SCHEDULE RANDOM REPLICA in alphabetical order.

2017-01-31 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] List SCHEDULE_RANDOM_REPLICA in alphabetical order. .. Patch Set 1: Code-Review+2 I'll finalize this minor change. -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-31 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5668/3/docs/topics/impala_new_features.xml File docs/topics/impa

[Impala-ASF-CR] [DOCS] List SCHEDULE RANDOM REPLICA in alphabetical order.

2017-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: [DOCS] List SCHEDULE_RANDOM_REPLICA in alphabetical order. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5835 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#8). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs Very often we ha

[Impala-ASF-CR] IMPALA-4829: Change default Kudu read behavior for "RYW"

2017-01-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4829: Change default Kudu read behavior for "RYW" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5802 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-31 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5611 To unsubscri

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs Very often we ha

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. Patch Set 1: (6 comments) Thanks Alex for the reviews. Very helpful. I agree this

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File be/src/exprs/strin

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 23: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File be/src/exprs/str

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#6). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File be/src/exprs/stri

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-31 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 13: John, when do you plan to post a new patch that addresses the last comments? I think after th

[Impala-ASF-CR] [DOCS] List SCHEDULE RANDOM REPLICA in alphabetical order.

2017-01-31 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5835 Change subject: [DOCS] List SCHEDULE_RANDOM_REPLICA in alphabetical order. .. [DOCS] List SCHEDULE_RANDOM_REPLICA in alphabetical order.

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/5611/9/be/src/exec/parquet-column-sta

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File be/src/exprs/str

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5668/6/docs/topics/impala_incompatible_changes.xml File docs/top

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5668/7/docs/shared/impala_common.xml File docs/shared/impala_co

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-31 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5668/6/docs/topics/impala_incompatible_changes.xml File docs/

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File be/src/exprs/stri

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/5811/4/be/src/runtime/buffered-tupl

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-31 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#7). Change subject: Release note updates for Impala 2.8 .. Release note updates for Impala 2.8 First cut at 'new features' topic. Includes the Incompatible Changes subtopic for Impala

[Impala-ASF-CR] [DOCS] Apply conditionalization to tags.

2017-01-31 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5834 Change subject: [DOCS] Apply conditionalization to tags. .. [DOCS] Apply conditionalization to tags. Housekeeping change. Apply same co

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-01-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add .pep8rc for Impala's Python style .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc File .pep8rc: PS1, Line 5: # E251 - Remove whi

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 9: (8 comments) Thanks for the review. Please see my inline comments and PS11. http://ger

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-31 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5611 to look at the new patch set (#11). Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer ..

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 11: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dry

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Add .pep8rc for Impala's Python style .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc File .pep8rc: PS1, Line 5: # E251 - Remove w

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Add .pep8rc for Impala's Python style .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc File .pep8rc: PS1, Line 2: # E101 - Reinden

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File be/src/exprs/str

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File be/src/exprs/strin

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-01-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add .pep8rc for Impala's Python style .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc File .pep8rc: PS1, Line 5: # E251 - Remove whi

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-01-31 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. Patch Set 4: (3 comments) looks good, but let's talk about the nscd requirement

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-01-31 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Add .pep8rc for Impala's Python style .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc File .pep8rc: PS1, Line 2: # E101 - Reind

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-31 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5611/6/be/src/exec/hdfs-parquet-ta

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-31 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 10: (9 comments) http://gerrit.cloudera.org:8080/#/c/5611/9/be/src/exec/hdfs-parquet-

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-01-31 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#23). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTIT

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-01-31 Thread Attila Jeges (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4144 to look at the new patch set (#23). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-01-31 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 22: (10 comments) http://gerrit.cloudera.org:8080/#/c/4144/22/fe/

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4617: remove IsConstant() analysis from be .. IMPALA-4617: remove IsConstant() analysis from be This change avoids the need to duplicate

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4617: remove IsConstant() analysis from be .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5415 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File be/src/exprs/stri