Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as
small query
..
Patch Set 1:
Do you have a test for the case when the table is missing stats? I
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5658: addtl. process/system-wide memory metrics
..
IMPALA-5658: addtl. process/system-wide memory metrics
This is meant to help
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as
small query
..
Patch Set 1:
(1 comment)
Looks good! Just 1 small thing
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7102
To unsubscribe, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5616: Add --enable_minidumps startup flag
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7541
To unsubscribe,
Bikramjeet Vig has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7560
Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as
small query
..
IMPALA-5602: Fix kudu queries being
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-3894: Change the behavior parsing date "YY"
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7530/9//COMMIT_MSG
Commit Message:
PS9, Line
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5572: Timestamp codegen for text scanner
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7556/1/be/src/exec/hdfs-scanner-ir.cc
File
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3894: Change the behavior parsing date "YY"
..
Patch Set 9:
(9 comments)
A few code comments that I think you can address now, plus a few behavior
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5572: Timestamp codegen for text scanner
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7556/1/be/src/exec/hdfs-scanner-ir.cc
File
Jim Apple has posted comments on this change.
Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil
..
Patch Set 4:
(5 comments)
I may not have expressed my previous comments in a simple way. Let me try again.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5417: make I/O buffer queue fixed-size
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7408/6/be/src/runtime/disk-io-mgr-test.cc
File
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7408
to look at the new patch set (#7).
Change subject: IMPALA-5417: make I/O buffer queue fixed-size
..
IMPALA-5417:
Michael Ho has posted comments on this change.
Change subject: IMPALA-5417: make I/O buffer queue fixed-size
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7408/6/be/src/runtime/disk-io-mgr-test.cc
File
anujphadke has posted comments on this change.
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
Patch Set 5:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil
..
Patch Set 4: Code-Review+1
The change looks good to me. Thanks for contributing. It looks like you
anujphadke has uploaded a new patch set (#5).
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec
If
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5658: addtl. process/system-wide memory metrics
..
Patch Set 6: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/7472
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5658: addtl. process/system-wide memory metrics
..
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/970/
--
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5658: addtl. process/system-wide memory metrics
..
Patch Set 5:
Yeah, hopefully this is a case where they take "don't break userspace"
seriously.
--
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5572: Timestamp codegen for text scanner
..
Patch Set 1:
(6 comments)
Nice! No major concerns, mostly comments about comments.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5658: addtl. process/system-wide memory metrics
..
Patch Set 5: Code-Review+2
(1 comment)
Sorry for the delay
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream
interface
..
Patch Set 4:
(2 comments)
I think you need to replace the types of the objects with
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker
during Close()
..
Patch Set 1:
Talked with Michael offline. We agreed that it would be good to
Sailesh Mukil has uploaded a new patch set (#4).
Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream
interface
..
IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface
This patch
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7558
Change subject: IMPALA-5743: Allow TLS version configuration
..
IMPALA-5743: Allow TLS version configuration
* Backport THRIFT-2258 to
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc
File
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc
File
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc
File
Tianyi Wang has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7556
Change subject: IMPALA-5572: Timestamp codegen for text scanner
..
IMPALA-5572: Timestamp codegen for text scanner
Currently codegen is
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5658: addtl. process/system-wide memory metrics
..
Patch Set 5: Code-Review+1
I'll carry Henry's +2 as a +1 since Matt still had concerns.
--
To view,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 4:
rebased
--
To view, visit http://gerrit.cloudera.org:8080/7380
To
Tim Armstrong has uploaded a new patch set (#4).
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations
We were missing
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4703: reservation denial debug action
..
Patch Set 11: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7022
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool
..
Patch Set 39: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/5801
To
Hello Thomas Tauber-Marshall, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5801
to look at the new patch set (#39).
Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 12: Code-Review+2
Rebase. Kicking off a merge ahead of the follow-on patches.
--
To view, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-5616: Add --enable_minidumps startup flag
..
Patch Set 4: Code-Review+2
Rebased, ran the tests again. Carrying MJ's +2.
--
To view, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-5616: Add --enable_minidumps startup flag
..
Patch Set 2:
(2 comments)
Thanks for the reviews. I will rebase next.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5745: Bump Breakpad version
..
IMPALA-5745: Bump Breakpad version
This change bumps the breakpad version to pull in a change that
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5745: Bump Breakpad version
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7547
To unsubscribe, visit
Hello Matthew Jacobs, Thomas Tauber-Marshall,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7541
to look at the new patch set (#3).
Change subject: IMPALA-5616: Add --enable_minidumps startup flag
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker
during Close()
..
Patch Set 1:
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/7492
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7438/4//COMMIT_MSG
Commit Message:
Line
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5616: Add --enable_minidumps startup flag
..
Patch Set 2: Code-Review+2
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
Patch Set 4:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker
during Close()
..
Patch Set 1:
I wrote up a short page on the wiki per Henry's suggestion:
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5616: Add --enable_minidumps startup flag
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7541
To unsubscribe,
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-5616: Add --enable_minidumps startup flag
..
IMPALA-5616: Add --enable_minidumps startup flag
If set to 'false', this flag will disable registration of the
Lars Volker has posted comments on this change.
Change subject: IMPALA-5616: Add --enable_minidumps startup flag
..
Patch Set 1:
(2 comments)
Thank you for the review, please see PS2.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker
during Close()
..
Patch Set 1:
Any more comments?
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5745: Bump Breakpad version
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/967/
--
To view, visit
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5616: Add --enable_minidumps startup flag
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7541/1//COMMIT_MSG
Commit Message:
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5745: Bump Breakpad version
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7547
To unsubscribe, visit
Thomas Tauber-Marshall has submitted this change and it was merged.
Change subject: Bump Kudu version to 1c0276a
..
Bump Kudu version to 1c0276a
Change-Id: If9437a4731ed721a4d53669340e01892b60e80de
---
M buildall.sh
1 file
Thomas Tauber-Marshall has posted comments on this change.
Change subject: Bump Kudu version to 1c0276a
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7550
To unsubscribe, visit
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 1c0276a
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7550
To unsubscribe, visit
Thomas Tauber-Marshall has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7550
Change subject: Bump Kudu version to 1c0276a
..
Bump Kudu version to 1c0276a
Change-Id:
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-1470: Fix error message with catalog down
..
IMPALA-1470: Fix error message with catalog down
When the catalog server cannot be reached,
60 matches
Mail list logo
