Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5757: Make tbl property toSql deterministic
..
Patch Set 1:
Previous job failed with flaky data load. I filed IMPALA-5765
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5757: Make tbl property toSql deterministic
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/984/
--
To view,
Michael Ho has posted comments on this change.
Change subject: Upgrade OpenSSL to 1.0.2l
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7582
To unsubscribe, visit
Michael Ho has submitted this change and it was merged.
Change subject: Upgrade OpenSSL to 1.0.2l
..
Upgrade OpenSSL to 1.0.2l
1.0.2l contains fixes for quite a number of CVEs against
the existing version 1.0.1p in the
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit
..
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/983/
--
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit
..
Patch Set 3:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/981/
--
To
Henry Robinson has posted comments on this change.
Change subject: Upgrade OpenSSL to 1.0.2l
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7582
To unsubscribe, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 1: Code-Review+1
(1 comment)
Not sure if Henry has more comments ?
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5757: Make tbl property toSql deterministic
..
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/982/
--
Michael Ho has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 1:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 1:
(1 comment)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables
..
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/980/
Michael Ho has uploaded a new patch set (#2).
Change subject: Upgrade OpenSSL to 1.0.2l
..
Upgrade OpenSSL to 1.0.2l
1.0.2l contains fixes for quite a number of CVEs against
the existing version 1.0.1p in the toolchain.
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7582
Change subject: Upgrade OpenSSL to 1.0.2l
..
Upgrade OpenSSL to 1.0.2l
Change-Id: Ib83c72cce0e64b24729affb5ba10a1e57bc5f837
---
M
Zach Amsden has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7581
Change subject: IMPALA-5764: Allow overriding packaged components
..
IMPALA-5764: Allow overriding packaged components
For allowing
Michael Ho has posted comments on this change.
Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream
interface
..
Patch Set 6:
(11 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 3: Code-Review+1
(3 comments)
Looks good to me. Lets see if Michael wants to take
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7492
to look at the new patch set (#3).
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
(4 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
(4 comments)
Maybe I've been staring at this too long, but why do we have
Zach Amsden has posted comments on this change.
Change subject: Guide to important environment variables for build, test, and
mini-cluster operations.
..
Patch Set 2:
I cut this back in scope somewhat and made it use
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5417: make I/O buffer queue fixed-size
..
Patch Set 7:
I thought about it some more and I'm not sure that adding meaningful timers is
simple. We already
Zach Amsden has uploaded a new patch set (#2).
Change subject: Guide to important environment variables for build, test, and
mini-cluster operations.
..
Guide to important environment variables for
build, test, and mini-cluster
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5757: Make tbl property toSql deterministic
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/982/
--
To view,
Jim Apple has posted comments on this change.
Change subject: IMPALA-5757: Make tbl property toSql deterministic
..
Patch Set 1: Code-Review+2
> > > Didn't find any test cases that needed to be updated when I ran
> > the
> >
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5757: Make tbl property toSql deterministic
..
Patch Set 1:
> > Didn't find any test cases that needed to be updated when I ran
> the
> > tests I was
Jim Apple has posted comments on this change.
Change subject: IMPALA-5757: Make tbl property toSql deterministic
..
Patch Set 1:
> Didn't find any test cases that needed to be updated when I ran the
> tests I was aware of
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5757: Make tbl property toSql deterministic
..
Patch Set 1:
Didn't find any test cases that needed to be updated when I ran the tests I was
aware of
Matthew Jacobs has abandoned this change.
Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
..
Abandoned
created a new commit, forgot to take the old Change-Id. New review:
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7580
Change subject: IMPALA-5757: Make tbl property toSql deterministic
..
IMPALA-5757: Make tbl property toSql deterministic
On Ubuntu
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten
..
Patch Set 2: Verified-1
Build failed:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7438/4//COMMIT_MSG
Commit Message:
Line
Lars Volker has posted comments on this change.
Change subject: IMPALA-2869: Log why codegen is disabled in
TextConverter::CodegenWriteSlot()
..
Patch Set 2:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2869: Log why codegen is disabled in
TextConverter::CodegenWriteSlot()
..
Patch Set 2:
(4 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
..
Patch Set 1:
> > > > (1 comment)
> > >
> > > I recently changed several places in the FE to use
Lars Volker has posted comments on this change.
Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
..
Patch Set 1:
> > > (1 comment)
> >
> > I recently changed several places in the FE to use
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit
..
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/981/
--
To
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5572: Timestamp codegen for text scanner
..
Patch Set 3:
Rebase done
--
To view, visit http://gerrit.cloudera.org:8080/7556
To unsubscribe, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit
..
Patch Set 3: Verified-1
Build failed:
Bikramjeet Vig has posted comments on this change.
Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as
small query
..
Patch Set 3:
(1 comment)
Bikramjeet Vig has uploaded a new patch set (#3).
Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as
small query
..
IMPALA-5602: Fix kudu queries being incorrectly optimized as small query
Fix a bug
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5572: Timestamp codegen for text scanner
..
Patch Set 2: Code-Review+2
Looks great. I can start the merge after you rebase onto the latest master.
--
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
Patch Set 1:
(8 comments)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables
..
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/980/
--
To
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
IMPALA-5696: Enable cipher configuration when using TLS / Thrift
The 'cipher suite' is a
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
..
Patch Set 1:
> > (1 comment)
>
> I recently changed several places in the FE to use
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5572: Timestamp codegen for text scanner
..
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/7556/1//COMMIT_MSG
Commit Message:
Line 14:
>
Lars Volker has posted comments on this change.
Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
..
Patch Set 1:
> (1 comment)
I recently changed several places in the FE to use LinkedHashMaps in
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
> The conclusion was that it was very difficult to reason about the
> lifetime
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7446
To unsubscribe,
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 1:
> Does this trigger only when there are two concurrent calls to
>
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7438/4//COMMIT_MSG
Commit Message:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 1:
Does this trigger only when there are two concurrent calls to
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 1: Code-Review+1
(1 comment)
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables
..
Patch Set 3:
(1 comment)
Thomas Tauber-Marshall has uploaded a new patch set (#3).
Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables
..
IMPALA-5546: Allow creating unpartitioned Kudu tables
This patch makes it possible to create
Thomas Tauber-Marshall has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7577
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
IMPALA-5749: coordinator race hits
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
The conclusion was that it was very difficult to reason about the lifetime of
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
> That was a bit more involved than expected, but all MemTrackers
> should now
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit
..
Patch Set 3: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/7572
To
Attila Jeges has posted comments on this change.
Change subject: IMPALA-3548: Prune runtime filters based on query options in
the FE
..
Patch Set 2:
(6 comments)
Thanks for the review!
Attila Jeges has uploaded a new patch set (#2).
Change subject: IMPALA-3548: Prune runtime filters based on query options in
the FE
..
IMPALA-3548: Prune runtime filters based on query options in the FE
Currently, the FE
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7575/1//COMMIT_MSG
Commit Message:
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten
..
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/979/
--
Attila Jeges has uploaded a new patch set (#2).
Change subject: IMPALA-3548: Prune runtime filters based on query options in
the FE
..
IMPALA-3548: Prune runtime filters based on query options in the FE
Currently, the FE
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7575/1//COMMIT_MSG
Commit Message:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7575/1//COMMIT_MSG
Commit Message:
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7575/1//COMMIT_MSG
Commit Message:
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
..
Patch Set 7: Code-Review+1
LGTM, thanks. I didn't review the codegen code in detail, deferring to
anujphadke has posted comments on this change.
Change subject: IMPALA-2869: Log why codegen is disabled in
TextConverter::CodegenWriteSlot()
..
Patch Set 2:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
That was a bit more involved than expected, but all MemTrackers should now have
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
IMPALA-5715: (mitigation only) defer destruction of MemTrackers
One potential candidate for the
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit
..
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/978/
--
To
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5756: start memory maintenance thread after metric
creation
..
IMPALA-5756: start memory maintenance thread after metric creation
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
..
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7526/6//COMMIT_MSG
Commit Message:
Tim Armstrong has uploaded a new patch set (#7).
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
..
IMPALA-3931: arbitrary fixed-size uda intermediate types
Make many builtin aggregate functions use
Jim Apple has posted comments on this change.
Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7575/1//COMMIT_MSG
Commit Message:
PS1,
Tianyi Wang has uploaded a new patch set (#2).
Change subject: IMPALA-5572: Timestamp codegen for text scanner
..
IMPALA-5572: Timestamp codegen for text scanner
Currently codegen is disabled when scanning text tables with
Lars Volker has posted comments on this change.
Change subject: IMPALA-2869: Log why codegen is disabled in
TextConverter::CodegenWriteSlot()
..
Patch Set 2:
(11 comments)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5756: start memory maintenance thread after metric
creation
..
Patch Set 2:
Build started:
anujphadke has uploaded a new patch set (#2).
Change subject: IMPALA-2869: Log why codegen is disabled in
TextConverter::CodegenWriteSlot()
..
IMPALA-2869: Log why codegen is disabled in TextConverter::CodegenWriteSlot()
Michael Ho has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5717/12/CMakeLists.txt
File CMakeLists.txt:
anujphadke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7574
Change subject: Impala-2869: Log why codegen is disabled in
TextConverter::CodegenWriteSlot()
..
Impala-2869: Log why codegen is disabled
Michael Ho has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5717/12/CMakeLists.txt
File CMakeLists.txt:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5717/12/CMakeLists.txt
File CMakeLists.txt:
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
Patch Set 1:
(12 comments)
A lot of the comments are just about refactoring. Feel free to
Tim Armstrong has abandoned this change.
Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics"
..
Abandoned
See https://gerrit.cloudera.org/#/c/7573/
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5756: start memory maintenance thread after metric
creation
..
Patch Set 2:
Build started:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5756: start memory maintenance thread after metric
creation
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7573
To
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7573
to look at the new patch set (#2).
Change subject: IMPALA-5756: start memory maintenance thread after metric
creation
90 matches
Mail list logo