Henry Robinson has uploaded a new patch set (#7).
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC
This patch
Henry Robinson has posted comments on this change.
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 7:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 5:
(3 comments)
The next patch after this will be a rebase, but will
Henry Robinson has posted comments on this change.
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 7:
This patch is a rebase. The only outstanding issue is the performance
Henry Robinson has uploaded a new patch set (#6).
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC
This patch
Henry Robinson has posted comments on this change.
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 7:
(1 comment)
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5888
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
IMPALA-4856: Port ImpalaInternalService to KRPC
This patch ports
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 7:
(22 comments)
Took a look, had some comments.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in
header
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5916/2//COMMIT_MSG
Commit
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in
header
..
IMPALA-3909 (follow-up): Properly qualify min() and max() in header
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in
header
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5916/1//COMMIT_MSG
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/7/common/thrift/Logging.thrift
File
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5887
Change subject: IMPALA-4874: Increase the maximum KRPC message size to 4GB
..
IMPALA-4874: Increase the maximum KRPC message size to
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5916
Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in
header
..
IMPALA-3909 (follow-up): Properly qualify min()
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3785: Record query handle for invalid handle
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5748/3/be/src/util/debug-util-test.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 3:
(4 comments)
Henry Robinson has uploaded a new patch set (#4).
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC
This patch
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend
JVMs
..
Patch Set 1:
Could you also add support for changing log levels in C++ code? I think
Henry Robinson has posted comments on this change.
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 3:
(28 comments)
Although it might look like a lot has changed in this
Henry Robinson has uploaded a new patch set (#5).
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC
This patch
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore
services to KRPC
..
IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC
This
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5748 Record query handle for invalid handle
..
Patch Set 2:
(2 comments)
Do you think the perf difference is worth considering replacing Substitute()?
Henry Robinson has posted comments on this change.
Change subject: Prepare for official 2.8 release by icnrementing version number
..
Patch Set 1:
(1 comment)
one typo.
http://gerrit.cloudera.org:8080/#/c/5763/1//COMMIT_MSG
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6030
Change subject: IMPALA-4926: Upgrade LZ4 to 1.7.5
..
IMPALA-4926: Upgrade LZ4 to 1.7.5
LZ4 has deprecated the method names
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress"
for exhaustive tests
..
Patch Set 3:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6056/3/be/src/rpc/authentication.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization
..
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6056/3/bin/impala-config.sh
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4885: Expose Jvm thread info in web UI
..
Patch Set 1:
(5 comments)
this is pretty cool. Got a couple of suggestions about organisation and
Henry Robinson has posted comments on this change.
Change subject: Three misc webpage changes
..
Patch Set 1:
Anyone want to take a quick look at this?
--
To view, visit http://gerrit.cloudera.org:8080/6045
To unsubscribe,
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4885: Expose Jvm thread info in web UI
..
Patch Set 2:
(11 comments)
Just minor things.
Henry Robinson has posted comments on this change.
Change subject: Remove Scheduler abstract interface, rename SimpleScheduler ->
Scheduler
..
Patch Set 1:
Although this patch looks big, the files are moved + clang-formatted.
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6149
Change subject: Remove Scheduler abstract interface, rename SimpleScheduler ->
Scheduler
..
Remove Scheduler abstract interface,
Henry Robinson has posted comments on this change.
Change subject: Three misc webpage changes
..
Patch Set 1:
Thanks for the reviews!
> seems fine but I don't really know jquery
If it makes it easier, this is basically C
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 12:
> I'm not sure the extra complexity of the UI is worth it.
Without the UI, we'd have to
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5971
Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler
..
IMPALA-4905: Reduce coordinator lock contention in
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler
..
IMPALA-4905: Reduce coordinator lock contention in RPC handler
Fragment instances call
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler
..
Patch Set 1:
(1 comment)
Changed how the logging works - it didn't quite work in the
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4885: Expose Jvm thread info in web UI
..
Patch Set 1:
This is super useful. Could you post the screenshot somewhere that's publicly
accessible?
--
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 2:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: Add the query handle to error messages for Invalid Query Handle
for beeswax interface.
..
Patch Set 1:
(1 comment)
Any chance you want to do the same thing
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 14: Code-Review+2
Discussed offline. I believe the out-of-the-box behaviour hasn't changed.
--
Henry Robinson has posted comments on this change.
Change subject: Bump breakpad upstream version
..
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6213/2//COMMIT_MSG
Commit Message:
PS2, Line 7:
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6190
Change subject: IMPALA-5005: Don't allow server to send SASL COMPLETE msg out
of order
..
IMPALA-5005: Don't allow server to send SASL
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
Patch Set 1:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4983: Compile LZ4 in release mode
..
Patch Set 1: Code-Review+2 Verified+1
Carry +2 from Toolchain project. Verified by complete build.
--
To view,
Henry Robinson has posted comments on this change.
Change subject: Remove Scheduler abstract interface, rename SimpleScheduler ->
Scheduler
..
Patch Set 2:
(1 comment)
I've reverted the renames, temporarily, for easy review.
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4983: Compile LZ4 in release mode
..
IMPALA-4983: Compile LZ4 in release mode
LZ4 was not compiled (apparently ever?) with optimization
Henry Robinson has uploaded a new patch set (#2).
Change subject: Remove Scheduler abstract interface, rename SimpleScheduler ->
Scheduler
..
Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler
For the
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6165
Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags
..
IMPALA-4983: Set toolchain version to include LZ4
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6164
Change subject: IMPALA-4983: Compile LZ4 in release mode
..
IMPALA-4983: Compile LZ4 in release mode
LZ4 was not compiled (apparently
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6166
Change subject: IMPALA-5001: Redownload dependencies if toolchain ID changes
..
IMPALA-5001: Redownload dependencies if toolchain ID
Henry Robinson has posted comments on this change.
Change subject: Remove Scheduler abstract interface, rename SimpleScheduler ->
Scheduler
..
Patch Set 2:
(2 comments)
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6149
to look at the new patch set (#3).
Change subject: Remove Scheduler abstract interface, rename SimpleScheduler ->
Scheduler
Henry Robinson has posted comments on this change.
Change subject: Remove Scheduler abstract interface, rename SimpleScheduler ->
Scheduler
..
Patch Set 3: Code-Review+2
Rebase, carry +2.
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5001: Redownload dependencies if toolchain ID changes
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6166/1/bin/bootstrap_toolchain.py
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags
..
Patch Set 1:
> I assume this has passed tests with the new lz4 bits?
Basic tests pass. The
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags
..
Patch Set 1:
Confirmed that the perf regression is fixed.
With IMPALA-5001 the steps aren't
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13: Code-Review+2
(4 comments)
Looks pretty good to me.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5001: Redownload dependencies if toolchain ID changes
..
Patch Set 1:
(2 comments)
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6166
to look at the new patch set (#2).
Change subject: IMPALA-5001: Redownload dependencies if toolchain ID changes
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4138: Fix AcquireState() for batches that have
MarkCapacity() called
..
Patch Set 1:
(1 comment)
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4138: Fix AcquireState() for batches that have
MarkCapacity() called
..
IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called
If
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4138: Fix AcquireState() for batches that have
MarkCapacity() called
..
Patch Set 2:
(1 comment)
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4428
to look at the new patch set (#4).
Change subject: IMPALA-4138: Fix AcquireState() for batches that have
MarkCapacity() called
Hello Juan Yu, Matthew Jacobs, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4516
to look at the new patch set (#4).
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3823: Add timer to measure Parquet footer reads
..
Patch Set 6:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4135: Thrift threaded server times-out connections
during high load
..
Patch Set 3:
(8 comments)
Some comments before I head off to Strata. I would
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4135: Thrift threaded server times-out connections
during high load
..
Patch Set 4:
(7 comments)
Looking pretty good.
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4564
Change subject: Remove spurious Boost warnings on compilation errors
..
Remove spurious Boost warnings on compilation errors
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4135: Thrift threaded server times-out connections
during high load
..
Patch Set 6: Code-Review+2
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4246: SleepForMs() utility function has undefined
behavior for > 1s
..
Patch Set 1: Code-Review+2
(2 comments)
Henry Robinson has uploaded a new patch set (#8).
Change subject: IMPALA-4135: Thrift threaded server times-out connections
during high load
..
IMPALA-4135: Thrift threaded server times-out connections during high load
During
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 9:
After some discussion, moved the result materialization into Send(). The
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4135: Thrift threaded server times-out connections
during high load
..
Patch Set 8: Code-Review+2
Rebase (plus add a flag and disable the test), carry
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3853: squeasel is MIT (and dual copyright) not Apache
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4646
To
Henry Robinson has uploaded a new patch set (#8).
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
IMPALA-2905: Handle coordinator fragment lifecycle like all others
The plan-root fragment
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3902: Scheduler improvements for running multiple
fragment instances on a single backend
..
Patch Set 18: Code-Review+1
(1 comment)
Changes since PS16
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 7:
(28 comments)
This patch passes EE tests.
I haven't completely addressed
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after
load
..
Patch Set 2:
(1 comment)
Any easy way to test this? Can you add some UDFs and then check
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3342: Adding new timer to accurately measure the
TotalCpuTime
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4633/1//COMMIT_MSG
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4135: Thrift threaded server times-out connections
during high load
..
IMPALA-4135: Thrift threaded server times-out connections during high
Henry Robinson has uploaded a new patch set (#9).
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
IMPALA-2905: Handle coordinator fragment lifecycle like all others
The plan-root fragment
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 10:
EE tests pass with this new sink implementation as well.
--
To view,
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 6:
(1 comment)
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4428
Change subject: IMPALA-4138: Fix AcquireState() for batches that have
MarkCapacity() called
..
IMPALA-4138: Fix AcquireState() for
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4138: Fix AcquireState() for batches that have
MarkCapacity() called
..
Patch Set 1:
(1 comment)
Agree that this maybe isn't a fix so much as an
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4445
Change subject: Remove Llama support.
..
Remove Llama support.
Alas, poor Llama! I knew him, Impala: a system
of infinite jest, of
Henry Robinson has posted comments on this change.
Change subject: Remove Llama support.
..
Patch Set 1:
Passed a core test run.
--
To view, visit http://gerrit.cloudera.org:8080/4445
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4014: HEADERS ONLY: Introduce query-wide execution state.
..
Patch Set 1:
(17 comments)
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4428
to look at the new patch set (#5).
Change subject: IMPALA-4138: Fix AcquireState() for batches that change capacity
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4138: Fix AcquireState() for batches that change capacity
..
Patch Set 4:
(2 comments)
Rebased to include IMPALA_ASSERT_DEBUG_DEATH macro from trunk.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4610: Remove Llama support.
..
Patch Set 1:
(4 comments)
Matt's going to weigh in on what parts of the memory estimation path we can
remove, depending
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4610: Remove Llama support.
..
IMPALA-4610: Remove Llama support.
Alas, poor Llama! I knew him, Impala: a system
of infinite jest, of most excellent
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4160: Remove Llama support.
..
Patch Set 1:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/4445/1//COMMIT_MSG
Commit Message:
Line 7: Remove Llama
Hello Marcel Kornacker, Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4445
to look at the new patch set (#5).
Change subject: IMPALA-4160: Remove Llama support.
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4160: Remove Llama support.
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/query-schedule.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4011: Remove / reword messages when statestore messages
are late
..
Patch Set 2: Code-Review+2
I'm going to submit this as is, then someone can take on
1 - 100 of 874 matches
Mail list logo
