[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

2017-04-08 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6600 Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks .. IMPALA-4544: ASAN should ignore SEGV and leaks The environment variable AS

[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

2017-04-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks .. Patch Set 1: I think there are a lot of broken-build P1s open, and I don't know this addresses any of them, so thi

[Impala-ASF-CR](asf-site) First publishing of Apache Impala (incubating) documentation to the Apache web site.

2017-04-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: First publishing of Apache Impala (incubating) documentation to the Apache web site. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6601/1/docs/bu

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior: left shift of large signed

2017-04-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior: left shift of large signed .. Patch Set 2: There are 16 open blocker bugs right now, so I'm going to hold off on submitting

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-04-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5589/2/docs/topics/impala_string_functions

[Impala-ASF-CR](asf-site) Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project.

2017-04-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project. .. Patch

[Impala-ASF-CR](asf-site) Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project.

2017-04-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project. .. Patch

[Impala-ASF-CR](asf-site) IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF resources.

2017-04-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF resources. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6604/1//COMMIT_MSG Commi

[Impala-ASF-CR](asf-site) IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF site

2017-04-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF site .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/660

[Impala-ASF-CR](asf-site) IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF site

2017-04-12 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF site .. IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF site Add Impala doc

[Impala-ASF-CR](asf-site) Change incubator logo, following edict from IPMC

2017-04-14 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6632 Change subject: Change incubator logo, following edict from IPMC .. Change incubator logo, following edict from IPMC For the full set of new

[Impala-ASF-CR](asf-site) Change incubator logo, following edict from IPMC

2017-04-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Change incubator logo, following edict from IPMC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6632/1//COMMIT_MSG Commit Message: PS1, Line 13: c

[Impala-ASF-CR](asf-site) Change incubator logo, following edict from IPMC

2017-04-14 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Change incubator logo, following edict from IPMC .. Change incubator logo, following edict from IPMC For the full set of new incubator logos, see: http://incubator.st

[Impala-ASF-CR](asf-site) Change incubator logo, following edict from IPMC

2017-04-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Change incubator logo, following edict from IPMC .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6632 To unsubscribe, visit http://gerr

[Impala-ASF-CR](asf-site) Change incubator logo, following edict from IPMC

2017-04-14 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Change incubator logo, following edict from IPMC .. Change incubator logo, following edict from IPMC For the full set of new incubator logos, see: http://i

[Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs

2017-04-15 Thread Jim Apple (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6487 to look at the new patch set (#5). Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs .. IMPALA-3

[Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs

2017-04-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs .. Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/6487/2/testdata/bin/create-load-data.sh File testdata/b

[Impala-ASF-CR] IMPALA-5031: Apply UBSan options to catalogd

2017-04-15 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6652 Change subject: IMPALA-5031: Apply UBSan options to catalogd .. IMPALA-5031: Apply UBSan options to catalogd catalogd runs some C++ code,

[Impala-ASF-CR] [DOCS] Remove references to DSSD storage appliance

2017-04-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: [DOCS] Remove references to DSSD storage appliance .. Patch Set 1: > This is more of a marketing-related change, so I'll make it in > downstream docs but not upstre

[Impala-ASF-CR] [DOCS] Remove references to DSSD storage appliance

2017-04-15 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: [DOCS] Remove references to DSSD storage appliance .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6412 To unsubscribe, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR](asf-site) [site] add links to built docs on Documentation page

2017-04-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: [site] add links to built docs on Documentation page .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c//1//COMMIT_MSG Commit Message

[Impala-ASF-CR](asf-site) IMPALA-4181: [site] add links to built docs on Documentation page

2017-04-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4181: [site] add links to built docs on Documentation page .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c//2//COMMIT_MSG

[Impala-ASF-CR](asf-site) IMPALA-4181: add links to built docs on Documentation page

2017-04-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4181: add links to built docs on Documentation page .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/ To unsubscribe, visi

[Impala-ASF-CR] IMPALA-5085: large rows in BufferedTupleStreamV2

2017-04-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6638/2/be/src/runtime/buffered-tuple-stream-v2.h Fi

[Impala-ASF-CR] IMPALA-5085: large rows in BufferedTupleStreamV2

2017-04-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6638/2/be/src/runtime/buffered-tuple-stream-v2.h Fi

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > > > > @Matthew: Would you be needing the ppc64le infra for > temporary > > > > usage to test the chang

[Impala-ASF-CR] IMPALA-5031: Apply UBSan options to catalogd

2017-04-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5031: Apply UBSan options to catalogd .. Patch Set 2: Code-Review+2 carry +2 -- To view, visit http://gerrit.cloudera.org:8080/6652 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior: left shift of large signed

2017-04-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior: left shift of large signed .. Patch Set 3: carry +2 -- To view, visit http://gerrit.cloudera.org:8080/6528 To unsubscribe,

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior: left shift of large signed

2017-04-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior: left shift of large signed .. Patch Set 3: Flaky build failure: [ERROR] Failed to execute goal on project impala-fronten

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior: left shift of large signed

2017-04-20 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-5031: Remove undefined behavior: left shift of large signed .. IMPALA-5031: Remove undefined behavior: left shift of large signed Shifting large pos

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior: left shift of large signed

2017-04-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior: left shift of large signed .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6528 To unsubscr

[Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

2017-04-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. .. Patch Set 2: > I added a test case, including a parquet file containing ENUM. I > haven

[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: nullptr member function call

2017-04-22 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6714 Change subject: IMPALA-5031: remove undefined behavior: nullptr member function call .. IMPALA-5031: remove undefined behavior: nullptr memb

[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

2017-04-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks .. Patch Set 2: Code-Review+2 Carry Alex Behm's +2 -- To view, visit http://gerrit.cloudera.org:8080/6600 To unsubsc

[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

2017-04-22 Thread Jim Apple (Code Review)
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6600 to look at the new patch set (#2). Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks .. IMPA

[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

2017-04-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks .. Patch Set 2: > Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/494/ Looks flaky to me: https:

[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: nullptr member function call

2017-04-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5031: remove undefined behavior: nullptr member function call .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6714/1/be/src/runtime/coordina

[Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

2017-04-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. .. Patch Set 2: (2 comments) I'm going to add a review, since Lars is AFK and I am not ver

[Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

2017-04-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. .. Patch Set 2: Taras, could you take a look? I'm not vary familiar with Parquet or if ther

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's ..

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's ..

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's ..

[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: call to strncmp with nullptr

2017-04-29 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6767 Change subject: IMPALA-5031: remove undefined behavior: call to strncmp with nullptr .. IMPALA-5031: remove undefined behavior: call to strn

[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: call to strncmp with nullptr

2017-04-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5031: remove undefined behavior: call to strncmp with nullptr .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6767/1/be/src/runtime/string-v

[Impala-ASF-CR] Experiment: glibc strncmp/memcmp appears much faster than SSE4.2

2017-04-29 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6768 Change subject: Experiment: glibc strncmp/memcmp appears much faster than SSE4.2 .. Experiment: glibc strncmp/memcmp appears much faster than

[Impala-ASF-CR] Experiment: glibc strncmp/memcmp appears much faster than SSE4.2

2017-04-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Experiment: glibc strncmp/memcmp appears much faster than SSE4.2 .. Patch Set 1: Dan, I'm interested in your thoughts on this. Does it imply we should just use memc

[Impala-ASF-CR] Experiment: glibc strncmp/memcmp appears much faster than SSE4.2

2017-04-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Experiment: glibc strncmp/memcmp appears much faster than SSE4.2 .. Patch Set 1: I can confirm this is much faster on my machine. Specifically, select count(*) from

[Impala-ASF-CR] Experiment: glibc strncmp/memcmp appears much faster than SSE4.2

2017-05-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Experiment: glibc strncmp/memcmp appears much faster than SSE4.2 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6768/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5821/5/be/src/util/bit-util.h File be/src/util/bit-util.h: L

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-05-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). .. Patch Set 5: Any updates on this? The comment about line 335 was left on January 3rd. -- To view, visit

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5821/5/be/src/util/bit-util.h File be/src/util/bit-util.h: L

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5821/5/be/src/util/bit-util.h File be/src/util/bit-util.h: L

[Impala-ASF-CR] Experiment: glibc strncmp/memcmp appears much faster than SSE4.2

2017-05-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Experiment: glibc strncmp/memcmp appears much faster than SSE4.2 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6768/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] Experiment: glibc strncmp/memcmp appears much faster than SSE4.2

2017-05-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Experiment: glibc strncmp/memcmp appears much faster than SSE4.2 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6768/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] Experiment: glibc strncmp/memcmp appears much faster than SSE4.2

2017-05-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Experiment: glibc strncmp/memcmp appears much faster than SSE4.2 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6768/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-02 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. IMPALA-5273: Replace StringCompare with glibc memcmp glibcs memcmp, which dispatches dynamically based on the i

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6768/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6768/1//COMMIT_MSG Commit Message: PS1, Line 1

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6768/2/be/src/benchmarks/string-compare-benchma

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-05 Thread Jim Apple (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6768 to look at the new patch set (#3). Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. IMPALA-5273

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6768/2/be/src/benchmarks/string-compare-benchma

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 3: Code-Review+2 Forgot to carry +2 -- To view, visit http://gerrit.cloudera.org:8080/6768 To uns

[Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs

2017-05-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs .. Patch Set 5: Lars, any more thoughts? -- To view, visit http://gerrit.cloudera.org:8080/6487 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs

2017-05-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs .. Patch Set 6: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/6487 To unsubscribe, visit htt

[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: call to strncmp with nullptr

2017-05-06 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-5031: remove undefined behavior: call to strncmp with nullptr .. Abandoned Done in another commit -- To view, visit http://gerrit.cloudera.org:8080/6767 To unsubscr

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-07 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6818 Change subject: Add a script to test performance on a developer machine .. Add a script to test performance on a developer machine This is a

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 1: (1 comment) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/6819/1/be/src/runtime/bufferpoo

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 2: Looks good. One last question - how did you test? -- To view, visit http://gerrit.cloudera.org:8080/681

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6819 To unsubscribe, visit http://gerrit

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/5821/8/be/src/util/bit-util.h File be/src/util/bit-util.h: L

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-13 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Add a script to test performance on a developer machine .. Add a script to test performance on a developer machine This is a migration from an old and broken script fr

[Impala-ASF-CR] IMPALA-5319: Fix test hdfs scan node errors failures

2017-05-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5319: Fix test_hdfs_scan_node_errors failures .. Patch Set 1: > Good idea, thanks. I cancelled that job and started: > http://sandbox.jenkins.cloudera.com/vi

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a script to test performance on a developer machine .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6818/2//COMMIT_MSG Commit Message: PS2, Lin

[Impala-ASF-CR](asf-site) IMPALA-4803: add 2.8 change log

2017-05-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4803: add 2.8 change log .. Patch Set 3: Code-Review+2 > When this is settled, I'll add steps to > https://cwiki.apache.org/confluence/display/IMPALA/ SG. I

[Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

2017-05-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. .. Patch Set 4: Code-Review+1 Nice work. I am +1ing, which means we will wait for someone w

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-05-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5589 To unsubscribe, visit

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: Add a script to test performance on a developer machine .. Add a script to test performance on a developer machine This is a migration from an old and broken script fr

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4). Change subject: Add a script to test performance on a developer machine .. Add a script to test performance on a developer machine This is a migration from an old and broken script fr

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a script to test performance on a developer machine .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/6818/2//COMMIT_MSG Commit Message: PS2, L

[Impala-ASF-CR] IMPALA-5031: Initialize only parsing header before reading it

2017-05-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6937 Change subject: IMPALA-5031: Initialize only_parsing_header_ before reading it .. IMPALA-5031: Initialize only_parsing_header_ before reading

[Impala-ASF-CR] IMPALA-5031: Initialize only parsing header before reading it

2017-05-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5031: Initialize only_parsing_header_ before reading it .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6937/1//COMMIT_MSG Commit Message: E

[Impala-ASF-CR] Ninja support: use MAKE CMD in run-backend-tests.sh when possible

2017-05-20 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6942 Change subject: Ninja support: use MAKE_CMD in run-backend-tests.sh when possible .. Ninja support: use MAKE_CMD in run-backend-tests.sh whe

[Impala-ASF-CR] Ninja support: use MAKE CMD in run-backend-tests.sh when possible

2017-05-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Ninja support: use MAKE_CMD in run-backend-tests.sh when possible .. Patch Set 1: https://issues.apache.org/jira/browse/IMPALA-5346 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-5347: Parquet scanner microoptimizations

2017-05-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5347: Parquet scanner microoptimizations .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6950/5/be/src/exec/parquet-column-readers.cc File b

[Impala-ASF-CR] IMPALA-5347: Parquet scanner microoptimizations

2017-05-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5347: Parquet scanner microoptimizations .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6950/5/be/src/exec/parquet-column-readers.cc File b

[Impala-ASF-CR] IMPALA-5347: Parquet scanner microoptimizations

2017-05-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5347: Parquet scanner microoptimizations .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6950/5/be/src/exec/parquet-column-readers.cc File be

[Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function

2017-05-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5326: [DOCS] Document REPLACE() function .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6979/1/docs/topics/impala_string_functions.xml File

[Impala-ASF-CR] IMPALA-5347: Parquet scanner microoptimizations

2017-05-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5347: Parquet scanner microoptimizations .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/6950/14/be/src/common/compiler-util.h File be/src/c

[Impala-ASF-CR] IMPALA-5347: Parquet scanner microoptimizations

2017-05-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5347: Parquet scanner microoptimizations .. Patch Set 15: Code-Review+2 THank you! -- To view, visit http://gerrit.cloudera.org:8080/6950 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04

2017-05-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6989 Change subject: IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04 .. IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04

[Impala-ASF-CR] IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04

2017-05-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04 .. Patch Set 1: David and I poked at this a little and tried to figure out what was going on - why, for

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6468/5/source/breakpad/breakpad-ffe3e478657dc7126fca6329d

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/6478/20/be/src/runtime/disk-io-mgr-handle-cache.h File be/src

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 22: (2 comments) http://gerrit.cloudera.org:8080/#/c/6478/22/be/src/runtime/disk-io-mgr-handle-cache.h File be/sr

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior "reference binding to null"

2017-05-26 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/7008 Change subject: IMPALA-5031: Remove undefined behavior "reference binding to null" .. IMPALA-5031: Remove undefined behavior "reference bind

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#5). Change subject: Add a script to test performance on a developer machine .. Add a script to test performance on a developer machine This is a migration from an old and broken script fr

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a script to test performance on a developer machine .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/6818/4/bin/single_node_perf_run.py File bin

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior "reference binding to null"

2017-05-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-5031: Remove undefined behavior "reference binding to null" .. IMPALA-5031: Remove undefined behavior "reference binding to null" When p has type T* and p is n

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior "reference binding to null"

2017-05-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: IMPALA-5031: Remove undefined behavior "reference binding to null" .. IMPALA-5031: Remove undefined behavior "reference binding to null" When p has type T* and p is n

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-30 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a script to test performance on a developer machine .. Patch Set 6: Code-Review+2 Rebase, carry +2 -- To view, visit http://gerrit.cloudera.org:8080/6818 To un

<    1   2   3   4   5   6   7   8   9   10   >