[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 7: (1 comment)

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: > > I'm not sure I understand why a person might want to run the > inferencer again, even if

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 2: (34 comments) First pass, didn't get to all of it yet but I thought you might want to see what was done

[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.

2016-09-30 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. .. IMPALA-4230: ASF policy issues from 2.7.0 rc3. In our IPMC vote to release 2.7.0 rc3, Justing Mclean pointed out a

[Impala-ASF-CR] DO NOT SUBMIT: Example diffs of http://gerrit.cloudera.org/#/c/4590/

2016-10-02 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4591 Change subject: DO NOT SUBMIT: Example diffs of http://gerrit.cloudera.org/#/c/4590/ .. DO NOT SUBMIT: Example diffs of

[Impala-ASF-CR] DO NOT SUBMIT: Example diffs of http://gerrit.cloudera.org/#/c/4590/

2016-10-02 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: DO NOT SUBMIT: Example diffs of http://gerrit.cloudera.org/#/c/4590/ .. DO NOT SUBMIT: Example diffs of http://gerrit.cloudera.org/#/c/4590/ PS1 is before, PS2 is

[Impala-ASF-CR] new clang formatting

2016-10-02 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: new clang formatting .. Abandoned accidental upload -- To view, visit http://gerrit.cloudera.org:8080/4592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

[Impala-ASF-CR](asf-site) Allow votes to go long is they overlap a weekend.

2016-09-26 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4536 Change subject: Allow votes to go long is they overlap a weekend. .. Allow votes to go long is they overlap a weekend. On our first release

[Impala-ASF-CR](asf-site) Allow votes to go long if they overlap a weekend.

2016-09-26 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Allow votes to go long if they overlap a weekend. .. Allow votes to go long if they overlap a weekend. On our first release vote, Tom White explained that this is

[Impala-ASF-CR](asf-site) Allow votes to go long if they overlap a weekend.

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Allow votes to go long if they overlap a weekend. .. Allow votes to go long if they overlap a weekend. On our first release vote, Tom White explained that

[Impala-ASF-CR](asf-site) Allow votes to go long if they overlap a weekend.

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Allow votes to go long if they overlap a weekend. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4536 To unsubscribe, visit

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add downloads page .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4544/1/downloads.html File downloads.html: PS1, Line 135: class="active" >

[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/4187/8/be/src/util/redactor.detail.h File

[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4187 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-09 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment .. IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment This script bootstraps an Impala dev

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-26 Thread Jim Apple (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4758 to look at the new patch set (#9). Change subject: IMPALA-3676: Use clang as a static analysis tool ..

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 8: PS8 is rebase-only -- To view, visit http://gerrit.cloudera.org:8080/4758 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 9: Code-Review+1 PS9 fixes warning from PS8; carry Tim's +1 -- To view, visit

[Impala-ASF-CR] IMPALA-4381: Incorrect AVX version of BloomFilter::Or

2016-10-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4866 Change subject: IMPALA-4381: Incorrect AVX version of BloomFilter::Or .. IMPALA-4381: Incorrect AVX version of BloomFilter::Or The

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 7: > > I rearranged them all. Tim convinced me to roll some back. > > That doesn't really answer my

[Impala-ASF-CR] IMPALA-4381: Incorrect AVX version of BloomFilter::Or

2016-10-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4381: Incorrect AVX version of BloomFilter::Or .. Patch Set 3: Code-Review+2 (2 comments) Carry Tim's +2

[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4868 Change subject: Fix distcc instructions to help users know they must set BUILD_FARM .. Fix distcc instructions to help users know they must

[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Fix distcc instructions to help users know they must set BUILD_FARM .. Fix distcc instructions to help users know they must set BUILD_FARM While I'm here, remove an

[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Fix distcc instructions to help users know they must set BUILD_FARM .. Patch Set 3: Code-Review+2 (1 comment) Carry +2

[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-27 Thread Jim Apple (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4868 to look at the new patch set (#3). Change subject: Fix distcc instructions to help users know they must set BUILD_FARM

[Impala-ASF-CR] IMPALA-3200 (buffer pool): warn if Status is ignored

2016-10-28 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3200 (buffer pool): warn if Status is ignored .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4878/1//COMMIT_MSG Commit Message: Line 14:

[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-29 Thread Jim Apple (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4683 to look at the new patch set (#3). Change subject: Follow Apache Project Branding Requirements .. Follow Apache

[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Follow Apache Project Branding Requirements .. Patch Set 3: Code-Review+2 (1 comment) Carry +2 http://gerrit.cloudera.org:8080/#/c/4683/2/community.html File

[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Follow Apache Project Branding Requirements .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4683 To unsubscribe, visit

[Impala-ASF-CR] Add -build shared libs for default build for speed.

2016-11-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add -build_shared_libs for default build for speed. .. Patch Set 1: > > I'm fine with this change, but I remember Dan had some > reservations > > when this change

[Impala-ASF-CR] IMPALA-4438: Serialize test failpoints.py to reduce memory pressure

2016-11-08 Thread Jim Apple (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4999 to look at the new patch set (#2). Change subject: IMPALA-4438: Serialize test_failpoints.py to reduce memory pressure

[Impala-ASF-CR] IMPALA-4438: Serialize test failpoints.py to reduce memory pressure

2016-11-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4438: Serialize test_failpoints.py to reduce memory pressure .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4438: Serialize test failpoints.py to reduce memory pressure

2016-11-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4438: Serialize test_failpoints.py to reduce memory pressure .. Patch Set 3: Code-Review+2 rebase, carry Alex's +2 -- To view, visit

[Impala-ASF-CR] Add -build shared libs for default build for speed.

2016-11-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add -build_shared_libs for default build for speed. .. Patch Set 1: > I'm ok with this as long as we have automated test coverage of this > script (in case the

[Impala-ASF-CR] IMPALA-3200 (buffer pool): warn if Status is ignored

2016-11-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3200 (buffer pool): warn if Status is ignored .. Patch Set 2: > (1 comment) Any updates no this? -- To view, visit http://gerrit.cloudera.org:8080/4878 To

[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.

2016-11-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 2: Code-Review+2 Carry Tim's +2 -- To view, visit http://gerrit.cloudera.org:8080/4774 To

[Impala-ASF-CR] IMPALA-4447: Rein in overly broad sed that dirties the tree

2016-11-08 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5008 Change subject: IMPALA-4447: Rein in overly broad sed that dirties the tree .. IMPALA-4447: Rein in overly broad sed that dirties the tree

[Impala-ASF-CR] IMPALA-3398: Add docs to main Impala branch.

2016-11-08 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5014 Change subject: IMPALA-3398: Add docs to main Impala branch. .. IMPALA-3398: Add docs to main Impala branch. These are refugees from

[Impala-ASF-CR] IMPALA-4433: Fix undefined NDV calculations

2016-11-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4433: Fix undefined NDV calculations .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5004/1//COMMIT_MSG Commit Message: Line 10: argument

[Impala-ASF-CR] IMPALA-4433: Fix undefined NDV calculations

2016-11-08 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-4433: Fix undefined NDV calculations .. IMPALA-4433: Fix undefined NDV calculations GCC's __builtin_ctz[l[l]] functions return undefined results when the

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 4: > There is no point in sending it through GVO. Just submit it > directly Only committers can

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4936 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4433: Fix undefined NDV calculations

2016-11-09 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-4433: Fix undefined NDV calculations .. Abandoned Doesn't bring consensus to all the platforms on the NDV of timestamp_col. Let's bring the discussion back to

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-09 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5022 Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof .. IMPALA-4455: MemPoolTest.TryAllocateAligned

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-09 Thread Jim Apple (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5022 to look at the new patch set (#2). Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-11-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 4: (34 comments) http://gerrit.cloudera.org:8080/#/c/4715/4//COMMIT_MSG Commit Message:

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2016-11-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4944/1/pelicanconf.py File

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-10 Thread Jim Apple (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5022 to look at the new patch set (#3). Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-10 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof .. IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof This was

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof .. Patch Set 3: Data load failed with #7 0x01853932 in

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

2016-11-05 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4967 Change subject: Don't overwrite user's .ssh/config file when bootstrapping .. Don't overwrite user's .ssh/config file when bootstrapping

[Impala-ASF-CR] IMPALA-4435: Fix in-predicate-benchmark linking by moving templates

2016-11-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4435: Fix in-predicate-benchmark linking by moving templates .. Patch Set 2: Code-Review+2 rebase, carry +2 -- To view, visit

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

2016-11-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Don't overwrite user's .ssh/config file when bootstrapping .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4967/1//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] Add -build shared libs for default build for speed.

2016-11-05 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4970 Change subject: Add -build_shared_libs for default build for speed. .. Add -build_shared_libs for default build for speed. This is already

[Impala-ASF-CR] IMPALA-4435: Fix in-predicate-benchmark linking by moving templates

2016-11-05 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4966 Change subject: IMPALA-4435: Fix in-predicate-benchmark linking by moving templates .. IMPALA-4435: Fix in-predicate-benchmark linking by

[Impala-ASF-CR] IMPALA-3676,4321: Use clang as a static analysis tool

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676,4321: Use clang as a static analysis tool .. Patch Set 1: (44 comments) http://gerrit.cloudera.org:8080/#/c/4758/1//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-3676,4321: Use clang as a static analysis tool

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-3676,4321: Use clang as a static analysis tool .. IMPALA-3676,4321: Use clang as a static analysis tool This patch adds a script to run clang-tidy over the

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4758 Change subject: IMPALA-3676: Use clang as a static analysis tool .. IMPALA-3676: Use clang as a static analysis tool This patch adds a

[Impala-ASF-CR] IMPALA-3420: use gold by default

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3420: use gold by default .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4751 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3676,4321: Use clang as a static analysis tool

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676,4321: Use clang as a static analysis tool .. Patch Set 3: (23 comments) http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-3676,4321: Use clang as a static analysis tool

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: IMPALA-3676,4321: Use clang as a static analysis tool .. IMPALA-3676,4321: Use clang as a static analysis tool This patch adds a script to run clang-tidy over the

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4494/11/be/src/util/bit-packing.inline.h File

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-20 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4). Change subject: IMPALA-3676: Use clang as a static analysis tool .. IMPALA-3676: Use clang as a static analysis tool This patch adds a script to run clang-tidy over the whole code

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt File be/CMakeLists.txt:

[Impala-ASF-CR] IMPALA-4300: Speed up BloomFilter::Or with SIMD

2016-10-23 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-4300: Speed up BloomFilter::Or with SIMD .. IMPALA-4300: Speed up BloomFilter::Or with SIMD Manually vectorizing speeds up BloomFilter::Or by up to 184x. The

[Impala-ASF-CR] IMPALA-4300: Speed up BloomFilter::Or with SIMD

2016-10-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4300: Speed up BloomFilter::Or with SIMD .. Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/4813/1/be/src/util/bloom-filter.cc File

[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.

2016-10-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4300: Speed up BloomFilter::Or with SIMD

2016-10-23 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4813 Change subject: IMPALA-4300: Speed up BloomFilter::Or with SIMD .. IMPALA-4300: Speed up BloomFilter::Or with SIMD Manually vectorizing

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt File be/CMakeLists.txt:

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-23 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#5). Change subject: IMPALA-3676: Use clang as a static analysis tool .. IMPALA-3676: Use clang as a static analysis tool This patch adds a script to run clang-tidy over the whole code

[Impala-ASF-CR] Remove unused Bitmap code.

2016-10-23 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4801 Change subject: Remove unused Bitmap code. .. Remove unused Bitmap code. These methods and code paths have been made obsolete by the switch

[Impala-ASF-CR] Add distcc infrastructure.

2016-10-23 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4820 Change subject: Add distcc infrastructure. .. Add distcc infrastructure. This has been working for several months, and it it was written

[Impala-ASF-CR] IMPALA-4300: Speed up BloomFilter::Or with SIMD

2016-10-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4300: Speed up BloomFilter::Or with SIMD .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4813/2/be/src/util/bloom-filter.cc File

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-23 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#6). Change subject: IMPALA-3676: Use clang as a static analysis tool .. IMPALA-3676: Use clang as a static analysis tool This patch adds a script to run clang-tidy over the whole code

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-24 Thread Jim Apple (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4758 to look at the new patch set (#7). Change subject: IMPALA-3676: Use clang as a static analysis tool ..

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 2: Code-Review+1 Not +2 because I think it could use a review from someone who knows Cmake much

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 7: (8 comments) > (8 comments) > > The commit message doesn't really tell the full story here. In

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe,

[Impala-ASF-CR] Add distcc infrastructure.

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add distcc infrastructure. .. Patch Set 3: Code-Review+2 Carry Tim's +2 -- To view, visit http://gerrit.cloudera.org:8080/4820 To unsubscribe, visit

[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.

2016-10-20 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4774 Change subject: Minor fixes to remove more "cloudera"s from the code. .. Minor fixes to remove more "cloudera"s from the code. Change-Id:

[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.

2016-10-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4774/1//COMMIT_MSG Commit Message: Line 7:

[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.

2016-10-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4295: XFAIL wildcard SSL test

2016-10-21 Thread Jim Apple (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4784 to look at the new patch set (#2). Change subject: IMPALA-4295: XFAIL wildcard SSL test .. IMPALA-4295: XFAIL

[Impala-ASF-CR] IMPALA-4300: Speed up BloomFilter::Or with SIMD

2016-10-24 Thread Jim Apple (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4813 to look at the new patch set (#4). Change subject: IMPALA-4300: Speed up BloomFilter::Or with SIMD ..

[Impala-ASF-CR] Add distcc infrastructure.

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Add distcc infrastructure. .. Add distcc infrastructure. This has been working for several months, and it it was written mainly by Casey Ching while he was at

[Impala-ASF-CR] Add distcc infrastructure.

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add distcc infrastructure. .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4820/1/bin/distcc/distcc.sh File bin/distcc/distcc.sh: Line 1:

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 1: (5 comments) Have you tested this in a clean environment, maybe with Docker or Jenkins?

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4771/2//COMMIT_MSG Commit Message: PS2,

[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Follow Apache Project Branding Requirements .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4683/1/bylaws.html File bylaws.html: PS1, Line 134:

[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-17 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Follow Apache Project Branding Requirements .. Follow Apache Project Branding Requirements See: http://www.apache.org/foundation/marks/pmcs.html Specifically: 1.

[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. .. Patch Set 6: Code-Review+2 rebase, carry Tim's +2 -- To view, visit http://gerrit.cloudera.org:8080/4582 To

[Impala-ASF-CR] IMPALA-3420: use gold by default

2016-10-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3420: use gold by default .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4751/2//COMMIT_MSG Commit Message: Line 15: Did ASAN and debug

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-14 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5082 Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Add a build flag for the undefined behavior

[Impala-ASF-CR] IMPALA-4433: Always generate testdata using the same time zone setting

2016-11-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4433: Always generate testdata using the same time zone setting .. Patch Set 3: Code-Review+2 rebase-only; carry +2 -- To view, visit

[Impala-ASF-CR] Increase wait times for startup of Hive and its Metastore

2016-11-14 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5068 Change subject: Increase wait times for startup of Hive and its Metastore .. Increase wait times for startup of Hive and its Metastore On

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/4956/14/be/src/codegen/mcjit-mem-mgr.h

[Impala-ASF-CR] Avoid std::function when possible.

2016-11-26 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5230 Change subject: Avoid std::function when possible. .. Avoid std::function when possible. std::function does some tricky stuff under the

[Impala-ASF-CR] Start a docs build system.

2016-11-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5238 Change subject: Start a docs build system. .. Start a docs build system. The docs can be built by running "make" from the docs directory.

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific

2016-11-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5239 Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific .. IMPALA-3398: Rework Impala documentation to be

[Impala-ASF-CR] Avoid std::function when possible.

2016-11-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Avoid std::function when possible. .. Patch Set 1: See Effective Modern C++, slide 39 of

<    1   2   3   4   5   6   7   8   9   >