Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8085 )
Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of
parquet
..
Patch Set 6:
(1 comment)
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/7793 )
Change subject: IMPALA-4252: Min-max runtime filters for Kudu
..
Patch Set 5:
(33 comments)
I did a pass over the backend part of it.
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8151 )
Change subject: IMPALA-5307: Part 3: remove TODO from RCFile
..
Patch Set 2: Code-Review+2
--
To view, visit
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8164 )
Change subject: IMPALA-4736: Add SIGUSR1 bahavior to help string for
'minidump_path' flag
..
Patch Set 1:
(2 comments)
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8147 )
Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet
scan node
..
Patch Set 1:
(10 comments)
The change
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8085 )
Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of
parquet
..
Patch Set 6:
(1 comment)
Tim Armstrong has uploaded this change for review. (
http://gerrit.cloudera.org:8080/8151
Change subject: IMPALA-5307: Part 3: remove TODO from RCFile
..
IMPALA-5307: Part 3: remove TODO from RCFile
Our RCFile implementations
Tim Armstrong has uploaded a new patch set (#7). (
http://gerrit.cloudera.org:8080/8146 )
Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro
..
IMPALA-5307: Part 2: copy out strings in uncompressed Avro
Tim Armstrong has uploaded a new patch set (#2). (
http://gerrit.cloudera.org:8080/8145 )
Change subject: IMPALA-5988: optimise MemPool::TryAllocate()
..
IMPALA-5988: optimise MemPool::TryAllocate()
Testing:
Ran core tests.
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8148 )
Change subject: IMPALA-4252: Move runtime filters to ScanNode
..
Patch Set 1:
(4 comments)
Looks fine, just very minor comments. It
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8153 )
Change subject: Test cleanup related to the old join node.
..
Patch Set 1: Code-Review+2
(1 comment)
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8123 )
Change subject: IMPALA-5870: Improve runtime profile for partial sort
..
Patch Set 3: Code-Review+2
--
To view, visit
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8085 )
Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of
parquet
..
Patch Set 5:
(1 comment)
Hello Lars Volker, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8085
to look at the new patch set (#6).
Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of
parquet
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8085 )
Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of
parquet
..
Patch Set 5:
(8 comments)
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8025 )
Change subject: IMPALA-5844: use a MemPool for expr result allocations
..
Patch Set 9:
Rebased
--
To view, visit
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8025
to look at the new patch set (#9).
Change subject: IMPALA-5844: use a MemPool for expr result allocations
..
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8025 )
Change subject: IMPALA-5844: use a MemPool for expr result allocations
..
Patch Set 7:
(5 comments)
I think I addressed all the
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8025
to look at the new patch set (#8).
Change subject: IMPALA-5844: use a MemPool for expr result allocations
..
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8123 )
Change subject: IMPALA-5870: Improve runtime profile for partial sort
..
Patch Set 2: Code-Review+2
--
To view, visit
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8029 )
Change subject: IMPALA-3360: Codegen inserting into runtime filters
..
Patch Set 6: Code-Review+2
--
To view, visit
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8004 )
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 7: Code-Review+2
--
To view, visit
Tim Armstrong has uploaded a new patch set (#5). (
http://gerrit.cloudera.org:8080/8085 )
Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of
parquet
..
IMPALA-5307: part 1: don't transfer disk I/O
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8123 )
Change subject: IMPALA-5870: Improve explain/profile output for partial sort
..
Patch Set 1:
(3 comments)
The profile changes look
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8025 )
Change subject: IMPALA-5844: use a MemPool for expr local allocations
..
Patch Set 6:
(4 comments)
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8025
to look at the new patch set (#7).
Change subject: IMPALA-5844: use a MemPool for expr local allocations
..
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8025 )
Change subject: IMPALA-5844: use a MemPool for expr local allocations
..
Patch Set 6:
(4 comments)
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8111 )
Change subject: IMPALA-5949: fix test_exchange_small_delay failure
..
Patch Set 2: Code-Review+2
--
To view, visit
Tim Armstrong has uploaded this change for review. (
http://gerrit.cloudera.org:8080/8117
Change subject: IMPALA-5965: avoid per-value switch on NeedsConversionInline()
in parquet
..
IMPALA-5965: avoid per-value switch on
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8114 )
Change subject: Remove unused MemPool::peak_allocated_bytes_
..
Patch Set 1: Verified+1
Build passed but submission failed.
--
To
Tim Armstrong has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/8114 )
Change subject: Remove unused MemPool::peak_allocated_bytes_
..
Remove unused MemPool::peak_allocated_bytes_
The value is not
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8029 )
Change subject: IMPALA-3360: Codegen inserting into runtime filters
..
Patch Set 3:
(1 comment)
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8030 )
Change subject: IMPALA-5250: Unify decompressor output_length semantics
..
Patch Set 4: Code-Review+2
--
To view, visit
Tim Armstrong has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/7245 )
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
IMPALA-4863/IMPALA-5311:
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/7245 )
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
Patch Set 11: Verified+1
Build
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
Patch Set 11: Code-Review+2
--
To view, visit
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8114
Change subject: Remove unused MemPool::peak_allocated_bytes_
..
Remove unused MemPool::peak_allocated_bytes_
The value is not used for
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
Patch Set 9:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5425: Add test for validating input when setting query
options
..
Patch Set 8:
(4 comments)
I'm generally ok with this patch. I think there are places
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5425: Add test for validating input when setting query
options
..
Patch Set 7:
The really nice thing about the patch is that all the tests are all
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5425: Add test for validating input when setting query
options
..
Patch Set 7:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8049
To unsubscribe, visit
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8111
Change subject: IMPALA-5949: fix test_exchange_small_delay failure
..
IMPALA-5949: fix test_exchange_small_delay failure
Avoid running
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5425: Add test for validating input when setting query
options
..
Patch Set 7:
(8 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5920: addendum - add missing RAT check
..
Patch Set 1:
Matt manually submitted it thinking it was a spurious failure:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 12: Code-Review+2
rebase onto the rat check fix to unblock merging
--
To view, visit
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8108
Change subject: IMPALA-5920: addendum - add missing RAT check
..
IMPALA-5920: addendum - add missing RAT check
Change-Id:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 7:
The rat-check job actually failed because of a file introduced here - it broke
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8049/3/bin/clean.sh
File bin/clean.sh:
Line 33: pushd
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7974/9/.clang-tidy
File .clang-tidy:
Line 27:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8069
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 10:
Fix wasn't totally trivial so would be good to have you check my work
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 9:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8069/9/be/src/exec/data-source-scan-node.cc
Hello Sailesh Mukil, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8069
to look at the new patch set (#10).
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3360: Codegen inserting into runtime filters
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8029/3/be/src/exec/CMakeLists.txt
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8049/2//COMMIT_MSG
Commit Message:
Line
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 8:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8069/8//COMMIT_MSG
Commit Message:
Line 19:
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8069
to look at the new patch set (#9).
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
IMPALA-5895:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 7:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/8069/7/be/src/util/runtime-profile.cc
File
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8069
to look at the new patch set (#8).
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
IMPALA-5895:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5941: Fix Metastore schema creation in
create-test-configuration.sh
..
Patch Set 3: Code-Review+2
--
To view, visit
Tim Armstrong has uploaded a new patch set (#7).
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
IMPALA-5895: clean up runtime profile lifecycle
Require callers to explicitly stop counter updating instead of
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 6:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/8069/6/be/src/exec/hdfs-scan-node-base.h
File
Tim Armstrong has uploaded a new patch set (#6).
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
IMPALA-5895: clean up runtime profile lifecycle
Require callers to explicitly stop counter updating instead of
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Patch Set 9: Code-Review+2
Missed a couple of clang warnings.
--
To view, visit http://gerrit.cloudera.org:8080/7974
To
Hello Impala Public Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7974
to look at the new patch set (#9).
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3360: Codegen inserting into runtime filters
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/exec/filter-context.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Patch Set 8: Code-Review+2
Need to suppress a few new clang-tidy checks
--
To view, visit
Hello Impala Public Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7974
to look at the new patch set (#8).
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7974
to look at the new patch set (#7).
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
IMPALA-5860: upgrade to LLVM
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Patch Set 7: Code-Review+2
carry +2
--
To view, visit http://gerrit.cloudera.org:8080/7974
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Patch Set 6: Code-Review+2
rebase and update build ID
--
To view, visit http://gerrit.cloudera.org:8080/7974
To
Tim Armstrong has posted comments on this change.
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
..
Patch Set 2: Verified+1
Successfully built with ID 468-0b4f08e601
--
To view, visit
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7974
to look at the new patch set (#6).
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
IMPALA-5860: upgrade to LLVM
Tim Armstrong has submitted this change and it was merged.
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
..
Bump LLVM to 3.9.1 and CMake to 3.8.2
LLVM required a newer CMake version than the previous one, so upgrade
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5908: Allow SET to unset modified query options.
..
Patch Set 4:
That last error looks like an infra issue but it does looks like there was a
test
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3360: Codegen inserting into runtime filters
..
Patch Set 2: Code-Review+1
(4 comments)
Looks good to me minus a couple of things. Not sure if Dan wants
Tim Armstrong has uploaded a new patch set (#5).
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
IMPALA-5895: clean up runtime profile lifecycle
Require callers to explicitly stop counter updating instead of
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8069
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
IMPALA-5895: clean up runtime profile lifecycle
TODO: cleanup
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3877: support unpatched LLVM
..
Patch Set 4: Code-Review+2
carry
--
To view, visit http://gerrit.cloudera.org:8080/7973
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5199: prevent hang on empty row batch exchange
..
Patch Set 3: Code-Review+2
carry
--
To view, visit http://gerrit.cloudera.org:8080/8005
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8049/1/bin/distcc/distcc_env.sh
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5941: Fix Metastore schema creation in
create-test-configuration.sh
..
Patch Set 2: Code-Review+2
Sounds like you're doing some additional testing so
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5941: Fix Metastore schema creation in
create-test-configuration.sh
..
Patch Set 1: Code-Review+2
(1 comment)
Looks good. Will wait to see if you agree
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5908: Allow SET to unset modified query options.
..
Patch Set 2: Code-Review+1
(3 comments)
Wrote these up earlier but didn't push them out.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5199: prevent hang on empty row batch exchange
..
Patch Set 2:
I spoke to Alex. He had some general concerns with whether it could possible
cause
Tim Armstrong has posted comments on this change.
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
..
Patch Set 1:
(1 comment)
Tim Armstrong has uploaded a new patch set (#2).
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
..
Bump LLVM to 3.9.1 and CMake to 3.8.2
LLVM required a newer CMake version than the previous one, so upgrade
CMake to a
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7974
To unsubscribe, visit
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7974
to look at the new patch set (#5).
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
IMPALA-5860: upgrade to LLVM
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7974/2/be/src/codegen/codegen-symbol-emitter.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7974
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Patch Set 2:
unintended rebase, still need to address comments
--
To view, visit http://gerrit.cloudera.org:8080/7974
To
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7974
to look at the new patch set (#4).
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
IMPALA-5860: upgrade to LLVM
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3877: support unpatched LLVM
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7973
To unsubscribe, visit
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7973
to look at the new patch set (#3).
Change subject: IMPALA-3877: support unpatched LLVM
..
IMPALA-3877: support
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7974
to look at the new patch set (#3).
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
IMPALA-5860: upgrade to LLVM
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3877: support unpatched LLVM
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7973/2/be/src/codegen/codegen-util.h
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7916
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
..
Patch Set 6:
(1 comment)
401 - 500 of 2851 matches
Mail list logo
