[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#11). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. IMPALA-4810: Add DECIMAL_V2 query option This query option is going to be used to change both rounding semantics and

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

Zach Amsden has posted comments on this change. Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5889/1/be/src/exprs/expr.cc File be/src/exprs/expr.cc:

[Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle

Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-3785: Record query handle for invalid handle .. IMPALA-3785: Record query handle for invalid handle Add the query handle to error messages for Invalid Query

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 6: (1 comment) After pre-loading the data (lost the first few lines, can't figure out how to get more scrollback

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5902 Change subject: IMPALA-2020: Make it easy to work with big numbers .. IMPALA-2020: Make it easy to work with big numbers We're going to

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-2020: Make it easy to work with big numbers .. IMPALA-2020: Make it easy to work with big numbers We're going to be working with some really big numbers that

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 9: Added support for saving StringSearcher for complicated queries.

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#9). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4809: Add Stability for codegen constants

Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5848 Change subject: IMPALA-4809: Add Stability for codegen constants .. IMPALA-4809: Add Stability for codegen constants Having two boolean

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 9: Michael, yeah, I will fix those. I still need to plug in the additional tests that will be required now that we

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#6). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#14). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Make it easy to work with big numbers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5902/2/be/src/util/decimal-util.h File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#13). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#16). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/5776/15/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#18). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 16: (1 comment)

[Impala-ASF-CR] Impala ABM / LZCNT support

Zach Amsden has uploaded a new patch set (#2). Change subject: Impala ABM / LZCNT support .. Impala ABM / LZCNT support I recently added some code that wants to do upwards power of 2 calculation. Turns out this can be done

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

Zach Amsden has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 1: Code-Review+1 Looks pretty straightforward -- To view, visit

[Impala-ASF-CR] Impala ABM / LZCNT support

Zach Amsden has uploaded a new patch set (#3). Change subject: Impala ABM / LZCNT support .. Impala ABM / LZCNT support I recently added some code that wants to do upwards power of 2 calculation. Turns out this can be done

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. IMPALA-2020: Add rounding when casting from decimal to int Preview diff, not working yet, mostly to

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#10). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/10/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5889 Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. IMPALA-4810: Add DECIMAL_V2 query option Change-Id:

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/10/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#12). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 11: (9 comments) http://gerrit.cloudera.org:8080/#/c/5776/11/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-2020: Make it easy to work with big numbers .. IMPALA-2020: Make it easy to work with big numbers We're going to be working with some really big numbers that

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Make it easy to work with big numbers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5902/2/be/src/util/decimal-util.h File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/11/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/11/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#19). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729:

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/8/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#8). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5776/2/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/2//COMMIT_MSG Commit Message: Line 11: since function

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5776 Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/2/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 4: This is good to go and fully tested now. I had to replumb a few things to get a StringVal.Resize()

[Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle

Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-3785: Record query handle for invalid handle .. IMPALA-3785: Record query handle for invalid handle Add the query handle to error messages for Invalid Query

[Impala-ASF-CR] Impala ABM / LZCNT support

Zach Amsden has posted comments on this change. Change subject: Impala ABM / LZCNT support .. Patch Set 1: I don't know if this is a good idea or not but I wanted to learn more about the build and so here it is. -- To view,

[Impala-ASF-CR] Impala ABM / LZCNT support

Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5821 Change subject: Impala ABM / LZCNT support .. Impala ABM / LZCNT support I recently added some code that wants to do upwards power of 2

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] Impala ABM / LZCNT support

Zach Amsden has posted comments on this change. Change subject: Impala ABM / LZCNT support .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5821/1/be/src/util/bit-util.h File be/src/util/bit-util.h: Line 98:

[Impala-ASF-CR] IMPALA-5748 Record query handle for invalid handle

Zach Amsden has posted comments on this change. Change subject: IMPALA-5748 Record query handle for invalid handle .. Patch Set 2: Henry, I don't think it matters at all in this case, but I did want to figure out how to use

[Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle

Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-3785: Record query handle for invalid handle .. IMPALA-3785: Record query handle for invalid handle Add the query handle to error messages for Invalid Query

[Impala-ASF-CR] IMPALA-5748 Record query handle for invalid handle

Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-5748 Record query handle for invalid handle .. IMPALA-5748 Record query handle for invalid handle Add the query handle to error messages for Invalid Query

[Impala-ASF-CR] IMPALA-5748 Record query handle for invalid handle

Zach Amsden has posted comments on this change. Change subject: IMPALA-5748 Record query handle for invalid handle .. Patch Set 1: So I wrote a little benchmark. As expected, karma blew away all the other forms of string

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

Zach Amsden has uploaded a new patch set (#11). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/literal.cc File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/10/be/src/runtime/decimal-value.inline.h File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 11: I have not updated the Python test yet, as that would require a rebase. Python test and benchmark

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

Zach Amsden has uploaded a new patch set (#17). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. IMPALA-2020, 4915, 4936: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 16: (1 comment) After fighting the compiler for over an hour to figure out why our operator<< was not

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

Zach Amsden has posted comments on this change. Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. Patch Set 2: (3 comments) I'm folding this into the cast change anyway.

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

Zach Amsden has uploaded a new patch set (#18). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. IMPALA-2020, 4915, 4936: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

Zach Amsden has uploaded a new patch set (#21). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. IMPALA-2020, 4915, 4936: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 18: > Uploaded patch set 20. > Uploaded patch set 21. rebased and fixed merge conflict --

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/17/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

Zach Amsden has posted comments on this change. Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6068/2/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

Zach Amsden has uploaded a new patch set (#19). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. IMPALA-2020, 4915, 4936: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

Zach Amsden has uploaded a new patch set (#20). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. IMPALA-2020, 4915, 4936: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/12/be/src/runtime/decimal-value.inline.h File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

Zach Amsden has uploaded a new patch set (#13). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-2020: Inline big number strings .. IMPALA-2020: Inline big number strings We can directly spcecify these in the header instead of keeping the constants out

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

Zach Amsden has uploaded a new patch set (#15). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6068 Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. IMPALA-4936 and IMPALA-4915: Fix decimal overflow test The root

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. IMPALA-4936 and IMPALA-4915: Fix decimal overflow test The root cause of both behaviors turned out to be

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5902/5/be/src/exprs/expr-value.h File

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-2020: Inline big number strings .. IMPALA-2020: Inline big number strings We can directly spcecify these in the header instead of keeping the constants out

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 22: (1 comment)

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6132 Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6132/2/be/src/exprs/decimal-operators-ir.cc File

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 2: (12 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/6132/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

Zach Amsden has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 1: Code-Review+1 Looks simple and correct. Maybe add a 39 digit overflow test and a 39 digit

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 21: (1 comment)

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5951 to look at the new patch set (#22). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts ..

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/21/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

Zach Amsden has posted comments on this change. Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

Zach Amsden has abandoned this change. Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. Abandoned Rolled this into casting change -- To view, visit http://gerrit.cloudera.org:8080/6068 To

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 12: (8 comments) http://gerrit.cloudera.org:8080/#/c/5951/15//COMMIT_MSG Commit Message: Line 122 >

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

Zach Amsden has uploaded a new patch set (#16). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 10: (1 comment) I am trying to get the DCHECK_EQ to work with int128_t, for which we do provide a

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Hello Impala Public Jenkins, Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#23). Change subject: IMPALA-4729: Implement REPLACE()

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

Zach Amsden has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 5: Jim, if you haven't done so already, I resolved the merge conflicts here

[Impala-ASF-CR] IMPALA-4809: Enable support for DECIMAL V2 in decimal casting.py

Zach Amsden has posted comments on this change. Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 3: > I'm not opposed to cleaning up the AnyVal stuff like that, but > given that udf.h

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. IMPALA-2020: Add rounding when casting from decimal to int Preview diff, not working yet, mostly to

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

Hello Impala Public Jenkins, Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#21). Change subject: IMPALA-4729: Implement REPLACE()

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 3: (2 comments)

  1   2   3   4   >