[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

2017-02-02 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5889 Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. IMPALA-4810: Add DECIMAL_V2 query option Change-Id: I6cf25fe5c1766c86ebfe196d4

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-02 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#10). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/10/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/10/be/src/exprs/string-functions-ir.cc File be/src/exprs/st

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 6: (1 comment) After pre-loading the data (lost the first few lines, can't figure out how to get more scrollback in

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#11). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. IMPALA-4810: Add DECIMAL_V2 query option This query option is going to be used to change both rounding semantics and esta

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5889/1/be/src/exprs/expr.cc File be/src/exprs/expr.cc:

[Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-3785: Record query handle for invalid handle .. IMPALA-3785: Record query handle for invalid handle Add the query handle to error messages for Invalid Query H

[Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-3785: Record query handle for invalid handle .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5748/4/be/src/service/impala-beeswax-server.c

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5902 Change subject: IMPALA-2020: Make it easy to work with big numbers .. IMPALA-2020: Make it easy to work with big numbers We're going to be

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-2020: Make it easy to work with big numbers .. IMPALA-2020: Make it easy to work with big numbers We're going to be working with some really big numbers that

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#12). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Make it easy to work with big numbers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5902/2/be/src/util/decimal-util.h File be/src/

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-2020: Make it easy to work with big numbers .. IMPALA-2020: Make it easy to work with big numbers We're going to be working with some really big numbers that

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 11: (9 comments) http://gerrit.cloudera.org:8080/#/c/5776/11/be/src/exprs/string-functions-ir.cc File be/src/exprs/s

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/11/be/src/exprs/string-functions-ir.cc File be/src/exprs/st

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/11/be/src/exprs/string-functions-ir.cc File be/src/exprs/st

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#13). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Make it easy to work with big numbers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5902/2/be/src/util/decimal-util.h File be/src/

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#14). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#15). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/5776/14/be/src/exprs/string-functions-ir.cc File be/src/exprs/s

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/5776/15/be/src/exprs/string-functions-ir.cc File be/src/exprs/s

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#16). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLAC

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 16: (5 comments) http://gerrit.cloudera.org:8080/#/c/5776/16/be/src/exprs/string-functions-ir.cc File be/src/exprs/s

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/16/testdata/workloads/functional-query/queries/QueryTest/ex

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#17). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLAC

[Impala-ASF-CR] IMPALA-5548 Fix some minor issues with HDFS / parquet column readers

2017-06-20 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/7240 Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column readers .. IMPALA-5548 Fix some minor issues with HDFS / parq

[Impala-ASF-CR] IMPALA-5548 Fix some minor issues with HDFS / parquet column readers

2017-06-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column readers .. Patch Set 1: Some pretty simple fixes that came from work on IMPALA-4864. Running build a

[Impala-ASF-CR] IMPALA-4864 Speed up single slot predicates with dictionaries

2017-06-20 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries .. Abandoned Not enough win for the complexity. -- To view, visit http://gerrit.cloudera.org:8080/6726 To un

[Impala-ASF-CR] IMPALA-5548 Fix some minor issues with HDFS / parquet column readers

2017-06-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column readers .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7240/1/be/src/exec/hdfs-sca

[Impala-ASF-CR] IMPALA-5548 Fix some minor issues with HDFS / parquet column readers

2017-06-21 Thread Zach Amsden (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7240 to look at the new patch set (#2). Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column readers .

[Impala-ASF-CR] IMPALA-5548 Fix some minor nits with HDFS parquet column readers

2017-06-21 Thread Zach Amsden (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7240 to look at the new patch set (#3). Change subject: IMPALA-5548 Fix some minor nits with HDFS parquet column readers ..

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7257/1/fe/src/main/java/org/apache/impala/planner/JoinN

[Impala-ASF-CR] IMPALA-5128: BE Test Infrastructure

2017-06-27 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5128: BE Test Infrastructure .. Patch Set 2: Code-Review-1 I think we have more important things to do and there are probably even more egregious tests. N

[Impala-ASF-CR] IMPALA-5128: BE Test Infrastructure

2017-06-27 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. Change subject: IMPALA-5128: BE Test Infrastructure .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Ger

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7257/1/fe/src/main/java/org/apache/impala/planner/JoinNo

[Impala-ASF-CR] Complete guide to important environment variables for build, test, and mini-cluster operations.

2017-06-30 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/7350 Change subject: Complete guide to important environment variables for build, test, and mini-cluster operations. .. Complete guide to impor

[Impala-ASF-CR] Complete guide to important environment variables for build, test, and mini-cluster operations.

2017-06-30 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: Complete guide to important environment variables for build, test, and mini-cluster operations. .. Patch Set 1: I personally abhor Google docs as they just seem t

[Impala-ASF-CR] Complete guide to important environment variables for build, test, and mini-cluster operations.

2017-07-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: Complete guide to important environment variables for build, test, and mini-cluster operations. .. Patch Set 1: (2 comments) > > I personally abhor Google docs a

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 3: (6 comments) Looks promising! http://gerrit.cloudera.org:8080/#/c/7267/3/be/src/exec/partial-sort-node.cc

[Impala-ASF-CR] IMPALA-5623: Fix lag() on STRING cols to release UDF mem

2017-07-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5623: Fix lag() on STRING cols to release UDF mem .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7371/1/testdata/workloads/f

[Impala-ASF-CR] IMPALA-XXXX: Bloom filter benchmark fails to complete

2017-07-07 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/7381 Change subject: IMPALA-: Bloom filter benchmark fails to complete .. IMPALA-: Bloom filter benchmark fails to complete Due to larg

[Impala-ASF-CR] IMPALA-XXXX: Bloom filter benchmark fails to complete

2017-07-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-: Bloom filter benchmark fails to complete .. Patch Set 1: @jbapple, Is there a JIRA open for this already? -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5164: Bloom filter benchmark fails to complete

2017-07-10 Thread Zach Amsden (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7381 to look at the new patch set (#2). Change subject: IMPALA-5164: Bloom filter benchmark fails to complete .. IMPALA-516

[Impala-ASF-CR] IMPALA-5164: Bloom filter benchmark fails to complete

2017-07-10 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5164: Bloom filter benchmark fails to complete .. Patch Set 1: @jbapple, let's go ahead with this diff and if there are more failures, I'll attach more fix

[Impala-ASF-CR] IMPALA-5164: Better benchmark heuristic

2017-07-10 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5164: Better benchmark heuristic .. Patch Set 1: Code-Review+1 Turns out this approach works even better and avoids any special changes to benchmarks. --

[Impala-ASF-CR] IMPALA-5164: Better benchmark heuristic

2017-07-10 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/7389 Change subject: IMPALA-5164: Better benchmark heuristic .. IMPALA-5164: Better benchmark heuristic If any benchmark took longer than 50ms

[Impala-ASF-CR] IMPALA-5164: Better benchmark heuristic

2017-07-10 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5164: Better benchmark heuristic .. Patch Set 1: -Code-Review -- To view, visit http://gerrit.cloudera.org:8080/7389 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-17 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/7438/1/be/src/exprs/expr-test.cc File be/src

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-26 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7438/1/be/src/exprs/expr-test.cc File be/src/

[Impala-ASF-CR] Guide to important environment variables for build, test, and mini-cluster operations.

2017-08-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: Guide to important environment variables for build, test, and mini-cluster operations. .. Guide to important environment variables for build, test, and mini-cluster

[Impala-ASF-CR] Guide to important environment variables for build, test, and mini-cluster operations.

2017-08-03 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: Guide to important environment variables for build, test, and mini-cluster operations. .. Patch Set 2: I cut this back in scope somewhat and made it use README.md

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/7581 Change subject: IMPALA-5764: Allow overriding packaged components .. IMPALA-5764: Allow overriding packaged components For allowing multip

[Impala-ASF-CR] Guide to important environment variables for build, test, and mini-cluster operations.

2017-08-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: Guide to important environment variables for build, test, and mini-cluster operations. .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7350/2/bi

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7581/1//COMMIT_MSG Commit Message: Line 9: For

[Impala-ASF-CR] IMPALA-5768

2017-08-04 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7350 to look at the new patch set (#3). Change subject: IMPALA-5768 .. IMPALA-5768 Guide to important environment vari

[Impala-ASF-CR] IMPALA-5768: Better developer documentation

2017-08-04 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7350 to look at the new patch set (#4). Change subject: IMPALA-5768: Better developer documentation .. IMPALA-5768: Bet

[Impala-ASF-CR] IMPALA-5768: Better developer documentation

2017-08-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5768: Better developer documentation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7350/2/bin/impala-config.sh File bin/impala-config.sh:

[Impala-ASF-CR] IMPALA-5768: Better developer documentation

2017-08-07 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7350 to look at the new patch set (#5). Change subject: IMPALA-5768: Better developer documentation .. IMPALA-5768: Bet

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-10 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 1: needs rebase against merged changes, coming presently -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-10 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/7648 Change subject: IMPALA-5764: Allow overriding packaged components .. IMPALA-5764: Allow overriding packaged components For allowing multip

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-10 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-5764: Allow overriding packaged components .. IMPALA-5764: Allow overriding packaged components For allowing multiple different distributions to build against

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-10 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Abandoned Gerrit created another change for some reason. -- To view, visit http://gerrit.cloudera.org:8080/7648 To un

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-14 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 2: (4 comments) A couple of minor nits. Also, let me make sure I didn't accidentally introduce ty

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7581/2/bin/impala-config.sh File bin/impala-conf

[Impala-ASF-CR] IMPALA-5854: Update external hadoop versions

2017-08-29 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/7892 Change subject: IMPALA-5854: Update external hadoop versions .. IMPALA-5854: Update external hadoop versions These versions need to be upd

[Impala-ASF-CR] IMPALA-5854: Update external hadoop versions

2017-08-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5854: Update external hadoop versions .. Patch Set 1: Components are already built, S3 buckets updated, and I ran a private exhaustive build & load job, wh

[Impala-ASF-CR] IMPALA-5854: Update external hadoop versions

2017-08-30 Thread Zach Amsden (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7892 to look at the new patch set (#2). Change subject: IMPALA-5854: Update external hadoop versions .. IMPALA-5854: Up

[Impala-ASF-CR] IMPALA-5854: Update external hadoop versions

2017-08-30 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5854: Update external hadoop versions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7892/1/bin/impala-config.sh File bin/impala-config.sh

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-09-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 2: Need to get back to this now that I have smokes fixed. I imagine I'll want to do things a littl

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/8004 Change subject: IMPALA-4513: Promote integer types for ABS() .. IMPALA-4513: Promote integer types for ABS() The internal representation o

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4513: Promote integer types for ABS() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8004/1/be/src/exprs/expr-test.cc File be/src/exprs/ex

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4513: Promote integer types for ABS() .. IMPALA-4513: Promote integer types for ABS() The internal representation of the most negative number in 2's complemen

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4513: Promote integer types for ABS() .. Patch Set 2: As per Greg's request, add overflow check for BIGINT. All other types just get promoted. -- To vie

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4513: Promote integer types for ABS() .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8004/2/be/src/exprs/expr-test.cc File be/src/exprs/e

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-4513: Promote integer types for ABS() .. IMPALA-4513: Promote integer types for ABS() The internal representation of the most negative number in two's complem

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4513: Promote integer types for ABS() .. Patch Set 3: (2 comments) Decimal is immune to this because the range is clamped. Float and double are immune be

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-08 Thread Zach Amsden (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8004 to look at the new patch set (#4). Change subject: IMPALA-4513: Promote integer types for ABS() .. IMPALA-4513: Prom

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4513: Promote integer types for ABS() .. Patch Set 5: Sorry, been under C6 crunch. Will get back to this today. -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 4: (17 comments) Looks good but I have a few comments - there is a lot more that coul

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/8035/4/common/yarn-extras/src/mai

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/8035/5/common/yarn-e

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 5: Have we ever tried using SSE/AVX for multiplication? It should be possible to avoid using int

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-22 Thread Zach Amsden (Code Review)
Hello Lars Volker, Michael Brown, Tim Armstrong, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8004 to look at the new patch set (#6). Change subject: IMPALA-4513: Promote integer types for ABS() ..

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8004 ) Change subject: IMPALA-4513: Promote integer types for ABS() .. Patch Set 7: Finally got back to this, looks like this was the only broke

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-22 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8132 Change subject: IMPALA-5975: Work around broken beeline clients .. IMPALA-5975: Work around broken beeline clients To make statements exec

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 ) Change subject: IMPALA-5975: Work around broken beeline clients .. Patch Set 1: I will do that now. -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-25 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 ) Change subject: IMPALA-5975: Work around broken beeline clients .. Patch Set 1: I tested this with a local data load, but we need to kick

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-26 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 ) Change subject: IMPALA-5975: Work around broken beeline clients .. Patch Set 1: >From private build and test 6418, 14:21:05 Executing: c

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-26 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 6: I totally agree about doing anything fancy as a follo

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 6: The algorithm mentioned here, on page 17 seems quite

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-13 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8274 Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ Hadoop chan

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 ) Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-13 Thread Zach Amsden (Code Review)
Hello Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8274 to look at the new patch set (#2). Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ ..

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-18 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 ) Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. Patch Set 2: Looks like a transient failure, retrying -- To vi

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-18 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 ) Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. Patch Set 4: Anyone know what's going on with this change not go

[Impala-ASF-CR] IMPALA-6070: Parallel data load.

2017-10-18 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8320 ) Change subject: IMPALA-6070: Parallel data load. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8320/1/testdata/bin/cre

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-19 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 ) Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. Patch Set 4: Looks like I finally got a good GVO on this. Tim,

<    1   2   3   4   5   >