[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.

2017-11-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8496 ) Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Patch Set 4: Code-Review+2 Rebase, carry + 2 -- To view,

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed a vote on this change. Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Removed Verified+1 by Joe McDonnell -- To view, visit

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 5: Verified+1 Code-Review+2 Rebase, carry +2. -- To

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 6: (1 comment) One small comment

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-11-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 15: (3 comments)

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 4: Made a first pass through this and it makes

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resourcesa

2017-10-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resourcesa .. Patch Set 4: Code-Review+1 This looks good to me. It is

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 12: (5 comments) I think this is very

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8350 ) Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat .. Patch Set 6: Code-Review+2 Rebased, carry +2 -- To view,

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8350 ) Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat .. Patch Set 5: Code-Review+1 Carry Alex's +1 -- To view,

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-24 Thread Joe McDonnell (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8350 to look at the new patch set (#4). Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat ..

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8350 ) Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat .. Patch Set 3: (1 comment) Found a couple issues in testing.

[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

2017-10-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8303 ) Change subject: IMPALA-1575: Part 1: eagerly release query exec resources .. Patch Set 9: Code-Review+1 (1 comment) This makes sense

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-23 Thread Joe McDonnell (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8350 to look at the new patch set (#3). Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat ..

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8350 ) Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat .. Patch Set 2: (1 comment) The next upload does two things: 1.

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8350 ) Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat .. IMPALA-6068: Fix dataload for complextypes_fileformat Dataload

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8350 Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat .. IMPALA-6068: Fix dataload for complextypes_fileformat Dataload

[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

2017-10-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8303 ) Change subject: IMPALA-1575: Part 1: eagerly release query exec resources .. Patch Set 9: (1 comment) Making my way through this.

[Impala-ASF-CR] IMPALA-6070: Parallel data load.

2017-10-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8320 ) Change subject: IMPALA-6070: Parallel data load. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-10-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 8: (8 comments)

[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching

2017-10-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 ) Change subject: IMPALA-4623: [DOCS] Document file handle caching .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching

2017-10-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 ) Change subject: IMPALA-4623: [DOCS] Document file handle caching .. Patch Set 3: Code-Review+1 This looks right to me. Are we

[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching

2017-10-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 ) Change subject: IMPALA-4623: [DOCS] Document file handle caching .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-10-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8056 ) Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet .. Patch Set 5: (2 comments) I'm close to a +1

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-09-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 ) Change subject: IMPALA-5975: Work around broken beeline clients .. Patch Set 2: Code-Review+2 Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-09-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8056 ) Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet .. Patch Set 4: (4 comments) I like the overall

[Impala-ASF-CR] IMPALA-5174: Suppress kudu flags that aren't relevant to Impala

2017-09-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5174: Suppress kudu flags that aren't relevant to Impala .. Patch Set 1: Code-Review+1 I think this makes sense. At some point, should we add a test that

[Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

2017-09-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh .. Patch Set 3: Ran full dataload + tests and everything worked. I think this is

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-09-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-09-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

2017-09-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh .. Patch Set 1: (1 comment) We have had it this way for a very long time, so I'm

[Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

2017-09-15 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8081 to look at the new patch set (#2). Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-09-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet .. Patch Set 2: (2 comments) Take a look at these suggestions and let me know if they make

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-09-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

2017-09-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/8081 Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh .. IMPALA-5941: Fix Metastore schema

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-09-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-1649 Pass precision to Print TCounterType::DOUBLE VALUE

2017-09-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-1649 Pass precision to Print TCounterType::DOUBLE_VALUE .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-09-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8034/1/be/src/exec/exec-node.h

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-06 Thread Joe McDonnell (Code Review)
Hello Sailesh Mukil, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#12). Change subject: IMPALA-5750: Catch exceptions from boost thread creation

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 11: (1 comment) Rebased all the way and incorporated changes from IMPALA-5892.

[Impala-ASF-CR] IMPALA-5888: free other local allocations in Parquet

2017-09-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5888: free other local allocations in Parquet .. Patch Set 2: Code-Review+1 This makes sense to me. -- To view, visit

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-06 Thread Joe McDonnell (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7943 to look at the new patch set (#3). Change subject: IMPALA-5892: Allow reporting status independent of fragment instance

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 2: (3 comments) Also rebased all the way.

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#11). Change subject: IMPALA-5750: Catch exceptions from boost thread creation

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 10: (1 comment) Also rebased.

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7730/8/be/src/runtime/query-state.cc

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7730/8/be/src/runtime/query-state.cc

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#10). Change subject: IMPALA-5750: Catch exceptions from boost thread creation

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/7730/8/be/src/runtime/query-state.cc

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. IMPALA-5892: Allow reporting status independent of fragment instance Queries can hit an

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (9 comments)

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#9). Change subject: IMPALA-5750: Catch exceptions from boost thread creation ..

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7943 Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. IMPALA-5892: Allow reporting status independent

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7730/7/be/src/exec/kudu-scan-node.cc

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#8). Change subject: IMPALA-5750: Catch exceptions from boost thread creation ..

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/7730/7/be/src/exec/hdfs-scan-node.cc

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 6: (11 comments) http://gerrit.cloudera.org:8080/#/c/7730/6/be/src/exec/kudu-scan-node.cc

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-31 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#7). Change subject: IMPALA-5750: Catch exceptions from boost thread creation ..

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 6: (9 comments) Still going through the comments, but I thought I'd put up some quick

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7730/5/be/src/util/thread.cc File

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-29 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#6). Change subject: IMPALA-5750: Catch exceptions from boost thread creation ..

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#5). Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. IMPALA-5750: Catch exceptions from boost thread creation The boost thread constructor will throw

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/7730/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#4). Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. IMPALA-5750: Catch exceptions from boost thread creation The boost thread constructor will throw

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/7730/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-22 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7640 to look at the new patch set (#10). Change subject: IMPALA-5352: Age out unused file handles from the cache

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-22 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7640 to look at the new patch set (#9). Change subject: IMPALA-5352: Age out unused file handles from the cache

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache .. Patch Set 8: Fixed the run time of disk-io-mgr-test by changing to an interruptible wait. -- To

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-21 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7640 to look at the new patch set (#5). Change subject: IMPALA-5352: Age out unused file handles from the cache ..

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#3). Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. IMPALA-5750: Catch exceptions from boost thread creation The boost thread constructor will throw

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 1: (17 comments) http://gerrit.cloudera.org:8080/#/c/7730/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-20 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7640 to look at the new patch set (#4). Change subject: IMPALA-5352: Age out unused file handles from the cache ..

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache .. Patch Set 2: (12 comments) Also rebased to the latest

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-19 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7640 to look at the new patch set (#3). Change subject: IMPALA-5352: Age out unused file handles from the cache ..

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. IMPALA-5750: Catch exceptions from boost thread creation The boost thread constructor will throw

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7730 Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. IMPALA-5750: Catch exceptions from boost thread creation

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). Change subject: IMPALA-5352: Age out unused file handles from the cache .. IMPALA-5352: Age out unused file handles from the cache Currently, a file handle in the file handle

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-15 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7597 to look at the new patch set (#4). Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded ..

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded .. Patch Set 3: (2 comments) Also rebased to the latest.

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded .. Patch Set 2: (1 comment) Fix long line and fix a backend test I had missed.

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-14 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7597 to look at the new patch set (#3). Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded ..

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded .. IMPALA-5598: Fix excessive dumping in MemLimitExceeded ExecQueryFInstances RPC timeouts in stress tests

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded .. Patch Set 1: (3 comments) Rebased all the way.

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7640 Change subject: IMPALA-5352: Age out unused file handles from the cache .. IMPALA-5352: Age out unused file handles from the cache

[Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations

2017-08-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations .. Patch Set 6: Code-Review+1 This looks good to me. -- To view, visit

[Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations

2017-08-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7597 Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded .. IMPALA-5598: Fix excessive dumping in MemLimitExceeded

[Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end

2017-08-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end .. Patch Set 3: (1 comment)

  1   2   3   >