[kudu-CR] [c++ client] AUTO FLUSH BACKGROUND optimizations

2016-09-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4308 Change subject: [c++ client] AUTO_FLUSH_BACKGROUND optimizations .. [c++ client] AUTO_FLUSH_BACKGROUND optimizations Some optimizations

[kudu-CR] [c++ client] AUTO FLUSH BACKGROUND optimizations

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [c++ client] AUTO_FLUSH_BACKGROUND optimizations .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3224/ -- To view, visit

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-09-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 5: (6 comments)

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-02 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 4: Code-Review+1 (1 comment)

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4180/4/src/kudu/tools/tool_action_cluster.cc File

[kudu-CR] Predicate evaluation pushdown

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/3222/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-02 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#3). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Predicate evaluation pushdown

2016-09-02 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#8). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3223/ -- To view, visit

[kudu-CR] docs: workflow for master migration

2016-09-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: workflow for master migration .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/4300/1//COMMIT_MSG Commit Message: Line 7: docs: workflow

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-02 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4180/3/src/kudu/tools/tool_action_cluster.cc File

[kudu-CR] tool: port log-dump

2016-09-02 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 3: > (3 comments) Thank you for the responses here. -- To view, visit http://gerrit.cloudera.org:8080/4167 To unsubscribe,

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/4180/3/src/kudu/tools/tool_action_cluster.cc File

[kudu-CR] docs: workflow for master migration

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: workflow for master migration .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4300/1/docs/administration.adoc File

[kudu-CR] docs: workflow for master migration

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: docs: workflow for master migration .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3221/ -- To view, visit

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-02 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 4: (6 comments) Consider +1 from me, except one Qn about REMOVE_SERVER below.

[kudu-CR] Update some comments in Tablet impl and rename a method

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Update some comments in Tablet impl and rename a method .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3219/ -- To view, visit

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/3216/ -- To view, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 19: Build Started http://104.196.14.100/job/kudu-gerrit/3220/ -- To view, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-02 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#19). Change subject: KUDU-236 (part 1). Implement tablet history GC .. KUDU-236

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 3). Enable tablet history GC by default .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3217/ -- To view, visit

[kudu-CR] zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d

2016-09-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4293

[kudu-CR] zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d

2016-09-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d .. zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d Fixes

[kudu-CR] docs: workflow for master migration

2016-09-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: docs: workflow for master migration .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/4300/1/docs/administration.adoc File

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [server] clean-up: stringstream --> ostringstream .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4303 To unsubscribe, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Fix kudu-ts-cli crash when there is no data in tablet NULL pointer was being sent in as an

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4303 to look at the new patch set (#3). Change subject: [server] clean-up: stringstream --> ostringstream

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [server] clean-up: stringstream --> ostringstream .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3215/ -- To view, visit

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [server] clean-up: stringstream --> ostringstream .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4303/2/src/kudu/util/mem_tracker.cc File

[kudu-CR] [benchmarks/tpch] introduced AUTO FLUSH BACKGROUND mode

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode .. [benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode Added an ability to run KuduSession in

[kudu-CR] [benchmarks/tpch] introduced AUTO FLUSH BACKGROUND mode

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [server] clean-up: stringstream --> ostringstream .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3214/ -- To view, visit

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [server] clean-up: stringstream --> ostringstream .. Patch Set 1: (1 comment) > (1 comment) > > If you're interested in fixing these kinds of issues, you

[kudu-CR] master: tag master addresses as stable

2016-09-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: master: tag master_addresses as stable .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4298 To unsubscribe, visit

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP) .. Patch Set 1: (7 comments) Just did a quick first pass.

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [server] clean-up: stringstream --> ostringstream .. Patch Set 1: Code-Review+1 LGTM besides Adar's nit. -- To view, visit

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-02 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4305 to review the following change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP) ..

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP) .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3213/ -- To view, visit

[kudu-CR] master: tag master addresses as stable

2016-09-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master: tag master_addresses as stable .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3212/ -- To view, visit

[kudu-CR] master: tag master addresses as stable

2016-09-02 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4298 to look at the new patch set (#2). Change subject: master: tag master_addresses as stable .. master: tag

[kudu-CR] master: tag master addresses as stable

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: master: tag master_addresses as stable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4298/1/src/kudu/master/master_options.cc File

[kudu-CR] [benchmarks/tpch] introduced AUTO FLUSH BACKGROUND mode

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1581 Fix DataFrame read failure when table has Binary Col

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1581 Fix DataFrame read failure when table has Binary Col .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4145 To

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [server] clean-up: stringstream --> ostringstream .. Patch Set 1: (1 comment) If you're interested in fixing these kinds of issues, you can take a crack at

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4303 Change subject: [server] clean-up: stringstream --> ostringstream .. [server] clean-up: stringstream --> ostringstream Replaced