[kudu-CR] KUDU-2099: drop Java 7 support

2019-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12816 ) Change subject: KUDU-2099: drop Java 7 support .. KUDU-2099: drop Java 7 support Two commits merged since 1.9 yield compilation

[kudu-CR] KUDU-2750: Add create and alter timestamp to tables

2019-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12842 ) Change subject: KUDU-2750: Add create and alter timestamp to tables .. KUDU-2750: Add create and alter timestamp to tables Add

[kudu-CR] [maintenance] Add privilege maintenance thread pool for privilege tables and tablets

2019-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12852 ) Change subject: [maintenance] Add privilege maintenance thread pool for privilege tables and tablets .. Patch Set 1: A few questions

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-2750: Add create and alter timestamp to tables

2019-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12842 ) Change subject: KUDU-2750: Add create and alter timestamp to tables .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

2019-03-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 ) Change subject: [blog] a blogpost about location awareness in Kudu .. Patch Set 8: (28 comments)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 1: (6 comments) What happens if you try to add a

[kudu-CR] KUDU-2750: Add create and alter timestamp to tables

2019-03-25 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12842 ) Change subject: KUDU-2750: Add create and alter timestamp to tables .. Patch Set 2: (5 comments)

[kudu-CR] [maintenance] Add privilege maintenance thread pool for privilege tables and tablets

2019-03-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12852 Change subject: [maintenance] Add privilege maintenance thread pool for privilege tables and tablets .. [maintenance] Add privilege

[kudu-CR] KUDU-2750: Add create and alter timestamp to tables

2019-03-25 Thread helifu (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12842 to look at the new patch set (#2). Change subject: KUDU-2750: Add create and alter timestamp to tables

[kudu-CR] KUDU-2744: Expose RPC interface for diff scan

2019-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12592 ) Change subject: KUDU-2744: Expose RPC interface for diff scan .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR] More Jenkins testing

2019-03-25 Thread Mike Percy (Code Review)
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12851 Change subject: More Jenkins testing .. More Jenkins testing Plese don't commit this, either Change-Id:

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-25 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12849 Change subject: KUDU-1711: ColumnSchema supports storing column comment .. KUDU-1711: ColumnSchema supports storing column comment This patch

[kudu-CR] Jenkins test

2019-03-25 Thread Mike Percy (Code Review)
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12850 Change subject: Jenkins test .. Jenkins test Do not commit this Change-Id: Ie40be849d1336eae91cc90c3f3e44215aa0c6578 --- M README.adoc 1

[kudu-CR] KUDU-2744: Expose RPC interface for diff scan

2019-03-25 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12592 to look at the new patch set (#10). Change subject: KUDU-2744: Expose RPC interface for diff scan

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

2019-03-25 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Greg Solovyev, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12119 to look at the new patch set (#8). Change subject: [blog] a blogpost about location awareness in Kudu

[kudu-CR] tablet service: improve error handling specificity

2019-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12840 ) Change subject: tablet_service: improve error handling specificity .. Patch Set 3: Code-Review+2 The test failures look legit. -- To

[kudu-CR] WIP [master] introduced SentryAuthzCache

2019-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryAuthzCache .. Patch Set 4: (6 comments) Haven't reviewed yet, just flipping through.

[kudu-CR] WIP [util] introduce TTL cache

2019-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12825 ) Change subject: WIP [util] introduce TTL cache .. Patch Set 3: (27 comments) http://gerrit.cloudera.org:8080/#/c/12825/3//COMMIT_MSG

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-25 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 1: (1 comment)

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 1: (1 comment)

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-25 Thread Greg Solovyev (Code Review)
Greg Solovyev has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12847 Change subject: [KUDU-1344] Part 1: cmake install for executables .. [KUDU-1344] Part 1: cmake install for executables This change

[kudu-CR] tablet service: improve error handling specificity

2019-03-25 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12840 to look at the new patch set (#3). Change subject: tablet_service: improve error handling specificity

[kudu-CR] tablet service: improve error handling specificity

2019-03-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12840 ) Change subject: tablet_service: improve error handling specificity .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2744: Expose RPC interface for diff scan

2019-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12592 ) Change subject: KUDU-2744: Expose RPC interface for diff scan .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] tablet service: improve error handling specificity

2019-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12840 ) Change subject: tablet_service: improve error handling specificity .. Patch Set 2: (2 comments)

[kudu-CR] tablet server-test-base: make types match schema

2019-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12839 ) Change subject: tablet_server-test-base: make types match schema .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] WIP [util] introduce TTL cache

2019-03-25 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12825 to look at the new patch set (#3). Change subject: WIP [util] introduce TTL cache

[kudu-CR] WIP [master] introduced SentryAuthzCache

2019-03-25 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12833 to look at the new patch set (#4). Change subject: WIP [master] introduced SentryAuthzCache

[kudu-CR] WIP [util] introduce TTL cache

2019-03-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12825 ) Change subject: WIP [util] introduce TTL cache .. Patch Set 2: (6 comments)

[kudu-CR] add document for KUDU-2080

2019-03-25 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12774 ) Change subject: add document for KUDU-2080 .. Patch Set 1: Code-Review+1 +1 (please address Adar's comment on wording) -- To view,

[kudu-CR] [java] Add private diff scan support

2019-03-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12689 ) Change subject: [java] Add private diff scan support .. Patch Set 15: Code-Review+2 -- To view, visit

[kudu-CR] [sentry] Integrate AuthzProvider into CatalogManager

2019-03-25 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11797 ) Change subject: [sentry] Integrate AuthzProvider into CatalogManager .. [sentry] Integrate AuthzProvider into CatalogManager This

[kudu-CR] KUDU-2744: Expose RPC interface for diff scan

2019-03-25 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12592 to look at the new patch set (#9). Change subject: KUDU-2744: Expose RPC interface for diff scan

[kudu-CR] tablet service: improve error handling specificity

2019-03-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12840 ) Change subject: tablet_service: improve error handling specificity .. Patch Set 1: (6 comments)

[kudu-CR] [sentry] Integrate AuthzProvider into CatalogManager

2019-03-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11797 ) Change subject: [sentry] Integrate AuthzProvider into CatalogManager .. Patch Set 16: Code-Review+2 -- To view, visit

[kudu-CR] [sentry] Integrate AuthzProvider into CatalogManager

2019-03-25 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [sentry] Integrate AuthzProvider into CatalogManager .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11797 To unsubscribe,

[kudu-CR] [sentry] Integrate AuthzProvider into CatalogManager

2019-03-25 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11797 ) Change subject: [sentry] Integrate AuthzProvider into CatalogManager .. Patch Set 16: Verified+1 Unrelated flaky

[kudu-CR] tablet service: improve error handling specificity

2019-03-25 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12840 to look at the new patch set (#2). Change subject: tablet_service: improve error handling specificity

[kudu-CR] tablet server-test-base: make types match schema

2019-03-25 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12839 to look at the new patch set (#2). Change subject: tablet_server-test-base: make types match schema ..

[kudu-CR] tablet server-test-base: make types match schema

2019-03-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12839 ) Change subject: tablet_server-test-base: make types match schema .. Patch Set 1: (2 comments)

[kudu-CR] authz: verify tokens on scans

2019-03-25 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11753 ) Change subject: authz: verify tokens on scans .. authz: verify tokens on scans Adds privilege checking to enforce the following

[kudu-CR] authz: verify tokens on scans

2019-03-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11753 ) Change subject: authz: verify tokens on scans .. Patch Set 15: Code-Review+2 Rolling forward Hao's +2 since all that has changed is the

[kudu-CR] tserver: sanitize write op types

2019-03-25 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12815 ) Change subject: tserver: sanitize write op types .. tserver: sanitize write op types We previously wouldn't make sure that

[kudu-CR] KUDU-2099: drop Java 7 support

2019-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12816 ) Change subject: KUDU-2099: drop Java 7 support .. Patch Set 3: Code-Review+1 Agree it would be nice to use a few Java 8 things (eg

[kudu-CR] KUDU-2750: Add create and alter timestamp to tables

2019-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12842 ) Change subject: KUDU-2750: Add create and alter timestamp to tables .. Patch Set 1: (5 comments)

[kudu-CR] KUDU-2099: drop Java 7 support

2019-03-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12816 ) Change subject: KUDU-2099: drop Java 7 support .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12816