[kudu-CR] KUDU-2846 (part 1): optimize predicate evaluation for primitives

2019-06-11 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13591 to look at the new patch set (#4). Change subject: KUDU-2846 (part 1): optimize predicate evaluation for primitives

[kudu-CR] thirdparty: fix build curl some more

2019-06-11 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13593 ) Change subject: thirdparty: fix build_curl some more .. thirdparty: fix build_curl some more As written, the function would

[kudu-CR] [docs] Add 'CLI tools to access a cluster via cluster name' section

2019-06-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13579 ) Change subject: [docs] Add 'CLI tools to access a cluster via cluster name' section .. Patch Set 1: (5 comments) Thanks for doing

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 6: (2 comments)

[kudu-CR] KUDU-2514 Part 2: Supports setting history max age sec for the specified table

2019-06-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13573 ) Change subject: KUDU-2514 Part 2: Supports setting history_max_age_sec for the specified table .. Patch Set 5: Verified+1 Code-Review+2

[kudu-CR] KUDU-2514 Part 2: Supports setting history max age sec for the specified table

2019-06-11 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13573 ) Change subject: KUDU-2514 Part 2: Supports setting history_max_age_sec for the specified table .. KUDU-2514 Part 2: Supports

[kudu-CR] KUDU-2514 Part 2: Supports setting history max age sec for the specified table

2019-06-11 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13573 ) Change subject: KUDU-2514 Part 2: Supports setting history_max_age_sec for the specified table .. Removed reviewer Kudu Jenkins

[kudu-CR] thirdparty: fix build curl some more

2019-06-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13593 ) Change subject: thirdparty: fix build_curl some more .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2514 Part 2: Supports setting history max age sec for the specified table

2019-06-11 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13573 ) Change subject: KUDU-2514 Part 2: Supports setting history_max_age_sec for the specified table .. Patch Set 5: (2 comments) Emm, the

[kudu-CR] thirdparty: fix build curl some more

2019-06-11 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13593 to review the following change. Change subject: thirdparty: fix build_curl some more .. thirdparty:

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 6: (1 comment) How can I fix this issue except wrapping it

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 6: (10 comments)

[kudu-CR] KUDU-2514 Part 2: Supports setting history max age sec for the specified table

2019-06-11 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13573 to look at the new patch set (#5). Change subject: KUDU-2514 Part 2: Supports setting history_max_age_sec for the specified table

[kudu-CR] [metrics] Merge metrics by table

2019-06-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by table .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2846 (part 1): optimize predicate evaluation for primitives

2019-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13591 ) Change subject: KUDU-2846 (part 1): optimize predicate evaluation for primitives .. Patch Set 3: (3 comments) Code looks fine but the

[kudu-CR] KUDU-2846 (part 1): optimize predicate evaluation for primitives

2019-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has removed Andrew Wong from this change. ( http://gerrit.cloudera.org:8080/13591 ) Change subject: KUDU-2846 (part 1): optimize predicate evaluation for primitives .. Removed reviewer Andrew Wong. -- To view,

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 6: (10 comments)

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-2846 (part 1): optimize predicate evaluation for primitives

2019-06-11 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13591 to look at the new patch set (#3). Change subject: KUDU-2846 (part 1): optimize predicate evaluation for primitives

[kudu-CR] [java] Add “default” database to ITBLL

2019-06-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13588 ) Change subject: [java] Add “default” database to ITBLL .. Patch Set 1: Verified-1 (1 comment)

[kudu-CR] [java] Add “default” database to ITBLL

2019-06-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13588 ) Change subject: [java] Add “default” database to ITBLL .. Patch Set 1: (1 comment)

[kudu-CR] Modernize AsyncKuduClient

2019-06-11 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13589 ) Change subject: Modernize AsyncKuduClient .. Modernize AsyncKuduClient Lambdas, etc. There are no functional changes in this

[kudu-CR] [java] Add “default” database to ITBLL

2019-06-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13588 ) Change subject: [java] Add “default” database to ITBLL .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [metrics] Merge metrics by table

2019-06-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by table .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2846 (part 1): optimize predicate evaluation for primitives

2019-06-11 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13591 to look at the new patch set (#2). Change subject: KUDU-2846 (part 1): optimize predicate evaluation for primitives

[kudu-CR] KUDU-2846 (part 1): optimize predicate evaluation for primitives

2019-06-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13591 ) Change subject: KUDU-2846 (part 1): optimize predicate evaluation for primitives .. Patch Set 1: (1 comment)

[kudu-CR] Modernize AsyncKuduClient

2019-06-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13589 ) Change subject: Modernize AsyncKuduClient .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13589 To

[kudu-CR] KUDU-2846 (part 1): optimize predicate evaluation for primitives

2019-06-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13591 ) Change subject: KUDU-2846 (part 1): optimize predicate evaluation for primitives .. Patch Set 1: (1 comment)

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13562 ) Change subject: [java] Favor column ids over column names in scan tokens .. Patch Set 4: (3 comments)

[kudu-CR] KUDU-2846 (part 1): optimize predicate evaluation for primitives

2019-06-11 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13591 to review the following change. Change subject: KUDU-2846 (part 1): optimize predicate evaluation for primitives ..

[kudu-CR] [java] Add “default” database to ITBLL

2019-06-11 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/13588 ) Change subject: [java] Add “default” database to ITBLL .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [java] Add “default” database to ITBLL

2019-06-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13588 ) Change subject: [java] Add “default” database to ITBLL .. Patch Set 1: (1 comment) Yes, it passes when HMS sync is disabled.

[kudu-CR] [java] Add “default” database to ITBLL

2019-06-11 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/13588 ) Change subject: [java] Add “default” database to ITBLL .. Patch Set 1: Will these tests pass with this change when HMS sync is

[kudu-CR] Modernize AsyncKuduClient

2019-06-11 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13589 Change subject: Modernize AsyncKuduClient .. Modernize AsyncKuduClient Lambdas, etc. There are no functional changes in this patch.

[kudu-CR] [java] Add “default” database to ITBLL

2019-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13588 ) Change subject: [java] Add “default” database to ITBLL .. Patch Set 1: (1 comment)

[kudu-CR] docs: Add simplest possible Spark SQL example

2019-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11095 ) Change subject: docs: Add simplest possible Spark SQL example .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [java] Add “default” database to ITBLL

2019-06-11 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13588 Change subject: [java] Add “default” database to ITBLL .. [java] Add “default” database to ITBLL This patch adds “default.” to the

[kudu-CR] docs: Add simplest possible Spark SQL example

2019-06-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11095 ) Change subject: docs: Add simplest possible Spark SQL example .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-11 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13562 to look at the new patch set (#4). Change subject: [java] Favor column ids over column names in scan tokens

[kudu-CR] docs: Add simplest possible Spark SQL example

2019-06-11 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Dan Burkert, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11095 to look at the new patch set (#4). Change subject: docs: Add simplest possible Spark SQL example

[kudu-CR] docs: Add simplest possible Spark SQL example

2019-06-11 Thread Mike Percy (Code Review)
Hello Dan Burkert, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11095 to look at the new patch set (#3). Change subject: docs: Add simplest possible Spark SQL example

[kudu-CR] docs: Add simplest possible Spark SQL example

2019-06-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11095 ) Change subject: docs: Add simplest possible Spark SQL example .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13556 ) Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. KUDU-2841. Expose HMS DB UUID to clients in

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13556 ) Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. Patch Set 2: Verified+1 The failures were all due to

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13556

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-11 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13562 to look at the new patch set (#3). Change subject: [java] Favor column ids over column names in scan tokens

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13562 ) Change subject: [java] Favor column ids over column names in scan tokens .. Patch Set 3: The current revision has a known defect that

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13556 ) Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2514 Part 2: Supports setting history max age sec for the specified table

2019-06-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13573 ) Change subject: KUDU-2514 Part 2: Supports setting history_max_age_sec for the specified table .. Patch Set 4: (2 comments)

[kudu-CR] [build] Fix jar verification via verify jars.pl

2019-06-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13584 ) Change subject: [build] Fix jar verification via verify_jars.pl .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13556 ) Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-11 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13556 to look at the new patch set (#2). Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13556 ) Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. Patch Set 2: (2 comments)

[kudu-CR] [build] Fix jar verification via verify jars.pl

2019-06-11 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13584 ) Change subject: [build] Fix jar verification via verify_jars.pl .. [build] Fix jar verification via verify_jars.pl This patch

[kudu-CR] [build] Fix jar verification via verify jars.pl

2019-06-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13584 ) Change subject: [build] Fix jar verification via verify_jars.pl .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] [build] Fix jar verification via verify jars.pl

2019-06-11 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [build] Fix jar verification via verify_jars.pl .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13584 To unsubscribe,

[kudu-CR] [build] Fix jar verification via verify jars.pl

2019-06-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13584 ) Change subject: [build] Fix jar verification via verify_jars.pl .. Patch Set 1: Code-Review+2 lgtm -- To view, visit

[kudu-CR] [rebalance] Add '--ignored tservers' flag to rebalancer

2019-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13539 ) Change subject: [rebalance] Add '--ignored_tservers' flag to rebalancer .. [rebalance] Add '--ignored_tservers' flag to

[kudu-CR] [rebalance] Add '--ignored tservers' flag to rebalancer

2019-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13539 ) Change subject: [rebalance] Add '--ignored_tservers' flag to rebalancer .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] [rebalance] Add '--ignored tservers' flag to rebalancer

2019-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13539 ) Change subject: [rebalance] Add '--ignored_tservers' flag to rebalancer .. Patch Set 5: Verified+1 It seems test failures are

[kudu-CR] [build] Fix jar verification via verify jars.pl

2019-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13584 ) Change subject: [build] Fix jar verification via verify_jars.pl .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [rebalance] Add '--ignored tservers' flag to rebalancer

2019-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13539 ) Change subject: [rebalance] Add '--ignored_tservers' flag to rebalancer .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [metrics] Merge metrics by table

2019-06-11 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#3). Change subject: [metrics] Merge metrics by table .. [metrics] Merge metrics by

[kudu-CR] [build] Fix RAT report

2019-06-11 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13581 ) Change subject: [build] Fix RAT report .. [build] Fix RAT report This patch fixes the RAT report by fixing the excludes

[kudu-CR] [build] Fix jar verification via verify jars.pl

2019-06-11 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13584 Change subject: [build] Fix jar verification via verify_jars.pl .. [build] Fix jar verification via verify_jars.pl This patch fixes jar

[kudu-CR] [tserver] Move cell size checking to prepare phase

2019-06-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13470 ) Change subject: [tserver] Move cell size checking to prepare phase .. Patch Set 2: (1 comment)

[kudu-CR] [metrics] Merge metrics by table

2019-06-11 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#2). Change subject: [metrics] Merge metrics by table .. [metrics] Merge metrics by

[kudu-CR] [build] Fix RAT report

2019-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13581 ) Change subject: [build] Fix RAT report .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13581 To

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 5: > (5 comments) > > Overall this looks great. Thanks for

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-11 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#6). Change subject: KUDU-2797: the master aggregates tablet metrics

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 5: (16 comments)

[kudu-CR] [build] Fix RAT report

2019-06-11 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13581 Change subject: [build] Fix RAT report .. [build] Fix RAT report This patch fixes the RAT report by fixing the excludes location for the

[kudu-CR] [metrics] Merge metrics by table

2019-06-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13580 Change subject: [metrics] Merge metrics by table .. [metrics] Merge metrics by table This commit merge tablets metrics by table on

[kudu-CR] [tserver] Move cell size checking to prepare phase

2019-06-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13470 ) Change subject: [tserver] Move cell size checking to prepare phase .. Patch Set 2: (2 comments)

[kudu-CR] [tserver] Move cell size checking to prepare phase

2019-06-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13470 ) Change subject: [tserver] Move cell size checking to prepare phase .. Patch Set 2: > Patch Set 2: > > Does this change user-facing

[kudu-CR] [docs] Add 'CLI tools to access a cluster via cluster name' section

2019-06-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13579 Change subject: [docs] Add 'CLI tools to access a cluster via cluster name' section .. [docs] Add 'CLI tools to access a cluster via

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 5: (5 comments) Overall this looks great. Thanks for

[kudu-CR] KUDU-2514 Part 2: Supports setting history max age sec for the specified table

2019-06-11 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13573 ) Change subject: KUDU-2514 Part 2: Supports setting history_max_age_sec for the specified table .. Patch Set 4: (2 comments)