[kudu-CR] [tools] Add get/set extra-configs for CLI tools

2019-06-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13649 ) Change subject: [tools] Add get/set extra-configs for CLI tools .. Patch Set 2: (5 comments) Overall looks good! A few nits and some

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

2019-06-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13669 ) Change subject: [docs] Add 1.10.0 release notes .. Patch Set 1: (12 comments)

[kudu-CR] [tablet copy client-test] fix compiler warning

2019-06-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13674 ) Change subject: [tablet_copy_client-test] fix compiler warning .. [tablet_copy_client-test] fix compiler warning Fixed

[kudu-CR] [tablet copy client-test] fix compiler warning

2019-06-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13674 ) Change subject: [tablet_copy_client-test] fix compiler warning .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tablet copy client-test] fix compiler warning

2019-06-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13674 ) Change subject: [tablet_copy_client-test] fix compiler warning .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [tablet copy client-test] fix compiler warning

2019-06-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13674 ) Change subject: [tablet_copy_client-test] fix compiler warning .. Patch Set 1: Verified+1 Unrelated flakes in TSAN build related to

[kudu-CR] [tablet copy client-test] fix compiler warning

2019-06-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13674 Change subject: [tablet_copy_client-test] fix compiler warning .. [tablet_copy_client-test] fix compiler warning Fixed compilation

[kudu-CR] DeltaPreparer: use vectors instead of deques

2019-06-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13668 ) Change subject: DeltaPreparer: use vectors instead of deques .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2866. Optimize CFileSet::Iterator::FinishBatch

2019-06-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13666 ) Change subject: KUDU-2866. Optimize CFileSet::Iterator::FinishBatch .. Patch Set 2: Code-Review+1 (2 comments)

[kudu-CR] KUDU-2866. Optimize CFileSet::Iterator::FinishBatch

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13666 ) Change subject: KUDU-2866. Optimize CFileSet::Iterator::FinishBatch .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2866. Optimize CFileSet::Iterator::FinishBatch

2019-06-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13666 ) Change subject: KUDU-2866. Optimize CFileSet::Iterator::FinishBatch .. Patch Set 2: (2 comments)

[kudu-CR] DeltaPreparer: use vectors instead of deques

2019-06-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13668 ) Change subject: DeltaPreparer: use vectors instead of deques .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2867. Optimize delta timestamp decoding

2019-06-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13667 ) Change subject: KUDU-2867. Optimize delta timestamp decoding .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2867. Optimize delta timestamp decoding

2019-06-18 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13667 to look at the new patch set (#2). Change subject: KUDU-2867. Optimize delta timestamp decoding ..

[kudu-CR] [docs] Add 1.10.0 release notes

2019-06-18 Thread Grant Henke (Code Review)
Grant Henke has abandoned this change. ( http://gerrit.cloudera.org:8080/13662 ) Change subject: [docs] Add 1.10.0 release notes .. Abandoned See https://gerrit.cloudera.org/#/c/13669/ -- To view, visit

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

2019-06-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13669 Change subject: [docs] Add 1.10.0 release notes .. [docs] Add 1.10.0 release notes Change-Id: I040df9debdf78f1bd932915164a1b6ba490be135

[kudu-CR] KUDU-2866. Optimize CFileSet::Iterator::FinishBatch

2019-06-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13666 ) Change subject: KUDU-2866. Optimize CFileSet::Iterator::FinishBatch .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2867. Optimize delta timestamp decoding

2019-06-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13667 ) Change subject: KUDU-2867. Optimize delta timestamp decoding .. Patch Set 1: Code-Review+1 IWYU failed -- To view, visit

[kudu-CR] DeltaPreparer: use vectors instead of deques

2019-06-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13668 ) Change subject: DeltaPreparer: use vectors instead of deques .. Patch Set 1: Code-Review+1 Looks like there are some IWYU changes

[kudu-CR] DeltaPreparer: use vectors instead of deques

2019-06-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13668 ) Change subject: DeltaPreparer: use vectors instead of deques .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] DeltaPreparer: use vectors instead of deques

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13668 Change subject: DeltaPreparer: use vectors instead of deques .. DeltaPreparer: use vectors instead of deques We had a few std::deque<>s

[kudu-CR] KUDU-2867. Optimize delta timestamp decoding

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13667 Change subject: KUDU-2867. Optimize delta timestamp decoding .. KUDU-2867. Optimize delta timestamp decoding When using hybrid clock,

[kudu-CR] KUDU-2866. Optimize CFileSet::Iterator::FinishBatch

2019-06-18 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13666 to look at the new patch set (#2). Change subject: KUDU-2866. Optimize CFileSet::Iterator::FinishBatch ..

[kudu-CR] KUDU-2381: Optimize DeltaMemStore for case of no matching deltas.

2019-06-18 Thread ZhangYao (Code Review)
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13661 ) Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas. .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2381: Optimize DeltaMemStore for case of no matching deltas.

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13661 ) Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas. .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2381: Optimize DeltaMemStore for case of no matching deltas.

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13661 ) Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas. .. KUDU-2381: Optimize DeltaMemStore for case

[kudu-CR] KUDU-2381: Optimize DeltaMemStore for case of no matching deltas.

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13661 ) Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas. .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2836: Release memory to OS periodically

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2836: Release memory to OS periodically .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13606 To unsubscribe,

[kudu-CR] KUDU-2836: Release memory to OS periodically

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13606 ) Change subject: KUDU-2836: Release memory to OS periodically .. Patch Set 7: Verified+1 Code-Review+2 Test failure seems to be a flake

[kudu-CR] KUDU-2836: Release memory to OS periodically

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13606 ) Change subject: KUDU-2836: Release memory to OS periodically .. KUDU-2836: Release memory to OS periodically In read-only

[kudu-CR] KUDU-2381: Optimize DeltaMemStore for case of no matching deltas.

2019-06-18 Thread ZhangYao (Code Review)
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13661 ) Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas. .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-2381: Optimize DeltaMemStore for case of no matching deltas.

2019-06-18 Thread ZhangYao (Code Review)
Hello Kudu Jenkins, Yao Xu, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13661 to look at the new patch set (#3). Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas.

[kudu-CR] KUDU-2866. Optimize CFileSet::Iterator::FinishBatch

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13666 Change subject: KUDU-2866. Optimize CFileSet::Iterator::FinishBatch .. KUDU-2866. Optimize CFileSet::Iterator::FinishBatch I was running

[kudu-CR] KUDU-2836: Release memory to OS periodically

2019-06-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13606 ) Change subject: KUDU-2836: Release memory to OS periodically .. Patch Set 7: (7 comments)

[kudu-CR] KUDU-2836: Release memory to OS periodically

2019-06-18 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13606 to look at the new patch set (#7). Change subject: KUDU-2836: Release memory to OS periodically

[kudu-CR] KUDU-2381: Optimize DeltaMemStore for case of no matching deltas.

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13661 ) Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas. .. Patch Set 2: (3 comments)