[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. KUDU-1625: background op to GC ancient, fully

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

2020-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15506 ) Change subject: tablet: plumb delta stats into delta compaction outputs .. tablet: plumb delta stats into delta compaction

[kudu-CR] tablet: cache delta stats when flushing a DMS

2020-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15460 ) Change subject: tablet: cache delta stats when flushing a DMS .. tablet: cache delta stats when flushing a DMS This allows us

[kudu-CR] test: add some buffer in timing metrics

2020-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15518 ) Change subject: test: add some buffer in timing metrics .. test: add some buffer in timing metrics We've seen some flakiness in

[kudu-CR] test: add some buffer in timing metrics

2020-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15518 ) Change subject: test: add some buffer in timing metrics .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] tablet: cache delta stats when flushing a DMS

2020-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15460 ) Change subject: tablet: cache delta stats when flushing a DMS .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

2020-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15506 ) Change subject: tablet: plumb delta stats into delta compaction outputs .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

2020-03-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15506 to look at the new patch set (#7). Change subject: tablet: plumb delta stats into delta compaction outputs

[kudu-CR] test: add some buffer in timing metrics

2020-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15518 Change subject: test: add some buffer in timing metrics .. test: add some buffer in timing metrics We've seen some flakiness in

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 9: (3 comments)

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15145 to look at the new patch set (#9). Change subject: KUDU-1625: background op to GC ancient, fully deleted

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

2020-03-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15506 to look at the new patch set (#5). Change subject: tablet: plumb delta stats into delta compaction outputs

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

2020-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15506 ) Change subject: tablet: plumb delta stats into delta compaction outputs .. Patch Set 3: (7 comments)

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

2020-03-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15506 to look at the new patch set (#4). Change subject: tablet: plumb delta stats into delta compaction outputs

[kudu-CR] KUDU-3079 Add MiniRanger

2020-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 16: (43 comments) http://gerrit.cloudera.org:8080/#/c/15483/16//COMMIT_MSG Commit

[kudu-CR] [mini kdc] MiniKdc::Kinit() atomically replaces ccache

2020-03-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15516 ) Change subject: [mini_kdc] MiniKdc::Kinit() atomically replaces ccache .. [mini_kdc] MiniKdc::Kinit() atomically replaces

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 ) Change subject: KUDU-3079 Add MiniPostgres .. Patch Set 15: (20 comments)

[kudu-CR] KUDU-3079 Add MiniRanger

2020-03-20 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 16: (1 comment)

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-20 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15374 to look at the new patch set (#15). Change subject: KUDU-3079 Add MiniPostgres

[kudu-CR] KUDU-3079 Add MiniRanger

2020-03-20 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15483 to look at the new patch set (#16). Change subject: KUDU-3079 Add MiniRanger

[kudu-CR] [mini kdc] MiniKdc::Kinit() atomically replaces ccache

2020-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15516 ) Change subject: [mini_kdc] MiniKdc::Kinit() atomically replaces ccache .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [test] add securityDebug option for Java tests

2020-03-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [test] add securityDebug option for Java tests .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15515 To unsubscribe,

[kudu-CR] [test] add securityDebug option for Java tests

2020-03-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15515 ) Change subject: [test] add securityDebug option for Java tests .. Patch Set 1: Verified+1 Unrelated test failure in

[kudu-CR] [test] add securityDebug option for Java tests

2020-03-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15515 ) Change subject: [test] add securityDebug option for Java tests .. [test] add securityDebug option for Java tests Added

[kudu-CR] [mini kdc] MiniKdc::Kinit() atomically replaces ccache

2020-03-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15516 Change subject: [mini_kdc] MiniKdc::Kinit() atomically replaces ccache .. [mini_kdc] MiniKdc::Kinit() atomically replaces ccache This

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-3079 Add MiniRanger

2020-03-20 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15483 to look at the new patch set (#15). Change subject: KUDU-3079 Add MiniRanger

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 8: (3 comments)

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-20 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 ) Change subject: KUDU-3079 Add MiniPostgres .. Patch Set 14: (1 comment)

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

2020-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15506 ) Change subject: tablet: plumb delta stats into delta compaction outputs .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-3079 Add MiniRanger

2020-03-20 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15483 to look at the new patch set (#14). Change subject: KUDU-3079 Add MiniRanger

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-20 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15374 to look at the new patch set (#14). Change subject: KUDU-3079 Add MiniPostgres

[kudu-CR] [test] add securityDebug option for Java tests

2020-03-20 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15515 ) Change subject: [test] add securityDebug option for Java tests .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [test] add securityDebug option for Java tests

2020-03-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15515 Change subject: [test] add securityDebug option for Java tests .. [test] add securityDebug option for Java tests Added securityDebug

[kudu-CR] [java] use KuduTestHarness in TestSecurity

2020-03-20 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15433 ) Change subject: [java] use KuduTestHarness in TestSecurity .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [java] use KuduTestHarness in TestSecurity

2020-03-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15433 to look at the new patch set (#3). Change subject: [java] use KuduTestHarness in TestSecurity ..

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15145 to look at the new patch set (#8). Change subject: KUDU-1625: background op to GC ancient, fully deleted

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2020-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 7: (7 comments)

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize result batch cell getters by outlining cold path .. client: micro-optimize result batch

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: client: micro-optimize result batch cell getters by outlining cold path .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize result batch cell getters by outlining cold path .. Patch Set 2: Verified+1 failed tests seem

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15502 ) Change subject: tserver: avoid spinlock in scanners hot path .. tserver: avoid spinlock in scanners hot path This replaces a

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 ) Change subject: KUDU-3079 Add MiniPostgres .. Patch Set 6: (1 comment)

[kudu-CR] [util] KUDU-3067 add OpenStack metadata detector

2020-03-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15488 ) Change subject: [util] KUDU-3067 add OpenStack metadata detector .. Patch Set 2: > > > @Alexey Serbin Thanks for address this, LGTM

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-20 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 ) Change subject: KUDU-3079 Add MiniPostgres .. Patch Set 13: (4 comments)

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-20 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15374 to look at the new patch set (#13). Change subject: KUDU-3079 Add MiniPostgres

[kudu-CR] KUDU-3079 Add MiniPostgres

2020-03-20 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15374 to look at the new patch set (#12). Change subject: KUDU-3079 Add MiniPostgres

[kudu-CR] KUDU-3079 Add MiniRanger

2020-03-20 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15483 to look at the new patch set (#12). Change subject: KUDU-3079 Add MiniRanger

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. KUDU-2780: create thread for auto-rebalancing The

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 26: Code-Review+2 LGTM! Thank you for the contribution :)

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 26: Code-Review+2 (2 comments) Looks good enough to me.

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize result batch cell getters by outlining cold path .. Patch Set 2: Code-Review+2 -- To view,

[kudu-CR] [thirdparty] python3 is good for building LLVM

2020-03-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. [thirdparty] python3 is good for building LLVM With python2