[kudu-CR] [client] Add a note that only FAST HASH is supported in Bloom filter predicate

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15608 ) Change subject: [client] Add a note that only FAST_HASH is supported in Bloom filter predicate .. [client] Add a note that only

[kudu-CR] [client] Add a note that only FAST HASH is supported in Bloom filter predicate

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15608 ) Change subject: [client] Add a note that only FAST_HASH is supported in Bloom filter predicate .. Patch Set 1: Code-Review+2 -- To

[kudu-CR] KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15605 ) Change subject: KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace .. KUDU-3093: another band-aid for this

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. gutil: remove callback and bind from the codebase It is

[kudu-CR] KUDU-2059: add a TSAN suppression

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15603 ) Change subject: KUDU-2059: add a TSAN suppression .. KUDU-2059: add a TSAN suppression No one is actively working on fixing

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Remove return types from various lambdas Only the ones that were

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. [util] Add special handling for nullptr in fast hash

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] WIP [release notes] support for RHEL/CentOS 8.1

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15594 ) Change subject: WIP [release notes] support for RHEL/CentOS 8.1 .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15611 ) Change subject: [site] add Yifan Zhang to the committers page .. Patch Set 2: Verified+1 -- To view, visit

[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15611 ) Change subject: [site] add Yifan Zhang to the committers page .. [site] add Yifan Zhang to the committers page Change-Id:

[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page

2020-03-30 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/15611 ) Change subject: [site] add Yifan Zhang to the committers page .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page

2020-03-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15611 ) Change subject: [site] add Yifan Zhang to the committers page .. Patch Set 2: Thank you for updating the page. Indeed, I took a look

[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page

2020-03-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15611 ) Change subject: [site] add Yifan Zhang to the committers page .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page

2020-03-30 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15611 to look at the new patch set (#2). Change subject: [site] add Yifan Zhang to the committers page .. [site] add

[kudu-CR](gh-pages) [site] add Zhang Yifan to the committers page

2020-03-30 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15611 to review the following change. Change subject: [site] add Zhang Yifan to the committers page .. [site] add Zhang

[kudu-CR] [ranger] allow subprocess to log to a file

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15525 ) Change subject: [ranger] allow subprocess to log to a file .. Patch Set 2: (2 comments)

[kudu-CR] [ranger] allow subprocess to log to a file

2020-03-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15525 ) Change subject: [ranger] allow subprocess to log to a file .. Patch Set 2: (2 comments)

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Patch Set 3: Code-Review+2 Thank you for cleaning up these! -- To view,

[kudu-CR] [ranger] allow subprocess to log to a file

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15525 ) Change subject: [ranger] allow subprocess to log to a file .. Patch Set 2: (2 comments)

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. Patch Set 1: (1 comment)

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-30 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15609 Change subject: [ranger] authorize list tables should never throw NotAuthorized .. [ranger] authorize list tables should never throw

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Patch Set 3: > Patch Set 3: Verified-1 > > Build Failed > >

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2059: add a TSAN suppression

2020-03-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15603 ) Change subject: KUDU-2059: add a TSAN suppression .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [client] Add a note that only FAST HASH is supported in Bloom filter predicate

2020-03-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15608 Change subject: [client] Add a note that only FAST_HASH is supported in Bloom filter predicate .. [client] Add a note that only

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15600 to look at the new patch set (#3). Change subject: [util] Add special handling for nullptr in fast hash

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 3: (10 comments)

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] WIP [release notes] support for RHEL/CentOS 8.1

2020-03-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15594 to look at the new patch set (#2). Change subject: WIP [release notes] support for RHEL/CentOS 8.1 ..

[kudu-CR] WIP [release notes] support for RHEL/CentOS 8.1

2020-03-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15594 ) Change subject: WIP [release notes] support for RHEL/CentOS 8.1 .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace

2020-03-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15605 ) Change subject: KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace .. Patch Set 2: Code-Review+2 -- To view,

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15602 ) Change subject: tserver: add support for returning scan result in columnar layout .. Patch Set 2: (10 comments)

[kudu-CR] [docs] added RHEL/CentOS 8 into the list of supported systems

2020-03-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15595 ) Change subject: [docs] added RHEL/CentOS 8 into the list of supported systems .. [docs] added RHEL/CentOS 8 into the list of

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Patch Set 3: (1 comment)

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Patch Set 3: (1 comment)

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Patch Set 3: Code-Review+1 (1 comment)

[kudu-CR] KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15605 to look at the new patch set (#2). Change subject: KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace

[kudu-CR] KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15605 ) Change subject: KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace .. Patch Set 2: (1 comment)

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-3093: another band-aid for this test

2020-03-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15605 ) Change subject: KUDU-3093: another band-aid for this test .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-30 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15601 to look at the new patch set (#3). Change subject: KUDU-3081 Add Kerberos support to MiniRanger

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 1: (21 comments) the rebase on master somehow introduced

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15600 to look at the new patch set (#2). Change subject: [util] Add special handling for nullptr in fast hash

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-30 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15601 to look at the new patch set (#2). Change subject: KUDU-3081 Add Kerberos support to MiniRanger

[kudu-CR] KUDU-3093: another band-aid for this test

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15605 to review the following change. Change subject: KUDU-3093: another band-aid for this test ..

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Patch Set 3: Verified+1 Overriding Jenkins, unrelated test failure for which

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 1: (21 comments)

[kudu-CR] KUDU-2059: add a TSAN suppression

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15603 to review the following change. Change subject: KUDU-2059: add a TSAN suppression .. KUDU-2059: add a

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Add functionality to serialize a RowBlock into

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15602 to look at the new patch set (#2). Change subject: tserver: add support for returning scan result in columnar layout

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Patch Set 2: Verified+1 Overriding Jenkins, unrelated test failures (and

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Patch Set 1: (4 comments)

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. Patch Set 4: (4 comments)

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15583 to look at the new patch set (#5). Change subject: gutil: remove callback and bind from the codebase

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15582 ) Change subject: consensus: remove kudu::Bind usage from dirty callbacks .. consensus: remove kudu::Bind usage from dirty

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15582 ) Change subject: consensus: remove kudu::Bind usage from dirty callbacks .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15582 ) Change subject: consensus: remove kudu::Bind usage from dirty callbacks .. Patch Set 3: Verified+1 Overriding Jenkins, KUDU-2059. --

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15582 ) Change subject: consensus: remove kudu::Bind usage from dirty callbacks .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. Patch Set 4: (2 comments)

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-30 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15602 to review the following change. Change subject: tserver: add support for returning scan result in columnar layout ..

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-30 Thread Attila Bukor (Code Review)
Attila Bukor has removed Anonymous Coward (314) from this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Removed reviewer null. -- To view, visit

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15560 to look at the new patch set (#7). Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-30 Thread Attila Bukor (Code Review)
Hello Andrew Wong, Anonymous Coward (314), Adar Dembo, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15601 to review the following change. Change subject: KUDU-3081 Add Kerberos support to MiniRanger

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15582 ) Change subject: consensus: remove kudu::Bind usage from dirty callbacks .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15600 Change subject: [util] Add special handling for nullptr in fast hash .. [util] Add special handling for nullptr in fast hash

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. Patch Set 4: Code-Review+1 (2 comments)

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 6: Code-Review+2 (2 comments) IWYU's still

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15599 to look at the new patch set (#2). Change subject: Remove return types from various lambdas

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15583 to look at the new patch set (#4). Change subject: gutil: remove callback and bind from the codebase

[kudu-CR] gutil: remove BASE EXPORT

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15576 ) Change subject: gutil: remove BASE_EXPORT .. gutil: remove BASE_EXPORT The various definitions of BASE_EXPORT cause IWYU to

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15582 ) Change subject: consensus: remove kudu::Bind usage from dirty callbacks .. Patch Set 2: (5 comments)

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15599 Change subject: Remove return types from various lambdas .. Remove return types from various lambdas Only the ones that were absolutely

[kudu-CR] rpc: remove kudu::Bind usage from ServerPicker

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15578 ) Change subject: rpc: remove kudu::Bind usage from ServerPicker .. rpc: remove kudu::Bind usage from ServerPicker Snuck in a Bind

[kudu-CR] tracing: remove kudu::Bind usage from various callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15580 ) Change subject: tracing: remove kudu::Bind usage from various callbacks .. tracing: remove kudu::Bind usage from various

[kudu-CR] logging: remove kudu::Bind usage from LoggingCallback

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15577 ) Change subject: logging: remove kudu::Bind usage from LoggingCallback .. logging: remove kudu::Bind usage from LoggingCallback

[kudu-CR] fs: remove kudu::Bind usage from ErrorManager

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15579 ) Change subject: fs: remove kudu::Bind usage from ErrorManager .. fs: remove kudu::Bind usage from ErrorManager Change-Id:

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15582 to look at the new patch set (#3). Change subject: consensus: remove kudu::Bind usage from dirty callbacks

[kudu-CR] env: remove kudu::Bind usage from Walk

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15575 ) Change subject: env: remove kudu::Bind usage from Walk .. env: remove kudu::Bind usage from Walk This isn't as elegant as the

[kudu-CR] fs: remove kudu::Bind usage from DataDir closures

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15581 ) Change subject: fs: remove kudu::Bind usage from DataDir closures .. fs: remove kudu::Bind usage from DataDir closures

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. Patch Set 2: (1 comment)

[kudu-CR] subprocess: use a fifo instead of stdout for IO

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15574 ) Change subject: subprocess: use a fifo instead of stdout for IO .. subprocess: use a fifo instead of stdout for IO Today,

[kudu-CR] env: add a fifo class

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15584 ) Change subject: env: add a fifo class .. env: add a fifo class This adds a basic Fifo class and a PosixFifo variant that

[kudu-CR] subprocess: use a fifo instead of stdout for IO

2020-03-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15574 ) Change subject: subprocess: use a fifo instead of stdout for IO .. Patch Set 7: Code-Review+2 (2 comments) Thanks a lot Andrew for the

[kudu-CR] subprocess: use a fifo instead of stdout for IO

2020-03-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15574 ) Change subject: subprocess: use a fifo instead of stdout for IO .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] env: add a fifo class

2020-03-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15584 ) Change subject: env: add a fifo class .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15584 To

[kudu-CR] subprocess: use a fifo instead of stdout for IO

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15574 ) Change subject: subprocess: use a fifo instead of stdout for IO .. Patch Set 7: (1 comment)

[kudu-CR] env: add a fifo class

2020-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15584 ) Change subject: env: add a fifo class .. Patch Set 5: (1 comment)

[kudu-CR] env: add a fifo class

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15584 ) Change subject: env: add a fifo class .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15584 To

[kudu-CR] env: add a fifo class

2020-03-30 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15584 to look at the new patch set (#5). Change subject: env: add a fifo class .. env: add a fifo

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15560 to look at the new patch set (#6). Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 5: (10 comments)

  1   2   >