[kudu-CR] KUDU-3498 Scanner keeps alive in periodically

Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/20282/2//C

[kudu-CR] KUDU-3498 Scanner keeps alive in periodically

Hello Mahesh Reddy, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20282 to look at the new patch set (#3). Change subject: KUDU-3498 Scanner keeps alive in periodically .

[kudu-CR] KUDU-3498 Scanner keeps alive in periodically

Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/20282/2/

[kudu-CR](branch-1.17.x) [clock] fix HybridClockTest.TimeSourceAutoSelection

Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20335 ) Change subject: [clock] fix HybridClockTest.TimeSourceAutoSelection .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.clouder

[kudu-CR](branch-1.17.x) [clock] fix HybridClockTest.TimeSourceAutoSelection

Yingchun Lai has removed a vote on this change. Change subject: [clock] fix HybridClockTest.TimeSourceAutoSelection .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20335 To unsubscri

[kudu-CR] [tools] Enable 'kudu test' CLI tool when -DKUDU CLI TOOL NO TESTS=0

Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 ) Change subject: [tools] Enable 'kudu test' CLI tool when -DKUDU_CLI_TOOL_NO_TESTS=0 .. Patch Set 2: (1 comment) http://gerrit.clouder

[kudu-CR](branch-1.17.x) [build-support] fix build on CentOS/RHEL

Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20334 ) Change subject: [build-support] fix build on CentOS/RHEL .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR](branch-1.17.x) [clock] fix HybridClockTest.TimeSourceAutoSelection

Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20335 ) Change subject: [clock] fix HybridClockTest.TimeSourceAutoSelection .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR] [logging] Call GetLoggingDirectories before first write

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20292 ) Change subject: [logging] Call GetLoggingDirectories before first write .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] [tools] Enable 'kudu test' CLI tool when -DKUDU CLI TOOL NO TESTS=0

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 ) Change subject: [tools] Enable 'kudu test' CLI tool when -DKUDU_CLI_TOOL_NO_TESTS=0 .. Patch Set 1: (1 comment) http://gerrit.cloude

[kudu-CR](branch-1.17.x) [clock] fix HybridClockTest.TimeSourceAutoSelection

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20335 Change subject: [clock] fix HybridClockTest.TimeSourceAutoSelection .. [clock] fix HybridClockTest.TimeSourceAutoSelection It was repor

[kudu-CR](branch-1.17.x) [build-support] fix build on CentOS/RHEL

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20334 ) Change subject: [build-support] fix build on CentOS/RHEL .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20334/1//COM

[kudu-CR](branch-1.17.x) [build-support] fix build on CentOS/RHEL

Hello Abhishek Chennaka, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/20334 to review the following change. Change subject: [build-support] fix build on CentOS/RHEL .. [build-support] fix

[kudu-CR] [consensus] clean-up on OpId utilities

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20320 ) Change subject: [consensus] clean-up on OpId utilities .. [consensus] clean-up on OpId utilities This patch cleans up the code

[kudu-CR] [consensus] clean-up on OpId utilities

Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20320 ) Change subject: [consensus] clean-up on OpId utilities .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] [consensus] clean-up on OpId utilities

Alexey Serbin has removed a vote on this change. Change subject: [consensus] clean-up on OpId utilities .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20320 To unsubscribe, visit ht

[kudu-CR] [consensus] clean-up on OpId utilities

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20320 ) Change subject: [consensus] clean-up on OpId utilities .. Patch Set 2: Verified+1 unrelated test failure in ConcurrentRebalancersTest.

[kudu-CR] [consensus] clean-up on OpId utilities

Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20320 ) Change subject: [consensus] clean-up on OpId utilities .. Patch Set 2: Verified+1 Code-Review+2 Unrelated failures. -- To view,

[kudu-CR] [consensus] clean-up on OpId utilities

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20320 ) Change subject: [consensus] clean-up on OpId utilities .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/20320/1/src/k

[kudu-CR] [consensus] clean-up on OpId utilities

Hello Mahesh Reddy, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20320 to look at the new patch set (#2). Change subject: [consensus] clean-up on OpId utilities .

[kudu-CR] [mvcc] use operator==() instead of Equals()

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20325 ) Change subject: [mvcc] use operator==() instead of Equals() .. [mvcc] use operator==() instead of Equals() This patch replaces

[kudu-CR] [mvcc] use operator==() instead of Equals()

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20325 ) Change subject: [mvcc] use operator==() instead of Equals() .. Patch Set 2: Verified+1 unrelated test failure in TxnOpDispatcherITest.

[kudu-CR] [mvcc] use operator==() instead of Equals()

Alexey Serbin has removed a vote on this change. Change subject: [mvcc] use operator==() instead of Equals() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20325 To unsubscribe, vis

[kudu-CR] [mvcc] use operator==() instead of Equals()

Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20325 ) Change subject: [mvcc] use operator==() instead of Equals() .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] [consensus] clean-up on OpId utilities

Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20320 ) Change subject: [consensus] clean-up on OpId utilities .. Patch Set 1: (1 comment) Apart from Mahesh's questions rest all looks g

[kudu-CR] [tools] Enable 'kudu test' CLI tool when -DKUDU CLI TOOL NO TESTS=0

Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 ) Change subject: [tools] Enable 'kudu test' CLI tool when -DKUDU_CLI_TOOL_NO_TESTS=0 .. Patch Set 2: > Patch Set 1: > > (1 comment) Su

[kudu-CR] [tools] Enable 'kudu test' CLI tool when -DKUDU CLI TOOL NO TESTS=0

Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20326 to look at the new patch set (#2). Change subject: [tools] Enable 'kudu test' CLI tool when -DKUDU_CLI_TOOL_NO_TESTS=0

[kudu-CR] [mvcc] use operator==() instead of Equals()

Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20325 ) Change subject: [mvcc] use operator==() instead of Equals() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] [tools] Enable 'kudu test' CLI tool when -DNO TESTS=1

Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 ) Change subject: [tools] Enable 'kudu test' CLI tool when -DNO_TESTS=1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR] KUDU-3497 optimize leader rebalancer algorithm

Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20310 to look at the new patch set (#4). Change subject: KUDU-3497 optimize leader rebalancer algorithm ...

[kudu-CR] KUDU-3495 Initialize the bitmap while decoding insert/upsert

Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20327 ) Change subject: KUDU-3495 Initialize the bitmap while decoding insert/upsert .. Patch Set 1: Hi, I'm not sure this is a bug. But in my

[kudu-CR] KUDU-3495 Initialize the bitmap while decoding insert/upsert

Song Jiacheng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20327 Change subject: KUDU-3495 Initialize the bitmap while decoding insert/upsert .. KUDU-3495 Initialize the bitmap while decoding insert/up

[kudu-CR] KUDU-3497 optimize leader rebalancer algorithm

Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20310 ) Change subject: KUDU-3497 optimize leader rebalancer algorithm .. Patch Set 3: > (16 comments) All the changes are done and added a t

[kudu-CR] KUDU-3497 optimize leader rebalancer algorithm

Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20310 ) Change subject: KUDU-3497 optimize leader rebalancer algorithm .. Patch Set 3: > (1 comment) Hi, thanks for your review. I added the

[kudu-CR] KUDU-3497 optimize leader rebalancer algorithm

Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20310 ) Change subject: KUDU-3497 optimize leader rebalancer algorithm .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/20310

[kudu-CR] KUDU-3497 optimize leader rebalancer algorithm

Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20310 to look at the new patch set (#3). Change subject: KUDU-3497 optimize leader rebalancer algorithm .

[kudu-CR] [tools] Enable 'kudu test' CLI tool when -DNO TESTS=1

Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 ) Change subject: [tools] Enable 'kudu test' CLI tool when -DNO_TESTS=1 .. Patch Set 1: Verified+1 The failed test AutoAddMasterTest.Test

[kudu-CR] [tools] Enable 'kudu test' CLI tool when -DNO TESTS=1

Yingchun Lai has removed a vote on this change. Change subject: [tools] Enable 'kudu test' CLI tool when -DNO_TESTS=1 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20326 To unsubsc

[kudu-CR] [logging] Call GetLoggingDirectories before first write

Hello Marton Greber, Alexey Serbin, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20292 to look at the new patch set (#5). Change subject: [logging] Call GetLoggingDirectories before first write

[kudu-CR] [tools] Enable 'kudu test' CLI tool when -DNO TESTS=1

Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20326 Change subject: [tools] Enable 'kudu test' CLI tool when -DNO_TESTS=1 .. [tools] Enable 'kudu test' CLI tool when -DNO_TESTS=1 'kudu tes