[kudu-CR] Add missing pb util proto dependency to token proto

2017-02-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add missing pb_util_proto dependency to token_proto .. Add missing pb_util_proto dependency to token_proto Change-Id:

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: compaction: Add additional validation in DeltaTracker .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5919 To

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#10). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#9). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Make Boost a regular dependency .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5818/5//COMMIT_MSG Commit Message: PS5,

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: compaction: Add additional validation in DeltaTracker .. Patch Set 1: (3 comments)

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Make Boost a regular dependency .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5818/1/CMakeLists.txt File CMakeLists.txt:

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 2: Verified+1 Overriding jenkins (unrelated jenkins flakes). also tested

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#8). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Make Boost a regular dependency .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/5818/5//COMMIT_MSG Commit Message: PS5,

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#7). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: (1 comment)

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#6). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread David Ribeiro Alves (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5894 to look at the new patch set (#2). Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Make Boost a regular dependency .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5818/4/thirdparty/build-definitions.sh File

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#5). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5894 Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. [thirdparty] Avoid building tsan on macOS on

[kudu-CR] exactly once rpc-test: properly propagate sleep parameter

2017-02-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: exactly_once_rpc-test: properly propagate sleep parameter .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5883 To

[kudu-CR] [timestamp] Build and and add boost's date time lib

2017-01-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Build and and add boost's date_time lib .. Patch Set 1: (1 comment)

[kudu-CR] [timestamp] Build and and add boost's date time lib

2017-01-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Build and and add boost's date_time lib .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1835 (part 2): enable WAL compression .. Patch Set 9: just a tiny nit, feel free to ignore or fix and keep the +2 -- To view, visit

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1835 (part 2): enable WAL compression .. Patch Set 9: Code-Review+2 (1 comment)

[kudu-CR] WIP: Add a new TIMESTAMP type

2017-01-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5819 to look at the new patch set (#3). Change subject: WIP: Add a new TIMESTAMP type .. WIP: Add a new TIMESTAMP type

[kudu-CR] WIP: Add a new TIMESTAMP type

2017-01-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: WIP: Add a new TIMESTAMP type .. WIP: Add a new TIMESTAMP type This adds a new timestamp type that matches Impala's. The new type can be used as a key and

[kudu-CR] [timestamp] Build and and add boost's date time lib

2017-01-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5818 Change subject: [timestamp] Build and and add boost's date_time lib .. [timestamp] Build and and add boost's date_time lib

[kudu-CR] WIP: Add a new TIMESTAMP type

2017-01-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5819 Change subject: WIP: Add a new TIMESTAMP type .. WIP: Add a new TIMESTAMP type This adds a new timestamp type that matches

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1835 (part 2): enable WAL compression .. Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/5736/8/src/kudu/consensus/log.cc File

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5737 To unsubscribe, visit

[kudu-CR] [kudu-jepsen] fixed misprints in packaged mode

2017-01-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] fixed misprints in packaged mode .. Patch Set 1: (1 comment) also are you sure that the regular jenkins job would not be broken by the

[kudu-CR] [kudu-jepsen] added Jenkins script

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] added Jenkins script .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5624 To unsubscribe, visit

[kudu-CR] [kudu-jepsen] added Jenkins script

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] added Jenkins script .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/5624/6//COMMIT_MSG Commit Message: PS6, Line 12:

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 22: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5492 To unsubscribe, visit

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [kudu-jepsen] Kudu Jepsen tests .. [kudu-jepsen] Kudu Jepsen tests This patch contains David's code for the initial kudu-jepsen tests as it was

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 22: I'm merging this anyway. We can address any docker specific issues in follow up patches. -- To view,

[kudu-CR] docs: clarify guidelines on boost usage

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: docs: clarify guidelines on boost usage .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5752 To unsubscribe, visit

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 18: (7 comments) final q: does this still work with docker instances?

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: still planning on adding those numbers? -- To view, visit

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5737/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] Kudu Jepsen Tests - Initial Commit

2016-12-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#12). Change subject: Kudu Jepsen Tests - Initial Commit .. Kudu Jepsen Tests -

[kudu-CR] Kudu Jepsen Tests - Initial Commit

2016-12-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#11). Change subject: Kudu Jepsen Tests - Initial Commit .. Kudu Jepsen Tests -

[kudu-CR] Kudu Jepsen Tests - Initial Commit

2016-12-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#10). Change subject: Kudu Jepsen Tests - Initial Commit .. Kudu Jepsen Tests -

[kudu-CR] Kudu Jepsen Tests - Initial Commit

2016-12-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Kudu Jepsen Tests - Initial Commit .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/5492/9/build-support/jenkins/toolchains.xml File

[kudu-CR] Kudu Jepsen Tests - Initial Commit

2016-12-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#9). Change subject: Kudu Jepsen Tests - Initial Commit .. Kudu Jepsen Tests -

[kudu-CR] Kudu Jepsen Tests - Initial Commit

2016-12-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#7). Change subject: Kudu Jepsen Tests - Initial Commit .. Kudu Jepsen Tests -

[kudu-CR] KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER

2016-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5488 To

[kudu-CR] [delete table-test] parameterized DeleteTableWhileScanInProgress

2016-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [delete_table-test] parameterized DeleteTableWhileScanInProgress .. Patch Set 2: Code-Review+2 lgtm modulo Will's nits -- To view, visit

[kudu-CR] WIP: KUDU-1369. client: fail over scans to a new replica if current replica is out-of-date

2016-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1369. client: fail over scans to a new replica if current replica is out-of-date .. Patch Set 1: anything in here you think we should still

[kudu-CR] WIP: KUDU-1622. Stripe the ResultTracker to lessen contention

2016-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1622. Stripe the ResultTracker to lessen contention .. Patch Set 1: with your recent changes is striping still needed? -- To view, visit

[kudu-CR] Fix bug in incorrect response rebuilding on tablet boostrap

2016-12-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5489 to look at the new patch set (#2). Change subject: Fix bug in incorrect response rebuilding on tablet boostrap ..

[kudu-CR] Fix bug in incorrect response rebuilding on tablet boostrap

2016-12-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5489 Change subject: Fix bug in incorrect response rebuilding on tablet boostrap .. Fix bug in incorrect response rebuilding on tablet

[kudu-CR] Test for bug in exactly-once during tablet bootstrap

2016-12-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5417 to look at the new patch set (#3). Change subject: Test for bug in exactly-once during tablet bootstrap .. Test

[kudu-CR] WIP Fix exactly once bug in tablet bootstrap

2016-12-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: WIP Fix exactly_once bug in tablet bootstrap .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5432 To unsubscribe, visit

[kudu-CR] WIP: bug in exactly-once during tablet bootstrap

2016-12-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: bug in exactly-once during tablet bootstrap .. Patch Set 2: I figured out the bug. Will post a fix soon -- To view, visit

[kudu-CR] WIP: bug in exactly-once during tablet bootstrap

2016-12-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: bug in exactly-once during tablet bootstrap .. Patch Set 2: After digging around a bit more. I think the problem is a bit more insidious than us

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 continue scan if tablet is being deleted .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5346 To unsubscribe,

[kudu-CR] WIP: bug in exactly-once during tablet bootstrap

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: bug in exactly-once during tablet bootstrap .. Patch Set 2: oops sorry ended up rebasing your patch on master -- To view, visit

[kudu-CR] WIP Fix exactly once bug in tablet bootstrap

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5432 Change subject: WIP Fix exactly_once bug in tablet bootstrap .. WIP Fix exactly_once bug in tablet bootstrap Change-Id:

[kudu-CR] WIP: bug in exactly-once during tablet bootstrap

2016-12-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5417 to look at the new patch set (#2). Change subject: WIP: bug in exactly-once during tablet bootstrap .. WIP: bug in

[kudu-CR] Fix linked list-test flakiness

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5424 Change subject: Fix linked_list-test flakiness .. Fix linked_list-test flakiness A recent patch changed this test to do a

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 7: (1 comment)

[kudu-CR] Remove the clock from MvccManager

2016-12-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5326 to look at the new patch set (#6). Change subject: Remove the clock from MvccManager .. Remove the clock from

[kudu-CR] Remove the clock from MvccManager

2016-12-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5326 to look at the new patch set (#5). Change subject: Remove the clock from MvccManager .. Remove the clock from

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 continue scan if tablet is being deleted .. Patch Set 6: (2 comments) lgtm, excepting nits. see my comment on the test patch though.

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798 (part 5) Correct safe time advancement This patch fixes safe time advancement in

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 34: Verified+1 overriding jenkins, all tests passed but debug build failed due to: 05:06:31

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#34). Change subject: KUDU-798 (part 5) Correct safe time advancement ..

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#33). Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 32: (35 comments) http://gerrit.cloudera.org:8080/#/c/5240/32//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 30: I won't address any more tidy bot nits that aren't part of the changes in this patch.

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 28: (12 comments) http://gerrit.cloudera.org:8080/#/c/5240/27//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#30). Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#29). Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798

[kudu-CR] KUDU-1753 [tablet service] continue scan request on deleted tablet

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [tablet_service] continue scan request on deleted tablet .. Patch Set 5: ha, my bad. Thought this was an old test that was disabled due to

[kudu-CR] KUDU-1753 [tablet service] continue scan request on deleted tablet

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [tablet_service] continue scan request on deleted tablet .. Patch Set 5: Did you make sure the test is not flaky anymore? -- To view, visit

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 28: (3 comments)

[kudu-CR] WIP integration test for snapshot scans

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: WIP integration test for snapshot scans .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5375 To unsubscribe, visit

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5305 To unsubscribe, visit

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#28). Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798

[kudu-CR] Silence gcc warning on TimeManager::GetSafeTimeUnlocked()

2016-12-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Silence gcc warning on TimeManager::GetSafeTimeUnlocked() .. Silence gcc warning on TimeManager::GetSafeTimeUnlocked() gcc is issuing this

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 27: (1 comment)

[kudu-CR] Silence gcc warning on TimeManager::GetSafeTimeUnlocked()

2016-12-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5381 Change subject: Silence gcc warning on TimeManager::GetSafeTimeUnlocked() .. Silence gcc warning on

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#8). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#7). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#6). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#4). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#5). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#27). Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#3). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] [NOT FOR REVIEW WIP] Design doc for repeatable reads

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5229 to look at the new patch set (#10). Change subject: [NOT FOR REVIEW WIP] Design doc for repeatable reads .. [NOT

[kudu-CR] Leader leases

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: Leader leases .. Abandoned oops pushed some old half-baked stuff -- To view, visit http://gerrit.cloudera.org:8080/5376 To unsubscribe, visit

[kudu-CR] Leader leases

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5376 Change subject: Leader leases .. Leader leases Change-Id: I7776ad5c65f9c79a7437d8226b59398762dbd6d4 --- M

[kudu-CR] Remove the clock from MvccManager

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5326 to look at the new patch set (#4). Change subject: Remove the clock from MvccManager .. Remove the clock from

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5305 to look at the new patch set (#4). Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time

[kudu-CR] WIP integration test for snapshot scans

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#2). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] Output more info when a snapshot scan fails due to history gc

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5374 to look at the new patch set (#4). Change subject: Output more info when a snapshot scan fails due to history gc ..

[kudu-CR] Output more info when a snapshot scan fails due to history gc

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Output more info when a snapshot scan fails due to history gc .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. KUDU-798 (part 4) Add a TimeManager to manage safe time advancement This

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 18: Code-Review+2 keeping todd's previous +2 since I fixed the nit --

<    5   6   7   8   9   10   11   12   13   14   >