[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-18 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. KUDU-2069 p3: add RPC endpoint for maintenance mode This

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 6: Code-Review+2 (1 comment) Carrying forward the +2

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 4: Code-Review+1 (1 comment) LGTM, but it seems

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: (12 comments)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-17 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14221 to look at the new patch set (#3). Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: Code-Review+1 (3 comments)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: (8 comments) overall looks good, just a few nits

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: Verified+1 Failed test was KUDU-1736 -- To view,

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14221 To

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14221 to look at the new patch set (#2). Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode ..

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14221 Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. KUDU-2069 p3: add RPC endpoint for maintenance mode This patch