[kudu-CR] KUDU-1865: Avoid heap allocation for payload slices

2017-07-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/7471 Change subject: KUDU-1865: Avoid heap allocation for payload slices .. KUDU-1865: Avoid heap allocation for payload slices As shown in

[kudu-CR] Integrate Mustache templates to webserver

2017-07-19 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7448 to look at the new patch set (#6). Change subject: Integrate Mustache templates to webserver .. Integrate Mustache

[kudu-CR] disk failure: coordinate error handling

2017-07-19 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7029 to look at the new patch set (#21). Change subject: disk failure: coordinate error handling .. disk failure:

[kudu-CR] KUDU-2068: pass --gcc-toolchain into clang codegen build

2017-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-2068: pass --gcc-toolchain into clang codegen build .. KUDU-2068: pass --gcc-toolchain into clang codegen build As a brief refresher: Kudu can be

[kudu-CR] kudu-spark-tools: Spark tool for Import & Export different format of files such as parquet,avro,csv in and to from kudu tables kudu-client-tools: mapreduced base export to csv and import par

2017-07-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: kudu-spark-tools: Spark tool for Import & Export different format of files such as parquet,avro,csv in and to from kudu tables kudu-client-tools: mapreduced base export to csv and import parquet files.

[kudu-CR] kudu-spark-tools: Spark tool for Import & Export different format of files such as parquet,avro,csv in and to from kudu tables kudu-client-tools: mapreduced base export to csv and import par

2017-07-19 Thread Sandish Kumar HN (Code Review)
Sandish Kumar HN has posted comments on this change. Change subject: kudu-spark-tools: Spark tool for Import & Export different format of files such as parquet,avro,csv in and to from kudu tables kudu-client-tools: mapreduced base export to csv and import parquet files.

[kudu-CR](branch-1.3.x) [security] fixed shortened TSK validity interval

2017-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] fixed shortened TSK validity interval .. Patch Set 1: > Hey Alexey. That link isn't publicly accessible, maybe worth > explaining what the problem

[kudu-CR](branch-1.3.x) [security] fixed shortened TSK validity interval

2017-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [security] fixed shortened TSK validity interval .. Abandoned After some discussion with Dan, JD and Todd, it was decided to abandon this patch. -- To view, visit

[kudu-CR] Upgrade to cmake 3.9.0

2017-07-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Upgrade to cmake 3.9.0 .. Upgrade to cmake 3.9.0 Change-Id: I6e5504bcb136e70a5e5c83ee95c98df3cad4d3bd Reviewed-on: http://gerrit.cloudera.org:8080/7460

[kudu-CR](branch-1.3.x) [security] added TokenSigner::IsCurrentKeyValid() method

2017-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [security] added TokenSigner::IsCurrentKeyValid() method .. Abandoned This patch is not needed since after some discussion with Dan, JD and Todd, it was decided to

[kudu-CR](gh-pages) Add a note in the YCSB post

2017-07-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a note in the YCSB post .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7396 To unsubscribe, visit

[kudu-CR] [tools] Add a 'kudu tablet relocate' tool

2017-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] Add a 'kudu tablet relocate' tool .. Patch Set 4: (22 comments) http://gerrit.cloudera.org:8080/#/c/7444/4//COMMIT_MSG Commit Message: Line 18: tablet

[kudu-CR] Integrate Mustache templates to webserver

2017-07-19 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7448 to look at the new patch set (#9). Change subject: Integrate Mustache templates to webserver .. Integrate Mustache

[kudu-CR](gh-pages) Add a note in the YCSB post

2017-07-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add a note in the YCSB post .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7396 To unsubscribe, visit

[kudu-CR](gh-pages) Add a note in the YCSB post

2017-07-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add a note in the YCSB post .. Add a note in the YCSB post Last year we posted results in a blog post and recommended users try some

[kudu-CR] WIP disk failure: forced shutdown of replicas

2017-07-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP disk failure: forced shutdown of replicas .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/4//COMMIT_MSG Commit Message: PS4, Line 15:

[kudu-CR] Integrate Mustache templates to webserver

2017-07-19 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7448 to look at the new patch set (#8). Change subject: Integrate Mustache templates to webserver .. Integrate Mustache

[kudu-CR](gh-pages) Add a note in the YCSB post

2017-07-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new patch set (#2). Change subject: Add a note in the YCSB post .. Add a note in the YCSB post Last year we posted results in a blog post and recommended users try some configurations related

[kudu-CR] Integrate Mustache templates to webserver

2017-07-19 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7448 to look at the new patch set (#7). Change subject: Integrate Mustache templates to webserver .. Integrate Mustache

[kudu-CR] Integrate Mustache templates to webserver

2017-07-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Integrate Mustache templates to webserver .. Patch Set 8: (1 comment) sorry I realized I had this old review item from a previous revision, but looks like it

[kudu-CR] [WIP]log block manager:mark container as 'non-writable' after IOError

2017-07-19 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7374 to look at the new patch set (#7). Change subject: [WIP]log block manager:mark container as 'non-writable' after IOError

[kudu-CR] [WIP]log block manager:mark container as 'non-writable' after IOError

2017-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [WIP]log block manager:mark container as 'non-writable' after IOError .. Patch Set 7: (22 comments)

[kudu-CR] KUDU-2065: Support cancellation for outbound RPC call

2017-07-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2065: Support cancellation for outbound RPC call .. Patch Set 2: (19 comments) http://gerrit.cloudera.org:8080/#/c/7455/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] [WIP]log block manager:mark container as 'non-writable' after IOError

2017-07-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [WIP]log block manager:mark container as 'non-writable' after IOError .. Patch Set 7: (1 comment)

[kudu-CR] thirdparty: use ninja when possible

2017-07-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7461 to look at the new patch set (#2). Change subject: thirdparty: use ninja when possible .. thirdparty: use ninja

[kudu-CR] Integrate Mustache templates to webserver

2017-07-19 Thread Sam Okrent (Code Review)
Sam Okrent has posted comments on this change. Change subject: Integrate Mustache templates to webserver .. Patch Set 9: This commit didn't go anywhere near raft consensus, and the log doesn't look like the failure of

[kudu-CR] nonsense change to test gerrit trigger

2017-07-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: nonsense change to test gerrit trigger .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

[kudu-CR] [WIP]log block manager:mark container as 'non-writable' after IOError

2017-07-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: [WIP]log block manager:mark container as 'non-writable' after IOError .. Patch Set 7: (5 comments)

[kudu-CR] [WIP]log block manager:mark container as 'non-writable' after IOError

2017-07-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: [WIP]log block manager:mark container as 'non-writable' after IOError .. Patch Set 7: (3 comments)

[kudu-CR] disk failure: local testing for disk failure

2017-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: local testing for disk failure .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/7441/3/src/kudu/tserver/ts_disk_failure-test.cc File

[kudu-CR] disk failure: tests for disk failure recovery

2017-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: tests for disk failure recovery .. Patch Set 10: (8 comments)

[kudu-CR] KUDU-2065: Support cancellation for outbound RPC call

2017-07-19 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7455 to look at the new patch set (#3). Change subject: KUDU-2065: Support cancellation for outbound RPC call ..

[kudu-CR] KUDU-2065: Support cancellation for outbound RPC call

2017-07-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: KUDU-2065: Support cancellation for outbound RPC call .. Patch Set 2: (17 comments) http://gerrit.cloudera.org:8080/#/c/7455/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] [WIP]log block manager:mark container as 'non-writable' after IOError

2017-07-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: [WIP]log block manager:mark container as 'non-writable' after IOError .. Patch Set 7: (14 comments)

[kudu-CR] [WIP]log block manager:mark container as 'non-writable' after IOError

2017-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [WIP]log block manager:mark container as 'non-writable' after IOError .. Patch Set 7: (2 comments)

[kudu-CR] WIP disk failure: handle disk failures in blocks

2017-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP disk failure: handle disk failures in blocks .. Patch Set 14: (26 comments) http://gerrit.cloudera.org:8080/#/c/7030/14/src/kudu/fs/data_dirs.h File

[kudu-CR] thirdparty: use ninja when possible

2017-07-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: thirdparty: use ninja when possible .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7461/1//COMMIT_MSG Commit Message: PS1, Line 10: less ugly