[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7821 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [rpc] don't issue authn tokens over non-confidential connections

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9025 ) Change subject: [rpc] don't issue authn tokens over non-confidential connections .. Patch Set 1: (1 comment)

[kudu-CR] [rpc] don't issue authn tokens over non-confidential connections

Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9025 to look at the new patch set (#3). Change subject: [rpc] don't issue authn tokens over non-confidential connections

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8376 ) Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing .. Patch Set 6: Code-Review+1 (2 comments)

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7821 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 3: > LD_LIBRARY_PATH against both versions

[kudu-CR] [rpc] don't issue authn tokens over non-confidential connections

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9025 ) Change subject: [rpc] don't issue authn tokens over non-confidential connections .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [rpc] don't issue authn tokens over non-confidential connections

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9025 ) Change subject: [rpc] don't issue authn tokens over non-confidential connections .. Patch Set 1: > Build Failed > >

[kudu-CR] KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8830 ) Change subject: KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client) .. Patch Set 11: (5 comments)

[kudu-CR] [rpc] don't issue authn tokens over non-confidential connections

Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9025 to look at the new patch set (#2). Change subject: [rpc] don't issue authn tokens over non-confidential connections

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9041 to look at the new patch set (#4). Change subject: KUDU-2148: do not crash on GetStatus during server startup

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9041 ) Change subject: KUDU-2148: do not crash on GetStatus during server startup .. Patch Set 4: (1 comment)

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7821 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 3: Code-Review+2 I tested this on

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9041 ) Change subject: KUDU-2148: do not crash on GetStatus during server startup .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9041 ) Change subject: KUDU-2148: do not crash on GetStatus during server startup .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9041 ) Change subject: KUDU-2148: do not crash on GetStatus during server startup .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] rpc: avoid an extra copy of shared ptr for OutboundCall

Hello Michael Ho, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9047 to review the following change. Change subject: rpc: avoid an extra copy of shared_ptr for OutboundCall ..

[kudu-CR] rpc: micro-optimize delayed task handling

Hello Michael Ho, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9048 to review the following change. Change subject: rpc: micro-optimize delayed task handling .. rpc:

[kudu-CR] KUDU-1489: allow configuration of metadata dir

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 11: (6 comments)

[kudu-CR] [rpc] don't issue authn tokens over non-confidential connections

Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9025 to look at the new patch set (#4). Change subject: [rpc] don't issue authn tokens over non-confidential connections

[kudu-CR] KUDU-1913: LIFO wake up ordering for threadpool worker threads

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9021 ) Change subject: KUDU-1913: LIFO wake up ordering for threadpool worker threads .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9041 to look at the new patch set (#3). Change subject: KUDU-2148: do not crash on GetStatus during server startup

[kudu-CR] KUDU-2195 (part 1): always sync PBC-format metadata files

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9043 ) Change subject: KUDU-2195 (part 1): always sync PBC-format metadata files .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-1865: Avoid some heap allocations in RPC paths

Hello Tidy Bot, Kudu Jenkins, Sailesh Mukil, Todd Lipcon, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8895 to look at the new patch set (#4). Change subject: KUDU-1865: Avoid some heap allocations in RPC paths

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8376 ) Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing .. Patch Set 7: (2 comments)

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

Hello Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8376 to look at the new patch set (#8). Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing

[kudu-CR] KUDU-2202: support for removing data directories (take two)

Hello Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8978 to look at the new patch set (#7). Change subject: KUDU-2202: support for removing data directories (take two)

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

Hello Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8376 to look at the new patch set (#7). Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing

[kudu-CR] KUDU-1913: LIFO wake up ordering for threadpool worker threads

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9021 ) Change subject: KUDU-1913: LIFO wake up ordering for threadpool worker threads .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1913: LIFO wake up ordering for threadpool worker threads

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9021 ) Change subject: KUDU-1913: LIFO wake up ordering for threadpool worker threads .. KUDU-1913: LIFO wake up ordering for threadpool

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7821 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. rpc: allow setting --rpc_tls_min_protocol on

[kudu-CR] WIP [master] no half-baked responses on ConnectoToMaster

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9052 Change subject: WIP [master] no half-baked responses on ConnectoToMaster .. WIP [master] no half-baked responses on ConnectoToMaster Do

[kudu-CR] rpc: avoid an extra copy of shared ptr for OutboundCall

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9047 ) Change subject: rpc: avoid an extra copy of shared_ptr for OutboundCall .. Patch Set 1: Code-Review+1 Looks good to me, but I think

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9041 ) Change subject: KUDU-2148: do not crash on GetStatus during server startup .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9041 ) Change subject: KUDU-2148: do not crash on GetStatus during server startup .. KUDU-2148: do not crash on GetStatus during server

[kudu-CR] rpc: avoid an extra copy of shared ptr for OutboundCall

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9047 ) Change subject: rpc: avoid an extra copy of shared_ptr for OutboundCall .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [rpc] don't issue authn tokens over non-confidential connections

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9025 ) Change subject: [rpc] don't issue authn tokens over non-confidential connections .. Patch Set 5: Code-Review+2 Carrying over Dan's +2

[kudu-CR] [rpc] don't issue authn tokens over non-confidential connections

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9025 ) Change subject: [rpc] don't issue authn tokens over non-confidential connections .. [rpc] don't issue authn tokens over

[kudu-CR] Add unsigned-integer overflow checking to UBSAN

Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6637 to look at the new patch set (#3). Change subject: Add unsigned-integer overflow checking to UBSAN

[kudu-CR] Add unsigned-integer overflow checking to UBSAN

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/6637 ) Change subject: Add unsigned-integer overflow checking to UBSAN .. Patch Set 3: (12 comments)

[kudu-CR] Enable vptr UBSAN checker

Dan Burkert has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9051 Change subject: Enable vptr UBSAN checker .. Enable vptr UBSAN checker The issue with boost intrusive list no longer appears to be

[kudu-CR] KUDU-2195 (part 1): always sync PBC-format metadata files

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9043 ) Change subject: KUDU-2195 (part 1): always sync PBC-format metadata files .. Patch Set 1: (1 comment)

[kudu-CR] rpc: micro-optimize delayed task handling

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9048 ) Change subject: rpc: micro-optimize delayed task handling .. Patch Set 1: (2 comments)

[kudu-CR] WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9050 ) Change subject: WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9041 to look at the new patch set (#5). Change subject: KUDU-2148: do not crash on GetStatus during server startup

[kudu-CR] Fix bug causing undercounting of thread count metric

Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9049 ) Change subject: Fix bug causing undercounting of thread count metric .. Fix bug causing undercounting of thread count metric

[kudu-CR] WIP: Add unsigned-integer overflow checking to UBSAN

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/6637 ) Change subject: WIP: Add unsigned-integer overflow checking to UBSAN .. Patch Set 2: (8 comments)

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9041 ) Change subject: KUDU-2148: do not crash on GetStatus during server startup .. Patch Set 4: (1 comment)

[kudu-CR] [docs] Removed the note about KUDU-1626

Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9020 ) Change subject: [docs] Removed the note about KUDU-1626 .. Patch Set 1: Code-Review+1 Could you please review and approve the change?

[kudu-CR] [docs] Added steps to update HMS after migrating to multiple Kudu masters

Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/8948 ) Change subject: [docs] Added steps to update HMS after migrating to multiple Kudu masters .. Patch Set 15: Code-Review+1 -- To view,

[kudu-CR] [docs] Added a section for Kudu clients connecting to secure clusters

Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/8953 ) Change subject: [docs] Added a section for Kudu clients connecting to secure clusters .. Patch Set 8: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9041 ) Change subject: KUDU-2148: do not crash on GetStatus during server startup .. Patch Set 4: (1 comment)

[kudu-CR] WIP: Add unsigned-integer overflow checking to UBSAN

Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6637 to look at the new patch set (#2). Change subject: WIP: Add unsigned-integer overflow checking to UBSAN

[kudu-CR] rpc: avoid an extra copy of shared ptr for OutboundCall

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9047 ) Change subject: rpc: avoid an extra copy of shared_ptr for OutboundCall .. rpc: avoid an extra copy of shared_ptr for

[kudu-CR] rpc: avoid an extra copy of shared ptr for OutboundCall

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9047 ) Change subject: rpc: avoid an extra copy of shared_ptr for OutboundCall .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [rpc] don't issue authn tokens over non-confidential connections

Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9025 to look at the new patch set (#5). Change subject: [rpc] don't issue authn tokens over non-confidential connections

[kudu-CR] Fix bug causing undercounting of thread count metric

Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9049 to review the following change. Change subject: Fix bug causing undercounting of thread count metric ..

[kudu-CR] Fix bug causing undercounting of thread count metric

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9049 ) Change subject: Fix bug causing undercounting of thread count metric .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration

Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9050 to review the following change. Change subject: WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration

[kudu-CR] KUDU-1489: allow configuration of metadata dir

Hello Tidy Bot, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9027 to look at the new patch set (#12). Change subject: KUDU-1489: allow configuration of metadata dir

[kudu-CR] KUDU-1489: allow configuration of metadata dir

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 12: (6 comments)

[kudu-CR] KUDU-1489: allow configuration of metadata dir

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 12: Code-Review+2 Since this is a pretty significant change,