[kudu-CR] KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9409 to review the following change. Change subject: KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization ..

[kudu-CR] rw semaphore: dont include debug-util.h when not necessary

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9328 ) Change subject: rw_semaphore: dont include debug-util.h when not necessary .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] rw semaphore: dont include debug-util.h when not necessary

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9328 to look at the new patch set (#9). Change subject: rw_semaphore: dont include debug-util.h when not necessary

[kudu-CR](branch-1.6.x) KUDU-1613: evict replicas with wrong server UUIDs

2018-02-22 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9410 to review the following change. Change subject: KUDU-1613: evict replicas with wrong server UUIDs ...

[kudu-CR] KUDU-2319 follower masters must be able to verify authn tokens

2018-02-22 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9373 to look at the new patch set (#3). Change subject: KUDU-2319 follower masters must be able to verify authn tokens .

[kudu-CR] rw semaphore: dont include debug-util.h when not necessary

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9328 ) Change subject: rw_semaphore: dont include debug-util.h when not necessary .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] tools: add more detail about unsafe change config

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9278 ) Change subject: tools: add more detail about unsafe_change_config .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] KUDU-2291 (part 7): fix race in stack trace collection

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9406 ) Change subject: KUDU-2291 (part 7): fix race in stack trace collection .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] KUDU-2297 (part 1): refactor metrics log out of ServerBase

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9326 ) Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloude

[kudu-CR] KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9327 ) Change subject: KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog .. Patch Set 8: Code-Review+2 -- To view, visit h

[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9329 ) Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. Patch Set 8: (1 comment) http://gerrit.clou

[kudu-CR] tools: add more detail about unsafe change config

2018-02-22 Thread Andrew Wong (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9278 to look at the new patch set (#4). Change subject: tools: add more detail about unsafe_change_config .

[kudu-CR] KUDU-2319 follower masters should be able to verify authn tokens

2018-02-22 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9373 to look at the new patch set (#4). Change subject: KUDU-2319 follower masters should be able to verify authn tokens .

[kudu-CR] tools: add more detail about unsafe change config

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9278 ) Change subject: tools: add more detail about unsafe_change_config .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9409 ) Change subject: KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization .. Patch Set 1: (2 comments) http://gerrit.cloudera.o

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9330 ) Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log .. Patch Set 9: Code-Review+2 -- To view, visit http://ge

[kudu-CR] KUDU-2291 (part 7): fix race in stack trace collection

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2291 (part 7): fix race in stack trace collection .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9406 To unsubscr

[kudu-CR] KUDU-2291 (part 7): fix race in stack trace collection

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9406 ) Change subject: KUDU-2291 (part 7): fix race in stack trace collection .. KUDU-2291 (part 7): fix race in stack trace collection

[kudu-CR] KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9327 ) Change subject: KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog .. KUDU-2297 (part 2). Convert diagnostics

[kudu-CR] KUDU-2291 (part 7): fix race in stack trace collection

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9406 ) Change subject: KUDU-2291 (part 7): fix race in stack trace collection .. Patch Set 1: Verified+1 Going to address the IWYU issue separat

[kudu-CR] KUDU-2297 (part 1): refactor metrics log out of ServerBase

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9326 ) Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase .. KUDU-2297 (part 1): refactor metrics log out of Serv

[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9329 ) Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. Patch Set 7: (1 comment) http://gerrit.clo

[kudu-CR] rw semaphore: dont include debug-util.h when not necessary

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9328 ) Change subject: rw_semaphore: dont include debug-util.h when not necessary .. rw_semaphore: dont include debug-util.h when not nec

[kudu-CR] KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9409 ) Change subject: KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization .. Patch Set 1: Verified-1 This can cause a deadlock

[kudu-CR] KUDU-2319 follower masters should be able to verify authn tokens

2018-02-22 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9373 to look at the new patch set (#5). Change subject: KUDU-2319 follower masters should be able to verify authn tokens .

[kudu-CR] webserver-stress-itest: fix flakiness

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9414 to review the following change. Change subject: webserver-stress-itest: fix flakiness .. webserver-stress-itest: fix fl

[kudu-CR] KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9409 to look at the new patch set (#2). Change subject: KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization ..

[kudu-CR] KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9409 to look at the new patch set (#3). Change subject: KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization

[kudu-CR] Fix move constructors to be noexcept

2018-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9382 ) Change subject: Fix move constructors to be noexcept .. Fix move constructors to be noexcept I noticed while looking at a profi

[kudu-CR] Fix move constructors to be noexcept

2018-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9382 ) Change subject: Fix move constructors to be noexcept .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9

[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319

2018-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9388 ) Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319 .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] tools: add more detail about unsafe change config

2018-02-22 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9278 ) Change subject: tools: add more detail about unsafe_change_config .. tools: add more detail about unsafe_change_config Given the

[kudu-CR] fs: clarify error message at startup

2018-02-22 Thread Andrew Wong (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9281 to look at the new patch set (#5). Change subject: fs: clarify error message at startup ..

[kudu-CR] KUDU-2319 follower masters should be able to verify authn tokens

2018-02-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9373 ) Change subject: KUDU-2319 follower masters should be able to verify authn tokens .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:808

[kudu-CR] KUDU-2319 follower masters should be able to verify authn tokens

2018-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9373 ) Change subject: KUDU-2319 follower masters should be able to verify authn tokens .. Patch Set 5: (3 comments) http://gerrit.cloudera.o

[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319

2018-02-22 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9388 to look at the new patch set (#2). Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319

[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319

2018-02-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9388 ) Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9388

[kudu-CR] KUDU-2319 follower masters should be able to verify authn tokens

2018-02-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9373 ) Change subject: KUDU-2319 follower masters should be able to verify authn tokens .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:808

[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319

2018-02-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9388 ) Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319 .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/9388

[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319

2018-02-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9388 ) Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9388/

<    1   2