[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 4: Talked to ZhangYao offline

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#5) to the change originally created by ZhangYao. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock ..

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#6) to the change originally created by ZhangYao. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock ..

[kudu-CR] Deprecated TabletLocationsPB.ReplicaPB message

2019-07-24 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13908 Change subject: Deprecated TabletLocationsPB.ReplicaPB message .. Deprecated TabletLocationsPB.ReplicaPB message According to the comments of

[kudu-CR] Deprecated TabletLocationsPB.ReplicaPB message

2019-07-24 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: Deprecated TabletLocationsPB.ReplicaPB message .. Patch Set 1: > (1 comment) It seems like this. :( I think I can make some

[kudu-CR] Deprecated TabletLocationsPB.ReplicaPB message

2019-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: Deprecated TabletLocationsPB.ReplicaPB message .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-24 Thread honeyhexin (Code Review)
honeyhexin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13833 ) Change subject: KUDU-2881 Support create/drop range partition by command line .. Patch Set 8: (11 comments)

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-24 Thread honeyhexin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13833 to look at the new patch set (#9). Change subject: KUDU-2881 Support create/drop range partition by command line

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-24 Thread honeyhexin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13833 to look at the new patch set (#8). Change subject: KUDU-2881 Support create/drop range partition by command line

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-24 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#2). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-24 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#3). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client

[kudu-CR] [master] Change the timeout threshold for unit test case

2019-07-24 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13909 Change subject: [master] Change the timeout threshold for unit test case .. [master] Change the timeout threshold for unit test case In the

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-24 Thread honeyhexin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13833 to look at the new patch set (#10). Change subject: KUDU-2881 Support create/drop range partition by command line

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. Patch Set 1: (1 comment)

[kudu-CR] docs: add the required config for Sentry

2019-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13902 ) Change subject: docs: add the required config for Sentry .. Patch Set 3: Verified+1 Unrelated flaky test -- To view, visit

[kudu-CR] docs: add the required config for Sentry

2019-07-24 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: docs: add the required config for Sentry .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13902 To unsubscribe, visit

[kudu-CR] docs: add the required config for Sentry

2019-07-24 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13902 ) Change subject: docs: add the required config for Sentry .. docs: add the required config for Sentry This commit adds the required

[kudu-CR] version util: track extra delimiter too

2019-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1

[kudu-CR] version util: track extra delimiter too

2019-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. Patch Set 2: Verified+1 Overriding Jenkins, failures were in NTP. -- To

[kudu-CR] version util: track extra delimiter too

2019-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. Patch Set 2: (1 comment)

[kudu-CR] version util: track extra delimiter too

2019-07-24 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13911 to review the following change. Change subject: version_util: track extra delimiter too ..

[kudu-CR] version util: track extra delimiter too

2019-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. Patch Set 2: (1 comment)

[kudu-CR] version util: track extra delimiter too

2019-07-24 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13911 to look at the new patch set (#2). Change subject: version_util: track extra delimiter too

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. Patch Set 3: (4 comments) Echoing Todd's

[kudu-CR] version util: track extra delimiter too

2019-07-24 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. version_util: track extra delimiter too One of the version_util tests

[kudu-CR] [master] Change the timeout threshold for unit test case

2019-07-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13909 ) Change subject: [master] Change the timeout threshold for unit test case .. Patch Set 1: I actually haven't been able to reproduce the

[kudu-CR] version util: track extra delimiter too

2019-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-24 Thread honeyhexin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13833 to look at the new patch set (#11). Change subject: KUDU-2881 Support create/drop range partition by command line

[kudu-CR] [master] Change the timeout threshold for unit test case

2019-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13909 ) Change subject: [master] Change the timeout threshold for unit test case .. Patch Set 1: > I actually haven't been able to reproduce

[kudu-CR] [master] Change the timeout threshold for unit test case

2019-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13909 ) Change subject: [master] Change the timeout threshold for unit test case .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [clock] introduce mini chronyd

2019-07-24 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13916 to look at the new patch set (#2). Change subject: [clock] introduce mini_chronyd .. [clock] introduce

[kudu-CR] WIP [clock] introduce mini chronyd

2019-07-24 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13916 to look at the new patch set (#3). Change subject: WIP [clock] introduce mini_chronyd .. WIP [clock] introduce

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-24 Thread honeyhexin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13833 to look at the new patch set (#12). Change subject: KUDU-2881 Support create/drop range partition by command line

[kudu-CR] [clock] introduce mini chronyd

2019-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13916 Change subject: [clock] introduce mini_chronyd .. [clock] introduce mini_chronyd This patch introduces a wrapper around chronyd, so

[kudu-CR] [thirdparty] introduce chrony

2019-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13915 Change subject: [thirdparty] introduce chrony .. [thirdparty] introduce chrony Added chrony into the thirdparty: a set of follow-up

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-24 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2881 Support create/drop range partition by command line .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13833 To

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-24 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2881 Support create/drop range partition by command line .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13833 To

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13833 ) Change subject: KUDU-2881 Support create/drop range partition by command line .. Patch Set 12: Verified+1 Unrelated test failure of

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-24 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. Patch Set 3: (1 comment)