[kudu-CR] docs: update installation with new OS support

2016-08-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4128/1//COMMIT_MSG Commit Message: Line 10: 1. Th

[kudu-CR] subprocess: use SIGKILL instead of SIGTERM death signal

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: subprocess: use SIGKILL instead of SIGTERM death signal .. subprocess: use SIGKILL instead of SIGTERM death signal This addresses a potential source of te

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 15: Build Started http://104.196.14.100/job/kudu-gerrit/3107/ -- To view, vi

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#15). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] subprocess: use SIGKILL instead of SIGTERM death signal

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: subprocess: use SIGKILL instead of SIGTERM death signal .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4139 To unsubscribe, visit

[kudu-CR] docs: update installation with new OS support

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 2: Verified+1 Overriding Jenkins, hit KUDU-1527. -- To view, visit http://gerrit.cloudera.org:8080/4128

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: cleanup/refactoring in consensus .. Patch Set 3: the timeout/failures I was seeing before in RaftConsensusITest seemed to be pre-existing. rebased this on to

[kudu-CR] raft consensus-itest: workaround flakiness due to KUDU-1580

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: raft_consensus-itest: workaround flakiness due to KUDU-1580 .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3106/ -- To view, visit http://g

[kudu-CR] raft consensus-itest: workaround flakiness due to KUDU-1580

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4142 to review the following change. Change subject: raft_consensus-itest: workaround flakiness due to KUDU-1580 .. raft_con

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: cleanup/refactoring in consensus .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3102/ -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] client-test: remove an unnecessary manual leader election

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: client-test: remove an unnecessary manual leader election .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3105/ -- To view, visit http://ger

[kudu-CR] subprocess: use SIGKILL instead of SIGTERM death signal

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4139 to review the following change. Change subject: subprocess: use SIGKILL instead of SIGTERM death signal .. subprocess:

[kudu-CR] subprocess: use SIGKILL instead of SIGTERM death signal

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: subprocess: use SIGKILL instead of SIGTERM death signal .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3103/ -- To view, visit http://gerri

[kudu-CR] raft consensus-itest: inserter thread should FATAL instead of FAIL

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: raft_consensus-itest: inserter thread should FATAL instead of FAIL .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3104/ -- To view, visit

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4133 to look at the new patch set (#3). Change subject: WIP: cleanup/refactoring in consensus .. WIP: cleanu

[kudu-CR] raft consensus-itest: inserter thread should FATAL instead of FAIL

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4140 to review the following change. Change subject: raft_consensus-itest: inserter thread should FATAL instead of FAIL ..

[kudu-CR] client-test: remove an unnecessary manual leader election

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4141 to review the following change. Change subject: client-test: remove an unnecessary manual leader election .. client-tes

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#14). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/3101/ -- To view, vi

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3823 To uns

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#13). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/3100/ -- To view, vi

[kudu-CR] Actually support downgrade to version that has LocalConsensus

2016-08-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Actually support downgrade to version that has LocalConsensus .. Patch Set 5: Punted because the code was equivalent and was already tested -- To view, visit http

[kudu-CR] Actually support downgrade to version that has LocalConsensus

2016-08-26 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Actually support downgrade to version that has LocalConsensus .. Actually support downgrade to version that has LocalConsensus Commit 74210b2546df9fd5dec7b

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 12: (1 comment) Thanks again, updated along with std:: prefixes to keep jenkin

[kudu-CR] Actually support downgrade to version that has LocalConsensus

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Actually support downgrade to version that has LocalConsensus .. Patch Set 4: Code-Review+2 (1 comment) Feel free to punt. http://gerrit.cloudera.org:8080/#/c/405

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/3099/ -- To view, vi

[kudu-CR] docs: updates to kudu impala integration.adoc

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: docs: updates to kudu_impala_integration.adoc .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3098/ -- To view, visit http://gerrit.cloudera

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#12). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] docs: update installation with new OS support

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3097/ -- To view, visit http://gerrit.cloudera

[kudu-CR] docs: updates to kudu impala integration.adoc

2016-08-26 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4138 to review the following change. Change subject: docs: updates to kudu_impala_integration.adoc .. docs:

[kudu-CR] docs: update installation with new OS support

2016-08-26 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4128 to look at the new patch set (#2). Change subject: docs: update installation with new OS support .. d

[kudu-CR] docs: update installation with new OS support

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4128/1//COMMIT_MSG Commit Message: Line 10: 1. The

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/3823/11/src/kudu/integrati

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 10: (10 comments) TFTR Mike, updated new patch, and also responses inline belo

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/3096/ -- To view, vi

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#11). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] master: include TS address in log messages

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: master: include TS address in log messages .. master: include TS address in log messages When looking at master logs, it's quite annoying to have to transl

[kudu-CR] master: include TS address in log messages

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: master: include TS address in log messages .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4131 To unsubscribe, visit http://gerrit

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: ksck: colorize and clean up output .. ksck: colorize and clean up output Dan and I were looking at some ksck output earlier and found it somewhat hard to r

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4129 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] Predicate evaluation pushdown

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3095/ -- To view, visit http://gerrit.cloudera.org:8080/3990 T

[kudu-CR] Predicate evaluation pushdown

2016-08-26 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#7). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] master: include TS address in log messages

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: master: include TS address in log messages .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4131/1//COMMIT_MSG Commit Message: Line 15: server. >

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3094/ -- To view, visit http://gerrit.cloudera.org:8080/4

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4129 to look at the new patch set (#4). Change subject: ksck: colorize and clean up output .. ksck: colorize and clean u

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 3: > One thing I noticed is that you have a newline separating tablet output, but > not tables. added > It would

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 3: > One thing I noticed is that you have a newline separating tablet output, but > not tables. added > It would

[kudu-CR] master: include TS address in log messages

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4131 to look at the new patch set (#2). Change subject: master: include TS address in log messages .. maste

[kudu-CR] master: include TS address in log messages

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master: include TS address in log messages .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3093/ -- To view, visit http://gerrit.cloudera.or

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 3: hrm, appears I may have forgotten to commit or something :) trying again in a moment -- To view, visit http:/

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4129/2/src/kudu/tools/color.cc File src/kudu/tools/color.cc: PS

[kudu-CR] java: inherit from ASF parent pom

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: inherit from ASF parent pom .. java: inherit from ASF parent pom This removes the Cloudera distribution management section and adds the ASF parent p

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4129 to look at the new patch set (#3). Change subject: ksck: colorize and clean up output .. ksck: colorize and clean u

[kudu-CR] tools: wrap descriptions

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tools: wrap descriptions .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4130/2//COMMIT_MSG Commit Message: PS2, Line 18: ksck Check the heal

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3092/ -- To view, visit http://gerrit.cloudera.org:8080/4

[kudu-CR] tools: wrap descriptions

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tools: wrap descriptions .. tools: wrap descriptions Wraps the help and usage output on a 78-column width so that it's much more readable. New output: t

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4129/2/src/kudu/tools/color.cc File src/kudu/tools/color.cc:

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. KUDU-1534 : Added software_version to ListMasters RPC This change also consolidates TSRegistration

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/3823/10/src/kudu/tablet/tab

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 10: (13 comments) http://gerrit.cloudera.org:8080/#/c/3823/8/src/kudu/integrati

[kudu-CR] Actually support downgrade to version that has LocalConsensus

2016-08-26 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Actually support downgrade to version that has LocalConsensus .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4059 To unsubscribe,

[kudu-CR] Support downgrade to version that has LocalConsensus

2016-08-26 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Support downgrade to version that has LocalConsensus .. Patch Set 2: > > Can you please give this a manual test as part of voting on 0.10 > RC? > > Sure, no pr

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4134/2/src/kudu/tools/ts-cli.cc File src/

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4129/2/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: PS2,

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: It would be really helpful to print the time that TABLET_DATA_COPYING operations started. Not sure if this is

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#2). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3091/ -- To view, visit http://gerrit.

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3090/ -- To view, visit http://gerrit.

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4134 to review the following change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: One thing I noticed is that you have a newline separating tablet output, but not tables. EG: Table customer_l

[kudu-CR] java: inherit from ASF parent pom

2016-08-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: inherit from ASF parent pom .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4118 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] Predicate evaluation pushdown

2016-08-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 6: (13 comments) http://gerrit.cloudera.org:8080/#/c/3990/6/src/kudu/common/column_eval_context.h File src/kudu/common/

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/4034/1/java/kudu-flume-sink/pom.xml File ja

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3089/ -- To view, visit http://gerrit.cl

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-26 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4034 to look at the new patch set (#4). Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Add AvroK

[kudu-CR] Add release notes for tablet history GC

2016-08-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3988/1/docs/release_notes.adoc File docs/release_notes.a

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: cleanup/refactoring in consensus .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3088/ -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: WIP: cleanup/refactoring in consensus .. WIP: cleanup/refactoring in consensus This is a fairly invasive cleanup/refactor to consensus in preparation for propagating

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4133 to review the following change. Change subject: WIP: cleanup/refactoring in consensus .. WIP: cleanup/refactoring in co

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: cleanup/refactoring in consensus .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3087/ -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] master: include TS address in log messages

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: master: include TS address in log messages .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4131/1/src/kudu/master/catalog_manager.cc File src/kudu/

[kudu-CR] java: inherit from ASF parent pom

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: java: inherit from ASF parent pom .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4118 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4129/2/src/kudu/tools/color.cc File src/kudu/tools/color.cc: P

[kudu-CR] tools: wrap descriptions

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tools: wrap descriptions .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4130/2//COMMIT_MSG Commit Message: PS2, Line 18: ksck C

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4099 To unsubscribe, visit ht