[kudu-CR] [NOT FOR REVIEW WIP] Design doc for repeatable reads

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5229 to look at the new patch set (#10). Change subject: [NOT FOR REVIEW WIP] Design doc for repeatable reads .. [NOT

[kudu-CR] Leader leases

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: Leader leases .. Abandoned oops pushed some old half-baked stuff -- To view, visit http://gerrit.cloudera.org:8080/5376 To unsubscribe, visit

[kudu-CR] Leader leases

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5376 Change subject: Leader leases .. Leader leases Change-Id: I7776ad5c65f9c79a7437d8226b59398762dbd6d4 --- M

[kudu-CR] Remove the clock from MvccManager

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5326 to look at the new patch set (#4). Change subject: Remove the clock from MvccManager .. Remove the clock from

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5305 to look at the new patch set (#4). Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time

[kudu-CR] WIP integration test for snapshot scans

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#2). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] Output more info when a snapshot scan fails due to history gc

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5374 to look at the new patch set (#4). Change subject: Output more info when a snapshot scan fails due to history gc ..

[kudu-CR] Output more info when a snapshot scan fails due to history gc

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Output more info when a snapshot scan fails due to history gc .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. KUDU-798 (part 4) Add a TimeManager to manage safe time advancement This

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 18: Code-Review+2 keeping todd's previous +2 since I fixed the nit --

[kudu-CR] Output more info when a snapshot scan fails due to history gc

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Output more info when a snapshot scan fails due to history gc .. Patch Set 2: (2 comments)

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. Patch Set 3: (10 comments)

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5300 to look at the new patch set (#18). Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 16: (2 comments)

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 16: (1 comment)

[kudu-CR] WIP integration test for snapshot scans

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5375 Change subject: WIP integration test for snapshot scans .. WIP integration test for snapshot scans This makes executions of

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 15: (1 comment)

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-766: limit number of glog files .. KUDU-766: limit number of glog files This commit introduces a new flag, 'max_log_files', that limits the maximum

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-766: limit number of glog files .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5340 To unsubscribe, visit

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 16: Code-Review+2 (1 comment)

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 15: (1 comment)

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 15: (1 comment)

[kudu-CR] rpc: show outbound call state in /rpcz dump

2016-12-05 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5371 to review the following change. Change subject: rpc: show outbound call state in /rpcz dump .. rpc: show outbound call

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 15: (1 comment)

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-766: limit number of glog files .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/5340/9/src/kudu/integration-tests/log-rolling-itest.cc File

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5340 to look at the new patch set (#10). Change subject: KUDU-766: limit number of glog files .. KUDU-766:

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-766: limit number of glog files .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/5340/9/src/kudu/integration-tests/log-rolling-itest.cc

[kudu-CR] WIP: KUDU-798 (part 5) Safe time advancement in the absence of writes

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#25). Change subject: WIP: KUDU-798 (part 5) Safe time advancement in the absence of writes

[kudu-CR] WIP: KUDU-798 (part 5) Safe time advancement in the absence of writes

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#24). Change subject: WIP: KUDU-798 (part 5) Safe time advancement in the absence of writes

[kudu-CR] WIP: KUDU-798 (part 5) Safe time advancement in the absence of writes

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#23). Change subject: WIP: KUDU-798 (part 5) Safe time advancement in the absence of writes

[kudu-CR] util: add file cache

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: util: add file cache .. Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/5146/8/src/kudu/util/cache.cc File src/kudu/util/cache.cc: PS8, Line

[kudu-CR] block manager: start using the file cache

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: block manager: start using the file cache .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5147/4/src/kudu/fs/block_manager.cc File

[kudu-CR] util: add file cache

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: util: add file cache .. Patch Set 9: Verified-1 Don't merge yet, I've found a race that needs to be addressed. -- To view, visit

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-766: limit number of glog files .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5340 To unsubscribe, visit

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5340 to look at the new patch set (#8). Change subject: KUDU-766: limit number of glog files .. KUDU-766:

[kudu-CR] WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock

2016-12-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock .. Abandoned ended up doing this here: https://gerrit.cloudera.org/#/c/5359/ -- To view, visit

[kudu-CR] KUDU-1622. result tracker: respond to RPCs outside of the lock

2016-12-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1622. result_tracker: respond to RPCs outside of the lock .. KUDU-1622. result_tracker: respond to RPCs outside of the lock This patch started with

[kudu-CR] KUDU-1622. result tracker: respond to RPCs outside of the lock

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1622. result_tracker: respond to RPCs outside of the lock .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5359 To

[kudu-CR] util: add file cache

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: util: add file cache .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5146 To unsubscribe, visit

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-766: limit number of glog files .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5340 To unsubscribe, visit

[kudu-CR] util: add file cache

2016-12-05 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5146 to look at the new patch set (#9). Change subject: util: add file cache .. util: add file cache This commit

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5340 to look at the new patch set (#7). Change subject: KUDU-766: limit number of glog files .. KUDU-766:

[kudu-CR] util: add file cache

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: util: add file cache .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/5146/6/src/kudu/util/file_cache-stress-test.cc File

[kudu-CR] WIP: KUDU-798 (part 5) Safe time advancement in the absence of writes

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#22). Change subject: WIP: KUDU-798 (part 5) Safe time advancement in the absence of writes

[kudu-CR] Add file globbing to Env

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Add file globbing to Env .. Add file globbing to Env Change-Id: Ic71160b11b19811ac9669dc7a572a7e4d2e59e79 Reviewed-on:

[kudu-CR] Add file modified time to Env

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Add file modified time to Env .. Add file modified time to Env Change-Id: I90b3e759a4dbb352a0c09dc726b428c9dcea5595 Reviewed-on:

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5300 to look at the new patch set (#16). Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 15: (14 comments)

[kudu-CR] Update partition syntax for single value range partitions

2016-12-05 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Matthew Jacobs, Dimitris Tsirogiannis, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5368 to review the following change. Change subject: Update partition syntax for single value range partitions

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-766: limit number of glog files .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5340 To unsubscribe, visit

[kudu-CR] WIP: KUDU-798 (part 5) Safe time advancement in the absense of writes

2016-12-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-798 (part 5) Safe time advancement in the absense of writes .. Patch Set 21: (29 comments)

[kudu-CR] [i-tests] separated implementation of the ext mini-cluster

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [i-tests] separated implementation of the ext mini-cluster .. [i-tests] separated implementation of the ext mini-cluster Separated implementation of the external

[kudu-CR] util: add file cache

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: util: add file cache .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/5146/8/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc: Line

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-scanned test

2016-12-05 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5345 to look at the new patch set (#6). Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test ..

[kudu-CR] [i-tests] separated implementation of the ext mini-cluster

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5367 Change subject: [i-tests] separated implementation of the ext mini-cluster .. [i-tests] separated implementation of the ext mini-cluster

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5340 to look at the new patch set (#6). Change subject: KUDU-766: limit number of glog files .. KUDU-766:

[kudu-CR] KUDU-1622. result tracker: respond to RPCs outside of the lock

2016-12-05 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5359 to look at the new patch set (#3). Change subject: KUDU-1622. result_tracker: respond to RPCs outside of the lock

[kudu-CR] KUDU-1608: Catalog manager can stop retrying DeleteTablet upon fatal errors

2016-12-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1608: Catalog manager can stop retrying DeleteTablet upon fatal errors .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5357/1//COMMIT_MSG

[kudu-CR] [consensus] KUDU-1407 replica is not evcited when TABLET NOT RUNNING

2016-12-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [consensus] KUDU-1407 replica is not evcited when TABLET_NOT_RUNNING .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5352/3//COMMIT_MSG Commit

[kudu-CR] util: add file cache

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: util: add file cache .. Patch Set 8: (4 comments) only 1/2 way through but going to switch to r8 for the rest.

[kudu-CR] KUDU-1608: Catalog manager can stop retrying DeleteTablet upon fatal errors

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1608: Catalog manager can stop retrying DeleteTablet upon fatal errors .. Patch Set 1: (1 comment) Looks good. As we discussed, please try to build tests

[kudu-CR] [consensus] KUDU-1407 replica is not evcited when TABLET NOT RUNNING

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [consensus] KUDU-1407 replica is not evcited when TABLET_NOT_RUNNING .. Patch Set 3: (4 comments) Again, will defer to Mike and David.

[kudu-CR] [consensus] KUDU-1613: Fix replica eviction failure for WRONG SERVER UUID

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [consensus] KUDU-1613: Fix replica eviction failure for WRONG_SERVER_UUID .. Patch Set 5: (5 comments) I'm deferring to Mike/David since I'm less familiar with

[kudu-CR] Add file modified time to Env

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add file modified time to Env .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5339 To unsubscribe, visit

[kudu-CR] Add file modified time to Env

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add file modified time to Env .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5339/1/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc:

[kudu-CR] Add file modified time to Env

2016-12-05 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5339 to look at the new patch set (#5). Change subject: Add file modified time to Env .. Add file modified time to Env

[kudu-CR] Add file globbing to Env

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add file globbing to Env .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5338 To unsubscribe, visit

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-766: limit number of glog files .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/5340/3/src/kudu/integration-tests/external_mini_cluster.cc

[kudu-CR] Add file globbing to Env

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add file globbing to Env .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/5338/1/src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc

[kudu-CR] Revert "env: change various file filename() functions to return copies"

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Revert "env: change various file filename() functions to return copies" .. Revert "env: change various file filename() functions to return copies" I

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5340 to look at the new patch set (#5). Change subject: KUDU-766: limit number of glog files .. KUDU-766: limit number

[kudu-CR] Revert "env: change various file filename() functions to return copies"

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Revert "env: change various file filename() functions to return copies" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5318 To

[kudu-CR] Add file globbing to Env

2016-12-05 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5338 to look at the new patch set (#4). Change subject: Add file globbing to Env .. Add file globbing to

[kudu-CR] KUDU-1622. result tracker: respond to RPCs outside of the lock

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1622. result_tracker: respond to RPCs outside of the lock .. Patch Set 2: Code-Review+2 (1 comment) Looks OK to me, but leaving unmerged in case David wanted

[kudu-CR] KUDU-1785. Fix potential crash in TabletCopySourceSession

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5363/2//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-766: limit number of glog files .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/5340/1/src/kudu/integration-tests/external_mini_cluster.cc

[kudu-CR] Add integration tests for duplicate keys

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add integration tests for duplicate keys .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5349/7/src/kudu/integration-tests/cluster_verifier.cc

[kudu-CR] [i-tests] fix TestWorkload to allow set num tablets(1)

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [i-tests] fix TestWorkload to allow set_num_tablets(1) .. Patch Set 2: > I just made this same change in a different patch, funny that this > lasted so long

[kudu-CR] [i-tests] fix TestWorkload to allow set num tablets(1)

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [i-tests] fix TestWorkload to allow set_num_tablets(1) .. [i-tests] fix TestWorkload to allow set_num_tablets(1) Fixed typo in

[kudu-CR] WIP: KUDU-1767. Create a client flush interleave test

2016-12-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: WIP: KUDU-1767. Create a client flush interleave test .. Patch Set 2: > ok, I see. I think you assumed we would check this in DISABLED. It's actually something I

[kudu-CR] WIP: KUDU-1767. Create a client flush interleave test

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: KUDU-1767. Create a client flush interleave test .. Patch Set 2: > Thanks for the review, Alexey. Yes, this test is currently pretty > messy. I do need to

[kudu-CR] WIP: KUDU-1369. client: fail over scans to a new replica if current replica is out-of-date

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: KUDU-1369. client: fail over scans to a new replica if current replica is out-of-date .. Patch Set 1: > David/Alexey -- just found this old WIP patch of

[kudu-CR] WIP: scanner should not retry a SCANNER EXPIRED error without reopening

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: scanner should not retry a SCANNER_EXPIRED error without reopening .. Patch Set 1: (2 comments) Todd, thank you for putting up the patch. I'll try to

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 15: (15 comments)

[kudu-CR] [python] - Add timeouts to Python unit tests

2016-12-05 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5362 to look at the new patch set (#4). Change subject: [python] - Add timeouts to Python unit tests .. [python] - Add

[kudu-CR] [i-tests] fix TestWorkload to allow set num tablets(1)

2016-12-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [i-tests] fix TestWorkload to allow set_num_tablets(1) .. Patch Set 2: I just made this same change in a different patch, funny that this lasted so long -- To

[kudu-CR] [i-tests] fix TestWorkload to allow set num tablets(1)

2016-12-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [i-tests] fix TestWorkload to allow set_num_tablets(1) .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5347 To unsubscribe, visit

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-05 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#9). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

[kudu-CR] [i-tests] fix TestWorkload to allow set num tablets(1)

2016-12-05 Thread Alexey Serbin (Code Review)
Hello Dinesh Bhat, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5347 to look at the new patch set (#2). Change subject: [i-tests] fix TestWorkload to allow set_num_tablets(1)

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5340 to look at the new patch set (#4). Change subject: KUDU-766: limit number of glog files .. KUDU-766: limit number

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-05 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5300 to look at the new patch set (#15). Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5340 to look at the new patch set (#3). Change subject: KUDU-766: limit number of glog files .. KUDU-766: limit number

[kudu-CR] KUDU-766: limit number of glog files

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-766: limit number of glog files .. Patch Set 2: (14 comments) http://gerrit.cloudera.org:8080/#/c/5340/1/src/kudu/integration-tests/external_mini_cluster.cc

[kudu-CR] java tests: Clean up and document binDir search

2016-12-05 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: java tests: Clean up and document binDir search .. java tests: Clean up and document binDir search This patch just does a small cleanup of the binDir

[kudu-CR] java tests: Clean up and document binDir search

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java tests: Clean up and document binDir search .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5348 To unsubscribe, visit

[kudu-CR] Tightening ScanSpec primary bounds when range predicate exists

2016-12-05 Thread Haijie Hong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5360 to look at the new patch set (#2). Change subject: Tightening ScanSpec primary bounds when range predicate exists

[kudu-CR] Tightening ScanSpec primary bounds when range predicate exists

2016-12-05 Thread Haijie Hong (Code Review)
Haijie Hong has restored this change. Change subject: Tightening ScanSpec primary bounds when range predicate exists .. Restored -- To view, visit http://gerrit.cloudera.org:8080/5360 To unsubscribe, visit

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 2: (1 comment)

[kudu-CR] raft consensus: avoid some unecessary allocations in hot path

2016-12-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: raft_consensus: avoid some unecessary allocations in hot path .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5344 To unsubscribe,

[kudu-CR] raft consensus: avoid some unecessary allocations in hot path

2016-12-05 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: raft_consensus: avoid some unecessary allocations in hot path .. raft_consensus: avoid some unecessary allocations in hot path In the stress cluster I

  1   2   >