[kudu-CR] [security-faults-itest] fix test flakiness

2017-04-06 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6586 to look at the new patch set (#2). Change subject: [security-faults-itest] fix test flakiness .. [security-faults-i

[kudu-CR] [security-faults-itest] fix test flakiness

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security-faults-itest] fix test flakiness .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6586/1/src/kudu/integration-tests/security-faults-ite

[kudu-CR] [security-faults-itest] fix test flakiness

2017-04-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [security-faults-itest] fix test flakiness .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6586/1/src/kudu/integration-tests/security-faults-itest.

[kudu-CR] [security-faults-itest] fix test flakiness

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6586 Change subject: [security-faults-itest] fix test flakiness .. [security-faults-itest] fix test flakiness When running the security-fault

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-06 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6585 to review the following change. Change subject: log block manager: use extent maps to decide whether to truncate containers .

[kudu-CR] log block manager: corruptor test utility

2017-04-06 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6582 to review the following change. Change subject: log block manager: corruptor test utility .. log

[kudu-CR] fs: ensure FS IOC FIEMAP can be used on LBM systems

2017-04-06 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6584 to review the following change. Change subject: fs: ensure FS_IOC_FIEMAP can be used on LBM systems ..

[kudu-CR] fs: generate report during Open

2017-04-06 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6581 to review the following change. Change subject: fs: generate report during Open .. fs: generate r

[kudu-CR] env: add RWFile::GetExtentMap for analyzing file extents

2017-04-06 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6583 to review the following change. Change subject: env: add RWFile::GetExtentMap for analyzing file extents .

[kudu-CR] [consensus] fixed typos in consensus flags tagging

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [consensus] fixed typos in consensus flags tagging .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6580/1/src/kudu/consensus/consensus_peers.cc

[kudu-CR] [consensus] fixed typos in consensus flags tagging

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [consensus] fixed typos in consensus flags tagging .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6580/1/src/kudu/consensus/consensus_peers.cc

[kudu-CR] [consensus] fixed typos in consensus flags tagging

2017-04-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [consensus] fixed typos in consensus flags tagging .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6580/1/src/kudu/consensus/consensu

[kudu-CR] [consensus] fixed typos in consensus flags tagging

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6580 Change subject: [consensus] fixed typos in consensus flags tagging .. [consensus] fixed typos in consensus flags tagging Change-Id: I39f

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 3: (17 comments) http://gerrit.cloudera.org:8080/#/c/6566/2/java/kudu-client/src/main/java/org/apache/kudu

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-06 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6566 to look at the new patch set (#3). Change subject: KUDU-579 [java_client] Scanner fault tolerance .. KUDU-579 [java

[kudu-CR] linked list-test: dump a histogram of Update performance

2017-04-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: linked_list-test: dump a histogram of Update performance .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6576/1/src/kudu/integration-test

[kudu-CR] linked list-test: dump a histogram of Update performance

2017-04-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: linked_list-test: dump a histogram of Update performance .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6576/1/src/kudu/integration-tests

[kudu-CR] tablet: revert batch-check-presence optimization for UPDATE/DELETE

2017-04-06 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6577 to review the following change. Change subject: tablet: revert batch-check-presence optimization for UPDATE/DELETE ...

[kudu-CR] linked list-test: dump a histogram of Update performance

2017-04-06 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6576 to review the following change. Change subject: linked_list-test: dump a histogram of Update performance .. li

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/1/src/kudu/client/scan_batch.h File src/kudu/c

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 1: Verified+1 Unrelated flake. -- To view, visit http://gerrit.cloudera.org:8080/6574 To unsu

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/1/src/kudu/client/scan_batch.h File sr

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/1/src/kudu/client/scan_batch.h File src/kudu/c

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6574/1/src/kudu/client/scan_batch.h File src/kudu/c

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6574 Change subject: Allow to get the raw data from a KuduScanBatch .. Allow to get the raw data from a KuduScanBatch This allows to fe

[kudu-CR] [python] Fix flaky test test connect timeouts

2017-04-06 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6573 to review the following change. Change subject: [python] Fix flaky test test_connect_timeouts .. [python] Fix flaky te

[kudu-CR](branch-1.2.x) KUDU-1607. Unpin tablet flush after failed bootstrap

2017-04-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. Patch Set 1: Argh I think this is dependent on https://github.com/apache/kudu/commit/4114ba9bf1cdfb

[kudu-CR] WIP: KUDU-1865 (part 2): pre-allocate OutboundTransfer for inbound calls

2017-04-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: WIP: KUDU-1865 (part 2): pre-allocate OutboundTransfer for inbound calls .. Patch Set 2: Just rebased this. Sorry for the noise. -- To view, visit http://gerr

[kudu-CR] WIP: KUDU-1865 (part 2): pre-allocate OutboundTransfer for inbound calls

2017-04-06 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5906 to look at the new patch set (#2). Change subject: WIP: KUDU-1865 (part 2): pre-allocate OutboundTransfer for inbound calls ...

[kudu-CR](branch-1.3.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

2017-04-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log index .. KUDU-1933. consensus: Avoid and repair integer overflow in log index We ob

[kudu-CR](branch-1.3.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

2017-04-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log index .. Patch Set 1: Code-Review+2 Verified+1 Unrelated flake. -- To view, visit http://g

[kudu-CR] [mini-cluster] allow more time for masters start up

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [mini-cluster] allow more time for masters start up .. [mini-cluster] allow more time for masters start up In case of sanitizer-enabled builds running o

[kudu-CR] [mini-cluster] allow more time for masters start up

2017-04-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [mini-cluster] allow more time for masters start up .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6571 To unsubscribe, visit http

[kudu-CR] [mini-cluster] allow more time for masters start up

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [mini-cluster] allow more time for masters start up .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6571/1/src/kudu/integration-tests/mini_clust

[kudu-CR] [mini-cluster] allow more time for masters start up

2017-04-06 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6571 to look at the new patch set (#2). Change subject: [mini-cluster] allow more time for masters start up .. [mini-clu

[kudu-CR] [mini-cluster] allow more time for masters start up

2017-04-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [mini-cluster] allow more time for masters start up .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6571/1/src/kudu/integration-tests/mini_cluster.

[kudu-CR](branch-1.2.x) KUDU-1607. Unpin tablet flush after failed bootstrap

2017-04-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/6572 Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. KUDU-1607. Unpin tablet flush after failed bootstrap We hav

[kudu-CR](branch-1.3.x) KUDU-1607. Unpin tablet flush after failed bootstrap

2017-04-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. KUDU-1607. Unpin tablet flush after failed bootstrap We have heard reports that, in certain

[kudu-CR](branch-1.3.x) KUDU-1607. Unpin tablet flush after failed bootstrap

2017-04-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6545 To unsubscribe, v

[kudu-CR] [mini-cluster] allow more time for masters start up

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6571 Change subject: [mini-cluster] allow more time for masters start up .. [mini-cluster] allow more time for masters start up In case of sa

[kudu-CR] [kudu-jepsen] install Kudu packages into local repo

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [kudu-jepsen] install Kudu packages into local repo .. [kudu-jepsen] install Kudu packages into local repo Install Kudu Java packages into the local mav

[kudu-CR] [kudu-jepsen] install Kudu packages into local repo

2017-04-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] install Kudu packages into local repo .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6256 To unsubscribe, v

[kudu-CR] [kudu-jepsen] install Kudu packages into local repo

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [kudu-jepsen] install Kudu packages into local repo .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6256/2/src/kudu/scripts/jepsen.sh File src/k

[kudu-CR] [kudu-jepsen] install Kudu packages into local repo

2017-04-06 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6256 to look at the new patch set (#3). Change subject: [kudu-jepsen] install Kudu packages into local repo .. [kudu-jep

[kudu-CR] [kudu-jepsen] install Kudu packages into local repo

2017-04-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] install Kudu packages into local repo .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6256/2/src/kudu/scripts/jepsen.sh File

[kudu-CR] [kudu-jepsen] install Kudu packages into local repo

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [kudu-jepsen] install Kudu packages into local repo .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6256/1/src/kudu/scripts/jepsen.sh File src/k

[kudu-CR] [kudu-jepsen] install Kudu packages into local repo

2017-04-06 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6256 to look at the new patch set (#2). Change subject: [kudu-jepsen] install Kudu packages into local repo .. [kudu-jep

[kudu-CR] [kudu-jepsen] install Kudu packages into local repo

2017-04-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] install Kudu packages into local repo .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6256/1/src/kudu/scripts/jepsen.sh File

[kudu-CR] WIP: KUDU-1713: add a client Partitioner API

2017-04-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API .. Patch Set 2: > Adar, did you have any more feedback? We'll wanna start consuming > this API pretty soon. Oh, I tho

[kudu-CR] [kudu-jepsen] clean up on require/import lists

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [kudu-jepsen] clean up on require/import lists .. [kudu-jepsen] clean up on require/import lists Change-Id: If3b25dd802e115dc4b0f0bc8aecef5fb2326438a Re

[kudu-CR] [kudu-jepsen] clean up on require/import lists

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [kudu-jepsen] clean up on require/import lists .. Patch Set 2: Code-Review+2 Re-based the patch, carrying over David's +2. -- To view, visit http://gerrit.clou

[kudu-CR] [kudu-jepsen] clean up on require/import lists

2017-04-06 Thread Alexey Serbin (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6570 to look at the new patch set (#2). Change subject: [kudu-jepsen] clean up on require/import lists .

[kudu-CR] [docs] Add security guide

2017-04-06 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/6479/4/docs/security.adoc File docs/security.adoc: PS4, Line 31: will

[kudu-CR] [kudu-jepsen] updated client model for Jepsen tests

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [kudu-jepsen] updated client model for Jepsen tests .. [kudu-jepsen] updated client model for Jepsen tests Use a single Kudu client object across all te

[kudu-CR] WIP [java client] fixed NPE in master RPC error handler

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: WIP [java client] fixed NPE in master RPC error handler .. Abandoned Partially addressed by bee8e875e21acb1d36f104f8388fc9ed6c963821, and in the long run this should be

[kudu-CR] [kudu-jepsen] updated client model for Jepsen tests

2017-04-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] updated client model for Jepsen tests .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6565 To unsubscribe, v

[kudu-CR] KUDU-1424. Add getters to PartialRow

2017-04-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1424. Add getters to PartialRow .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6554/1/java/kudu-client/src/main/java/org/apache/kudu

[kudu-CR] WIP: KUDU-1713: add a client Partitioner API

2017-04-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API .. Patch Set 2: Adar, did you have any more feedback? We'll wanna start consuming this API pretty soon. -- To vi

[kudu-CR] [docs] Add security guide

2017-04-06 Thread Dan Burkert (Code Review)
Hello Hao Hao, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6479 to look at the new patch set (#4). Change subject: [docs] Add security guide .. [docs] Add

[kudu-CR] [docs] Add security guide

2017-04-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6479/3/docs/security.adoc File docs/security.adoc: PS3, Line 113: are >

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 2: (18 comments) http://gerrit.cloudera.org:8080/#/c/6566/2/java/kudu-client/src/main/java/org/

[kudu-CR] [docs] Add security guide

2017-04-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6479/3/docs/security.adoc File docs/security.adoc: PS3, Line 113: are

[kudu-CR] [kudu-jepsen] updated client model for Jepsen tests

2017-04-06 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6565 to look at the new patch set (#3). Change subject: [kudu-jepsen] updated client model for Jepsen tests .. [kudu-jep

[kudu-CR] [kudu-jepsen] updated client model for Jepsen tests

2017-04-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [kudu-jepsen] updated client model for Jepsen tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6565/1//COMMIT_MSG Commit Message: PS1, Lin

[kudu-CR] [kudu-jepsen] updated client model for Jepsen tests

2017-04-06 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6565 to look at the new patch set (#2). Change subject: [kudu-jepsen] updated client model for Jepsen tests .. [kudu-jep