[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9255 ) Change subject: KUDU-2274 [itest] stress test for replica replacement .. Patch Set 5: (15 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9255 to look at the new patch set (#5). Change subject: KUDU-2274 [itest] stress test for replica replacement ..

[kudu-CR] KUDU-2291 (part 6) stacks: use libunwind directly for stack tracing

Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9319 to review the following change. Change subject: KUDU-2291 (part 6) stacks: use libunwind directly for stack tracing

[kudu-CR] KUDU-2291 (part 5): allow collecting stack traces asynchronously

Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9318 to review the following change. Change subject: KUDU-2291 (part 5): allow collecting stack traces asynchronously

[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9255 ) Change subject: KUDU-2274 [itest] stress test for replica replacement .. Patch Set 4: (16 comments) http://gerrit.cloudera.org:8080/#/c/9

[kudu-CR] WIP [consensus] re-replication stress test (TSAN enabled)

Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9317 to look at the new patch set (#2). Change subject: WIP [consensus] re-replication stress test (TSAN enabled)

[kudu-CR] WIP [consensus] re-replication stress test (TSAN enabled)

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9317 Change subject: WIP [consensus] re-replication stress test (TSAN enabled) .. WIP [consensus] re-replication stress test (TSAN enabled) W

[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9255 to look at the new patch set (#4). Change subject: KUDU-2274 [itest] stress test for replica replacement ..

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9262 ) Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection .. Patch Set 4: Code-Review+1 SGTM. I'd fe

[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9255 to look at the new patch set (#3). Change subject: KUDU-2274 [itest] stress test for replica replacement ..

[kudu-CR] [tools] Fail ksck if fetching consensus state fails

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9316 ) Change subject: [tools] Fail ksck if fetching consensus state fails .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.o

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9262 ) Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection .. Patch Set 3: (1 comment) http://gerrit.c

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9262 to look at the new patch set (#4). Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

[kudu-CR] [tools] Fail ksck if fetching consensus state fails

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9316 ) Change subject: [tools] Fail ksck if fetching consensus state fails .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/93

[kudu-CR] [tools] Fail ksck if fetching consensus state fails

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9316 ) Change subject: [tools] Fail ksck if fetching consensus state fails .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/93

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9262 ) Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection .. Patch Set 3: (1 comment) http://gerrit

[kudu-CR] [tools] Fail ksck if fetching consensus state fails

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9316 Change subject: [tools] Fail ksck if fetching consensus state fails .. [tools] Fail ksck if fetching consensus state fails Commonly, use

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9262 ) Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection .. Patch Set 2: ok, hopefully fixed sanitize

[kudu-CR] KUDU-2291 (part 2): Add a /stacks page

Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9253 to look at the new patch set (#4). Change subject: KUDU-2291 (part 2): Add a /stacks page ..

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9262 to look at the new patch set (#3). Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

[kudu-CR] KUDU-2291 (part 3): use futex to speed up stack collection

Hello Will Berkeley, Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9254 to look at the new patch set (#4). Change subject: KUDU-2291 (part 3): use futex to speed up stack collection ..

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode .. Patch Set 12: (20 comments) http://gerrit.cloudera.org:8080/#/c/8804/12/src/

[kudu-CR] [TestWorkload] an option to retry on read timeouts

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9295 ) Change subject: [TestWorkload] an option to retry on read timeouts .. Patch Set 3: > In the context of TestWorkload, it's the same story

[kudu-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9312 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Patch Set 2: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9312 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. KUDU-2296: Fix deserialization of messages larger t

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9213 ) Change subject: KUDU-721: [Spark] Add DECIMAL type support .. KUDU-721: [Spark] Add DECIMAL type support Adds DECIMAL support to

[kudu-CR] KUDU-721: [Java] Add DECIMAL column type support

Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8882 ) Change subject: KUDU-721: [Java] Add DECIMAL column type support .. KUDU-721: [Java] Add DECIMAL column type support This patch a

[kudu-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9312 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:80

[kudu-CR] KUDU-721: [Java] Add DECIMAL column type support

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8882 ) Change subject: KUDU-721: [Java] Add DECIMAL column type support .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/8882/1

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9213 ) Change subject: KUDU-721: [Spark] Add DECIMAL type support .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] [TestWorkload] an option to retry on read timeouts

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9295 ) Change subject: [TestWorkload] an option to retry on read timeouts .. Patch Set 3: > I'm not 100% following this. Reads should already

[kudu-CR] KUDU-721: [Java] Add DECIMAL column type support

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8882 ) Change subject: KUDU-721: [Java] Add DECIMAL column type support .. Patch Set 14: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8

[kudu-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9312 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9312 to look at the new patch set (#2). Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. KU

[kudu-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9312 Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. KUDU-2296: Fix deserialization of messages larger than 64M

[kudu-CR] KUDU-721: [Java] Add DECIMAL column type support

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8882 ) Change subject: KUDU-721: [Java] Add DECIMAL column type support .. Patch Set 14: (16 comments) http://gerrit.cloudera.org:8080/#/c/8882

[kudu-CR] Add back KuduColumnSchema DataTypeToString

Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9240 ) Change subject: Add back KuduColumnSchema DataTypeToString .. Add back KuduColumnSchema DataTypeToString KuduColumnSchema’s DataT

[kudu-CR] Add back KuduColumnSchema DataTypeToString

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9240 ) Change subject: Add back KuduColumnSchema DataTypeToString .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9262 ) Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection .. Patch Set 2: This breaks the macOS buil

[kudu-CR] [docs] Add scaling guide

Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8842 ) Change subject: [docs] Add scaling guide .. [docs] Add scaling guide This adds some more detailed information on how Kudu scale

[kudu-CR] [docs] Document how to recover from a majority failed tablet

Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8402 ) Change subject: [docs] Document how to recover from a majority failed tablet .. Removed reviewer Kudu Jenkins. -- To view, visit

[kudu-CR] [docs] Document how to recover from a majority failed tablet

Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8402 ) Change subject: [docs] Document how to recover from a majority failed tablet .. [docs] Document how to recover from a majority f

[kudu-CR] [docs] Document how to recover from a majority failed tablet

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8402 ) Change subject: [docs] Document how to recover from a majority failed tablet .. Patch Set 9: Verified+1 (1 comment) http://gerrit.clou

[kudu-CR] KUDU-2291 (part 2): Add a /stacks page

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9253 ) Change subject: KUDU-2291 (part 2): Add a /stacks page .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9253/3/src/kudu/

[kudu-CR] [tablet] fix nullptr dereference while capturing iterators

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9189 ) Change subject: [tablet] fix nullptr dereference while capturing iterators .. [tablet] fix nullptr dereference while capturing i

[kudu-CR] [tablet] fix nullptr dereference while capturing iterators

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9189 ) Change subject: [tablet] fix nullptr dereference while capturing iterators .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] [Java] Downgrade protobuf to 3.4.0

Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9304 ) Change subject: [Java] Downgrade protobuf to 3.4.0 .. [Java] Downgrade protobuf to 3.4.0 The recent bump in the Protobuf version

[kudu-CR] KUDU-2291 (part 3): use futex to speed up stack collection

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9254 ) Change subject: KUDU-2291 (part 3): use futex to speed up stack collection .. Patch Set 3: Code-Review+1 (1 comment) LGTM with one com

[kudu-CR] KUDU-2291 (part 2): Add a /stacks page

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9253 ) Change subject: KUDU-2291 (part 2): Add a /stacks page .. Patch Set 3: Code-Review+2 (2 comments) Nits only, I'd be fine with merging

[kudu-CR] [docs] Document how to recover from a majority failed tablet

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8402 ) Change subject: [docs] Document how to recover from a majority failed tablet .. Patch Set 9: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] [docs] Document how to recover from a majority failed tablet

Hello Alex Rodoni, Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8402 to look at the new patch set (#9). Change subject: [docs] Document how to recover from a majority failed tablet ...

[kudu-CR] KUDU-2291 (part 3): use futex to speed up stack collection

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9254 ) Change subject: KUDU-2291 (part 3): use futex to speed up stack collection .. Patch Set 3: Verified+1 Jenkins issue was a flake which I f

[kudu-CR] KUDU-2291 (part 3): use futex to speed up stack collection

Todd Lipcon has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9254 ) Change subject: KUDU-2291 (part 3): use futex to speed up stack collection .. Removed reviewer Kudu Jenkins with the following vot

[kudu-CR] [Java] Downgrade protobuf to 3.4.0

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9304 ) Change subject: [Java] Downgrade protobuf to 3.4.0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9304

[kudu-CR] KUDU-2291 (part 1): allow collecting a thread's stack without immediate symbolization

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9252 ) Change subject: KUDU-2291 (part 1): allow collecting a thread's stack without immediate symbolization .. KUDU-2291 (part 1): allo

[kudu-CR] [TestWorkload] an option to retry on read timeouts

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9295 ) Change subject: [TestWorkload] an option to retry on read timeouts .. Patch Set 3: I'm not 100% following this. Reads should already have

[kudu-CR] KUDU-2291 (part 1): allow collecting a thread's stack without immediate symbolization

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9252 ) Change subject: KUDU-2291 (part 1): allow collecting a thread's stack without immediate symbolization .. Patch Set 3: Code-Review+2 -

[kudu-CR] [Java] Downgrade protobuf to 3.4.0

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9304 Change subject: [Java] Downgrade protobuf to 3.4.0 .. [Java] Downgrade protobuf to 3.4.0 The recent bump in the Protobuf version breaks el

[kudu-CR] Make tcmalloc heap sampling more useful

Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9263 to look at the new patch set (#3). Change subject: Make tcmalloc heap sampling more useful .. Make tc

[kudu-CR] Make tcmalloc heap sampling more useful

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9263/2/src/kudu

[kudu-CR] [TestWorkload] an option to retry on read timeouts

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9295 to look at the new patch set (#3). Change subject: [TestWorkload] an option to retry on read timeouts .. [TestWorklo

[kudu-CR] Make tcmalloc heap sampling more useful

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 2: > You're telling me you can't symbolize addresses in your head?

[kudu-CR] [TestWorkload] an option to retry on read timeouts

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9295 to look at the new patch set (#2). Change subject: [TestWorkload] an option to retry on read timeouts .. [TestWorklo

[kudu-CR] [TestWorkload] an option to retry read timeouts

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9295 Change subject: [TestWorkload] an option to retry read timeouts .. [TestWorkload] an option to retry read timeouts Introduced a new opti

[kudu-CR] Make tcmalloc heap sampling more useful

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 2: > Is that because it's macOS? If not, how does one read that? Yo

[kudu-CR] Make tcmalloc heap sampling more useful

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 2: (3 comments) I tried this out on my macOS system and the heap

[kudu-CR] Simplify OpId/Timestamp assignment and make it atomic

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7221 ) Change subject: Simplify OpId/Timestamp assignment and make it atomic .. Patch Set 17: (18 comments) http://gerrit.cloudera.org:8080/#