[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15373 ) Change subject: [util] Import "Or" function to BlockBloomFilter from Impala .. Patch Set 1: (6 comments)

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 ) Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. Patch Set 1: (7 comments)

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: util: remove all gscoped_ptr .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15377 To unsubscribe, visit

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15377 ) Change subject: util: remove all gscoped_ptr .. util: remove all gscoped_ptr Except from callback_bind-test.cc, which tests

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 ) Change subject: util: remove all gscoped_ptr .. Patch Set 3: Verified+1 Overriding Jenkins, another dist-test temp dir issue. -- To

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 ) Change subject: util: remove all gscoped_ptr .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15377 To

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15377 to look at the new patch set (#3). Change subject: util: remove all gscoped_ptr ..

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15377 to look at the new patch set (#2). Change subject: util: remove all gscoped_ptr ..

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 ) Change subject: util: remove all gscoped_ptr .. Patch Set 1: (3 comments)

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 ) Change subject: util: remove all gscoped_ptr .. Patch Set 1: Code-Review+1 (2 comments)

[kudu-CR] [tserver] report the newly bootstrapped tablet after OpenTablet completes

2020-03-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15307 ) Change subject: [tserver] report the newly bootstrapped tablet after OpenTablet completes .. Patch Set 12: Code-Review+2 Looks good

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 ) Change subject: util: remove all gscoped_ptr .. Patch Set 1: (1 comment)

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 ) Change subject: util: remove all gscoped_ptr .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15377 To

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 ) Change subject: util: remove all gscoped_ptr .. Patch Set 1: (1 comment)

[kudu-CR] subprocess: add server metric for queue size

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: subprocess: add server metric for queue size .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15375 To unsubscribe,

[kudu-CR] subprocess: add server metric for queue size

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15375 ) Change subject: subprocess: add server metric for queue size .. subprocess: add server metric for queue size Unlike the Java

[kudu-CR] subprocess: add server metric for queue size

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15375 ) Change subject: subprocess: add server metric for queue size .. Patch Set 2: Verified+1 Flaky:

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15377 to review the following change. Change subject: util: remove all gscoped_ptr .. util: remove all

[kudu-CR] subprocess: add server metric for queue size

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15375 ) Change subject: subprocess: add server metric for queue size .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] subprocess: add server metric for queue size

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15375 ) Change subject: subprocess: add server metric for queue size .. Patch Set 2: (1 comment)

[kudu-CR] subprocess: add server metric for queue size

2020-03-05 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15375 to look at the new patch set (#2). Change subject: subprocess: add server metric for queue size

[kudu-CR] subprocess: add server metric for queue size

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15375 ) Change subject: subprocess: add server metric for queue size .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2972 Add Ranger authorization provider

2020-03-05 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15207 ) Change subject: KUDU-2972 Add Ranger authorization provider .. KUDU-2972 Add Ranger authorization provider Adds a new

[kudu-CR] KUDU-2972 Add Ranger authorization provider

2020-03-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15207 ) Change subject: KUDU-2972 Add Ranger authorization provider .. Patch Set 29: Code-Review+2 -- To view, visit

[kudu-CR] subprocess: add server metric for queue size

2020-03-05 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15375 to review the following change. Change subject: subprocess: add server metric for queue size .. subprocess:

[kudu-CR] [WIP] Mini Ranger + Postgres

2020-03-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 ) Change subject: [WIP] Mini Ranger + Postgres .. Patch Set 1: > Uploaded patch set 1. I'm getting close, but Ranger still fails to

[kudu-CR] [WIP] Mini Ranger + Postgres

2020-03-05 Thread Attila Bukor (Code Review)
Hello Andrew Wong, Anonymous Coward (314), Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15374 to review the following change. Change subject: [WIP] Mini Ranger + Postgres ..

[kudu-CR] KUDU-2972 Add Ranger authorization provider

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15207 ) Change subject: KUDU-2972 Add Ranger authorization provider .. Patch Set 29: Code-Review+1 -- To view, visit

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15373 ) Change subject: [util] Import "Or" function to BlockBloomFilter from Impala .. Patch Set 1: (3 comments)

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 ) Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2972 Add Ranger authorization provider

2020-03-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15207 ) Change subject: KUDU-2972 Add Ranger authorization provider .. Patch Set 29: (2 comments)

[kudu-CR] KUDU-2972 Add Ranger authorization provider

2020-03-05 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15207 to look at the new patch set (#29). Change subject: KUDU-2972 Add Ranger authorization provider

[kudu-CR] KUDU-2972 Add Ranger authorization provider

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15207 ) Change subject: KUDU-2972 Add Ranger authorization provider .. Patch Set 28: Code-Review+1 (2 comments)

[kudu-CR] subprocess: add server-side metrics

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15367 ) Change subject: subprocess: add server-side metrics .. subprocess: add server-side metrics This introduces server-side timing

[kudu-CR] subprocess: add server-side metrics

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 ) Change subject: subprocess: add server-side metrics .. Patch Set 3: Verified+1 (1 comment) Unrelated flake: security-itest

[kudu-CR] subprocess: add server-side metrics

2020-03-05 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: subprocess: add server-side metrics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15367 To unsubscribe, visit

[kudu-CR] KUDU-2972 Add Ranger authorization provider

2020-03-05 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15207 to look at the new patch set (#28). Change subject: KUDU-2972 Add Ranger authorization provider

[kudu-CR] Init kudu.write duration accumulator lazily

2020-03-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15368 ) Change subject: Init kudu.write_duration accumulator lazily .. Patch Set 1: Yes, this patch should not be needed. See

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15373 Change subject: [util] Import "Or" function to BlockBloomFilter from Impala .. [util] Import "Or" function to BlockBloomFilter from

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15372 Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. [util] Add support for 32 & 64 byte alignment to

[kudu-CR] KUDU-3063: Set a ratio to reserve some nvm memory

2020-03-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15313 ) Change subject: KUDU-3063: Set a ratio to reserve some nvm memory .. Patch Set 3: (5 comments)

[kudu-CR] subprocess: add server-side metrics

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 ) Change subject: subprocess: add server-side metrics .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] Init kudu.write duration accumulator lazily

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15368 ) Change subject: Init kudu.write_duration accumulator lazily .. Patch Set 1: I think Grant already addressed this issue within the

[kudu-CR] Init kudu.write duration accumulator lazily

2020-03-05 Thread Anonymous Coward (Code Review)
pengchengliu_b...@163.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15368 Change subject: Init kudu.write_duration accumulator lazily .. Init kudu.write_duration accumulator lazily Change-Id:

[kudu-CR] [WIP] Ranger authorization provider

2020-03-05 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15207 to look at the new patch set (#27). Change subject: [WIP] Ranger authorization provider

[kudu-CR] [WIP] Ranger authorization provider

2020-03-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15207 ) Change subject: [WIP] Ranger authorization provider .. Patch Set 27: (1 comment)