[kudu-CR] Add core algorithms for columnar serialization

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 4: (5 comments)

[kudu-CR] gutil: bump up linux-syscall-support.h

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15543 ) Change subject: iwyu: codebase-wide fixes based on libcpp .. Patch Set 3: (1 comment)

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15543 ) Change subject: iwyu: codebase-wide fixes based on libcpp .. Patch Set 3: (1 comment)

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15543 ) Change subject: iwyu: codebase-wide fixes based on libcpp .. Patch Set 3: (11 comments)

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15543 ) Change subject: iwyu: codebase-wide fixes based on libcpp .. Patch Set 3: (12 comments)

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15543 ) Change subject: iwyu: codebase-wide fixes based on libcpp .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15543 ) Change subject: iwyu: codebase-wide fixes based on libcpp .. Patch Set 3: Verified+1 Overriding Jenkins, unrelated test failure. -- To

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 2: (3 comments)

[kudu-CR] iwyu: standardize on libc++

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 10: > Looks good to me and I verified it works fine on CentOS8. > >

[kudu-CR] iwyu: standardize on libc++

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 10: Code-Review+2 Looks good to me and I verified it works fine on CentOS8.

[kudu-CR] rowblock: improve GetSelectedRows API

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15559 ) Change subject: rowblock: improve GetSelectedRows API .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] gutil: bump up linux-syscall-support.h

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] gutil: bump up linux-syscall-support.h

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. Patch Set 3: (1 comment) > Patch Set 2: > > (1 comment) > > It looks like the

[kudu-CR] rowblock: improve GetSelectedRows API

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15559 ) Change subject: rowblock: improve GetSelectedRows API .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] gutil: bump up linux-syscall-support.h

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. Patch Set 2: (1 comment) It looks like the other patch has an older

[kudu-CR] gutil: bump up linux-syscall-support.h

Hello Alexey Serbin, zhaoren...@hotmail.com, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15557 to look at the new patch set (#3). Change subject: gutil: bump up linux-syscall-support.h

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15543 to look at the new patch set (#3). Change subject: iwyu: codebase-wide fixes based on libcpp

[kudu-CR] Add core algorithms for columnar serialization

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 4: (4 comments)

[kudu-CR] Add core algorithms for columnar serialization

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3079 Add MiniRanger

Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. KUDU-3079 Add MiniRanger Apache Ranger has some setup scripts[1][2] that should be

[kudu-CR] KUDU-3079 Add MiniRanger

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 51: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15483 To

[kudu-CR] KUDU-3079 Add MiniRanger

Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 51: Verified+1 failure was an unrelated flaky test -- To view, visit

[kudu-CR] KUDU-3079 Add MiniRanger

Attila Bukor has removed a vote on this change. Change subject: KUDU-3079 Add MiniRanger .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15483 To unsubscribe, visit

[kudu-CR] Add core algorithms for columnar serialization

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 3: (3 comments)

[kudu-CR] Add core algorithms for columnar serialization

Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15556 to look at the new patch set (#4). Change subject: Add core algorithms for columnar serialization

[kudu-CR] rowblock: improve GetSelectedRows API

Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15559 to review the following change. Change subject: rowblock: improve GetSelectedRows API .. rowblock:

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15560 to review the following change. Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] Add core algorithms for columnar serialization

Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15556 to look at the new patch set (#3). Change subject: Add core algorithms for columnar serialization

[kudu-CR] KUDU-3079 Add MiniRanger

Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 51: (3 comments)

[kudu-CR] KUDU-3079 Add MiniRanger

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 51: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15483 To

[kudu-CR] KUDU-3079 Add MiniRanger

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15483 to look at the new patch set (#51). Change subject: KUDU-3079 Add MiniRanger

[kudu-CR] Add core algorithms for columnar serialization

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 2: (3 comments) Just passing through with a few comments.

[kudu-CR] KUDU-3079 Add MiniRanger

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 50: (3 comments)

[kudu-CR] Fix loop unroll pragma for GCC < 8

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15558 ) Change subject: Fix loop unroll pragma for GCC < 8 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Fix loop unroll pragma for GCC < 8

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15558 ) Change subject: Fix loop unroll pragma for GCC < 8 .. Fix loop unroll pragma for GCC < 8 The 'GCC unroll' pragma was only

[kudu-CR] [clock] hybrid clock-test to run in different environments

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15551 ) Change subject: [clock] hybrid_clock-test to run in different environments .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] gutil: bump up linux-syscall-support.h

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. Patch Set 2: (1 comment) FYI there's another outstanding patch that also

[kudu-CR] [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15554 ) Change subject: [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs .. [python] KUDU-3087 use 2048-bit RSA keys for

[kudu-CR] [clock] hybrid clock-test to run in different environments

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15551 ) Change subject: [clock] hybrid_clock-test to run in different environments .. [clock] hybrid_clock-test to run in different

[kudu-CR] [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15554 ) Change subject: [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Fix loop unroll pragma for GCC < 8

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15558 ) Change subject: Fix loop unroll pragma for GCC < 8 .. Patch Set 1: Verified+1 java test failure -- To view, visit

[kudu-CR] Fix loop unroll pragma for GCC < 8

Todd Lipcon has removed a vote on this change. Change subject: Fix loop unroll pragma for GCC < 8 .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15558 To unsubscribe, visit

[kudu-CR] Fix loop unroll pragma for GCC < 8

Todd Lipcon has removed a vote on this change. Change subject: Fix loop unroll pragma for GCC < 8 .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15558 To unsubscribe, visit

[kudu-CR] Fix loop unroll pragma for GCC < 8

Todd Lipcon has removed a vote on this change. Change subject: Fix loop unroll pragma for GCC < 8 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15558 To unsubscribe, visit

[kudu-CR] KUDU-3079 Add MiniRanger

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 50: Code-Review+2 Looks good to me, not sure if Andrew or Adar want to take another

[kudu-CR] KUDU-3079 Add MiniRanger

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15483 to look at the new patch set (#50). Change subject: KUDU-3079 Add MiniRanger

[kudu-CR] Add core algorithms for columnar serialization

Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15556 to look at the new patch set (#2). Change subject: Add core algorithms for columnar serialization

[kudu-CR] Fix loop unroll pragma for GCC < 8

Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15558 to review the following change. Change subject: Fix loop unroll pragma for GCC < 8 .. Fix loop unroll pragma for GCC

[kudu-CR] gutil: bump up linux-syscall-support.h

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. Patch Set 1: (2 comments)

[kudu-CR] gutil: bump up linux-syscall-support.h

Hello Alexey Serbin, zhaoren...@hotmail.com, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15557 to look at the new patch set (#2). Change subject: gutil: bump up linux-syscall-support.h

[kudu-CR] gutil: bump up linux-syscall-support.h

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. Patch Set 1: (2 comments)

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15550 ) Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. wire_protocol: some simplification

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

Todd Lipcon has removed a vote on this change. Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

Todd Lipcon has removed a vote on this change. Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Removed -Verified by Kudu Jenkins (120) -- To view, visit

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15550 ) Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Patch Set 3: Verified+1 k, skipping IWYU

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15550 ) Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Patch Set 3: Code-Review+2 There is an

[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 ) Change subject: KUDU-3085: Create Scala/SBT integration test example. .. Patch Set 2: (1 comment) Looks good. Just one more comment.

[kudu-CR] KUDU-3079 Add MiniRanger

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 49: Looks like this will need a rebase. -- To view, visit

[kudu-CR] gutil: bump up linux-syscall-support.h

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. Patch Set 1: Please ignore for now, I'm going to look at the failures --

[kudu-CR] gutil: bump up linux-syscall-support.h

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15557 Change subject: gutil: bump up linux-syscall-support.h .. gutil: bump up linux-syscall-support.h Bump up linux-syscall-support.h to

[kudu-CR] [clock] hybrid clock-test to run in different environments

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15551 ) Change subject: [clock] hybrid_clock-test to run in different environments .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15554 ) Change subject: [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3079 Add MiniRanger

Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 49: (2 comments) http://gerrit.cloudera.org:8080/#/c/15483/47//COMMIT_MSG

[kudu-CR] KUDU-3079 Add MiniRanger

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15483 to look at the new patch set (#49). Change subject: KUDU-3079 Add MiniRanger

[kudu-CR] KUDU-3079 Add MiniRanger

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15483 to look at the new patch set (#48). Change subject: KUDU-3079 Add MiniRanger

[kudu-CR] [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs

huangtianhua...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15554 ) Change subject: [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs .. Patch Set 2: Code-Review+1 So sorry,

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15550 to look at the new patch set (#3). Change subject: wire_protocol: some simplification and optimization for rowwise encoding

[kudu-CR] Add core algorithms for columnar serialization

Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15556 to review the following change. Change subject: Add core algorithms for columnar serialization .. Add

[kudu-CR] [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs

huangtianhua...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15554 ) Change subject: [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs .. Patch Set 2: Alexey Serbin, I took

[kudu-CR] [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs

Alexey Serbin has removed a vote on this change. Change subject: [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15554 ) Change subject: [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs .. Patch Set 2: >

[kudu-CR] [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15554 ) Change subject: [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs .. Patch Set 2: Verified+1 Unrelated test failure in

[kudu-CR] [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15554 ) Change subject: [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs .. Patch Set 2: > @Alexey Serbin, > I took python

[kudu-CR] [clock] hybrid clock-test to run in different environments

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15551 ) Change subject: [clock] hybrid_clock-test to run in different environments .. Patch Set 2: (3 comments)

[kudu-CR] [clock] hybrid clock-test to run in different environments

Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15551 to look at the new patch set (#3). Change subject: [clock] hybrid_clock-test to run in different environments

[kudu-CR] [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs

huangtianhua...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15554 ) Change subject: [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs .. Patch Set 1:

[kudu-CR] [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs

huangtianhua...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15554 ) Change subject: [python] KUDU-3087 use 2048-bit RSA keys for CA and server certs .. Patch Set 1: @Alexey Serbin, I took